Dan Balasescu
59d57a44d4
Prevent incorrect usages by hard-typing ctor type
2022-03-15 09:11:59 +09:00
Dan Balasescu
028750936c
Apply review suggestions
2022-03-14 17:10:37 +09:00
Dan Balasescu
3fff7f4b7e
Require ScoreProcessor to receive ruleset
2022-03-14 15:51:10 +09:00
Dan Balasescu
9cc7f70872
Nullable annotate classes
2022-03-14 15:38:00 +09:00
Dan Balasescu
926827207a
Reduce calculator allocations in counter
2022-03-14 14:44:06 +09:00
Dan Balasescu
4a3e3aba65
Restructure PerformanceCalculator to not require ScoreInfo argument
2022-03-14 14:25:28 +09:00
Dan Balasescu
fa456da0ec
Merge pull request #17225 from frenzibyte/taiko-classic-aspect-ratio
...
Remove osu!taiko playfield's 16:9 aspect ratio lock on "Classic" mod
2022-03-14 11:19:26 +09:00
Dan Balasescu
4037910cb3
Merge pull request #17238 from frenzibyte/storyboard-skinnable-sprite-size
...
Fix `SkinnableSprite`s in storyboards not autosizing to the textures
2022-03-14 10:53:54 +09:00
Dean Herbert
2c47c4a2e9
Merge branch 'master' into taiko-classic-aspect-ratio
2022-03-14 10:40:35 +09:00
Dean Herbert
f4b4c4d595
Merge pull request #17235 from frenzibyte/taiko-adjust-default-height
...
Nudge osu!taiko playfield's height to perfectly match with osu!(stable)
2022-03-14 10:40:23 +09:00
Salman Ahmed
c9d54834be
Fix SkinnableSprites in storyboards not autosizing to their textures
2022-03-14 03:46:13 +03:00
Salman Ahmed
dbc26c3534
Add failing test assertion
2022-03-14 03:46:11 +03:00
Salman Ahmed
4a8aa72d1b
Nudge osu!taiko playfield's height to perfectly match with osu!(stable)
2022-03-14 01:03:08 +03:00
Salman Ahmed
fb18dece8a
Merge branch 'master' into taiko-classic-aspect-ratio
2022-03-14 00:01:33 +03:00
Dean Herbert
b7a94f98a1
Merge pull request #17137 from frenzibyte/chat-mention-highlight
...
Add support for highlighting chat messages
2022-03-13 14:32:05 +09:00
Salman Ahmed
0b74bde653
Disable taiko playfield aspect ratio lock on "Classic" mod
2022-03-13 08:21:58 +03:00
Salman Ahmed
53c57661c7
Move implementtaion detail to inline comment
2022-03-11 18:34:22 +03:00
Salman Ahmed
5b70139b33
Avoid running message highlight processing more than once
2022-03-11 18:32:49 +03:00
Salman Ahmed
cc87563d57
Merge branch 'master' into chat-mention-highlight
2022-03-11 17:51:22 +03:00
Bartłomiej Dach
1813d73d4f
Merge pull request #17208 from peppy/blueprint-container-selected-items-bind
...
Automatically bind `BlueprintContainer`'s `SelectedItems` with its `SelectionHandler`
2022-03-11 03:48:42 +01:00
Bartłomiej Dach
398af246a5
Merge branch 'master' into blueprint-container-selected-items-bind
2022-03-11 00:37:45 +01:00
Salman Ahmed
d07e3101ea
Improve message highlight handling in DrawableChannel
2022-03-10 23:07:15 +03:00
Salman Ahmed
a31611bdec
Improve channel switching flow in HighlightMessage
2022-03-10 23:07:15 +03:00
Salman Ahmed
8086f73451
Revert "Add functionality to switch to successfully joined channel"
...
This reverts commit c72e8a8b5e
2022-03-10 23:07:15 +03:00
Salman Ahmed
e419370830
Add test coverage for highlighting message on left channel
2022-03-10 21:30:02 +03:00
Salman Ahmed
5315ff794a
Handle non-existing channels on message highlighting gracefully
2022-03-10 21:29:32 +03:00
Salman Ahmed
c72e8a8b5e
Add functionality to switch to successfully joined channel
2022-03-10 21:28:38 +03:00
Dean Herbert
68aedd63a7
Move SelectionHandler's SelectedItems binding to the base implementation
...
Until now it was up to each implementation to connect
`BlueprintContainer` to its `SelectionHandler`, which didn't make much
sense at all.
2022-03-10 23:22:19 +09:00
Dean Herbert
e31b174cc2
Merge pull request #17198 from smoogipoo/fix-beatmap-wedge-async-mutation
...
Fix beatmap wedge possibly applying transforms incorrectly and crashing
2022-03-10 23:12:58 +09:00
Dean Herbert
cee6a12d0b
Merge pull request #17199 from smoogipoo/fix-multiplayer-test-failures
...
Fix potential multiplayer crash with async disposal
2022-03-10 23:07:05 +09:00
Dean Herbert
db5e091b8e
Merge pull request #17203 from peppy/another-realm-intermittent-test
...
Fix intermittent failures on `TestBeatmapDownloadingFlow` due to slow realm refresh
2022-03-10 23:06:42 +09:00
Dean Herbert
80e1ffe762
Merge pull request #17206 from frenzibyte/skin-toolbox-autosizing
...
Fix skin components toolbox not autosizing properly
2022-03-10 23:03:07 +09:00
Salman Ahmed
717ddbba4e
Fix skin components toolbox not autosizing properly
2022-03-10 16:30:20 +03:00
Dean Herbert
e4ef540b5b
Fix intermittent failures on TestBeatmapDownloadingFlow due to slow realm refresh
2022-03-10 20:33:14 +09:00
Dan Balasescu
885cb3ce5b
Add current screen checks for added safety
2022-03-10 20:03:02 +09:00
Dan Balasescu
2de7795844
Fix always rolling up from zero
...
Co-authored-by: Dean Herbert <pe@ppy.sh>
2022-03-10 19:59:05 +09:00
Dean Herbert
2d135e5be6
Explain purpose of Schedule call in MultiplayerPlayer.onResultsReady
2022-03-10 19:56:13 +09:00
Dean Herbert
d1f8fd01df
Merge pull request #17180 from jai-x/new-chat-channel-listing
...
Implement `ChannelListing` for new chat design
2022-03-10 19:27:58 +09:00
Dean Herbert
3cd4136890
Merge pull request #17197 from peppy/more-realm-test-wait-fixes
...
Fix potential test failures due to slow realm refresh in `TestSceneScreenNavigation`
2022-03-10 19:25:24 +09:00
Dan Balasescu
dfe98c6536
Merge pull request #17162 from peppy/realm-offset-feedback-fix-2
...
Fix feedback from realm writes causing offset slider to jump around
2022-03-10 18:53:08 +09:00
Dan Balasescu
45d537ef72
Fix potential multiplayer crash with async disposal
2022-03-10 18:50:53 +09:00
Dean Herbert
d5eca16b69
Fix potential test failures due to slow realm refresh in TestSceneScreenNavigation
...
As seen at https://github.com/ppy/osu/runs/5492345983?check_suite_focus=true .
2022-03-10 18:10:08 +09:00
Dean Herbert
f82687a2c6
Merge pull request #17150 from SiimPender/master
...
Fix crash during kiai section on specific map due to negative transform duration
2022-03-10 18:09:41 +09:00
Dan Balasescu
671d614c92
Fix beatmap wedge mutating transforms incorrectly
2022-03-10 17:54:33 +09:00
Dean Herbert
db5c2c15dc
Merge pull request #17164 from smoogipoo/scoreprocessor-rework
...
Rework ScoreProcessor score calculation methods to fix various issues
2022-03-10 16:48:58 +09:00
Dean Herbert
a1b7bf3986
Use a minimum fade length for clamping rather than zero
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2022-03-10 16:47:02 +09:00
Dan Balasescu
c61397cc22
Fix whitespace/inspection
2022-03-10 16:22:27 +09:00
Dan Balasescu
13a4058efd
Merge pull request #17191 from peppy/fix-mod-conversion-exceptions
...
Change `ToMod` to return an `UnknownMod` rather than throw if a mod isn't available
2022-03-10 16:20:50 +09:00
Dan Balasescu
cf91353009
Merge branch 'master' into scoreprocessor-rework
2022-03-10 16:14:28 +09:00
Dean Herbert
46f2db1712
Move ChannelListingItem spacing into item so input is always handled by an item in the list
...
Without this change, there would be a couple of pixels between each list
item where nothing would be hovered. This is a pretty annoying UX which
we should be avoiding we possible.
2022-03-10 15:58:57 +09:00
