Bartłomiej Dach
59a1915451
Add failing test case for insufficient sample query leniency
2023-10-20 10:25:28 +02:00
Dean Herbert
f36a671eb4
Fix a couple of silly inspections
2023-10-20 15:38:00 +09:00
Dean Herbert
d49639bec3
Merge pull request #25173 from bdach/floating-fruits-borked
...
Fix Floating Fruits not flipping playfield properly
2023-10-20 13:04:08 +09:00
Dan Balasescu
6c61894514
Cleanup in a step
2023-10-20 11:35:31 +09:00
Dan Balasescu
e3bbf29333
Add cleanup step
2023-10-20 11:34:08 +09:00
Dan Balasescu
6cf0cbf3a9
Remove repo checkout step
2023-10-20 11:32:11 +09:00
Dan Balasescu
634323e71e
Fix wrong variable
2023-10-20 11:24:16 +09:00
Dean Herbert
6e3e6207ba
Merge pull request #25176 from smoogipoo/diffcalc-isolate-action
2023-10-20 10:45:25 +09:00
Dan Balasescu
d73650331d
Isolate diffcalc workflow runs
2023-10-20 09:44:10 +09:00
Bartłomiej Dach
cd3ff2b74c
Merge pull request #25154 from peppy/taiko-beat-snap-grid
...
Add beat snap grid to osu!taiko editor
2023-10-19 21:34:24 +02:00
Bartłomiej Dach
2c6bf9e346
Remove unused using directive
2023-10-19 20:45:47 +02:00
Bartłomiej Dach
cc1f1d2270
Fix Floating Fruits not flipping playfield properly
...
Regressed by https://github.com/ppy/osu/pull/25070 .
2023-10-19 19:47:49 +02:00
Dean Herbert
74b86349d5
Tidy up CatchHitObjectComposer
2023-10-19 23:57:36 +09:00
Dean Herbert
013b5fa916
Move beat snap grid implementation details to ScrollingHitObjectComposer
2023-10-19 23:54:34 +09:00
Dean Herbert
52c2eb93de
Merge branch 'master' into taiko-beat-snap-grid
2023-10-19 23:53:01 +09:00
Dean Herbert
e8d0962197
Merge pull request #25171 from bdach/distance-snapping-composition
...
Replace `DistancedHitObjectComposer` with composition-based approach
2023-10-19 23:46:10 +09:00
Bartłomiej Dach
0c4e74c82d
Inherit ScrollingHitObjectComposer in catch
2023-10-19 11:58:25 +02:00
Bartłomiej Dach
144ef5a87c
Remove DistancedHitObjectComposer
2023-10-19 11:46:30 +02:00
Bartłomiej Dach
31849192c3
Remove DistancedHitObjectComposer inheritance from catch composer
2023-10-19 11:46:30 +02:00
Bartłomiej Dach
dcfd6a0a8a
Remove DistancedHitObjectComposer inheritance from osu! composer
2023-10-19 11:46:30 +02:00
Bartłomiej Dach
3ab083b696
Split IPositionSnapProvider from IDistanceSnapProvider
...
In preparation to remove `DistancedHitObjectComposer`, split off
`IPositionSnapProvider` from `IDistanceSnapProvider`.
`DistancedHitObjectComposer` was not touching `IPositionSnapProvider`'s
only interface member at all, it was just forwarding it for subclasses
to override to their own leisure.
2023-10-19 11:45:24 +02:00
Bartłomiej Dach
0b8b87d6bd
Merge pull request #25169 from smoogipoo/fix-diffcalc-pr-command
...
Fix invalid PR URL in diffcalc GitHub action
2023-10-19 08:29:28 +02:00
Dan Balasescu
832ba861bb
Fix incorrect PR url in diffcalc workflow
2023-10-19 15:19:51 +09:00
Dean Herbert
66421a55ab
Merge pull request #25159 from smoogipoo/improve-diffcalc-command
...
Fix + improve diffcalc command for comment-based execution
2023-10-19 12:11:16 +09:00
Dan Balasescu
14cadd1eeb
Pin third-party actions
2023-10-19 02:39:34 +09:00
Bartłomiej Dach
12f343f0e2
Merge pull request #24640 from Givikap120/pitch_change
...
Add an "Adjust pitch" switch to DT/HT
2023-10-18 13:07:22 +02:00
Bartłomiej Dach
f1a16c50b8
Merge branch 'master' into pitch_change
2023-10-18 12:27:27 +02:00
Bartłomiej Dach
cff69d63a6
Add inline commentary in Mod{Day,Night}core about different speed adjustments
2023-10-18 12:27:16 +02:00
Dean Herbert
54da6f1048
Merge pull request #25160 from bdach/repeat-arrow-hidden-fade
...
Adjust slider repeat transforms to closer match stable
2023-10-18 18:03:48 +09:00
Dean Herbert
9907adc337
Take in IBindables and tidy up multiplier handling
2023-10-18 17:39:13 +09:00
Dean Herbert
161890292f
Move audio adjustment hookup to own method for clarity
2023-10-18 17:38:11 +09:00
Dean Herbert
e56ff33271
Also share ScoreMultiplier implementation
2023-10-18 17:23:50 +09:00
Dean Herbert
43238b0cee
Split common functionality from rate adjust mods into helper class
2023-10-18 17:23:50 +09:00
Dean Herbert
eabfcfbf2a
Merge branch 'master' into pitch_change
2023-10-18 16:33:03 +09:00
Dean Herbert
bf4aa3c118
Merge pull request #25163 from Joehuu/double-click-slider-nub-default
...
Add ability to revert slider settings to default when double-clicking nub
2023-10-18 16:23:05 +09:00
Joseph Madamba
18e8ca6245
Add ability to revert slider settings to default when double-clicking nub
2023-10-17 21:41:03 -07:00
Joseph Madamba
1a3a81c33b
Add slider nub double click revert to default test
2023-10-17 21:41:03 -07:00
Bartłomiej Dach
e927267c4d
Merge pull request #25155 from peppy/fix-new-inspections
...
Fix various new rider EAP inspections
2023-10-17 17:04:39 +02:00
Bartłomiej Dach
f3cda58474
Fix legacy slider repeats becoming much too large on hit
...
They had scale transforms applied to them in two places: the actual
legacy pieces themselves (esp. `LegacyHitCirclePiece`), and on the
`DrawableSliderRepeat` level.
This change moves all of the scale transforms to the skinnable pieces.
Argon and triangles have received a copy of the previous logic each,
so behaviour on those skins should not change.
2023-10-17 14:47:44 +02:00
Bartłomiej Dach
30e5f47007
Instantly fade out slider repeats when hidden is active
2023-10-17 14:15:21 +02:00
Bartłomiej Dach
f116854c9f
Add test step for covering slider appearance with hidden active
2023-10-17 14:15:21 +02:00
Dan Balasescu
4946b437c9
Run timeout job on self-hosted runner
2023-10-17 21:01:23 +09:00
Dan Balasescu
566b09ff20
Delete comment on cancellation
...
- Add always() pre-condition to force evaluation.
- Message is set as it's required by the action for a non-error status code.
2023-10-17 20:51:28 +09:00
Dan Balasescu
08845ec1c6
Use action for GHA diffcalc workflow permissions check
2023-10-17 20:28:04 +09:00
Dean Herbert
d9fc532a9f
Merge pull request #25152 from bdach/key-binding-deduplication
...
Clear pre-existing bindings of same key combination to single action
2023-10-17 17:49:51 +09:00
Dean Herbert
e081fa48a2
Fix various other inspections
2023-10-17 17:48:51 +09:00
Dean Herbert
5341a335a6
Bypass Parent nullability checks for now
2023-10-17 17:48:45 +09:00
Bartłomiej Dach
2192c9f2c2
Remove unused using directive
2023-10-17 10:30:01 +02:00
Bartłomiej Dach
22c1a963e7
Remove unused field
2023-10-17 10:27:16 +02:00
Bartłomiej Dach
7abd7fe658
Remove redundant explicit array type specification
2023-10-17 10:26:02 +02:00
