241 Commits

• Turn tests green, for a short while, maybe (#37218)

  ## [Rewrite `BackgroundMusicManager` to not run into framework
  breakage](https://github.com/ppy/osu/commit/622216d8911832c39fa4e126b2810e4e0f46cbf7)
  
  The attempted proper fix to this was
  https://github.com/ppy/osu-framework/pull/6727. Unfortunately when
  presented with [the framework
  bump](https://github.com/ppy/osu/pull/37217) with that change, CI says
  "you're stupid" and fails on some disposal idiocy that of course is
  undebuggable and irreproducible:
  
  The active test run was aborted. Reason: Test host process crashed :
  Unhandled exception. System.AggregateException: One or more errors
  occurred. (Object reference not set to an instance of an object.)
  ---> System.NullReferenceException: Object reference not set to an
  instance of an object.
  at osu.Framework.Audio.Sample.SampleChannelBass.Dispose(Boolean
  disposing)
  at System.Threading.ExecutionContext.RunInternal(ExecutionContext
  executionContext, ContextCallback callback, Object state)
  	--- End of stack trace from previous location ---
  at System.Threading.ExecutionContext.RunInternal(ExecutionContext
  executionContext, ContextCallback callback, Object state)
  at System.Threading.Tasks.Task.ExecuteWithThreadLocal(Task&
  currentTaskSlot, Thread threadPoolThread)
  	   --- End of inner exception stack trace ---
  	   at osu.Framework.Audio.AudioCollectionManager`1.UpdateChildren()
  	   at osu.Framework.Audio.AudioCollectionManager`1.UpdateChildren()
  	   at osu.Framework.Audio.AudioCollectionManager`1.UpdateChildren()
  	   at osu.Framework.Audio.AudioCollectionManager`1.UpdateChildren()
  	   at osu.Framework.Threading.AudioThread.OnExit()
  at osu.Framework.Threading.GameThread.setExitState(GameThreadState
  exitState)
  	   at osu.Framework.Threading.GameThread.RunSingleFrame()
  at osu.Framework.Threading.GameThread.<createThread>g__runWork|70_0()
  at System.Threading.ExecutionContext.RunInternal(ExecutionContext
  executionContext, ContextCallback callback, Object state)
  	--- End of stack trace from previous location ---
  at System.Threading.ExecutionContext.RunInternal(ExecutionContext
  executionContext, ContextCallback callback, Object state)
  
  
  (https://github.com/ppy/osu/actions/runs/24019928154/job/70046733058?pr=37217#step:5:119)
  
  I no longer have the energy for any of this shit.
  
  @nekodex would appreciate if you could check that I actually haven't
  broken anything with the bgm here. Seems okay to me in test scenes at
  least.
  
  ## [Apply lowest-effort maybe-fixing changes to a bunch of flaking
  tests](https://github.com/ppy/osu/commit/7bd3ca4adfcce5b90add11565a13f3fe9177ad5e)
  
  None of the failures are reproducible locally, of course. I'm tired of
  this. If anyone else wants to subject themselves to actually
  investigating any of these, by all means, godspeed and good luck.

  Bartłomiej Dach · 2026-04-06 17:59:39 +09:00
  809298ddeb
• Update lots of packages (#36996)

  It's been a while.
  
  Notes:
  
  - `SharpCompress` usages changed a bit. Manually adjusted these, mostly
  just renames or adjusted parameters.
  - nUnit 3 -> 4 migrated using
  https://gist.github.com/peppy/07994386d793a117350cb5f24b156585. there's
  a mode in this script to update to the newer `Assert.That` syntax but it
  requires fixes and couldn't really be bothered.
  - DeepEqual nuked as the only usage was on a disabled test. The reason
  it's disabled has been merged upstream, but it's failing for other
  (realm) reasons which I don't think is worthwhile to investigate for
  now.
  - This bumps Moq. I think the author is back in a sensible headspace and
  the new version has the stupid shit removed, so probably okay? Nice to
  be on a level playing field with packages for once in a long time.
  - Automapper is silly, but we've discussed this elsewhere.
  - `TestRealmKeyBindingStore` failures are a wildcard, but fixed by using
  a more standardised testing method. Dunno why, don't care.
  
  ---------
  
  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2026-03-17 03:58:02 +09:00
  a996261304
• Perform extra checks when loading rulesets (#36641)
  Bartłomiej Dach · 2026-02-10 13:34:43 +09:00
  655d725f0c
• Apply new inspections from 2026.1EAP1

  Nothing really egregious here so not bothering with PR review. One dodgy
  bug which has been
  [reported](https://youtrack.jetbrains.com/issue/RIDER-135036/Incorrect-recursive-on-all-execution-paths-inspection)
  and temporarily ignored.

  Dean Herbert · 2026-01-26 15:12:52 +09:00
  f1f4a0001b
• Revert "Merge pull request #36102 from bdach/move-check-to-better-place"

  This reverts commit 2cb2167765, reversing
  changes made to 0bcb3c5839.

  Dean Herbert · 2025-12-26 22:36:16 +09:00
  56ef5eae14
• Fix test
  Bartłomiej Dach · 2025-12-22 12:48:53 +01:00
  1ab922af12
• Fix test scene leaks through RealmRulesetStore/RealmAccess
  Dan Balasescu · 2025-10-09 15:28:15 +09:00
  79c367d208
• Add failing test case
  Bartłomiej Dach · 2025-09-02 14:43:41 +02:00
  95c7252467
• Attempt to fix intermittent BackgroundDataStoreProcessor tests
  Dan Balasescu · 2025-03-21 15:37:54 +09:00
  845e5fd39f
• Merge branch 'master' into beatmap-info-purge
  Dean Herbert · 2024-11-22 18:47:32 +09:00
  086a34f5c0
• Silence nullref inspection in test
  Bartłomiej Dach · 2024-10-18 09:42:08 +02:00
  8b4565b3d9
• Rename enum to non-plural now that it won't conflict
  Dean Herbert · 2024-10-01 19:55:46 +09:00
  8773c34fdd
• Adjust ILocalUserPlayInfo to expose whether gameplay is in a paused/break state
  Dean Herbert · 2024-10-01 17:53:46 +09:00
  ad3007eaad
• Merge branch 'master' into beatmap-info-purge
  Dean Herbert · 2024-09-15 04:53:35 +09:00
  58fe502af4
• Add failing test showing date added changing when importing as update with no change
  Dean Herbert · 2024-08-02 20:46:02 +09:00
  531cf64ddb
• Merge branch 'master' into beatmap-info-purge
  Dean Herbert · 2024-07-23 12:09:32 +09:00
  d707e29ff7
• Fix test not waiting properly for background processing to complete
  Bartłomiej Dach · 2024-07-16 14:04:51 +02:00
  53b6f9e385
• Restore test coverage of original fail case
  Bartłomiej Dach · 2024-07-16 14:04:50 +02:00
  6db135279f
• Fix BackgroundDataStoreProcessor test failure
  Dan Balasescu · 2024-07-16 19:59:13 +09:00
  ae5b0aa54b
• Fix test failure in TestMetadataTransferred
  Dean Herbert · 2024-07-14 01:36:51 +09:00
  2c102fc9d0
• Attempt to fix test failures by forcing refresh
  Bartłomiej Dach · 2024-07-11 08:18:16 +02:00
  a9c8c6e74d
• Inhibit original callback from firing when sending initial changeset
  Dean Herbert · 2024-07-09 16:05:58 +09:00
  ee9e329db3
• Add failing test showing realm not sending through null ChangeSet
  Dean Herbert · 2024-07-09 15:47:43 +09:00
  c8b9c117cd
• Move CountdownOffset out of BeatmapInfo
  Bartłomiej Dach · 2024-06-12 14:15:00 +02:00
  dd50d6fa6e
• Fix failing test due to missing ruleset store
  Dean Herbert · 2024-03-29 17:32:20 +08:00
  df4a28db91
• Update R# + fix inspections
  Dan Balasescu · 2024-02-02 21:00:28 +09:00
  b44f77cee1
• Remove outdated test

  Non-legacy scores *are* subject to upgrades again - albeit it is *rank*
  upgrades that they are subject to.

  Bartłomiej Dach · 2024-01-23 12:53:16 +01:00
  0b5be3c40c
• Move BackgroundDataStoreProcessor to better namespace
  Dean Herbert · 2024-01-22 21:43:32 +09:00
  4eba3b5d70
• Add failing test for not attempting to upgrade non-legacy scores

  This was a source of confusion for users previously, wondering why their
  non-legacy (non-stable) scores weren't being converted in line with new
  scoring changes, when it was never actually our intention to support
  anything of the sort.

  Bartłomiej Dach · 2024-01-08 22:10:09 +01:00
  388f6599e0
• Add failing test coverage for not attempting to upgrade custom ruleset scores
  Bartłomiej Dach · 2024-01-08 22:10:08 +01:00
  67df7b33fb
• Run score conversion for previously-imported scores
  Bartłomiej Dach · 2023-12-18 22:27:51 +01:00
  9c8df4e6d1
• Fix a couple of silly inspections
  Dean Herbert · 2023-10-20 15:38:00 +09:00
  f36a671eb4
• Merge branch 'master' into fix-legacy-score-multipliers-2
  Dan Balasescu · 2023-10-04 01:19:33 +09:00
  a120ea8464
• Fix legacy beatmap importer not always handling nested paths correctly

  Addresses https://github.com/ppy/osu/discussions/24989.

  Dean Herbert · 2023-10-03 16:01:17 +09:00
  b234a453da
• Update score conversion to consider legacy multiplier
  Dan Balasescu · 2023-10-02 16:56:15 +09:00
  b9ab4a2b7c
• Rename new flag and update xmldoc to match
  Dean Herbert · 2023-08-21 19:36:22 +09:00
  b3e7416972
• Fix some incorrect comments / test step descriptions

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2023-08-21 19:35:04 +09:00
  662073c472
• Merge branch 'master' into fix-score-import-fail-fail-fail
  Dean Herbert · 2023-08-21 19:34:12 +09:00
  db893f3dc7
• Tidy up test a bit more
  Dean Herbert · 2023-08-18 18:00:33 +09:00
  80a143ae85
• Cleanup tests
  Krzysztof Gutkowski · 2023-08-17 01:11:09 +02:00
  046cc62db2
• Set correct date added value when importing stable beatmapsets
  Krzysztof Gutkowski · 2023-08-17 00:49:48 +02:00
  59abb59ee8
• Add test coverage of upgrade success for good measure
  Dean Herbert · 2023-07-26 16:28:38 +09:00
  235cb2d73f
• Add test coverage of failed-to-upgrade flag
  Dean Herbert · 2023-07-26 16:22:21 +09:00
  a2f1ced5a2
• Rename BackgroundBeatmapProcessor to BackgroundDataStoreProcessor
  Dean Herbert · 2023-07-26 16:22:10 +09:00
  c1ba8fe175
• Fix broken test nullability
  Dean Herbert · 2023-07-07 16:28:49 +09:00
  ba0ab7383d
• Merge pull request #24114 from peppy/editor-save-local-score-management

  Ensure scores always have the correct linked `BeatmapInfo`

  Dean Herbert · 2023-07-07 15:40:54 +09:00
  d72765b6f8
• Sprinkle some more null-forgiving operators
  Bartłomiej Dach · 2023-07-06 22:08:48 +02:00
  ae2896ba7e
• Bring realm library up-to-date
  Dean Herbert · 2023-07-06 13:37:43 +09:00
  a98a36872e
• Reword comment
  Bartłomiej Dach · 2023-07-04 22:22:57 +02:00
  bcdbdf57ef
• Add full flow test of UpdateLocalScores
  Dean Herbert · 2023-07-04 15:18:51 +09:00
  a0bed0fcec