Dan Balasescu
520a5e4bfb
Merge pull request #31454 from bdach/select-closest-timing-point-on-every-enter
...
Select closest timing point every time the timing screen is changed to
2025-01-09 09:04:18 +09:00
Dean Herbert
2e10f83b5c
Merge pull request #31450 from peppy/association-manager-cleanup
2025-01-08 23:38:52 +09:00
Bartłomiej Dach
5a2024777d
Select closest timing point every time the timing screen is changed to
...
No issue thread for this, was pointed out internally:
https://discord.com/channels/90072389919997952/1259818301517725707/1316604605777444905
Due to the custom setup that editor has with its nested
"screens-that-aren't-screens", the logic that selects the closest
timing point to the current time would only fire on the first open of
the screen. Seems like a good idea to have it fire every time instead.
2025-01-08 14:24:46 +01:00
Dean Herbert
e131a6c39f
Add explicit ToString() to avoid sending LocalisableString to registry function
2025-01-08 20:19:38 +09:00
Bartłomiej Dach
e7070bd812
Merge pull request #31448 from bdach/automatic-new-combo-after-break
...
Force new combo on objects succeeding a break
2025-01-08 11:22:30 +01:00
Bartłomiej Dach
7c70dc4dc3
Only update combo information when any changes happened
2025-01-08 10:28:06 +01:00
Bartłomiej Dach
fbfda2e044
Extend test coverage with combo index correctness checks
2025-01-08 10:28:04 +01:00
Dean Herbert
f216c22806
Merge pull request #31445 from bdach/reset-speed-on-test-play
...
Reset playback speed to 100% on entering test play
2025-01-08 16:16:28 +09:00
Dean Herbert
b628880214
Change association localisation flow to make logical sense
2025-01-08 15:57:39 +09:00
Dean Herbert
d04947d400
Don't use records they are ugly
...
Refactor `WindowsAssociationManager` to be usable
2025-01-08 15:54:48 +09:00
Dan Balasescu
22b4f40eb5
Merge pull request #27920 from peppy/upgrade-packages
...
Upgrade packages
2025-01-08 14:48:35 +09:00
Dean Herbert
d5f2bdf6cd
Appease message pack new inspections
2025-01-08 03:13:29 +09:00
Dean Herbert
6f42b59e31
Upgrade more packages again
...
This also downgrades nunit to be aligned across all projects. Getting it
up-to-date is a bit high effort.
2025-01-08 03:13:11 +09:00
Dean Herbert
125d652dd8
Update realm xmldoc references
2025-01-08 01:35:56 +09:00
Dean Herbert
18ff25bc6d
Merge branch 'master' into upgrade-packages
2025-01-08 01:23:28 +09:00
Bartłomiej Dach
d0a39a7733
Merge pull request #31442 from peppy/supporter-button-always-warns
...
Always show dialog when clicking supporter icon before opening browser
2025-01-07 15:14:53 +01:00
Bartłomiej Dach
5431a08b35
Merge pull request #31435 from peppy/star-range-display-quality
...
Fix star range display looking a bit bad when changing opacity
2025-01-07 14:58:00 +01:00
Bartłomiej Dach
d2918894a0
Merge pull request #31390 from peppy/slider-end-suppress-fix
...
Fix slider end circles not remaining for long enough when hit animations disabled
2025-01-07 14:49:25 +01:00
Bartłomiej Dach
bda1c3f6e8
Merge pull request #31388 from peppy/fix-reverse-arrow-animation
...
Remove use of `Loop` (and transforms) for slider repeat arrow animations
2025-01-07 14:43:09 +01:00
Bartłomiej Dach
c93b87583a
Force new combo on objects succeeding a break
...
No issue thread for this again. Reported internally on discord:
https://discord.com/channels/90072389919997952/1259818301517725707/1320420768814727229
Placing this logic in the beatmap processor, as a post-processing step,
means that the new combo force won't be visible until a placement has
been committed. That can be seen as subpar, but I tried putting this
logic in the placement and it sucked anyway:
- While the combo number was correct, the colour looked off, because it
would use the same combo colour as the already-placed objects after
said break, which would only cycle to the next, correct one on
placement
- Not all scenarios can be handled in the placement. Refer to one of the
test cases added in the preceding commit, wherein two objects are
placed far apart from each other, and an automated break is inserted
between them - the placement has no practical way of knowing whether
it's going to have a break inserted automatically before it or not.
2025-01-07 14:06:23 +01:00
Bartłomiej Dach
973f606a9e
Add test coverage for expected behaviour
2025-01-07 13:59:26 +01:00
Bartłomiej Dach
98bb723438
Do not expose track directly in EditorClock
...
Intends to stop people from mutating it directly, and going through
`EditorClock` members like `AudioAdjustments` instead.
2025-01-07 11:40:18 +01:00
Bartłomiej Dach
275e8ce7b7
Remove unused protected field
2025-01-07 11:26:08 +01:00
Bartłomiej Dach
a5036cd092
Re-route editor tempo adjustment via EditorClock and remove it on gameplay test
2025-01-07 11:25:00 +01:00
Bartłomiej Dach
3c03406b45
Add failing test
2025-01-07 11:23:47 +01:00
Dean Herbert
b8a10d9b0e
Mark recommendation test as flaky
...
Will revisit during song select refactoring no doubt.
2025-01-07 17:58:12 +09:00
Dean Herbert
8d913e8971
Fix multiple animation inconsistencies pointed out in review
2025-01-07 16:54:11 +09:00
Dean Herbert
383fda7431
Fix star range display looking a bit bad when changing opacity
2025-01-07 16:42:06 +09:00
Dean Herbert
a0496c60a4
Refactor StarRatingRangeDisplay test to be more usable
2025-01-07 16:42:06 +09:00
Dean Herbert
1648f2efa3
Ensure slider is not selectable when body is not visible
2025-01-07 16:38:22 +09:00
Bartłomiej Dach
01e9c0f15e
Merge pull request #31418 from peppy/intro-file-integrity
...
Ensure intro files exist in storage during startup
2025-01-07 08:14:40 +01:00
Dan Balasescu
77d9c955ea
Merge pull request #31306 from bdach/aspire-slider-breakage
...
Fix slider event generator incorrectly not generating repeats when tick distance is zero
2025-01-07 11:50:18 +09:00
Dan Balasescu
638128ba88
Merge pull request #31436 from EVAST9919/editor-alloc
...
Reduce allocations in the editor caused by `TimelineBlueprintContainer`
2025-01-07 11:31:39 +09:00
Andrei Zavatski
d35b308745
Use cleaner array creation expression
2025-01-07 01:23:19 +03:00
Andrei Zavatski
791ca915e4
Fix allocations in updateSamplePointContractedState
2025-01-07 00:48:58 +03:00
Andrei Zavatski
e8dc09f5bc
Reduce HitSampleInfo constants allocations
2025-01-07 00:36:58 +03:00
Dean Herbert
1ca28d74a3
Merge pull request #31433 from bdach/romanised-metadata-ascii-only
...
Constrain range of usable characters in romanised metadata to ASCII only
2025-01-07 03:29:44 +09:00
Bartłomiej Dach
3a4497af32
Constrain range of usable characters in romanised metadata to ASCII only
...
Closes https://github.com/ppy/osu/issues/31398 .
Rationale given in issue.
Compare stable logic:
- 2280c4c436/osu2280c4c436/osue05cb86ff6/osu.Framework/Graphics/UserInterface/TextBox.cs (L92)
2025-01-06 14:04:47 +01:00
Dean Herbert
ca9e16387a
Don't require track to be playing to fix test failures on some platforms
2025-01-06 18:27:00 +09:00
Dean Herbert
4f1a6b4688
Always show dialog when clicking supporter icon before opening browser
...
I managed to do this by accident three times today while testing using
the dashboard display, so it's time to action on it.
Touched on in
https://github.com/ppy/osu/discussions/30740#discussioncomment-11345996 .
Was also mentioned recently in discord or another discussion explicitly
but I can't find that.
2025-01-06 17:51:04 +09:00
Dan Balasescu
448790a76f
Merge pull request #31386 from peppy/fix-applying-offset
...
Fix not being able to apply last play offset after returning to song select
2025-01-06 11:40:12 +09:00
Dean Herbert
d6e73d75d2
Merge pull request #31414 from frenzibyte/fix-display
...
Fix mobile release dialog obstructed by the software keyboard
2025-01-05 00:37:29 +09:00
Dean Herbert
37da72d764
Reduce nesting slightly
2025-01-05 00:32:06 +09:00
Dean Herbert
72dfdac2e2
Ensure intro files exist in storage
...
Guards against user interdiction.
See
[https://discord.com/channels/188630481301012481/1097318920991559880/1324765503012601927 ](recent)
but not only case of this occurring.
2025-01-04 15:27:49 +09:00
Dean Herbert
e15978cc65
Add test coverage of user deleting intro files
2025-01-04 15:26:42 +09:00
Salman Alshamrani
3fc86f60ee
Fix mobile release dialog obstructed by the software keyboard
2025-01-03 22:01:06 -05:00
Dean Herbert
b4698851a3
Merge pull request #31403 from frenzibyte/mobile-disclaimer
2025-01-04 02:35:36 +09:00
Dean Herbert
2cd86cbf91
Localise text
2025-01-04 01:28:33 +09:00
Dean Herbert
da85517036
Adjust popup icon animation slightly
2025-01-04 01:28:09 +09:00
Dean Herbert
60fd0be481
Make popup body text left aligned when multiple lines of text are provided
2025-01-04 01:19:56 +09:00
