585 Commits

• Move concurrent hold note tests to mania tests

  The general check no longer considers mania.

  Derrick Timmermans · 2025-05-25 17:33:48 +02:00
  9a254afa0a
• Add failing test case
  Bartłomiej Dach · 2025-05-20 12:28:28 +02:00
  b60cf08635
• Fix hold notes being missed after rewinding gameplay

  Closes https://github.com/ppy/osu/issues/27589.
  
  Follows osu! spinner precedent in storing the holding state to the
  judgement result rather than attempting to keep it in the DHO (which is
  prone to getting dropped on pool re-use).

  Bartłomiej Dach · 2025-05-19 12:23:47 +02:00
  59490054db
• Add failing test case
  Bartłomiej Dach · 2025-05-19 11:38:42 +02:00
  3d4763bdb5
• Adjust failing replay recording tests

  cd4ab9307c made these tests fail because
  they were basically pressing and releasing a key in a single frame,
  which hopefully never actually happens in real scenarios. (It's a bit
  tricky to determine if it can.)

  Bartłomiej Dach · 2025-05-16 08:59:56 +02:00
  953a93309c
• Add baseline test coverage of replay recording in all rulesets

  Nothing fancy, just basics to ensure the subsequent commit doesn't break
  anything.

  Bartłomiej Dach · 2025-05-14 11:25:14 +02:00
  168c3cf018
• Rename mod setting

  Just feels better?

  Bartłomiej Dach · 2025-05-08 07:47:24 +02:00
  1e61abde74
• Expand test coverage
  Bartłomiej Dach · 2025-05-08 07:46:51 +02:00
  4d5a7e5604
• Merge branch 'master' into perfect-feat
  fredzio2006 · 2025-05-07 21:58:29 +02:00
  9748073037
• Add test coverage
  fredzio2006 · 2025-05-07 21:29:17 +02:00
  70d2eb841d
• Add failing test case
  Salman Alshamrani · 2025-04-30 03:59:41 +03:00
  a3a4881432
• Add test coverage for mania hit windows with various mods active
  Bartłomiej Dach · 2025-04-21 12:26:09 +02:00
  a46a1f569b
• Merge branch 'master' into stable-hitwindow-tests
  Bartłomiej Dach · 2025-04-17 11:40:50 +02:00
  2eb3bfa232
• Add theoretically-valid-but-practically-not commented-out test cases
  Bartłomiej Dach · 2025-04-17 10:36:04 +02:00
  a82bb5c2f6
• Fix code quality once more
  Bartłomiej Dach · 2025-04-16 08:35:35 +02:00
  8273583fd0
• Add test cases covering correct legacy replay playback with respect to hitwindow treatment

  This continues on https://github.com/ppy/osu/pull/32770 via adding test
  cases which cover treatment of hit windows in stable in osu!, taiko, and
  mania. The test cases are exportable to beatmap `.osu` files and replay
  `.osr` files for stable crosscheck by setting `ExportLocation` on the
  test scene classes to a non-null path.
  
  For the most part, osu! and taiko ground truth matches previous findings
  - hit windows in those rulesets are floored to the nearest integer.
  The real "star" of this diff is mania, because:
  
  - The hit windows in mania depend on:
    - overall difficulty (as expected)
    - whether Score V2 is active
    - if Score V2 is not active, the hit windows also depend on whether
      the map was converted from another ruleset or not
  
  - Regardless of all aforementioned factors, mania hitwindows are *not
    symmetrical*. Due to what *appears* to be a straight-up bug, it is
    *not possible to achieve a MEH / 50 hit result when hitting late*.
    There is specific code that coerces late hits beyond 100 hit window
    range to full misses:
  
       https://github.com/peppy/osu-stable-reference/blob/996648fba06baf4e7d2e0b248959399444017895/osu!/GameplayElements/HitObjectManagerMania.cs#L737-L751
  
  Note that despite the fact that I'm PRing these test cases, none of this
  is a promise that all of stable behaviours will be returning unchanged
  when I PR something to actually do something about this and the other
  issue of replay instability. This is just coverage, to be used for
  awareness of what's still broken. The extent of how much stable is going
  to be humored here going forward will be subject to negotiation.

  Bartłomiej Dach · 2025-04-15 13:22:06 +02:00
  82b2a92894
• Add extra comments regarding notation
  Bartłomiej Dach · 2025-04-14 13:13:21 +02:00
  9cfba9008f
• Fix code quality
  Bartłomiej Dach · 2025-04-11 14:16:24 +02:00
  d4cae3232b
• Add test exercising mania replay playback stability after encode
  Bartłomiej Dach · 2025-04-11 12:09:53 +02:00
  674af698b6
• Remove redundant argument list
  Dan Balasescu · 2025-04-04 10:58:29 +09:00
  2df3dfb99c
• Add test coverage
  Bartłomiej Dach · 2025-04-02 09:56:30 +02:00
  71f55928b6
• Merge branch 'master' into mania-bring-back-touch-controls
  Dean Herbert · 2025-03-12 18:42:39 +09:00
  007198fd98
• Apply suggested renames
  Salman Alshamrani · 2025-03-11 09:06:01 -04:00
  b64e69d581
• Fix placement blueprint tests
  Bartłomiej Dach · 2025-03-11 07:55:48 +01:00
  c962210b4f
• Replace toggles with a single dropdown
  Salman Alshamrani · 2025-03-10 04:45:32 -04:00
  857b8637ae
• Bring back touch control under a setting
  Salman Alshamrani · 2025-03-10 03:48:45 -04:00
  edcc607f4b
• Add "discard unsaved changes" operation to beatmap editor

  Apparently useful in modding workflows when you want to test out a few
  different variants of a thing.
  
  Re-uses `Ctrl-L` binding from stable. Some folks may argue that the
  dialog makes the hotkey pointless, but I really do want to protect
  users from accidental data loss, and also if you want to power through
  it quickly, you can hit the 1 key when the dialog shows, which will
  bypass the hold-to-activate period (which wasn't intentional, but so
  many people want a bypass at this point that we're probably keeping that
  behaviour for power users).

  Bartłomiej Dach · 2025-03-05 14:34:44 +01:00
  3f461c0734
• Minor bump some packages
  Dean Herbert · 2025-02-17 15:23:26 +09:00
  db4a4a1723
• Merge pull request #31368 from frenzibyte/mobile-fix-mania

  Improve osu!mania playability on mobile devices

  Dean Herbert · 2025-02-01 14:49:46 +09:00
  cf3a379b1c
• Revert unnecessary inheritance

  Everyone is right, too much inheritance and polymorphism backfires very badly.

  Salman Alshamrani · 2025-01-25 19:12:37 -05:00
  8151c3095d
• Fix tests
  Bartłomiej Dach · 2025-01-24 11:59:07 +01:00
  269ade178e
• Remove dependence of blueprint containers on IPositionSnapProvider
  Bartłomiej Dach · 2025-01-24 11:59:05 +01:00
  15b6e28ebe
• Fix mania fade in test not actually testing the mod
  Salman Alshamrani · 2025-01-12 22:57:35 -05:00
  4774d9c9ae
• Merge branch 'master' into mobile-fix-mania
  Salman Alshamrani · 2025-01-12 02:00:49 -05:00
  f121b03a78
• Upgrade more packages again

  This also downgrades nunit to be aligned across all projects. Getting it
  up-to-date is a bit high effort.

  Dean Herbert · 2025-01-08 03:13:11 +09:00
  6f42b59e31
• Replace ManiaTouchInputArea with touchable columns
  Salman Alshamrani · 2024-12-31 12:28:04 -05:00
  bea61d2483
• Add another failing test
  Dan Balasescu · 2024-12-13 15:53:27 +09:00
  12e5999700
• Add failing test
  Dan Balasescu · 2024-12-06 16:40:25 +09:00
  62ea4e0970
• Merge pull request #29640 from smoogipoo/mania-imperfect-ss

  Make mania award SS even if there are GREAT judgements

  Dean Herbert · 2024-11-22 14:42:32 +09:00
  6a0ac4c29e
• Rename variable to imply it is now a function
  Dean Herbert · 2024-11-22 13:11:32 +09:00
  41addaae9a
• Recreate beatmap every test run in ModTestScene
  Salman Alshamrani · 2024-11-21 17:48:33 -05:00
  5dffc322af
• Remove unused using directive
  Bartłomiej Dach · 2024-11-07 08:40:01 +01:00
  fd17966605
• Fix test
  Bartłomiej Dach · 2024-11-05 15:29:52 +01:00
  3d4f5d4d10
• Merge pull request #30284 from bdach/mania-selection-preservation-again

  Fix flip operations sometimes not preserving selection in mania editor

  Dean Herbert · 2024-10-23 16:13:20 +09:00
  7df3976d1c
• Update all dependencies (except realm, nunit, moq and deepclone)
  Dean Herbert · 2024-10-18 16:20:07 +09:00
  ca2bd640b4
• Add failing tests
  Bartłomiej Dach · 2024-10-14 14:48:07 +02:00
  98141430b0
• Fix tests
  Bartłomiej Dach · 2024-10-03 13:11:02 +02:00
  8a650deab6
• Merge pull request #29899 from bdach/mania-selection-dropped

  Ensure selection is preserved when moving selection between columns

  Dean Herbert · 2024-09-27 18:11:23 +09:00
  d9de2ad97b
• Refactor PlacementBlueprint to not be hitobject specific
  OliBomby · 2024-09-24 20:31:00 +02:00
  e3b4483872
• Add test case covering failure
  Bartłomiej Dach · 2024-09-17 13:07:52 +02:00
  e0f92bab6a