h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2026-06-08 10:53:52 +08:00
Code Issues Releases Wiki Activity

Rename mod setting

Browse Source 
Just feels better?
This commit is contained in:
Bartłomiej Dach
2025-05-08 07:47:24 +02:00
Unverified
parent 4d5a7e5604
commit 1e61abde74
2 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
osu.Game.Rulesets.Mania.Tests/Mods/TestSceneManiaModPerfect.cs
+2 -2
View File
@@ -35,7 +35,7 @@ namespace osu.Game.Rulesets.Mania.Tests.Mods
{
Mod = new ManiaModPerfect
{
PerfectScoreOnly = { Value = requirePerfectHits }
RequirePerfectHits = { Value = requirePerfectHits }
},
PassCondition = () => ((ModFailConditionTestPlayer)Player).CheckFailed(false),
Autoplay = false,
@@ -61,7 +61,7 @@ namespace osu.Game.Rulesets.Mania.Tests.Mods
{
Mod = new ManiaModPerfect
{
PerfectScoreOnly = { Value = requirePerfectHits }
RequirePerfectHits = { Value = requirePerfectHits }
},
PassCondition = () => ((ModFailConditionTestPlayer)Player).CheckFailed(requirePerfectHits),
Autoplay = false,
osu.Game.Rulesets.Mania/Mods/ManiaModPerfect.cs
+3 -3
View File
@@ -11,8 +11,8 @@ namespace osu.Game.Rulesets.Mania.Mods
{
public class ManiaModPerfect : ModPerfect
{
[SettingSource("Only allow perfect hits")]
public BindableBool PerfectScoreOnly { get; } = new BindableBool();
[SettingSource("Require perfect hits")]
public BindableBool RequirePerfectHits { get; } = new BindableBool();
protected override bool FailCondition(HealthProcessor healthProcessor, JudgementResult result)
{
@@ -20,7 +20,7 @@ namespace osu.Game.Rulesets.Mania.Mods
return false;
// Mania allows imperfect "Great" hits without failing.
if (result.Judgement.MaxResult == HitResult.Perfect && !PerfectScoreOnly.Value)
if (result.Judgement.MaxResult == HitResult.Perfect && !RequirePerfectHits.Value)
return result.Type < HitResult.Great;
return result.Type != result.Judgement.MaxResult;