h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-01-31 05:32:57 +08:00
Code Issues Releases Wiki Activity
55,675 Commits 4 Branches 672 Tags 372 MiB
49af80e17b
Commit Graph

35490 Commits

Author SHA1 Message Date
Dean Herbert
454125123d Add failing test coverage showing mod reference leak path 2022-09-19 12:18:35 +09:00
Salman Ahmed
a413c7a3e6
Merge branch 'master' into fix-notification-count 2022-09-19 02:08:20 +03:00
O Thiago
a4e9c7711c Fix when flashlight shrinking takes place 2022-09-18 18:59:17 -04:00
O Thiago
407b104116 Revert changes 
This reverts commit beef3b418a.

Revert "Use linq expression for handling breaks"

This reverts commit 8464a1941b.

Revert "renames variables to make more logical sense"

This reverts commit 3b87ecf56c.

Revert "Removes overhead when not combo based size"

This reverts commit ac4229e3d4.
 2022-09-18 18:57:53 -04:00
Dean Herbert
0ac28cbecc Fix potential crash from missing DownloadProgress 2022-09-18 23:42:16 +09:00
Dean Herbert
6a06a5b1b5 Reword fallback instantiation handling comment to hopefully explain things better 2022-09-18 18:20:28 +09:00
Dean Herbert
d0b8409de5 Apply more renames 2022-09-18 18:19:00 +09:00
Dean Herbert
1914c41d0d
Merge pull request #20353 from Drison64/fix-timelineZoom-zero 
EditorBeatmap's TimelineZoom should never be zero
 2022-09-18 18:06:26 +09:00
Dan Balasescu
2dcaf7cfd8 Fix memory leak due to missing event unbind 2022-09-18 14:25:31 +09:00
O Thiago
ac4229e3d4 Removes overhead when not combo based size 2022-09-18 00:38:01 -04:00
O Thiago
3b87ecf56c renames variables to make more logical sense 2022-09-18 00:19:40 -04:00
O Thiago
8464a1941b Use linq expression for handling breaks 2022-09-17 23:49:23 -04:00
O Thiago
beef3b418a Simplifies size calculation 2022-09-17 23:41:23 -04:00
Drison64
c075d3de08 Create a test and a check if initial zoom value of ZoomableScrollContainer is in range 2022-09-17 22:43:40 +02:00
Ondřej Vajďák
9d94343317
Update osu.Game/Screens/Edit/Compose/Components/Timeline/Timeline.cs 
Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>
 2022-09-17 19:51:44 +02:00
Drison64
c8768eb399 Changed == to <= on TimelineZoom check 2022-09-17 19:00:50 +02:00
Drison64
88e6ce575a Merge branch 'fix-timelineZoom-zero' of https://github.com/Drison64/osu into fix-timelineZoom-zero 2022-09-17 18:57:36 +02:00
Drison64
3c7ea5c8fa Update 2022-09-17 18:57:09 +02:00
Salman Ahmed
9a10ecb378 Clarify purpose of APIUserScoreAggregate 2022-09-17 19:37:30 +03:00
Dean Herbert
41e69fbca6 Remove "default" prefix from naming 2022-09-18 00:15:26 +09:00
Dean Herbert
1c4e02fae8 Explicitly order default skins in dropdown to get correct order 2022-09-18 00:12:43 +09:00
Dean Herbert
1b475f9360 Ensure skin InstantiationInfo is updated when saving 2022-09-18 00:12:43 +09:00
Dean Herbert
64ee210825 Add realm migration to update skin names 2022-09-18 00:12:43 +09:00
Dean Herbert
487378f732 Fallback to default skin if instantiation fails 2022-09-17 23:57:25 +09:00
Dean Herbert
3e28ab72ce Standardise default skin names 2022-09-17 23:57:25 +09:00
Dean Herbert
51841988bf Rename references to DefaultSkin to have Triangles suffix 2022-09-17 23:57:25 +09:00
Ondřej Vajďák
448485a56b
Merge branch 'master' into fix-timelineZoom-zero 2022-09-17 16:24:18 +02:00
HiddenNode
2dfa89c62e Clean up 2022-09-17 15:05:25 +01:00
Drison64
0b6a77bc8b EditorBeatmap's TimelineZoom should never be zero 2022-09-17 15:59:42 +02:00
HiddenNode
d580b07063 Refactor update condition logic 2022-09-17 14:40:36 +01:00
Dean Herbert
a1d830e47f Fix formatting 2022-09-17 22:22:56 +09:00
vegguid
0bfe967452 moved BindValueChanged to LoadComplete 2022-09-17 12:58:23 +02:00
HiddenNode
e3d5ba5301 Check if graph DrawSize changed 2022-09-17 11:44:25 +01:00
HiddenNode
0d76f4501d Revert "Set InvalidationSource to Self" 
This reverts commit 2092008251.
 2022-09-17 10:10:20 +01:00
vegguid
288cc7b201 Fixed Leaderboard tooltip not following time format setting 2022-09-16 21:36:17 +02:00
Dan Balasescu
92b2417d4c Post notification when room joined 2022-09-16 21:10:11 +09:00
Dan Balasescu
e95983cdb4
Merge branch 'master' into fix-skin-flow 2022-09-16 20:15:51 +09:00
Dan Balasescu
433bb5ae24 Add ServerShuttingDownCountdown 2022-09-16 19:56:52 +09:00
Dean Herbert
85bb6f0beb Update framework 
Update framework (again)

Update framework
 2022-09-16 19:35:34 +09:00
Dean Herbert
4c4fdfd153 Provide scores directly to Player instance rather than relying on DI 2022-09-16 18:15:17 +09:00
Dean Herbert
38d8d457d9 Add back second completion post attempt for case when notification overlay isn't loaded yet 2022-09-16 17:54:44 +09:00
Dean Herbert
0d24fda4b9 Fire Notification.Closed immediately to ensure off-screen notifications are closed 2022-09-16 16:36:56 +09:00
Dean Herbert
0227eddda1 Merge branch 'master' into gameplay-leaderboards 2022-09-16 15:44:58 +09:00
Dan Balasescu
cbf55732da
Merge pull request #20337 from peppy/catch-unobserved-network-exceptions 
Catch any unobserved exceptions during beatmap metadata harvesting
 2022-09-16 14:37:08 +09:00
Dean Herbert
21ac3fd88b Catch any unobserved exceptions during beatmap metadata harvesting 
The process will retry when a connection is successful, so this doesn't
need to be as loud as it was.

Addresses https://github.com/ppy/osu/discussions/20331.
 2022-09-16 14:00:06 +09:00
Dean Herbert
4486fa2546
Merge pull request #20334 from Drison64/fix-scorePanel-timeFormat 
Make score panel timestamp adjust to 24-hour time setting
 2022-09-16 13:40:34 +09:00
Dan Balasescu
d9499abc33 Refactor to avoid passing around bindables 2022-09-16 13:14:25 +09:00
Dan Balasescu
fcba917419
Merge pull request #20320 from peppy/skin-transformers 
Allow skin transformers to be created for all skins
 2022-09-16 12:58:46 +09:00
Dan Balasescu
49d2c84646
Merge pull request #19991 from Feodor0090/mods-effect-displays 
Move `DifficultyMultiplierDisplay`'s layout and colour logic to a base class
 2022-09-16 10:30:30 +09:00
Drison64
4f208416be Fixed irresponsiveness of score panel timestamp to time format 2022-09-16 13:50:18 +14:00
Dean Herbert
db822696ed Use latest version of sqlite3 bundle 2022-09-16 01:02:46 +09:00
Dean Herbert
5ce67345ae Catch against sqlite initialisation failures 2022-09-16 01:02:38 +09:00
Dan Balasescu
f86bbaae30
Merge branch 'master' into mods-effect-displays 2022-09-15 21:17:58 +09:00
Dean Herbert
c7f8f948b9 Rename CreateLegacySkinProvider to CreateSkinTransformer and apply to all skins 2022-09-15 20:18:10 +09:00
HiddenNode
2092008251 Set InvalidationSource to Self 2022-09-15 11:16:00 +01:00
Dan Balasescu
96a89f4fca
Merge pull request #20319 from peppy/remove-ef-migration 
Remove all entity framework code and migrations
 2022-09-15 19:15:23 +09:00
HiddenNode
8286ab0d04 Revert "Fix SongProgress invalidating too often" 
This reverts commit 2b4b14ca99.
 2022-09-15 11:11:58 +01:00
Dean Herbert
ea513c539b
Merge pull request #20303 from peppy/hitobject-entry-nesting-stoled 
Fix editor performance drop over time due to lingering nested object references
 2022-09-15 17:15:01 +09:00
Dean Herbert
28b15e232d Remove all EF models 2022-09-15 16:59:36 +09:00
Dean Herbert
65d1c40dd5 Remove remaining package references and replace with SQLitePCLRaw direct reference 
This may require further consideration for test and iOS projects.
 2022-09-15 16:58:58 +09:00
Dean Herbert
581a4d2d6d Use APIBeatmap for realm migration requiring ShortName mapping 2022-09-15 16:58:58 +09:00
Dean Herbert
0aa92c78ec Add local sqlite initialisation to BeatmapUpdaterMetadataLookup for now 2022-09-15 16:58:58 +09:00
Dean Herbert
40a60f7145 Remove all entity framework code and migrations 2022-09-15 16:58:58 +09:00
Dan Balasescu
e56ea58e71 Fix up xmldoc 2022-09-15 16:06:21 +09:00
Dan Balasescu
c847cc521e Add some inline comments 2022-09-15 16:00:35 +09:00
Dan Balasescu
68e4d22898 Precondition against entryMap intead of parentMap 2022-09-15 15:43:15 +09:00
Dan Balasescu
31bc067dd1 Don't store nulls to parentMap 2022-09-15 15:38:44 +09:00
Salman Ahmed
efebe55d22 Display certain sort criterias based on selected category and query 2022-09-15 04:30:09 +03:00
Salman Ahmed
de7dd29d79 Add "Nominations" and "Updated" sorting criteria in beatmap listing 2022-09-15 03:57:05 +03:00
Dean Herbert
eb18d3661d
Merge pull request #20309 from mk56-spn/dead_class_removal 
Unused class KeyCounterState.cs Removal
 2022-09-15 03:38:39 +09:00
Mk-56spn
d6db82283a Removes unused class 2022-09-14 18:01:29 +02:00
Dean Herbert
5dc0d32e42 Apply NRT to hitobject lifetime related classes 2022-09-14 15:24:20 +09:00
ekrctb
c59aa57450 Remove createLifetimeEntry from HitObjectEntryManager 2022-09-14 15:19:33 +09:00
ekrctb
47539e2129 Add doc comments to HitObjectEntryManager 2022-09-14 15:19:05 +09:00
ekrctb
bde390828b Manage entries of nested hit objects in HitObjectEntryManager 
- Fix nested hit objects are leaked when parent hit object is edited or deleted
 2022-09-14 15:19:05 +09:00
ekrctb
a9eba27129 Factor out pooling logic from Playfield 2022-09-14 15:19:05 +09:00
Dan Balasescu
90e5949e9f
Merge pull request #20300 from peppy/stable-sort-local-scores 
Fix local scores potentially not being stable-sorted for leaderboard display
 2022-09-14 15:11:07 +09:00
Dean Herbert
bc07513c3c Fix local scores potentially not being stable-sorted for leaderboard display 2022-09-14 14:19:53 +09:00
Dean Herbert
fcf54f1bc8 Fix gameplay leaderboard not being sorted correctly in tie situations 2022-09-14 14:18:12 +09:00
Dean Herbert
8a6977213a Fix displayed scores in gameplay leaderboard not tracking display mode changes 2022-09-14 14:02:35 +09:00
Dan Balasescu
024f7991ad
Merge pull request #20292 from peppy/fix-preix-matching-status 
Fix song select status prefix matching no longer working
 2022-09-14 13:53:03 +09:00
Joseph Madamba
85e3a681b1 Fix notification overlay toast tray background absorbing input from behind 2022-09-13 21:07:30 -07:00
Dean Herbert
b4e6a20846 Fix song select status prefix matching no longer working 
Regressed in #19275 due to weird logic.
Closes #20289.
 2022-09-14 12:59:05 +09:00
Dan Balasescu
ef6d60ffe9
Merge pull request #20273 from frenzibyte/duplicate-beatmap-listing-cards 
Fix beatmap listing potentially showing duplicate beatmap cards
 2022-09-14 10:25:24 +09:00
Salman Ahmed
04dbb6fc1b Add inline comment 2022-09-14 00:49:02 +03:00
Dan Balasescu
4a49433e2e
Merge branch 'master' into notification-fling-right 2022-09-13 20:01:56 +09:00
Dean Herbert
81b5e4a865 Fix back-to-front condition on leaderboard always show configuration 2022-09-13 19:57:40 +09:00
Dean Herbert
94693a4667 Fix oversight when making interface implementation explicit 2022-09-13 19:55:57 +09:00
Dean Herbert
566a61e770
Merge pull request #20244 from peppy/notification-fling 
Add ability to "fling" notifications to dismiss them
 2022-09-13 19:50:34 +09:00
Dean Herbert
9226f0abbc Implement equality correctly in Live 2022-09-13 19:16:25 +09:00
Dean Herbert
e15a25ea49 Fix leaderboard positioning logic to actually consider elements on the left side 2022-09-13 18:45:11 +09:00
Dean Herbert
678eec1c67 Move LeaderboardFlow to HUDOverlay to share positioning logic 2022-09-13 18:45:11 +09:00
Dean Herbert
5894d2f0bc Ensure gameplay leaderboard hides with rest of HUD when it should 2022-09-13 18:45:11 +09:00
Dean Herbert
6d167070f8 Add back DI leaderboard retrieval via bindable pathway 2022-09-13 18:45:11 +09:00
Dean Herbert
70e6b595f1 Refactor SoloGameplayLeaderboard to not read scores via DI 
Also allows updating scores if they arrive late.
 2022-09-13 18:00:21 +09:00
Dean Herbert
d2b80645ab Change Leaderboard to use IUser instead of APIUser 2022-09-13 18:00:21 +09:00
Dean Herbert
ac58c222b9 Allow DrawableAvatar to accept an IUser for now 2022-09-13 18:00:21 +09:00
Dean Herbert
d251c0b2ac Move leaderboard implementation to Player itself 2022-09-13 18:00:21 +09:00
Dean Herbert
368faa0084 Make constructor protected in base implementation 2022-09-13 18:00:21 +09:00
Dean Herbert
4c669e2bce Track local Player.Score's user rather than using APIProvider 2022-09-13 18:00:21 +09:00