Salman Ahmed
|
f598de4cdb
|
ResourcesSkin -> ResourceStoreBackedSkin
|
2021-06-28 09:18:29 +03:00 |
|
Salman Ahmed
|
692f24437e
|
Maintain ruleset resources skin across multiple source changes
|
2021-06-28 09:11:28 +03:00 |
|
Dean Herbert
|
7dd566dc46
|
Add null check for safety
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
|
2021-06-28 15:08:49 +09:00 |
|
Dean Herbert
|
c281e43cd8
|
Remove Dispose() special case and add explicit exception to make debugging issues non-deadlock
|
2021-06-28 15:04:14 +09:00 |
|
Dean Herbert
|
f777741ca7
|
Simplify instantiation
|
2021-06-28 14:51:27 +09:00 |
|
Dean Herbert
|
73bd88cb31
|
Simplify caching in test
|
2021-06-28 14:44:52 +09:00 |
|
Dean Herbert
|
e387feb1d6
|
Add inline comment mentioning why CreateChildDependencies is being used in this instance
|
2021-06-28 14:39:55 +09:00 |
|
Dean Herbert
|
fdd6778f36
|
Merge branch 'master' into fix-initial-ruleset-skin-loading
|
2021-06-28 14:35:34 +09:00 |
|
Dean Herbert
|
a3946a1265
|
Fix typo in newly added xmldoc
Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>
|
2021-06-28 14:07:21 +09:00 |
|
Henry Lin
|
3d19364a71
|
Use BindValueChanged instead of setting the value in property setter
|
2021-06-28 11:20:00 +08:00 |
|
Dean Herbert
|
4d6002ab88
|
Remove redundant string interpolation (and mark all local logging strings as verbatim)
|
2021-06-28 12:16:15 +09:00 |
|
Henry Lin
|
0cceef8da5
|
Moved the string to int? conversion logic into SettingsNumberBox
|
2021-06-28 11:00:07 +08:00 |
|
Dean Herbert
|
4a557e73a7
|
Add logging to help understand existing case skips better
|
2021-06-28 10:42:42 +09:00 |
|
Dean Herbert
|
128f08ccba
|
Fix test oversights
|
2021-06-28 10:42:28 +09:00 |
|
Dan Balasescu
|
9c0840268a
|
Merge pull request #13598 from JimmyC7834/supporter-only-filter-content
Add supporter required placeholder in beatmap listing overlay
|
2021-06-28 10:27:56 +09:00 |
|
Dean Herbert
|
90b87cbb9e
|
Add back unidirectional online id check
|
2021-06-28 10:11:27 +09:00 |
|
Dean Herbert
|
9a96cd4a1d
|
Revert "Remove comparison of online beatmap IDs during dedupe checks"
This reverts commit 15af28d2a0.
|
2021-06-28 09:54:18 +09:00 |
|
Dean Herbert
|
a1e8cc5444
|
Merge pull request #13669 from Naxesss/hitsound-checks
Add hitsound checks
|
2021-06-28 03:13:43 +09:00 |
|
Naxess
|
b58644106c
|
Add nested hitobject tests for few hitsounds check
|
2021-06-27 15:58:00 +02:00 |
|
Naxess
|
1dbac76da5
|
Use local variables for common sample lists
|
2021-06-27 15:57:41 +02:00 |
|
Naxess
|
9f9e96ce9e
|
Add check for spanDuration <= 0 prior to division
|
2021-06-27 15:40:09 +02:00 |
|
Naxess
|
a4a5325b73
|
Improve acceptable difference for repeat edges
Likelihood that `spanDuration` is greater than E+7 is quite low in any realistic case, so this should work fine.
|
2021-06-27 15:39:31 +02:00 |
|
Naxess
|
1d5bff1660
|
Add concurrent hitobjects test for few hitsounds check
See https://github.com/ppy/osu/pull/13669#discussion_r659314980
|
2021-06-27 15:26:52 +02:00 |
|
Naxess
|
c2ceb83bbb
|
Move MockNestedHitObject to own class
|
2021-06-27 15:16:40 +02:00 |
|
Dean Herbert
|
e755dcc34d
|
Add log method for new flow
|
2021-06-27 20:37:12 +09:00 |
|
Dean Herbert
|
f470b7095d
|
Move private method down in class
|
2021-06-27 20:36:01 +09:00 |
|
Dean Herbert
|
cd9aa38d3d
|
Add back ignore cases for intentionally broken tests
|
2021-06-27 20:24:16 +09:00 |
|
Dean Herbert
|
f216404952
|
Fix missing undelete call on using existing
|
2021-06-27 20:22:48 +09:00 |
|
Bartłomiej Dach
|
8f5e3092ab
|
Merge pull request #13671 from peppy/import-process-clean-up
Tidy up some areas of `ArchiveModelManager` / beatmap imports
|
2021-06-27 12:12:04 +02:00 |
|
Dean Herbert
|
9120321731
|
Add comments mentioning shortcomings and avoid potential double check
|
2021-06-27 19:07:35 +09:00 |
|
Dean Herbert
|
44f875b802
|
Bypass optimised existing check in SkinManager (due to custom hashing function)
|
2021-06-27 16:35:13 +09:00 |
|
Dean Herbert
|
e493685c14
|
Add optimised existing check earlier in import process
|
2021-06-27 16:34:40 +09:00 |
|
Dean Herbert
|
15af28d2a0
|
Remove comparison of online beatmap IDs during dedupe checks
|
2021-06-27 14:48:57 +09:00 |
|
Dean Herbert
|
46f8100f43
|
Remove overly verbose logging during beatmap imports
|
2021-06-27 14:29:02 +09:00 |
|
Dean Herbert
|
d1f852d102
|
Make Populate abstract to avoid unnecessary base call async complexity
|
2021-06-27 14:29:02 +09:00 |
|
Dean Herbert
|
f6919b70c9
|
Merge pull request #13668 from gagahpangeran/od-filter
Add overall difficulty in query search filter
|
2021-06-27 12:00:36 +09:00 |
|
Naxess
|
4cfa0ae5ec
|
Improve precision for repeat edges
|
2021-06-27 03:26:35 +02:00 |
|
Naxess
|
2cd7eda3c4
|
Add "or equal to" to volume threshold xmldocs
|
2021-06-27 02:30:12 +02:00 |
|
Naxess
|
0c0fd291d9
|
Order hitobjects by endtime
|
2021-06-27 01:25:03 +02:00 |
|
Naxess
|
4796b1b208
|
Use local variables for hasHitsound & couldHaveHitsound
|
2021-06-27 00:04:30 +02:00 |
|
Naxess
|
5bc08ebadb
|
Rename hasHitsounds -> mapHasHitsounds
|
2021-06-26 23:49:25 +02:00 |
|
Naxess
|
d29e6f4695
|
Add negligible template to PossibleTemplates
|
2021-06-26 23:49:06 +02:00 |
|
Naxess
|
1913084342
|
Use HitSampleInfo.AllAdditions instead of new list
|
2021-06-26 23:48:28 +02:00 |
|
Naxess
|
5642d321b7
|
Fix comments in few hitsounds check tests
|
2021-06-26 23:43:08 +02:00 |
|
Naxess
|
f78cc9397e
|
Factor out edge type logic
|
2021-06-26 20:45:31 +02:00 |
|
Naxess
|
51147405c5
|
Make || and && priority explicit
|
2021-06-26 20:44:39 +02:00 |
|
Bartłomiej Dach
|
9061ab0a27
|
Update/reword comments in listing overlay
|
2021-06-26 20:42:13 +02:00 |
|
Bartłomiej Dach
|
b56dd7ff25
|
Fix naming and xmldocs in new beatmap search result structures
|
2021-06-26 20:35:07 +02:00 |
|
Bartłomiej Dach
|
709e555566
|
Rename test steps for legibility
|
2021-06-26 20:27:15 +02:00 |
|
Bartłomiej Dach
|
b7c4fe2052
|
Rewrite test helpers to also handle clearing filters
|
2021-06-26 20:25:43 +02:00 |
|