apollo-dw
40f560d7d0
Remove internal process method
2022-05-22 21:45:27 +01:00
apollo-dw
26985ca8af
Store hitobject history in the hitobject
2022-05-22 16:26:22 +01:00
Dean Herbert
d84119ac06
Merge pull request #18343 from frenzibyte/waveform-test-beatmap-failure
...
Fix `WaveformTestBeatmap`s potentially providing disposed track
2022-05-22 21:21:28 +09:00
Dean Herbert
8f20e9c04c
Merge pull request #18356 from bdach/fix-sheared-button-borders
...
Fix appearance of sheared button borders after click
2022-05-22 04:25:15 +09:00
Bartłomiej Dach
21e1576b2f
Fix appearance of sheared button borders after click
...
The border would previously get brighter after click, but then dim
instantly when the flash layer has fully faded out. The underlying issue
there is https://github.com/ppy/osu-framework/issues/5191 , but
`ShearedButton` was placing the flashing layer incorrectly anyway, as
the intent was that it should also apply to the border.
2022-05-21 20:53:23 +02:00
Salman Ahmed
a17eed64f9
Use Track to ensure its loaded before transferring
2022-05-21 16:52:16 +03:00
Salman Ahmed
a42f5ea34e
Bring back virtual track condition given its cheapness
...
Will still keep the override in `ClockBackedTestWorkingBeatmap` because
it still relies on a local track store and will fail the moment it uses
a non-virtual track.
2022-05-21 16:51:56 +03:00
Salman Ahmed
466ed3c791
Fix wrong return xmldoc
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2022-05-21 16:43:31 +03:00
Dan Balasescu
6994b8d392
Merge pull request #18347 from peppy/update-framework
...
Update framework
2022-05-21 16:19:01 +09:00
Dean Herbert
c587d10cc3
Revert storage workaround
2022-05-21 15:55:07 +09:00
Dean Herbert
ba21556d4e
Update framework
2022-05-21 15:54:43 +09:00
Dean Herbert
fa1d267b10
Merge branch 'safe-file-writes' into update-framework
2022-05-21 15:17:52 +09:00
Dean Herbert
982856a8b2
Merge branch 'localisable-filter-items' into update-framework
2022-05-21 15:17:51 +09:00
Dean Herbert
72386d9377
Fix incorrect storage being used in CreateFileSafely implementation
2022-05-21 15:17:10 +09:00
Dean Herbert
2f69c099cd
Merge branch 'master' into safe-file-writes
2022-05-21 15:16:20 +09:00
Dean Herbert
5bf17dde9f
Fix missing MutatePath calls
2022-05-21 14:43:35 +09:00
Dean Herbert
98e5bbd4f9
Merge pull request #18345 from frenzibyte/bpm-display-rounding-fix
...
Fix song select potentially displaying BPM range with equal min/max values
2022-05-21 13:51:51 +09:00
Salman Ahmed
1f17652c1d
Fix test failure due to async-loading of content
2022-05-20 19:08:41 +03:00
Dean Herbert
7dcb88759a
Remove unnecessary using statement
2022-05-21 00:28:17 +09:00
Salman Ahmed
84a3cee452
Apply rate multiplier outside BPM rounding
2022-05-20 18:04:12 +03:00
Dean Herbert
4633eed78c
Merge branch 'master' into localisable-filter-items
2022-05-20 23:55:16 +09:00
Salman Ahmed
596853da8f
Fix song select potentially displaying BPM range with equal min/max values
2022-05-20 17:53:28 +03:00
Salman Ahmed
de8aedf348
Add failing test case
2022-05-20 17:53:28 +03:00
Dean Herbert
2b3ec53fed
Merge branch 'safe-file-writes' into localisable-filter-items
2022-05-20 23:51:24 +09:00
Dean Herbert
a2950d9d4e
Update framework
2022-05-20 23:49:03 +09:00
Salman Ahmed
abf9039109
Use == instead of ??
2022-05-20 16:08:31 +03:00
Salman Ahmed
cef99fd020
Disallow transferring track from test WorkingBeatmaps which have local stores
2022-05-20 16:08:31 +03:00
Salman Ahmed
c78d90ccbd
Refactor track transferring logic for ability to override and disallow
2022-05-20 14:43:07 +03:00
Dan Balasescu
64a371638e
Merge pull request #18236 from peppy/snap-unification
...
Add `enum` to snap method as alternative to multiple nested invocations
2022-05-20 11:35:05 +09:00
Dean Herbert
77b4bd97f8
Merge pull request #18156 from ekrctb/catch-editor-per-object-sv
...
Automatically adjust per-hit object slider velocity in osu!catch editor
2022-05-19 19:12:38 +09:00
Dan Balasescu
bef0cbf178
Merge pull request #18335 from peppy/better-first-run-toolbar-handling
...
Fix toolbar potentially being in incorrect state after exiting the first run setup
2022-05-19 17:20:47 +09:00
Dean Herbert
363e7a6f53
Simplify toolbar hiding logic in FirstRunSetupOverlay
...
Rather than fiddling around with the activation modes, this seems like a
much cleaner way to make things work.
Closes https://github.com/ppy/osu/issues/18277 .
2022-05-19 16:42:48 +09:00
Dean Herbert
b3d6f76cfa
Add "None" snap type to fix flags not working correctly
2022-05-19 15:57:17 +09:00
Dean Herbert
5af7641e94
Add safety against playfield potentially not being available during mania note placement
2022-05-19 15:53:53 +09:00
Dean Herbert
16075d2a2f
Merge pull request #18321 from smoogipoo/legacy-catmull
...
Fix compatibility issues with legacy Catmull sliders
2022-05-19 15:42:21 +09:00
Dean Herbert
d187ca2d8c
Merge pull request #18246 from jai-x/new-chat-cache-loaded-channels
...
Add drawable channel caching to new chat overlay
2022-05-19 15:15:47 +09:00
Dan Balasescu
5709dc566a
Merge pull request #18313 from peppy/first-run-screen-import-from-stable
...
Add first run screen for importing from previous installation
2022-05-19 14:56:44 +09:00
Dean Herbert
ce3a3542ea
Merge pull request #18333 from peppy/ignore-misc-xml
...
Delete and ignore rider's `misc.xml`
2022-05-19 14:03:27 +09:00
Dean Herbert
70bd40ce44
Fix incorrect count of beatmaps available to import
2022-05-19 14:01:24 +09:00
Dean Herbert
f6fb8f3fb9
Delete and ignore rider's misc.xml
...
This file has changed on us too many times. Doesn't seem to contain
anything of value.
2022-05-19 13:55:19 +09:00
Dean Herbert
a443200d0d
Make dependency nullable to allow for safer disposal unbinding
2022-05-19 13:49:52 +09:00
Dean Herbert
1f6f06562b
Merge pull request #18329 from smoogipoo/ci-improvements
...
Bust CI cache on CodeAnalysis ruleset changes
2022-05-19 12:44:50 +09:00
Dan Balasescu
3bca014b52
Bust CI cache on CodeAnalysis ruleset changes
2022-05-19 09:44:11 +09:00
Salman Ahmed
5d3878a737
Add test coverage for slow-loading channels
2022-05-18 22:58:39 +03:00
Jai Sharma
371738b047
Check against the loaded drawable channel
2022-05-18 20:00:42 +01:00
Salman Ahmed
ccecf1cd6a
Merge pull request #18322 from peppy/banned-symbol-guid
...
Add `new Guid` bannedsymbols rule
2022-05-18 21:02:17 +03:00
Salman Ahmed
f5235f6a56
Correctify recommended method and property
2022-05-18 20:38:13 +03:00
Dean Herbert
0cee90e156
Add common strings for missing localisable content
2022-05-18 21:32:57 +09:00
Dean Herbert
d54e1503c7
Rename interaction toggle method
2022-05-18 21:32:57 +09:00
Dean Herbert
fa09270e62
Remove left-over todo
2022-05-18 21:32:57 +09:00
