68215 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
Dan Balasescu	3dd7db5499	Merge pull request #29046 from peppy/disable-macos-runs ... Disable macOS test runs for now	2024-07-25 09:49:00 +09:00
Dean Herbert	4cc07badbd	Disable macOS test runs for now ... We are seeing update frames run as little as [once per second](aa4d16bdb8/osu.Game/Overlays/BeatmapListingOverlay.cs (L141)). Until we can ascertain why this is happening, let's reduce developer stress by not running macOS tests for now.	2024-07-25 09:05:58 +09:00
Dan Balasescu	d057bee4fb	Merge pull request #29044 from frenzibyte/fix-drag-overwritten-by-focus ... Fix dragging number boxes no longer working correctly	2024-07-25 08:36:39 +09:00
Salman Ahmed	b3e3bf7cec	Add lenience to avoid floating point errors	2024-07-24 23:26:23 +03:00
Salman Ahmed	6645dac71d	Fix dragging number boxes overwritten by select-all-on-focus feature	2024-07-24 23:19:04 +03:00
Dean Herbert	4983e5f33e	Merge pull request #29039 from bdach/multiple-selection-sample-popover ... Make sample popover change properties of all samples in multiple selection	2024-07-24 22:49:20 +09:00
Bartłomiej Dach	1ed7e4b075	Make sample popover change properties of all samples in multiple selection ... Closes https://github.com/ppy/osu/issues/28916. The previous behaviour *may* have been intended, but it was honestly quite baffling. This seems like a saner variant.	2024-07-24 12:15:12 +02:00
Bartłomiej Dach	55382a4ba6	Add test coverage for expected sample popover behaviour	2024-07-24 12:08:13 +02:00
Dean Herbert	6e4625609d	Merge pull request #29036 from bdach/hardcode-positions-for-leaderboard ... Fill daily challenge top 50 position numbers client-side	2024-07-24 17:49:51 +09:00
Dean Herbert	65fcef1929	Merge pull request #29037 from bdach/daily-challenge-exit-when-offline ... Exit daily challenge screen when going offline	2024-07-24 17:48:07 +09:00
Bartłomiej Dach	788b70469d	Exit daily challenge screen when going offline ... This sort of thing is bound to happen when rewriting screens from scratch without invoking abstract eldritch entities sometimes. Damned if you do, damned if you don't...	2024-07-24 09:15:32 +02:00
Bartłomiej Dach	bf4bf4d39e	Fill daily challenge top 50 position numbers client-side ... Only doing this client-side, because doing this server-side is expensive: https://github.com/ppy/osu-web/pull/11354#discussion_r1689224285	2024-07-24 08:57:11 +02:00
Dean Herbert	aded31bd07	Merge pull request #29021 from bdach/editor-breaks-respect-time-preempt ... Respect pre-empt time when auto-generating breaks	2024-07-24 15:21:12 +09:00
Dean Herbert	a9ccb50b98	Merge pull request #29020 from bdach/drag-selection-tolerance ... Add tolerance when drag-scrolling editor timeline	2024-07-23 22:28:29 +09:00
Dean Herbert	aed7ba9508	Change order of application to avoid bias to side with more room to drag ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2024-07-23 20:56:21 +09:00
Bartłomiej Dach	c3062f96ee	Fix autogenerated breaks not invalidating on change to pre-empt time	2024-07-23 13:38:50 +02:00
Bartłomiej Dach	c2fa30bf81	Add test coverage for break generation respecting pre-empt time	2024-07-23 13:38:25 +02:00
Bartłomiej Dach	088e8ad0a2	Respect pre-empt time when auto-generating breaks ... Closes https://github.com/ppy/osu/issues/28703.	2024-07-23 13:30:13 +02:00
Bartłomiej Dach	25d63ac6a5	Move editor beatmap processor test cases off of OsuHitObjects ... Most of them are about to become obsolete once consideration for `TimePreempt` is re-added.	2024-07-23 13:28:49 +02:00
Dean Herbert	40b171f544	Merge pull request #29019 from bdach/catch-juice-stream-editing-weirdness-continued ... Fix duration fluctuations and one-frame jitters when editing juice streams	2024-07-23 19:02:30 +09:00
Dean Herbert	cc4ed0ff3f	Use non-screen-space coordinates and add time-based drag ramping for better control	2024-07-23 18:59:22 +09:00
Bartłomiej Dach	38fc6f70f6	Add tolerance when drag-scrolling editor timeline ... Closes https://github.com/ppy/osu/issues/28983. While the direct cause of this is most likely mouse confine in full-screen, it shouldn't/can't really be disabled just for this, and I also get this on linux in *windowed* mode. In checking other apps, adding some tolerance to this sort of drag-scroll behaviour seems like a sane UX improvement anyways.	2024-07-23 11:10:18 +02:00
Dean Herbert	aba05a21aa	Merge branch 'master' into catch-juice-stream-editing-weirdness-continued	2024-07-23 17:05:40 +09:00
Dean Herbert	5911c42116	Merge pull request #28999 from bdach/catch-juice-stream-editing-weirdness ... Fix various shortcomings in juice stream selection blueprint	2024-07-23 16:43:39 +09:00
Bartłomiej Dach	6100f5269d	Fix tests	2024-07-23 09:13:43 +02:00
Bartłomiej Dach	f3617eadad	Fix editing juice stream path sometimes changing its duration ... I'm not *super* sure why this works, but it appears to, and my educated guess as to why is that it counteracts the effects of a change in the SV of the juice stream by artificially increasing or decreasing the velocity when running the appropriate path conversions and expected distance calculations. The actual SV change takes effect on the next default application, which is triggered by the `Update()` call at the end of the method.	2024-07-22 15:14:45 +02:00
Bartłomiej Dach	56af009e77	Fix EditablePath.UpdateHitObjectFromPath() not automatically updating object ... This is important because the editable path conversions heavily depend on the value of `JuiceStream.Velocity` being correct. The value is only guaranteed to be correct after an `ApplyDefaults()` call, which is triggered by updating the object via `EditorBeatmap`.	2024-07-22 14:50:25 +02:00
Bartłomiej Dach	1d91201c43	Fix tests	2024-07-22 13:37:24 +02:00
Bartłomiej Dach	6b3c1f4e47	Unify juice stream piece UX with osu! control point pieces ... - Use same hover state - Use shift-right click for quick delete rather than shift-left click	2024-07-22 13:30:15 +02:00
Bartłomiej Dach	47964f33d7	Fix catch juice stream vertex remove operation not undoing	2024-07-22 13:21:49 +02:00
Bartłomiej Dach	64381d4087	Fix catch juice stream vertex add operation not undoing	2024-07-22 12:18:53 +02:00
Dean Herbert	7e5fda4539	Merge pull request #28996 from bdach/fix-dim-again ... Fix editor UI dimming when hovering over expanded part of toolboxes	2024-07-22 19:11:31 +09:00
Bartłomiej Dach	57fa502786	Fix editor UI dimming when hovering over expanded part of toolboxes ... Closes https://github.com/ppy/osu/issues/28969.	2024-07-22 11:57:46 +02:00
Bartłomiej Dach	dd8be62d07	Merge pull request #28849 from frenzibyte/custom-profile-colour ... Add custom hue support to user profile overlay	2024-07-22 09:41:32 +02:00
Bartłomiej Dach	088b8aff11	Merge pull request #28881 from smoogipoo/fix-judgement-cut ... Fix judgement animation getting cut early	2024-07-22 09:24:57 +02:00
Dean Herbert	15220f3bf4	Merge pull request #28954 from frenzibyte/fix-pause-input-handling ... Fix held gameplay keys stuck after pausing and resuming	2024-07-20 15:45:19 +09:00
Dean Herbert	401c0fe2bf	Merge branch 'master' into fix-pause-input-handling	2024-07-20 15:23:34 +09:00
Dean Herbert	88929a5636	Merge pull request #28963 from peppy/update-framework ... Update framework	2024-07-20 15:23:21 +09:00
Dean Herbert	d914b990f3	Update framework	2024-07-20 14:08:00 +09:00
Salman Ahmed	e539670df1	Add explanatory note	2024-07-19 19:19:36 +03:00
Salman Ahmed	818b60a3d8	Fix pause overlay hiding input from ruleset input manager ... If a key is pressed while the pause overlay is visible, the ruleset input manager will not see it, therefore if the user resumes while the key is held then releases the key, the ruleset input manager will not receive the key up event.	2024-07-19 18:48:35 +03:00
Salman Ahmed	4f6c7fe7c3	Schedule resume operation by one frame to ensure the triggered key down event does not cause a gameplay press	2024-07-19 18:48:35 +03:00
Salman Ahmed	d7651ef387	Add extensive test cases for correct input handling while paused in osu! & non-osu!	2024-07-19 18:48:35 +03:00
Bartłomiej Dach	2bd4a5e16b	Merge pull request #28949 from peppy/hold-off-incompatibility ... Make "Hold Off" and "No Release" mod incompatible	2024-07-19 14:36:45 +02:00
Bartłomiej Dach	41bad54313	Merge pull request #28948 from peppy/editor-blah ... Minor editor design tweaks	2024-07-19 13:49:42 +02:00
Bartłomiej Dach	27000aa8ed	Merge branch 'master' into editor-blah	2024-07-19 13:42:40 +02:00
Salman Ahmed	ce0397aaef	Merge branch 'master' into hold-off-incompatibility	2024-07-19 14:38:10 +03:00
Dan Balasescu	ad564f31cb	Merge pull request #28947 from peppy/fix-playlist-item-panel ... Fix various visuals of playlist beatmap panels	2024-07-19 20:12:40 +09:00
Dean Herbert	f500abd4f7	Make "Hold Off" and "No Release" mod incompatible	2024-07-19 14:08:39 +03:00
Dean Herbert	c2cc85e6f0	Use purple again for kiai time specifically	2024-07-19 19:59:38 +09:00