436 Commits

• Load items closer to the centre of the screen as a priority
  Dean Herbert · 2024-01-04 19:25:12 +09:00
  81c6fd5589
• Fix beatmap carousel not preloading panels when off-screen
  Dean Herbert · 2024-01-04 19:25:12 +09:00
  adac3b65ce
• Fix rewind backtracking
  Nathan Tran · 2023-12-25 15:27:32 -08:00
  060bf8beff
• Fix selection retention logic copy paste failure
  Dean Herbert · 2023-12-20 19:27:57 +09:00
  7fa4dcf0fb
• Fix beatmap updates causing one extra carousel selection
  Dean Herbert · 2023-12-20 19:15:02 +09:00
  e003462f7d
• Fix song select running updates when screen is not active

  Who would have guessed that `Schedule` calls were there for a reason!
  
  I've tidied things up. Most of the changes I've made here are not
  required – the schedule is the main thing here. The reason the sound was
  playing is because one-too-many schedules was removed causing beatmap
  updates to update carousel specifics while still at the player loader
  screen.
  
  Note that the selection sound still plays on returning to song select,
  but this is not a regression. I'm looking at fixing this in a separate
  PR because I'm in a good place as far as understanding the logic right
  now and it would be a waste to leave it broken.
  
  Closes https://github.com/ppy/osu/issues/25875.

  Dean Herbert · 2023-12-20 17:31:09 +09:00
  64f62e7d90
• Add missing invalidation call
  Dean Herbert · 2023-12-19 19:39:48 +09:00
  502e3edac3
• Actually fix realm selection retention regression
  Dean Herbert · 2023-12-19 18:10:55 +09:00
  8f5d21dc70
• Use sender's realm (because we can)
  Dean Herbert · 2023-12-19 17:27:52 +09:00
  7e9c1b2acb
• Fix a few of silly issues
  Dean Herbert · 2023-12-18 22:45:58 +09:00
  25e3a8e82e
• Cache non-filtered beatmap counts to massively improve count performance
  Dean Herbert · 2023-12-18 20:44:08 +09:00
  5755fa214a
• Simplify invalidation logic

  The only case where this was checking is guaranteed by realm to only be called once.

  Dean Herbert · 2023-12-18 20:31:02 +09:00
  6fa1f5ef9b
• Avoid calling invalidation logic per beatmap set updated

  Realm will batch the updates. We don't want to do expensive operations per set when we don't need to.

  Dean Herbert · 2023-12-18 20:31:02 +09:00
  87b7699fcc
• Combine multiple similar invalidation logic into single event
  Dean Herbert · 2023-12-18 20:31:02 +09:00
  32cc3f9ef7
• Allow interacting with the carousel anywhere in empty space at song select
  Dean Herbert · 2023-10-20 20:04:11 +09:00
  137a1d948d
• Fix status on carousel beatmap set not showing in split difficulty mode
  Bartłomiej Dach · 2023-09-06 08:25:19 +02:00
  63e92f8fab
• Fix changes to beatmap sets being undone on switching sort mode
  Bartłomiej Dach · 2023-08-28 11:02:22 +02:00
  b9795eb3d4
• Fix incorrect selection restore code in split case

  The fallback to "any of the added sets" needs to be applied after
  they've all been added, rather than with every added one. Otherwise, in
  flows that expect a particular difficulty to be selected in the end
  (such as exiting from editor) would end up switching away from the
  edited beatmap.

  Bartłomiej Dach · 2023-08-28 10:06:26 +02:00
  80ec18d117
• Fix online ID not being propagated in split difficulty mode

  Would result in failures to re-download the beatmap in update flows, for
  instance.

  Bartłomiej Dach · 2023-08-28 10:05:59 +02:00
  0af6cc1394
• Rename remove method to better explain return type being IEnumerable
  Dean Herbert · 2023-08-25 18:10:54 +09:00
  10b1450138
• Reduce complexity of selection restore
  Dean Herbert · 2023-08-25 00:52:54 +09:00
  89eeff515b
• Fix typo in local variable
  Dean Herbert · 2023-08-24 18:33:15 +09:00
  9e94f38091
• Fix selection not being retained when switching between split mode
  Dean Herbert · 2023-08-22 18:49:02 +09:00
  018be4c20f
• Fix incorrect handling when new beatmaps arrive
  Dean Herbert · 2023-08-22 18:48:07 +09:00
  ecbf0f138e
• Ensure ID is maintained in temporary BeatmapSetInfos
  Dean Herbert · 2023-08-22 18:48:07 +09:00
  2b1c6ae612
• Split out difficulties in beatmap carousel in a bit of a hacky way

  Seems like the simplest path forward for now, without a full rewrite.

  Dean Herbert · 2023-08-22 18:47:41 +09:00
  290d18ad69
• Bring realm library up-to-date
  Dean Herbert · 2023-07-06 13:37:43 +09:00
  a98a36872e
• Use better method to avoid rewinding to deleted beatmaps
  Salman Ahmed · 2023-06-15 11:22:11 +03:00
  39db17d2e9
• Add extra check in 'SelectPreviousRandom'

  Check if the poped beatmap exists within the beatmapSets

  Renzo Poggio · 2023-04-25 00:05:15 -03:00
  0991c56e1c
• Adjust BeatmapSetsChanged xmldoc

  Co-Authored-By: Dean Herbert <pe@ppy.sh>

  Joseph Madamba · 2023-04-10 11:28:23 -07:00
  f80de08f24
• Use existing BeatmapSetsChanged action
  Joseph Madamba · 2023-04-10 11:26:18 -07:00
  c7dea71793
• Fix song select beatmap difficulty count not updating when deleting
  Joseph Madamba · 2023-04-09 22:12:51 -07:00
  7f5b99c91b
• Show count of visible beatmaps at song select
  Dean Herbert · 2023-03-03 15:28:51 +09:00
  dc669835e2
• Move IsLoaded check inside BeatmapCarousel
  Dean Herbert · 2023-01-18 12:00:47 +09:00
  4ad79a8a0a
• Use OfType instead of forceful nullability
  Dean Herbert · 2023-01-10 17:52:21 +09:00
  93038ce496
• Further fix nullability
  mk56-spn · 2023-01-09 20:59:28 +01:00
  6abbc7dc28
• remove unnecessary usages of nullable forgiveness, add asserts for debugging
  mk56-spn · 2023-01-09 18:36:55 +01:00
  69260ca3c3
• Remove nullable disabling in carousel
  mk56-spn · 2023-01-08 19:02:48 +01:00
  47fb467012
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Fix phantom beatmap sets appearing on carousel after delete/update

  Regressed in c40c70509e.
  
  As it turns out, `item.Item.Filtered.Value` is not the only condition
  that should be checked to determine if a carousel item should be hidden
  or not - `item.Item.State.Value != CarouselItemState.Collapsed` should
  also be true. This was even available as the `item.Item.Visible`
  convenience property, which is used in this commit.
  
  Failing to check `item.Item.State.Value` led to setting non-zero alpha
  on collapsed carousel items, leading to phantom beatmap sets appearing,
  as the alpha was set in the entire carousel's `Update()` method, thus
  firing every frame.

  Bartłomiej Dach · 2022-11-20 10:08:34 +01:00
  7b274083d3
• Improve song select transition to gameplay
  Dean Herbert · 2022-11-04 15:24:37 +09:00
  c40c70509e
• Merge branch 'master' of https://github.com/ppy/osu into carousel-perform-selection

  
   Conflicts:
  
  	osu.Game.Tests/Visual/SongSelect/TestSceneBeatmapCarousel.cs

  Endrik Tombak · 2022-10-24 21:40:48 +03:00
  5a118cfdc3
• Fix weird edge case of nullability in CarouselRoot

  A bit unfortunately, but it's what we get for having ctor level bindings..

  Dean Herbert · 2022-09-07 14:27:25 +09:00
  f3bda4e040
• Fix missing null checks on selectedBeatmap fields in BeatmapCarousel
  Dean Herbert · 2022-09-07 14:12:35 +09:00
  e18b524f8e
• Apply NRT to BeatmapCarousel
  Dean Herbert · 2022-09-07 14:07:53 +09:00
  241d33d415
• Update comment to include inserted indices
  Salman Ahmed · 2022-08-26 14:51:19 +03:00
  a3e595a9aa
• Fix selection fallback path not updated to check inserted indices
  Salman Ahmed · 2022-08-26 14:51:08 +03:00
  81c0a641b4
• Merge branch 'master' into carousel-perform-selection
  Dean Herbert · 2022-08-26 19:29:00 +09:00
  a146db0e35
• Change conditional to check for insertions in addition to modifications

  It is possible that the import process itself marks the previous
  beatmaps as deleted due to an overlap in metadata or otherwise.

  Dean Herbert · 2022-08-16 16:21:36 +09:00
  9d2c2b71cf
• Guard against NewModifiedIndices being empty
  Dean Herbert · 2022-07-27 14:23:47 +09:00
  e6a3659581