Bartłomiej Dach
5fcea01c13
Merge branch 'master' into ruleset-specific-combo-counter
2024-06-04 15:44:11 +02:00
Bartłomiej Dach
a23d25e0a1
Fix BeatmapAttributeText breaking due to enum serialisation woes
2024-05-03 14:27:34 +02:00
Salman Ahmed
2fd8950b21
Disable inconsistent naming in some fields of LegacyManiaSkinConfigurationLookup
2024-05-01 17:22:10 +03:00
Dean Herbert
16fdd4e08d
Add ability to show beatmap source using skin editor's beatmap attribute text
...
As per https://github.com/ppy/osu/discussions/27955 .
2024-04-24 09:01:31 +08:00
Bartłomiej Dach
3d64ffc93e
Merge pull request #27935 from smoogipoo/serialised-drawable-sane-defaults
...
Give SerialisedDrawableInfo sane defaults
2024-04-19 17:00:49 +02:00
Dan Balasescu
bac70da1a1
Give SerialisedDrawableInfo sane defaults
2024-04-19 22:03:19 +09:00
Dean Herbert
6e08fd7f27
Merge pull request #27931 from smoogipoo/remove-unused-lookup-members
...
Remove unused members from GameplaySkinComponentLookup
2024-04-19 20:51:09 +08:00
Dan Balasescu
ddc1b90ee1
Remove unused method
2024-04-19 20:36:24 +09:00
Dan Balasescu
362a7b2c77
Remove unused members from GameplaySkinComponentLookup
2024-04-19 18:03:13 +09:00
Susko3
53900d5472
Fix tests failing locally due to not using invariant culture
2024-03-27 18:56:26 +01:00
Jamie Taylor
ad842b60f5
Add support for Argon hitsounds
2024-03-08 21:43:18 +09:00
Dean Herbert
d9cc619693
Merge branch 'master' into argon-pp-counter
2024-03-08 10:32:16 +08:00
Dean Herbert
9286398633
Move naming migrations to more correct place
2024-03-08 10:26:08 +08:00
Dean Herbert
0ebb12f67f
Move skinnable interface specification to non-abstract classes
2024-03-08 10:23:46 +08:00
Dean Herbert
f2753ef7a2
Decrease size of pp display relative to accuracy
2024-03-08 09:41:38 +08:00
Dean Herbert
0696e7de52
Update ImageSharp usages
2024-03-06 12:13:12 +08:00
Dean Herbert
6455c0583b
Update usage of CircularProgress.Current
2024-03-06 12:13:10 +08:00
Salman Ahmed
49b3e81e8a
Migrate DefaultPerformancePointsCounter and rename it
2024-03-05 04:35:39 +03:00
Salman Ahmed
0cbcfcecdc
Integrate "Argon" performance points counter with HUD layout
2024-03-05 03:58:43 +03:00
Bartłomiej Dach
c21af1bf3d
Use more explicit match
...
`taiko-bar-right-glow` is a prefix of `taiko-bar-right`...
2024-02-06 14:53:01 +01:00
Bartłomiej Dach
27b97a3c4d
Convert selected legacy skin sprites to grayscale
...
Matching stable.
Closes https://github.com/ppy/osu/issues/9858 .
I would have liked to apply this in the taiko transformer itself, but
the limited accessibility of texture uploads, and as such the raw image
data, sort of prevents that...
2024-02-06 12:33:37 +01:00
Dean Herbert
ebf637bd3c
Adjust slider tick / end misses to show slightly longer
2024-01-31 17:41:26 +09:00
Bartłomiej Dach
c5e118bd10
Revert "Move fade more local to avoid fading twice"
...
This reverts commit d0421fe206https://github.com/ppy/osu/issues/26801 .
https://github.com/ppy/osu/pull/26703#discussion_r1469409667
was correct in saying that the early fade-out needs to be restored, and
that's because of the early-return. Legacy judgements that are the
temporary displayed judgement from new piece should also receive the
fade-out, and d0421fe206
2024-01-30 22:16:46 +01:00
Dean Herbert
8341da7586
Revert "Remove dead code" (mostly)
...
This reverts commit 6070eac6ee
2024-01-29 19:43:40 +09:00
Dean Herbert
d0421fe206
Move fade more local to avoid fading twice
2024-01-25 19:31:57 +09:00
Dean Herbert
6070eac6ee
Remove dead code
2024-01-25 19:31:57 +09:00
Dean Herbert
47e9846315
Adjust slider tick / end miss animations to be less busy
2024-01-22 18:48:48 +09:00
Salman Ahmed
06da7f74de
Merge branch 'master' into fix-storyboard-sprites-2
2024-01-17 18:43:25 +03:00
Dean Herbert
e260e75fac
Merge pull request #26594 from frenzibyte/fix-storyboard-sprites-1
...
Change legacy beatmap skins to not handle `@2x` textures (to match stable)
2024-01-18 00:40:29 +09:00
Salman Ahmed
e54d20ea93
Remove ancient osu-resources lookup path from legacy skin textures
2024-01-17 16:33:14 +03:00
Salman Ahmed
98c65f36c9
Disable high resolution texture lookup for legacy beatmap skins to match stable
2024-01-17 12:56:29 +03:00
Salman Ahmed
5ad2918a75
Allow disabling high resolution texture lookups in LegacySkin
2024-01-17 12:56:29 +03:00
Dean Herbert
0b5cc8fb10
Fix gameplay counter textures not being cached ahead of time
...
Part of https://github.com/ppy/osu/issues/26535 .
2024-01-15 14:01:21 +09:00
Bartłomiej Dach
593ca9f84f
Merge pull request #26468 from frenzibyte/fix-skin-parsing
...
Fix mania skin array decoder not handling malformed entries rigorously
2024-01-12 12:52:02 +01:00
Salman Ahmed
7ca4d85441
Remove unnecessary AllowThousands flag
...
The flag is there to match `float.Parse` behaviour, but it's too illogical and unnecessary to have it.
2024-01-10 17:48:48 +03:00
Salman Ahmed
698ae66a49
Fix mania skin array decoder not handling malformed entries rigorously
2024-01-10 17:41:58 +03:00
Dean Herbert
f912a1ba31
Merge branch 'master' into health-less-value-changed
2024-01-10 18:03:34 +09:00
Dean Herbert
12a59eb34c
Remove vertex update overheads
2024-01-09 17:35:01 +09:00
Dean Herbert
1837b31f9b
Remove usage of HealthDisplay.BindValueChanged
...
Health updates very often when using HP drain. Let's avoid bindable overheads.
2024-01-09 16:38:05 +09:00
Dean Herbert
dc31c66f62
Return null on font lookup failure instead of asserting
...
Fallback weirdness.
2024-01-07 20:41:58 +09:00
Dean Herbert
9d9e6fcfdb
Remove LINQ calls in hot paths
2024-01-07 14:31:22 +09:00
Dean Herbert
5b55ca6692
Cache legacy skin character glyph lookups to reduce string allocations
2024-01-05 02:26:30 +09:00
Salman Ahmed
01219fa371
Disable "closest" anchor in mania combo counter for convenience
2023-12-30 05:29:44 +03:00
Salman Ahmed
ece532b837
Add legacy mania combo counter lookups
2023-12-30 05:29:22 +03:00
Salman Ahmed
78cb6b6851
Abstractify LegacyComboCounter to re-use for mania
2023-12-30 05:29:22 +03:00
Salman Ahmed
e469e06271
Refactor CatchLegacySkinTransformer logic and remove HiddenByRulesetImplementation entirely
2023-12-30 03:55:45 +03:00
Salman Ahmed
eedb436389
Move combo counter to ruleset-specific HUD components target
2023-12-30 03:47:52 +03:00
Dan Balasescu
2ec6aa7fbb
Make mania scroll speed independent of hit position
2023-12-26 12:46:21 +09:00
Bartłomiej Dach
8142a7cb7e
Remove incorrect spec
2023-12-25 14:00:32 +01:00
Dean Herbert
b1d994b6ff
Add classic skin sprites for slider tick and slider end misses
2023-12-25 17:17:23 +09:00
Dean Herbert
c5893f245c
Change legacy version checks to account for users specifying incorrect versions
2023-12-23 14:03:45 +09:00
Bartłomiej Dach
b4e71a0787
Fix slider tick / end misses displaying with full size on legacy skins with animated misses
...
Resolves https://github.com/ppy/osu/issues/25987 .
Structure is a bit clumsy but I'm not sure how to do better...
2023-12-21 13:58:12 +01:00
Bartłomiej Dach
975bacaeb7
Add back blank line to fix code quality inspection
2023-12-20 19:07:26 +01:00
Dean Herbert
eb8fb8092d
Attempt to standardise miss handling logic
2023-12-21 00:59:35 +09:00
Dean Herbert
d2716d8557
Improve animation for legacy skins
2023-12-20 20:34:05 +09:00
Dean Herbert
9b383e3276
Add support for showing tick misses
2023-12-20 20:23:19 +09:00
Dean Herbert
0be6743e87
Apply Bindable.Parse refactorings
2023-12-13 14:07:38 +09:00
Dean Herbert
95c00f9666
Add HexaconIcons lookup to allow usage with SpriteIcon
2023-11-24 13:17:39 +09:00
Dean Herbert
5239fee947
Allow use of skin username/flag/avatar components outside of gameplay
2023-11-23 17:15:03 +09:00
Dean Herbert
b88e3cd26f
Change ResourceStore provided to Skin to be a fallback, not replacement
2023-11-16 20:19:01 +09:00
Dean Herbert
73eda6c09c
Move non-matching default value to argon skin default speficiation instead
2023-11-16 14:18:49 +09:00
Dean Herbert
2264e1e249
Change default value and range of BoxElement's corner radius to match other usages
2023-11-15 10:45:01 +09:00
Dean Herbert
74fb1b5f81
Rename property to match expctations
2023-11-15 10:40:59 +09:00
Joseph Madamba
535282ba7d
Use existing localisation for corner radius in BoxElement
2023-11-14 14:13:20 -08:00
Dean Herbert
a745642f76
Fix customised argon skins no longer loading due to incorrect resource store spec
2023-11-14 22:01:56 +09:00
Dean Herbert
469b9e2546
Increase size and adjust positioning of max combo display in argon skin
2023-11-12 17:28:15 +09:00
Bartłomiej Dach
b7972e3c84
Merge branch 'skin-size-editing' into gameplay-hud-redesign/counters
2023-11-11 20:16:14 +09:00
Dean Herbert
57cd5194ce
Flip comparison to allow non-composite drawables to still get resized
2023-11-10 20:00:20 +09:00
Bartłomiej Dach
b7acbde719
Only store width/height of serialised drawable if it isn't automatically computed
2023-11-10 19:12:26 +09:00
Bartłomiej Dach
26eae0bdee
Remove unused using directive
2023-11-10 18:25:39 +09:00
Bartłomiej Dach
43a4b34295
Fix typo
2023-11-10 18:20:14 +09:00
Bartłomiej Dach
2c1f304f3b
Fix test failures due to fluctuations in needlessly-serialised automatic sizings
2023-11-10 18:13:36 +09:00
Dean Herbert
46a219e010
Add comment explaining AutoSize change in LegacySongProgress
2023-11-10 17:53:52 +09:00
Dean Herbert
67312a2db9
Remove ArgonScoreWedge and use ArgonWedgePiece directly
2023-11-10 16:53:16 +09:00
Dean Herbert
60df2722ab
Rename RoundedLine to BoxElement and make more generically useful
2023-11-10 16:20:05 +09:00
Dean Herbert
99d9db5b76
Use a better default size for line
2023-11-10 15:53:05 +09:00
Dean Herbert
f31c1c9c79
Rename and move skinnable line component to a more commomn place
2023-11-10 15:53:05 +09:00
Dean Herbert
0add035c67
Disable resizing of LegacySongProgress
...
Because it looks bad.
2023-11-10 14:31:02 +09:00
Dean Herbert
b0c5b3cb10
Add Size to serialised components of a SerialisedDrawableInfo
2023-11-10 14:22:20 +09:00
Salman Ahmed
18c71c95cc
Merge branch 'master' into gameplay-hud-redesign/counters
2023-11-08 02:12:37 +03:00
Salman Ahmed
07b7e13633
Place health display in front of the score wedge
2023-11-08 02:07:24 +03:00
Salman Ahmed
4de5454538
Bring back left-side line next to health display
...
Makes the score counter not look weird when it reaches 8 digits
2023-11-08 02:07:15 +03:00
Salman Ahmed
e6d3085353
Update accuracy counter design
2023-11-08 02:06:14 +03:00
Salman Ahmed
cbea2db4be
Support absolute-sized health bar and use it for default layout
2023-11-08 02:06:14 +03:00
Salman Ahmed
7c1c62ba8a
Remove argon combo wedge and update combo counter position
2023-11-07 01:59:36 +03:00
Salman Ahmed
4c7db4c262
Make score counter right-aligned
2023-11-07 01:59:36 +03:00
Salman Ahmed
754e05213c
Update argon score wedge design
2023-11-07 01:59:36 +03:00
Salman Ahmed
01e59d134a
Adjust health bar settings on default components initialiser to match new layout
2023-11-07 01:59:36 +03:00
Dean Herbert
e2b07628fb
Add player name skin component
...
3 minute implementation.
Addresses https://github.com/ppy/osu/discussions/25340 .
2023-11-06 15:24:16 +09:00
Salman Ahmed
1d4f4cf4c3
Merge branch 'master' into gameplay-hud-redesign/counters
2023-11-05 02:02:36 +03:00
Salman Ahmed
6c3169a0ed
Remove PP wedge and logic for gameplay layout
2023-11-05 01:56:54 +03:00
Salman Ahmed
1c844a155e
Remove health line detail
2023-11-05 01:55:54 +03:00
Dean Herbert
0d44b5af90
Fix potential texture corruption when cropping gameplay textures of weird aspet ratios
...
Closes https://github.com/ppy/osu/issues/25273 .
2023-10-31 17:36:23 +09:00
Dean Herbert
fbba3787d1
Merge pull request #25190 from frenzibyte/match-skin-element-animation-support
...
Match capability of animating legacy skin elements with osu!(stable)
2023-10-30 18:25:06 +09:00
Dean Herbert
caddbacfe8
Merge branch 'master' into gameplay-hud-redesign/counters
2023-10-30 16:35:10 +09:00
Salman Ahmed
dca5716709
Merge branch 'master' into legacy-font-fixed-width
2023-10-28 02:45:23 +03:00
Bartłomiej Dach
99e590c8dd
Fix legacy sprite texts not matching stable with respect to fixed width
...
stable's `pSpriteText` has a `TextConstantSpacing` flag, that is
selectively enabled for some usages. In particular, these are:
- mania combo counter (not yet implemented)
- taiko combo counter (not yet implemented)
- score counter
- accuracy counter
- scoreboard entries (not yet implemented)
Everything else uses non-fixed-width fonts.
Hilariously, `LegacySpinner` _tried_ to account for this by changing
`Font` to have `fixedWidth: false` specified, only to fail to notice
that `LegacySpriteText` changes `Font` in its BDL, making the property
set do precisely nothing. For this reason, attempting to set `Font`
on a `LegacySpriteText` will now throw.
2023-10-27 20:14:39 +02:00
Bartłomiej Dach
c9cb0561f7
Move maxSizePerGlyph optional ctor param to init-only property
...
I'm doing this as I'm about to add more similar properties to
`LegacySpriteText` and I don't want to create a twenty-argument
constructor monstrosity.
2023-10-27 19:48:10 +02:00
Dean Herbert
5a9d4170e8
Merge pull request #24794 from bdach/score-encoding-cleanup
...
Correctly handle multiple online score ID types
2023-10-28 02:29:56 +09:00
Bartłomiej Dach
5ad962070c
Fix skin editor freezing game if opened during active gameplay
2023-10-27 14:34:30 +02:00
