Dean Herbert
329f1a0822
Add test coverage of original fail case and improve test reliability and code quality
2022-06-20 14:08:05 +09:00
Dean Herbert
243806e810
Move common step of toggling skin editor to own method
2022-06-20 13:32:44 +09:00
Gabe Livengood
2b0e82be40
add test coverage
2022-06-19 14:35:05 -04:00
Gabe Livengood
a5bc769243
clear skineditor selected components on hide
2022-06-19 14:34:52 -04:00
Gabe Livengood
36df1da57f
Revert "stop component transform when skineditor is hidden"
...
This reverts commit 48ffd6aeb5
2022-06-19 14:26:02 -04:00
Gabe Livengood
48ffd6aeb5
stop component transform when skineditor is hidden
2022-06-17 11:28:58 -04:00
Dean Herbert
4bc26dbb48
Merge pull request #18743 from smoogipoo/nullable-by-default
...
Enable NRT by default
2022-06-17 23:18:35 +09:00
Dean Herbert
5d93db1522
Merge pull request #18726 from peppy/disclaimer-stop-handling-after-suspend
...
Fix `Disclaimer` screen handling user change events after initial display
2022-06-17 18:28:06 +09:00
Dan Balasescu
42c97baa97
Cache bust on more files
2022-06-17 17:55:58 +09:00
Dean Herbert
1900480d51
Inline animation method
2022-06-17 17:06:06 +09:00
Dean Herbert
e51babdb96
Change heart animation flow to be more correct
2022-06-17 17:01:11 +09:00
Dan Balasescu
11bd87045e
Add automated commit to git-blame-ignore-revs
2022-06-17 16:49:53 +09:00
Dan Balasescu
fd9902e816
Manual #nullable processing
2022-06-17 16:38:35 +09:00
Dan Balasescu
f8830c6850
Automated #nullable processing
2022-06-17 16:37:17 +09:00
Dan Balasescu
968640c951
Enable NRT by default
2022-06-17 16:34:09 +09:00
Dan Balasescu
ea191da496
Merge pull request #18728 from peppy/fix-unsafe-sample-playback
...
Fix unsafe sample playback in `GameplaySampleTriggerSource`
2022-06-17 12:26:46 +09:00
Salman Ahmed
c9a02aafd8
Merge pull request #18739 from bdach/unpin-xamarin-on-ci
...
Revert Xamarin regression workaround in Android CI build definition
2022-06-17 00:10:19 +03:00
Salman Ahmed
8ee6a49ad9
Merge branch 'master' into unpin-xamarin-on-ci
2022-06-16 23:30:07 +03:00
Bartłomiej Dach
b74bb83176
Merge pull request #18737 from frenzibyte/fix-up-down
...
Fix toolbar music button handling keys while not hovered
2022-06-16 22:29:35 +02:00
Bartłomiej Dach
6f2f4dda37
Merge branch 'master' into fix-up-down
2022-06-16 21:44:56 +02:00
Bartłomiej Dach
9141a7a907
Revert Xamarin regression workaround in Android CI build definition
...
This commit is a revert of 53e52d2c4b
2022-06-16 21:03:29 +02:00
Bartłomiej Dach
73ec43338a
Merge pull request #18731 from peppy/database-migration-reliability
...
Fix database migration potentially hard crashing during backup process without informing the user why
2022-06-16 19:53:05 +02:00
Salman Ahmed
e4ddf03ad6
Fix toolbar music button handling keys while not hovered
2022-06-16 20:22:57 +03:00
Salman Ahmed
42378dbb88
Improve test coverage to ensure volume is unaffected when mouse is away
2022-06-16 20:22:57 +03:00
Bartłomiej Dach
651862fee0
Merge branch 'master' into database-migration-reliability
2022-06-16 17:19:58 +02:00
Dean Herbert
bf6c6682bc
Move null to finally
2022-06-16 23:37:24 +09:00
Dean Herbert
7809566f16
Add explanatory comments
2022-06-16 23:31:49 +09:00
Dean Herbert
7b0fad6461
Null disposal token after use
2022-06-16 23:29:33 +09:00
Dean Herbert
c7287556e5
Merge pull request #18695 from frenzibyte/first-run-setup-notification-interruption
...
Silence important notifications during first-run setup
2022-06-16 23:01:43 +09:00
Bartłomiej Dach
9c4f6d2ce0
Merge branch 'master' into first-run-setup-notification-interruption
2022-06-16 15:14:40 +02:00
Bartłomiej Dach
d8657ee9e1
Merge pull request #18734 from peppy/bmm-cleanup-2
...
Remove `RealmArchiveModelManager` from hierarchy
2022-06-16 15:14:06 +02:00
Bartłomiej Dach
c90edf49a7
Merge branch 'master' into bmm-cleanup-2
2022-06-16 13:33:20 +02:00
Bartłomiej Dach
6df4b16a89
Merge pull request #18733 from peppy/bmm-cleanup
...
More model importer clean-ups (delete `BeatmapModelManager`)
2022-06-16 13:32:55 +02:00
Dean Herbert
d48fbdb439
Merge branch 'bmm-cleanup' into bmm-cleanup-2
2022-06-16 19:48:54 +09:00
Dean Herbert
e66ccfd980
Add back missing notification flow
2022-06-16 19:48:18 +09:00
Dean Herbert
448eee051a
Update filename to match new class name
2022-06-16 19:41:14 +09:00
Dean Herbert
3860f0b3e5
Remove unused GetWorkingBetamap method
2022-06-16 19:08:59 +09:00
Dean Herbert
ce3d3a967c
Reimplement missing methods
2022-06-16 19:05:25 +09:00
Bartłomiej Dach
a635664a86
Fix invalid method reference in comment
...
`BeatmapModelManager.Save()` was moved to `BeatmapManager`, not to
`BeatmapImporter`.
2022-06-16 12:01:53 +02:00
Dean Herbert
72c5b9009d
Remove local realm fields in manager classes
2022-06-16 18:56:53 +09:00
Dean Herbert
f3984d98e6
Remove RealmArchiveModelManager from hierarchy
2022-06-16 18:53:13 +09:00
Dean Herbert
8a5755ca52
Remove pointless override in test implementation
2022-06-16 18:27:16 +09:00
Dean Herbert
04e4c5ef88
Move and adjust implementation regions to restore sanity
2022-06-16 18:26:13 +09:00
Dean Herbert
4d9e3d1982
Rename Score/Skin ModelManager classes to Importer for now
2022-06-16 18:11:50 +09:00
Dean Herbert
1f3e1b2d97
Combine BeatmapManager and BeatmapModelManager into one class
2022-06-16 18:07:04 +09:00
Dean Herbert
8ea3042435
Move file extensions specification to common class
2022-06-16 18:00:27 +09:00
Dean Herbert
84dba36cf5
Update usages of BeatmapModelManager which only require importing to use BeatmapImporter
2022-06-16 17:59:24 +09:00
Dean Herbert
4c372539a1
Consolidate remaining methods in BeatmapModelManager
2022-06-16 17:59:24 +09:00
Dean Herbert
251923c106
Convert NotificationOverlay to NRT
2022-06-16 17:28:08 +09:00
Dean Herbert
6b30ee0950
Tidy up DI and binding logic
2022-06-16 17:26:43 +09:00
