Dean Herbert
300ffbb500
Don't bother checking for null editorBeatmap
2022-10-28 14:35:55 +09:00
Dean Herbert
10c658e440
Ensure updateVisualDefinition is called once on load
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2022-10-28 14:34:24 +09:00
Dean Herbert
7faf5cd1f6
Fix one more null edge case
2022-10-28 01:20:17 +09:00
Dean Herbert
361153f598
Fix nullref in tests due to missing EditorBeatmap dependency
2022-10-27 19:05:50 +09:00
Dean Herbert
2f172b66cf
Block hover if a multi-selection is made to avoid overlapping path visualisers
2022-10-27 14:52:46 +09:00
Dean Herbert
097d310d74
Only draw path visualiser when hovered or single slider is selected
2022-10-27 14:40:14 +09:00
Dan Balasescu
7916b99153
Merge pull request #20962 from peppy/fix-toggle-mute-repeat
...
Fix toggle mute (and volume meter traversal) handling repeat key presses
2022-10-27 12:51:50 +09:00
Dan Balasescu
2d829c3beb
Merge pull request #20945 from peppy/fix-misplaced-slider-head
...
Fix slider heads getting misplaced after flipping in editor
2022-10-27 12:51:27 +09:00
Dean Herbert
14c7cbde38
Fix toggle mute (and volume meter traversal) handling repeat key presses
...
Closes #20953 .
2022-10-27 11:41:00 +09:00
Dean Herbert
1b2ee44131
Merge pull request #20658 from sw1tchbl4d3r/fix-17143
...
Fix legacy BpmMultiplier clamp value
2022-10-27 11:27:59 +09:00
Dean Herbert
2a5465129e
Merge pull request #20960 from Joehuu/fix-logo-drag-area
...
Fix osu! logo drag area being a square
2022-10-27 11:18:23 +09:00
Dean Herbert
4c128f208e
Merge pull request #20943 from peppy/fix-time-snapping-when-nearby-objects
...
Apply distance snap time component even when nearby object snap kicks in
2022-10-27 11:01:41 +09:00
Joseph Madamba
0efbae6e70
Fix osu! logo drag area being a square
2022-10-26 18:33:07 -07:00
Bartłomiej Dach
4db01fc970
Merge branch 'master' into fix-time-snapping-when-nearby-objects
2022-10-26 23:31:17 +02:00
Bartłomiej Dach
8b8d0c2293
Fix typo in comment
2022-10-26 23:30:14 +02:00
Bartłomiej Dach
90a68880ea
Merge pull request #20854 from peppy/read-current-distance-snap
...
Show distance snap at current point in time (and add ability to set as usable value)
2022-10-26 23:25:15 +02:00
Bartłomiej Dach
71425ba937
Merge branch 'master' into read-current-distance-snap
2022-10-26 22:46:42 +02:00
Bartłomiej Dach
5c4ff87d07
Merge pull request #20828 from peppy/grid-momentary-shortcuts
...
Add momentary shortcuts to toggle grid/distance snap
2022-10-26 22:04:32 +02:00
Bartłomiej Dach
f787da892b
Merge branch 'master' into grid-momentary-shortcuts
2022-10-26 21:30:24 +02:00
Dean Herbert
674ae9e742
Refactor DrawableSliderHead to never update the drawable position
...
Slider heads are guaranteed to always be drawn at (0,0). This fixes
weird behaviour in the editor, but also simplifies things in the
process. Win-win.
Closes #20644 .
2022-10-26 15:26:22 +09:00
Dean Herbert
614011d612
Update TestSceneObjectOrderedHitPolicy to provide better output
2022-10-26 15:25:50 +09:00
Dean Herbert
d03161ec01
Apply distance snap time component even when nearby object snap kicks in
2022-10-26 14:39:39 +09:00
Dan Balasescu
72b594d72e
Merge pull request #20941 from peppy/fix-distance-snap-offset
...
Offset start of distance snap grid drawing if reference object's start time doesn't align
2022-10-26 13:46:31 +09:00
Dean Herbert
f8a4af5e0e
Add osu!catch read-distance-spacing implementation
2022-10-26 13:45:06 +09:00
Dan Balasescu
a8393a81a4
Merge pull request #20922 from ekrctb/fix-mania-hold-note-fade-out
...
Fix hold note disappearing instantly without fade out
2022-10-26 13:44:40 +09:00
Dean Herbert
6b53ea3400
Enable distance snapping when DS value is changed via user interaction
2022-10-26 13:37:01 +09:00
Dean Herbert
7d59bc6e2f
Merge branch 'grid-momentary-shortcuts' into read-current-distance-snap
2022-10-26 13:28:04 +09:00
Dean Herbert
54ae16badc
Move distance snap toggle button implementation to DistancedHitObjectComposer
2022-10-26 13:27:23 +09:00
Dean Herbert
8d9a85e9e5
Fix typos in xmldoc
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2022-10-26 13:14:12 +09:00
Dean Herbert
2016d33055
Offset start of distance snap grid drawing if reference object's start time doesn't align
...
Closes #20938 .
2022-10-26 13:11:26 +09:00
Dean Herbert
cab9a1c012
Add test coverage of distance snap grid failing visually
2022-10-26 13:10:54 +09:00
Dean Herbert
5f10b81af1
Move distance snap grid test cursor behind grid to better visualise centre-points
2022-10-26 13:10:54 +09:00
Dean Herbert
cbcebfa130
Remove switch back to selection tool to simplify test flow
2022-10-26 12:18:56 +09:00
Dean Herbert
ccbc39910c
Merge pull request #20934 from bdach/fix-taiko-flashlight-regression
...
Fix invalid taiko flashlight size calculation
2022-10-26 12:11:48 +09:00
Dean Herbert
7249542167
Merge pull request #20912 from LittleEndu/carousel-do-not-select-random
...
Make beatmap carousel select nearest to selection when selection was filtered
2022-10-26 11:40:56 +09:00
Dean Herbert
0ed40c8676
Merge pull request #20937 from Joehuu/listing-scroll-to-top-tags/source
...
Scroll beatmap listing to top when searching via tags/source
2022-10-26 11:37:09 +09:00
Dean Herbert
d9d083752a
Clamp backwards index to total current items to fix edge case of item removal
2022-10-26 11:03:11 +09:00
Joseph Madamba
8505848b1a
Scroll beatmap listing to top when searching via tags/source
2022-10-25 18:06:49 -07:00
Bartłomiej Dach
48057412f5
Merge branch 'master' into grid-momentary-shortcuts
2022-10-25 22:17:08 +02:00
Bartłomiej Dach
181c7d1d6e
Merge pull request #20901 from peppy/add-editor-object-clone
...
Add ability to clone objects in the editor
2022-10-25 22:16:07 +02:00
Bartłomiej Dach
f5ca447b8e
Rename one more "{duplicate -> clone}" reference
2022-10-25 21:34:41 +02:00
Bartłomiej Dach
bcdf24b972
Merge branch 'master' into add-editor-object-clone
2022-10-25 21:33:52 +02:00
Bartłomiej Dach
2ddb94db64
Merge pull request #20903 from peppy/beat-snap-divisor-hotkey
...
Add ability to use `Shift`+`Number` to set current beat divisor in editor
2022-10-25 21:06:59 +02:00
Bartłomiej Dach
3d31c9bbc5
Merge branch 'master' into beat-snap-divisor-hotkey
2022-10-25 20:32:32 +02:00
Bartłomiej Dach
974f22dd97
Attempt to make flashlight code slightly more legible
2022-10-25 20:15:19 +02:00
Bartłomiej Dach
e3bc1126d7
Fix invalid flashlight size calculation
...
This regressed in #20714 . One usage of `getSizeFor(0)` was replaced by
`adjustSize(GetSize())`, but another usage of `getSizeFor(Combo.Value)`
was replaced by `adjustSize(Combo.Value)`, which is not correct, since
`adjustSize()` is expecting to receive a combo-based size, rather than a
combo value directly.
2022-10-25 20:03:22 +02:00
Bartłomiej Dach
93e9b4a2c5
Add failing test case
2022-10-25 20:02:28 +02:00
Dean Herbert
521fbd2ea3
Merge pull request #20345 from mk56-spn/Freeze_frame_implementation
...
Add "Freeze Frame" mod
2022-10-26 01:28:23 +09:00
ekrctb
0b8b322322
Fix tests
2022-10-25 19:48:33 +09:00
ekrctb
92ab39f5c2
Fix hold note disappear instantly
2022-10-25 19:16:23 +09:00
