59101 Commits

This Branch

This Branch

All Branches

• Merge pull request #22670 from peppy/blueprint-improve-visuals

  Improve the appearance of skin blueprints

  Bartłomiej Dach · 2023-02-19 16:31:29 +01:00
  2cda7fced3
• Merge branch 'master' into blueprint-improve-visuals
  Bartłomiej Dach · 2023-02-19 15:55:30 +01:00
  1ba1298850
• Also tween origin position
  Dean Herbert · 2023-02-19 23:52:21 +09:00
  d7381b762c
• Merge pull request #22686 from MaxKruse/fix-automatic-seeking

  Add toggle to disable automatic seeking to object after placement

  Dean Herbert · 2023-02-19 23:38:23 +09:00
  cff57d7ee9
• Use more generic wording for future-proofing
  Bartłomiej Dach · 2023-02-19 15:06:40 +01:00
  d9ca7102f0
• Rename moved test method to describe its purpose better
  Bartłomiej Dach · 2023-02-19 13:54:48 +01:00
  8b25598d82
• Rewrite test cases

  - Depend less on arbitrary timings
  - Remove unnecessary seeks
  - Change method name to make more sense
  - Use nunit style assertions

  Bartłomiej Dach · 2023-02-19 13:37:06 +01:00
  80ee917c77
• Rename test scene to match contents

  It does not only test "placement before track start" anymore.

  Bartłomiej Dach · 2023-02-19 13:16:40 +01:00
  80b329f069
• Combine config and time checks into one

  Functionally equivalent right now, but the combined variant is more
  localised to what it actually needs to do, and less error-prone if
  any new code gets appended to the method.

  Bartłomiej Dach · 2023-02-19 13:14:51 +01:00
  aac32a2c9f
• naming change from Hitobject to HitObject
  Maximilian Kruse · 2023-02-19 10:18:22 +01:00
  723a043c43
• change bindable seekToHitObject to private
  Maximilian Kruse · 2023-02-19 10:18:02 +01:00
  f3522c4162
• fix formating in SeekOnNote test
  Maximilian Kruse · 2023-02-19 10:17:33 +01:00
  025061ba66
• Add test for seeking setting in mania placement test
  Maximilian Kruse · 2023-02-18 20:42:13 +01:00
  55e9a71f38
• Add setting to disable automatic seeking after object placement
  Maximilian Kruse · 2023-02-18 19:43:45 +01:00
  ddd37bb319
• Merge pull request #22671 from peppy/blueprint-labels-while-hovering

  Only show skin blueprint labels when selected or hovering

  Bartłomiej Dach · 2023-02-18 16:29:37 +01:00
  79e1dbfb6d
• Merge branch 'master' into blueprint-labels-while-hovering
  Bartłomiej Dach · 2023-02-18 15:57:30 +01:00
  ea04c487f2
• Merge pull request #22675 from cdwcgt/CompletionText-LocalisableString

  Make `CompletionText` in `ProgressNotification` a `LocalisableString`

  Bartłomiej Dach · 2023-02-18 14:25:21 +01:00
  ff5de04fb1
• Merge branch 'master' into CompletionText-LocalisableString
  Bartłomiej Dach · 2023-02-18 13:50:58 +01:00
  15d209d17e
• Merge pull request #22672 from peppy/skin-editor-improve-toolbox-hover

  Improve the feel of hovering components in the skin editor toolbox

  Bartłomiej Dach · 2023-02-18 10:34:28 +01:00
  6b1c8195bc
• Merge branch 'master' into skin-editor-improve-toolbox-hover
  Bartłomiej Dach · 2023-02-18 10:02:02 +01:00
  fbea3e312f
• Fix toolbox items spontaneously contracting after briefly losing hover

  Reproduction scenario:
  
  1. Hover a toolbox item
  2. Unhover the item, but do not hover any other item (can be done by
     exiting the toolbox completely to the right)
  3. Come back to the item hovered in step (1)
  4. The item would spontaneously contract after a second

  Bartłomiej Dach · 2023-02-17 22:54:11 +01:00
  2aa4481f68
• Remove unused field
  Bartłomiej Dach · 2023-02-17 21:51:19 +01:00
  b390fdb8cc
• Merge branch 'master' into blueprint-improve-visuals
  Bartłomiej Dach · 2023-02-17 21:40:16 +01:00
  8894a73b07
• Merge pull request #22648 from peppy/skinnable-clean-up-documentation

  Refactor structure and naming of skin-related classes

  Bartłomiej Dach · 2023-02-17 21:37:54 +01:00
  23a636b74b
• Merge branch 'master' into skinnable-clean-up-documentation
  Bartłomiej Dach · 2023-02-17 20:59:18 +01:00
  6afa65bd3d
• Rename one more left-over skinnable naming
  Salman Ahmed · 2023-02-17 22:09:55 +03:00
  449e5fa6f8
• CompletionText can be a LocalisableString

  I can't find a reason for not doing this, probably this was forgotten in https://github.com/ppy/osu/pull/15440

  cdwcgt · 2023-02-17 22:32:03 +09:00
  dbb366e279
• Improve the feel of hovering toolbox component items
  Dean Herbert · 2023-02-17 19:26:03 +09:00
  5ed038fbb3
• Only show blueprint labels when hovering or selected
  Dean Herbert · 2023-02-17 19:23:52 +09:00
  814080d982
• Fix selection on the edge of blueprints (in the new inflation area) failing
  Dean Herbert · 2023-02-17 18:19:46 +09:00
  6c61c5f4a8
• Improve visuals of skin blueprint
  Dean Herbert · 2023-02-17 18:19:46 +09:00
  16d94b4ea2
• Add xmldoc around SkinComponentsContainerLookup
  Dean Herbert · 2023-02-17 14:18:05 +09:00
  1a63ca9ece
• Merge pull request #22338 from Pasi4K5/hide-resume-overlay

  Hide `ResumeOverlay` when `OsuModAutopilot` is enabled

  Bartłomiej Dach · 2023-02-16 22:22:19 +01:00
  9f9893d93a
• Merge branch 'master' into hide-resume-overlay
  Bartłomiej Dach · 2023-02-16 21:33:23 +01:00
  66e9bb2581
• Merge pull request #22645 from peppy/adjust-song-select-background-dim

  Adjust song select background dimming to be more evenly applied

  Bartłomiej Dach · 2023-02-16 21:27:27 +01:00
  bba1722725
• Revert ResumeOverlay setter accessibility change
  Bartłomiej Dach · 2023-02-16 21:26:01 +01:00
  b8084a15eb
• Merge branch 'master' into adjust-song-select-background-dim
  Bartłomiej Dach · 2023-02-16 20:52:36 +01:00
  0186062246
• Remove redundant conditional access qualifier

  It is impossible for the callback passed to `ApplyToBackground()` to
  receive a null reference. See `OsuScreen.ApplyToBackground()` - if the
  background to call the callback on were `null`, then an
  `InvalidOperationException` would be thrown instead.

  Bartłomiej Dach · 2023-02-16 20:47:51 +01:00
  ad5132ed41
• Merge pull request #22658 from peppy/gameplay-sample-trigger-source-test-fix

  Refactor `GameplaySampleTriggerSource` test to not be realtime dependent

  Bartłomiej Dach · 2023-02-16 19:39:18 +01:00
  7d86f49fce
• Add one more assert to keep coverage from previous implementation
  Bartłomiej Dach · 2023-02-16 19:02:51 +01:00
  5bdc5dfadd
• Apply NRT to SerialisedDrawableInfo
  Dean Herbert · 2023-02-16 20:01:59 +09:00
  cb7df7282b
• Fix song select potentially updating background parameters when not the current screen
  Dean Herbert · 2023-02-16 18:45:22 +09:00
  394d368f16
• Refactor GameplaySampleTriggerSource test to not be realtime dependent
  Dean Herbert · 2023-02-16 17:58:44 +09:00
  979c079f8b
• Apply NRT to GamepleSampleTriggerSource tests
  Dean Herbert · 2023-02-16 17:58:44 +09:00
  9d02a2ef0e
• Always create ResumeOverlay, with UseResumeOverlay flag only affecting whether it is displayed or not
  Dean Herbert · 2023-02-16 15:47:20 +09:00
  ce9ef3bc3c
• Merge branch 'master' into hide-resume-overlay
  Dean Herbert · 2023-02-16 15:42:14 +09:00
  7afdcb9383
• Rename left-over skinnable naming in SerialisedDrawableExtensions
  Dean Herbert · 2023-02-16 15:34:41 +09:00
  81dcc105a9
• Standardise all local SkinComponentsContainerLookup variables to containerLookup
  Dean Herbert · 2023-02-16 15:33:56 +09:00
  76f7accd13
• Reword xmldoc on ISerialisableDrawable to make less skin-centric
  Dean Herbert · 2023-02-16 15:31:35 +09:00
  eea0cd3cf8
• Reword and fix typos in some new xmldoc

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2023-02-16 15:27:30 +09:00
  0b25f7baeb