69434 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
Bartłomiej Dach	29418226c0	Do not add checkbox padding to the left of menu items if no item actually needs it ... RFC. As per https://discord.com/channels/188630481301012481/188630652340404224/1291346164976980009. The diff is extremely dumb but I tried a few smarter methods and they're either not fully correct or don't work. Primary problem is that menu items are mutable externally and there's no hook provided by the framework to know that items changed. One could probably be made but I'd prefer that this change be examined visually first before I engage in too much ceremony and start changing framework around.	2024-10-03 15:36:53 +02:00
Bartłomiej Dach	4f823a3078	Merge pull request #30095 from peppy/increase-chat-font-size ... Increase chat font size again	2024-10-03 10:28:17 +02:00
Dean Herbert	1039d4e45d	Increase chat font size again	2024-10-03 16:23:17 +09:00
Dean Herbert	54e68005ef	Merge pull request #29691 from bdach/hotkeys-in-context-menus ... Add hotkey hints to editor menus	2024-10-01 19:29:05 +09:00
Dean Herbert	8ea1ff5de6	Merge pull request #30069 from peppy/grid-to-current-object ... Add button to centre editor grid to current hit object	2024-10-01 19:24:46 +09:00
Bartłomiej Dach	afc34b2614	Merge pull request #30074 from peppy/lock-because ... Fix usage of locked context without locking	2024-10-01 12:08:38 +02:00
Dean Herbert	598bc74614	Merge pull request #30058 from bdach/disabled-beatmap-comment-box ... Properly disable comment box on things that cannot be commented on	2024-10-01 18:52:40 +09:00
Dean Herbert	162558e0b8	Use record struct ... See https://www.jetbrains.com/help/rider/UsageOfDefaultStructEquality.html.	2024-10-01 18:48:34 +09:00
Dean Herbert	24d534929d	Less var please	2024-10-01 18:44:27 +09:00
Dean Herbert	ae75bfd966	Rename keyboard mapping methods to make more sense now that everything's on the left	2024-10-01 18:41:53 +09:00
Bartłomiej Dach	9dad38c457	Fix button being interactable when collapsed ... Did not match the expandable button in distance snap toolbox.	2024-10-01 11:35:43 +02:00
Dean Herbert	f08ace7522	Merge pull request #29917 from bdach/shuffle ... Shuffle playback order in global playlist by default	2024-10-01 18:29:39 +09:00
Bartłomiej Dach	44b982864c	Fix test failures	2024-10-01 11:12:56 +02:00
Dean Herbert	307cc5581d	Fix usage of locked context without locking ... Raised in the latest Rider EAP, seems valid enough.	2024-10-01 18:01:06 +09:00
Bartłomiej Dach	2a214f7c9f	Fix incorrect implementation of next track choice ... `SkipWhile()` in this context does not correctly ensure that `ElementAtOrDefault(1)` is not a protected track. An explicit `Where()` does. Spotted accidentally when I noticed that skipping to next track can select a protected track, but skipping to previous cannot.	2024-10-01 10:19:59 +02:00
Bartłomiej Dach	a2d9302f4a	Move shuffle button to left side	2024-10-01 10:12:38 +02:00
Bartłomiej Dach	8eb5e6b1d5	Merge branch 'master' into shuffle	2024-10-01 10:07:54 +02:00
Bartłomiej Dach	8d2f2517a3	Specify type explicitly	2024-10-01 10:01:31 +02:00
Bartłomiej Dach	a9818854f4	Merge pull request #30024 from peppy/edit-url-decode ... Fix editor timestamp URLs not working when they contain a space	2024-10-01 09:44:18 +02:00
Dean Herbert	87ab953935	Merge pull request #30062 from bdach/distance-snap-weirdness ... Fix various distance snap grid weirdness around unsnapped objects	2024-10-01 16:16:22 +09:00
Dean Herbert	0bff7e8697	Merge pull request #30063 from bdach/snap-sliders-on-path-type-change ... Ensure sliders are snapped when changing path types	2024-10-01 16:03:12 +09:00
Dean Herbert	590f27e0a0	Merge branch 'master' into hotkeys-in-context-menus	2024-10-01 15:50:19 +09:00
Dean Herbert	0409edccce	Add button to centre editor grid to current hit object	2024-10-01 15:22:05 +09:00
Bartłomiej Dach	493dcc7a1c	Fix test being dodgy ... Hitobjects are in an indeterminate state until defaults are applied. Adding the object to the beatmap will do this.	2024-09-30 14:38:21 +02:00
Bartłomiej Dach	48b03a328b	Ensure sliders are snapped when changing path types ... Closes https://github.com/ppy/osu/issues/29915. Uses behaviour suggested in https://github.com/ppy/osu/issues/29915#issuecomment-2361843011.	2024-09-30 14:38:20 +02:00
Bartłomiej Dach	74a9899fc0	Fix doubled-up enabled state management of commit button	2024-09-30 14:05:26 +02:00
Bartłomiej Dach	155d6e57be	Isolate tests properly	2024-09-30 14:05:20 +02:00
Bartłomiej Dach	11fc1f9a1c	Fix distance snap grid using wrong colour when reference object is unsnapped	2024-09-30 13:36:51 +02:00
Bartłomiej Dach	75fc57c34b	Fix distance spacing grid displaying incorrectly for unsnapped objects with duration	2024-09-30 13:36:16 +02:00
Bartłomiej Dach	4723efaf41	Add failing test coverage for incorrect distance snapping	2024-09-30 13:36:05 +02:00
Bartłomiej Dach	e91c8fb4bd	Properly disable comment box on beatmaps that cannot be commented on ... Closes https://github.com/ppy/osu/issues/30052. Compare: - 83816dbe24/resources/js/components/comment-editor.tsx (L54-L60) - 83816dbe24/resources/js/components/comment-editor.tsx (L47-L52)	2024-09-30 11:02:00 +02:00
Dean Herbert	7d756d0de2	Merge pull request #30056 from bdach/speed-change-hotkeys-lose-pitch ... Fix rate change hotkeys sometimes losing track of adjust pitch setting	2024-09-30 16:38:42 +09:00
Bartłomiej Dach	5e5bb49cd8	Fix rate change hotkeys sometimes losing track of adjust pitch setting ... Fixes https://osu.ppy.sh/community/forums/topics/1983327. The cause of the bug is a bit convoluted, and stems from the fact that the mod select overlay controls all of the game-global mod instances if present. `ModSpeedHotkeyHandler` would store the last spotted instance of a rate adjust mod - which in this case is a problem, because on deselection of a mod, the mod select overlay resets its settings to defaults: a258059d43/osu.Game/Overlays/Mods/ModSelectOverlay.cs (L424-L425) A way to defend against this is a clone, but this reveals another issue, in that the existing code was *relying* on the reference to the mod remaining the same in any other case, to read the latest valid settings of the mod. This basically only mattered in the edge case wherein Double Time would swap places with Half Time and vice versa (think [0.95,1.05] range). Therefore, track mod settings too explicitly to ensure that the stored clone is as up-to-date as possible.	2024-09-30 08:47:02 +02:00
Bartłomiej Dach	23b8354af4	Add more test steps demonstrating another failure case	2024-09-30 08:46:45 +02:00
Bartłomiej Dach	3fac9baa9f	Add test steps demonstrating failure case	2024-09-30 08:46:33 +02:00
Dean Herbert	a258059d43	Merge pull request #29918 from bdach/control-drag ... Add to existing selection when dragging with control pressed	2024-09-30 14:00:36 +09:00
Dean Herbert	71a5cd182a	Merge pull request #30040 from EVAST9919/file-popover-border ... Fix text in `FormFileSelector` bleeding through the border	2024-09-30 11:07:39 +09:00
Andrei Zavatski	f473f4398c	Fix text in FormFileSelector bleeding through the border	2024-09-28 22:37:16 +03:00
Dean Herbert	c46d787f1e	Merge pull request #29949 from minetoblend/feature/scale-around-center ... Support scaling around center when scaling with select box	2024-09-28 21:37:39 +09:00
Dean Herbert	9647a1be7d	Ensure editor timestamp args are URL decoded	2024-09-27 20:08:38 +09:00
Dean Herbert	f6c5f975ee	Add failing test showing url decoding is not being performed	2024-09-27 20:08:26 +09:00
Bartłomiej Dach	c1e51e05df	Merge pull request #29704 from Fabep/ModCustomisationHeaderColor ... Mod customisation header color	2024-09-27 12:40:35 +02:00
Bartłomiej Dach	d607331755	Fix control-drag selection expansion deselecting object if control is released over one of the blueprints	2024-09-27 12:15:08 +02:00
Bartłomiej Dach	eb725ec1fb	Nudge test coverage to also cover discovered fail case	2024-09-27 12:13:11 +02:00
Bartłomiej Dach	b45fedc356	Merge branch 'master' into control-drag	2024-09-27 11:39:50 +02:00
Dean Herbert	a358731af5	Merge pull request #29913 from Joehuu/fix-romanised-searching ... Fix searching by clicking title/artist in beatmap overlay not following original language setting	2024-09-27 18:39:33 +09:00
Dean Herbert	e7c4451206	Reduce brightness of hover effect	2024-09-27 18:20:16 +09:00
Dean Herbert	64c1ced80d	Merge branch 'master' into ModCustomisationHeaderColor	2024-09-27 18:15:30 +09:00
Dean Herbert	d9de2ad97b	Merge pull request #29899 from bdach/mania-selection-dropped ... Ensure selection is preserved when moving selection between columns	2024-09-27 18:11:23 +09:00
Bartłomiej Dach	a00ed8dd77	Merge pull request #29914 from peppy/fix-judgement-counter-sync ... Fix judgement counter not showing correct counts when spectating user mid-play	2024-09-27 10:57:26 +02:00