5430 Commits

Author	SHA1	Message	Date
Bartłomiej Dach	dfea2ade6d	Revert incorrect end position optimisation ... Closes https://github.com/ppy/osu/issues/26867. Reverts 882f490390 and ce643aa68f. The applied optimisation may have been valid as long as it was constrained to `Slider`. But it is not, as `SliderTailCircle` stores a local copy of the object position. And as the commit message of ce643aa68f states, this could be bypassed by some pretty hacky delegation from `SliderTailCircle.Position` to the slider, but it'd also be pretty hacky because it would make flows like `PositionBindable` break down. Long-term solution is to probably remove bindables from hitobjects.	2024-01-31 12:45:42 +01:00
Dean Herbert	ebf637bd3c	Adjust slider tick / end misses to show slightly longer	2024-01-31 17:41:26 +09:00
Bartłomiej Dach	2667cb8b36	Merge pull request #26703 from peppy/smaller-slider-misses ... Adjust slider tick / end defaults again	2024-01-29 13:51:07 +01:00
Dean Herbert	a3199333bb	Merge pull request #26698 from EVAST9919/slider-sample-alloc ... Reduce sliding sample allocations in `DrawableSlider`	2024-01-29 20:37:32 +09:00
Dean Herbert	034f8c0388	Also fix spinner case	2024-01-29 20:36:59 +09:00
Dean Herbert	760368709a	Mark some delegates as static because we can	2024-01-29 16:16:28 +09:00
Dean Herbert	b6fa50c312	Reduce allocation overheads in SliderInputManager	2024-01-26 17:49:20 +09:00
Dean Herbert	fd9527d523	Remove weird red fade that didn't work	2024-01-25 19:31:57 +09:00
Dean Herbert	107b37494e	Update triangles skin judgment display	2024-01-25 19:31:57 +09:00
Dean Herbert	0175f6e0b8	Add new judgement drawable for argon slider misses	2024-01-25 19:31:57 +09:00
Dean Herbert	dda96d7106	Rename JudgementPiece to TextJudgementPiece	2024-01-25 19:31:57 +09:00
Andrei Zavatski	21b11092d6	Fix slider sliding samples allocation	2024-01-25 04:06:15 +03:00
Dean Herbert	b272d34960	Merge pull request #26630 from peppy/s-rank-change ... Change S rank to require no miss	2024-01-24 13:27:40 +09:00
Andrei Zavatski	da992ccc55	Implement per-axis triangles clamping	2024-01-23 04:54:27 +03:00
Bartłomiej Dach	cb8ec48717	Make RankFromScore()'s dictionary param readonly ... Just to make sure nobody tries any "funny" business.	2024-01-22 19:56:30 +01:00
Bartłomiej Dach	5bae9074aa	Merge branch 'master' into s-rank-change	2024-01-22 19:54:53 +01:00
Dean Herbert	c8521b49cd	Change S rank to require no miss	2024-01-22 21:43:32 +09:00
Dean Herbert	47e9846315	Adjust slider tick / end miss animations to be less busy	2024-01-22 18:48:48 +09:00
Dean Herbert	993e733fce	Merge pull request #26598 from frenzibyte/fix-storyboard-sprites-2 ... Remove handling for non-legacy texture lookup paths in `LegacySkin`	2024-01-22 17:50:55 +09:00
Salman Ahmed	57b2d018a9	Fix slider sometimes not updating relative anchor position	2024-01-22 02:07:32 +03:00
Andrei Zavatski	1393f52b2b	Rename Masking to ClampToDrawable	2024-01-21 05:20:42 +03:00
Andrei Zavatski	e003ecb593	Change default masking value to true	2024-01-21 04:57:48 +03:00
Bartłomiej Dach	3853f63b74	Merge pull request #26567 from peppy/cusor-scale-rate ... Fix cursor scale animation not matching stable on classic skins	2024-01-18 13:59:49 +01:00
Salman Ahmed	1527ab89ef	Refactor DefaultApproachCircle/LegacyApproachCircle to make sense	2024-01-18 11:16:26 +03:00
Salman Ahmed	06da7f74de	Merge branch 'master' into fix-storyboard-sprites-2	2024-01-17 18:43:25 +03:00
Salman Ahmed	eaa748f075	Remove unused using directive	2024-01-17 18:35:34 +03:00
Salman Ahmed	ed1e66b8f9	Fix enabling beatmap skin cause hitobjects to use LegacyApproachCircle regardless of selected skin	2024-01-17 16:36:09 +03:00
Salman Ahmed	e54d20ea93	Remove ancient osu-resources lookup path from legacy skin textures	2024-01-17 16:33:14 +03:00
Bartłomiej Dach	d0e9402761	Fix flashlight not dimming if slider head is hit early ... Closes https://github.com/ppy/osu/issues/26551 Fix is a bit nuclear (`OnUpdate` should be considered last resort), but I don't see many better alternatives here as `ApplyCustomUpdateState` does not work...	2024-01-16 18:56:50 +01:00
Justin	7736445659	Merge branch 'master' into spinner-speed-fix	2024-01-17 01:40:53 +11:00
Dean Herbert	c45daa373e	Fix cursor scale animation not matching stable on classic skins	2024-01-16 17:15:25 +09:00
Justin	e3ab7b1e9f	Update disctop to use turnratio like stable	2024-01-16 17:22:22 +11:00
Dean Herbert	2fdbc501c2	Merge pull request #26499 from OliBomby/slider-performance ... Fix lag when dragging first slider control point in editor	2024-01-16 13:22:49 +09:00
Bartłomiej Dach	71d0543213	Merge pull request #26545 from frenzibyte/fix-resume-cursor-transition-abused ... Fix pop-in scale transition in resume overlay affecting input area	2024-01-15 20:06:16 +01:00
Dean Herbert	23815b2045	Merge pull request #26547 from bdach/cursor-ripple-pool-wrong ... Fix cursor ripple pool not loading pooled drawables ahead of time	2024-01-15 22:56:50 +09:00
Bartłomiej Dach	399fc8195a	Fix cursor ripple pool not loading pooled drawables ahead of time ... Increment the counter over at https://github.com/ppy/osu-framework/pull/6136.	2024-01-15 13:22:22 +01:00
OliBomby	96ffe8e737	change wording	2024-01-15 12:51:08 +01:00
Dean Herbert	6b844ed8b6	Split out judgement pooling concepts from OsuPlayfield for reuse	2024-01-15 20:50:09 +09:00
OliBomby	86382f4408	Clarify comment	2024-01-15 12:49:40 +01:00
Salman Ahmed	13517869f6	Apply scale transitions in resume overlay cursor to local container	2024-01-15 14:03:23 +03:00
Dean Herbert	6c0e968727	Merge pull request #26512 from OliBomby/slider-pathtype-update ... Fix glitchy path type correction for sliders in the editor	2024-01-15 16:19:24 +09:00
Bartłomiej Dach	0b2b1fc588	Fix flashlight dim being applied before slider start time ... Closes https://github.com/ppy/osu/issues/26515. Compare https://github.com/ppy/osu/pull/26053.	2024-01-14 13:05:02 +01:00
OliBomby	243b7b6fda	fix code quality	2024-01-13 23:17:38 +01:00
OliBomby	83e108071a	fix wrong path type being displayed	2024-01-13 22:51:33 +01:00
OliBomby	39908f5425	remove Validating event and instead call validation explicitly on edits	2024-01-13 22:39:09 +01:00
OliBomby	da4d83f8ca	remove the need for caching points in segment	2024-01-13 21:41:33 +01:00
OliBomby	b4f9878b46	working jank solution	2024-01-13 20:39:49 +01:00
OliBomby	f5d6d52d4c	Move logic for caching segments and updating path types to PathControlPointVisualiser	2024-01-13 14:47:40 +01:00
OliBomby	ce643aa68f	revert overwriting Position getter in SliderTailCircle ... It would have very weird implications when combined with the position bindable which would be all wrong and stuff	2024-01-13 13:54:04 +01:00
OliBomby	fca9b1f536	Fix so it reacts to PathVersion with Scheduler	2024-01-13 12:50:39 +01:00