1
0
mirror of https://github.com/ppy/osu.git synced 2024-11-16 19:47:51 +08:00
Commit Graph

663 Commits

Author SHA1 Message Date
Joseph Madamba
cdc148f78e Increase scope of identifier typo disables on special cases 2021-12-29 14:07:36 -08:00
Joseph Madamba
c22a07d9fc Bump identifier typo inspection and fix remaining identifier names 2021-12-28 11:26:42 -08:00
Joseph Madamba
98524d60a4 Fix clear identifier typos 2021-12-27 20:26:28 -08:00
Dean Herbert
090c3e84e7 Avoid blocking windows key usage when the osu! window is not active
As discussed in https://github.com/ppy/osu/discussions/16147.
2021-12-20 17:40:11 +09:00
Dean Herbert
c08b6cf160 Remove unnecessary StartAsync call on TcpIpcProvider 2021-12-16 19:53:22 +09:00
Salman Ahmed
d92f5039cd Reorder version overlay to display behind game-wide overlays 2021-12-13 06:53:18 +03:00
Dan Balasescu
34b0e374d8 Add serialisation/deserialisation explanation 2021-12-03 21:29:20 +09:00
Dan Balasescu
9acc0556a4 Remove unused event 2021-12-03 20:35:47 +09:00
Dean Herbert
f9ad307526 Apply nullable 2021-12-03 15:51:00 +09:00
Dean Herbert
79d723172a Remove Console.WriteLine usage 2021-12-03 15:48:53 +09:00
Dean Herbert
33992e11e0 Split out ruleset lookup code 2021-12-03 15:48:53 +09:00
Dean Herbert
2262b7b331 Adjust logging to avoid using tabs 2021-12-03 15:48:53 +09:00
Dan Balasescu
4ee2063683 Move event handlign internal to LegacyTcpIpcProvider 2021-11-28 23:02:57 +09:00
Dan Balasescu
fc3eb08452 Output raw message on failure 2021-11-28 22:28:01 +09:00
Dan Balasescu
18a0a791fd Refactor 2021-11-28 22:24:42 +09:00
Dan Balasescu
27ba3c6d1a Add back removed getter
Seems to somehow be required.
2021-11-28 22:16:21 +09:00
Dan Balasescu
36fffbd917 Refactoring 2021-11-28 21:31:22 +09:00
Dan Balasescu
f506cb35bc Bind legacy IPC on startup 2021-11-28 21:15:29 +09:00
Dan Balasescu
5711c428ca Increment IPC port 2021-11-28 21:15:21 +09:00
Dan Balasescu
ef24780642 Use IPC via TCP 2021-11-28 18:24:00 +09:00
Dan Balasescu
e5dcfc3113 Use console IPC 2021-11-28 14:03:21 +09:00
Dean Herbert
1dc1de3d1f Close a failed update notification immediately
Fixes visual issue pointed out at
https://github.com/ppy/osu/discussions/15653#discussioncomment-1679263.
2021-11-24 19:05:53 +09:00
Dean Herbert
bbd3ea5b77 Update all actual usages of RulesetInfo.ID to use OnlineID instead 2021-11-24 15:50:26 +09:00
David Paiva
58d3e66d8b
Update osu.Desktop/DiscordRichPresence.cs
Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>
2021-11-21 09:36:05 +00:00
David Paiva
5276300c08 Added required changes. 2021-11-20 14:11:02 +00:00
David Paiva
e65826979e Whoops, forgot that comment 2021-11-20 12:41:31 +00:00
David Paiva
abbc13c60f Added Beatmap Link button to Discord Rich Presence 2021-11-20 12:41:01 +00:00
Dean Herbert
d600a73277 Disable cancelling of update via notification 2021-11-17 11:41:42 +09:00
Dean Herbert
3fe89293af Add update manager which performs no update action
This is to be used in cases where updates are handled by an external
means. See
https://github.com/flathub/flathub/pull/2619#issuecomment-969731305 for
initial usage.
2021-11-16 12:11:13 +09:00
Dean Herbert
0ecf5f201c Rename User to APIUser and move to correct namespace 2021-11-07 11:26:01 +09:00
Dean Herbert
6944151486 Apply batch fixing of built-in types using var 2021-10-27 13:04:41 +09:00
Dean Herbert
ec61c3c5ee Rename all remaining cases 2021-10-03 00:55:29 +09:00
Dean Herbert
5e53058fbc Use same method of exiting execution as previously for safety 2021-09-21 18:03:43 +09:00
Dean Herbert
3b174a71a3 Move startup concurrency check to higher level
Makes more sense to perform this check outside of the game itself now
that we can.
2021-09-21 18:00:55 +09:00
smoogipoo
956c1cc216 Merge branch 'master' into activity-on-multiplayer-screens 2021-08-24 12:33:34 +09:00
Dean Herbert
82eddeffef Add LocalUserPlayInfo interface to convey common information about player status 2021-08-17 16:15:47 +09:00
Nathan Alo
cc3468b4ab apply suggestions
- make `UserActivity.InGame` and derive that to `InSoloGame` and `InMultiplayerGame`
- rename `SoloGame` to `InSoloGame`
- rename `MultiplayerGame` to `InMultiplayerGame`
2021-08-16 06:32:33 +08:00
Henry Lin
88d9e2ec06 Guard against IndexOutOfRange when parsing launch args 2021-07-23 10:23:31 +08:00
Dean Herbert
3dddcf3582 Remove unused using statement 2021-07-21 15:11:01 +09:00
Dean Herbert
4148d3fdac Add a bit more safety to argument parsing logic 2021-07-21 15:02:15 +09:00
Salman Ahmed
ebd555129f Change to int-only debug client ID 2021-07-21 07:53:24 +03:00
Salman Ahmed
37393a8432 Allow defining custom storage name for debug builds of osu!lazer 2021-07-21 03:12:44 +03:00
Dean Herbert
e0af5f0469 Fix osu!(lazer) overwriting osu!(stable) desktop icons by adding back a suffix
As discussed in https://github.com/ppy/osu/issues/13864, Squirrel will
use the product name before the title, allowing us to use this variable
to update the icon while not changing the window display title or naming
elsewhere.
2021-07-19 11:38:45 +09:00
Dean Herbert
47a593ad7d Force a re-check on any exception being thrown 2021-07-12 14:55:09 +09:00
Dean Herbert
a9250a0d98 Limit update notifications to once per startup
This logic was intentionally designed to continue to prompt the user to
update if they haven't, but that seems pretty anti-user. The change will
stop the update prompts from showing more than once per game startup,
unless manually invoked by the user a second time.

Closes https://github.com/ppy/osu/issues/13821.
2021-07-09 18:23:30 +09:00
Dean Herbert
ec71deec51 Remove some mentions of "lazer"
I am aware there are more throughout the codebase but intentionally left
the remaining mentioned for one reason or another. The intention here is
to mainly change user-facing versioning to change the positioning of the
"lazer" term (to be where we would expect "cuttingedge" or "beta" to
be).
2021-07-04 12:41:27 +09:00
Dean Herbert
f2d9d78455 Fix some incorrectly invoked async calls 2021-07-02 14:43:48 +09:00
Dean Herbert
d5d5a4d0d7 Actually combine the path 2021-06-02 15:13:21 +09:00
Dean Herbert
bf216687e1 Fix osu!stable directory selection failing if no Songs folder is present at install location 2021-06-02 15:05:06 +09:00
Dean Herbert
dbcb1259e2 Add a note about elevated privileges also breaking integrations 2021-04-27 14:38:19 +09:00
Dean Herbert
2673cd3d99 Remove unnecessary noop action 2021-04-27 14:36:15 +09:00
Dean Herbert
13de571b3c Rename private method 2021-04-27 14:35:57 +09:00
Dean Herbert
2303d108bb Simplify false return path 2021-04-27 14:35:14 +09:00
Christine Chen
5a3fbef5ac Use a try-catch, notification activation does nothing 2021-04-27 00:23:08 -04:00
Christine Chen
e0f54f5842 Move load() before LoadComplete() 2021-04-26 22:51:03 -04:00
Christine Chen
a2723f3f57 Perform elevated check asynchronously, use a separate function w/ switch statement 2021-04-26 22:44:22 -04:00
Christine Chen
c3bad1d4c5 Rename AdminChecker to ElevatedPrivilegesChecker, refactor elevated check 2021-04-26 21:05:18 -04:00
Christine Chen
260dd06f47 Move AdminChecker to osu.Desktop.Admin 2021-04-26 20:04:34 -04:00
Christine Chen
9ad30da729 Show a notification if game is run as administrator 2021-04-26 16:41:26 -04:00
Dean Herbert
b5954a55ad Remove empty <returns> xmldoc 2021-04-12 17:46:14 +09:00
Dean Herbert
30cae46cbd Group large drag drop imports into a single operation 2021-03-31 14:57:28 +09:00
Bartłomiej Dach
a16c0641b2 Revert EF Core to version 2.2
This reverts commit f3faad74d5, reversing
changes made to 712e7bc7bf.

Several issues arose after migrating to 5.0, including, but possibly not
limited to, performance regressions in song select, as well as failures
when attempting to save beatmaps after metadata changes in the editor.
2021-03-21 11:05:15 +01:00
Dean Herbert
79041c1c4b Remove osuTK reference 2021-03-17 18:07:42 +09:00
Dean Herbert
249ab8ab3d Merge branch 'master' into input-handler-configuration 2021-03-17 18:05:14 +09:00
Roman Kapustin
61d5a6cc57 Simplify Microsoft.EntityFrameworkCore.Design PackageReference 2021-03-14 19:47:14 +03:00
Dean Herbert
6eadae8aaf Remove remnants of OsuTK 2021-03-12 18:35:42 +09:00
Roman Kapustin
f1302d1600 Update Microsoft.EntityFrameworkCore 2021-03-11 19:23:56 +03:00
Dean Herbert
b1cd01ceb8 Apply ConfigureAwait changes to game side 2021-03-08 14:36:35 +09:00
Salman Ahmed
a845e96b7a Replace Ranks.Global completely with a GlobalRank property 2021-02-17 08:52:04 +03:00
Dean Herbert
a080a9bdbc
Merge pull request #11603 from Game4all/handle-stable-imports-custom-songs-folder
Handle beatmap import from a stable installation with a custom Songs directory
2021-02-12 21:42:36 +09:00
dependabot-preview[bot]
57213e6308
Bump DiscordRichPresence from 1.0.169 to 1.0.175
Bumps [DiscordRichPresence](https://github.com/Lachee/discord-rpc-csharp) from 1.0.169 to 1.0.175.
- [Release notes](https://github.com/Lachee/discord-rpc-csharp/releases)
- [Commits](https://github.com/Lachee/discord-rpc-csharp/commits)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2021-02-01 18:09:07 +00:00
Salman Ahmed
63f057a525 Fix dotnet run/publish with runtime specified not working again 2021-01-27 20:45:52 +03:00
Dean Herbert
f3061a8e83 Update squirrel to fix incorrect desktop icon creation on install 2021-01-25 18:47:41 +09:00
Lucas A
d71ac83428 Use StableStorage in ArchiveModelManager. 2021-01-24 19:46:10 +01:00
Lucas A
9a5790cd31 Implement StableStorage class. 2021-01-24 19:18:16 +01:00
Dean Herbert
3f88340304 Restore previous exception handling flow for stable path lookup 2021-01-15 15:17:38 +09:00
Roman Kapustin
0ea4e221b2 Merge branch 'master' into net5.0 2021-01-14 14:02:51 +03:00
Bartłomiej Dach
fb057857e7 Update references to current year 2021-01-06 18:38:24 +01:00
Dean Herbert
866fb28d6c
Merge pull request #11411 from LavaDesu/feature/discord-presence-toggle
Add ability to toggle discord rich presence
2021-01-07 00:52:38 +09:00
Dean Herbert
a8530fde9d Tidy up variables and spacing 2021-01-07 00:05:12 +09:00
Dean Herbert
d056e6575e Use IsDeployedBuild instead of IsDebugBuild for footer display conditional 2021-01-06 23:30:54 +09:00
Dean Herbert
cf3043fc08 Only show "development build" footer on debug releases 2021-01-06 23:20:26 +09:00
LavaDesu
7c9f345cd2
Use better naming for DiscordRichPresenceMode 2021-01-03 16:46:25 +07:00
LavaDesu
2e5c67be3f
Add ability to toggle discord rich presence
There are 3 modes: enabled, limited, and disabled.

The limited mode hides identifiable information such as username, rank, and
(if participating in one) multiplayer lobby name.
2021-01-03 10:37:28 +07:00
Dean Herbert
206bf3713e Make IAPIProvider read-only bindables into IBindables 2020-12-18 15:16:36 +09:00
Dean Herbert
53da137425
Merge branch 'master' into net5.0 2020-12-10 17:14:21 +09:00
Dean Herbert
42b810d0c8 Update DiscordRichPresence with fix for startup crashes 2020-12-07 13:03:34 +09:00
smoogipoo
8ac2f7d8cb Merge remote-tracking branch 'upstream/dependabot/nuget/System.IO.Packaging-5.0.0' into update-dependencies 2020-12-02 10:38:46 +09:00
dependabot-preview[bot]
8a65328a6d
Bump DiscordRichPresence from 1.0.150 to 1.0.166
Bumps [DiscordRichPresence](https://github.com/Lachee/discord-rpc-csharp) from 1.0.150 to 1.0.166.
- [Release notes](https://github.com/Lachee/discord-rpc-csharp/releases)
- [Commits](https://github.com/Lachee/discord-rpc-csharp/commits)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-12-02 00:56:08 +00:00
dependabot-preview[bot]
aac20eef44
Bump System.IO.Packaging from 4.7.0 to 5.0.0
Bumps [System.IO.Packaging](https://github.com/dotnet/runtime) from 4.7.0 to 5.0.0.
- [Release notes](https://github.com/dotnet/runtime/releases)
- [Commits](https://github.com/dotnet/runtime/commits)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-12-02 00:56:05 +00:00
Bartłomiej Dach
c9429632f4 Resolve new NRE inspections 2020-12-01 22:39:10 +01:00
dependabot-preview[bot]
b236c75ac8
Bump Microsoft.Win32.Registry from 4.7.0 to 5.0.0
Bumps [Microsoft.Win32.Registry](https://github.com/dotnet/runtime) from 4.7.0 to 5.0.0.
- [Release notes](https://github.com/dotnet/runtime/releases)
- [Commits](https://github.com/dotnet/runtime/commits)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-12-01 17:32:24 +00:00
Dean Herbert
285e62be9a Bring code in line with SDL2 defaults 2020-12-01 17:47:07 +09:00
Roman Kapustin
1feda1152d Fix InspectCode warnings 2020-11-21 02:06:20 +03:00
Roman Kapustin
7435416497 Workaround FileNotFoundException in a test projects 2020-11-20 14:13:16 +03:00
Roman Kapustin
1a676ef0d8 Resolve CA1416 properly using new API 2020-11-20 12:06:08 +03:00
Roman Kapustin
044622036c Disable CA1416 2020-11-20 11:53:17 +03:00
Roman Kapustin
f562a7ea0d Fix FileNotFoundException on startup 2020-11-20 11:52:17 +03:00
Roman Kapustin
ca0e1c8cee Update NuGet packages 2020-11-20 10:47:57 +03:00
Roman Kapustin
3b600f0a7b Target net5.0 instead of netcoreapp3 2020-11-20 10:45:19 +03:00
Dean Herbert
efc18887c8 Update framework 2020-11-18 18:01:55 +09:00
Dean Herbert
85d641c630
Merge pull request #10740 from Game4all/add-multi-statuses 2020-11-10 14:23:26 +09:00
Lucas A
b8c63e7944 Apply review suggestions. 2020-11-09 13:39:50 +01:00
Dean Herbert
2e3fdf8116 Update reference to TK game window class 2020-11-09 20:50:36 +09:00
Lucas A
e4fb9b4dd3 Display room name on discord rich presence. 2020-11-08 18:42:24 +01:00
Shane Woolcock
c2161bb4cf
Merge branch 'master' into sdl-icon 2020-10-11 16:21:39 +10:30
Dean Herbert
09e350d14d Remove canBNull specification 2020-10-10 13:28:27 +09:00
Dean Herbert
20f1eb2b33 Fix windows key blocking applying when window is inactive / when watching a replay
Closes #10467.
2020-10-10 13:11:39 +09:00
Dean Herbert
de47392e3d Display the "restart to update" notification on checking for update after dismissal 2020-10-06 13:19:57 +09:00
Dean Herbert
22b0105d62 Show a notification if checking for updates via button and there are none available 2020-10-06 13:00:02 +09:00
Shane Woolcock
7359c422dd Hoist icon stream 2020-10-03 12:58:43 +09:30
Shane Woolcock
42f666cd24 Set icon for SDL desktop window 2020-09-29 23:04:03 +09:30
Bartłomiej Dach
6c44513115 Update .csproj descriptions to match 2020-08-16 12:53:31 +02:00
Dean Herbert
dbe9180c55 Rename class and remove screen conditionals 2020-07-24 16:38:48 +09:00
Lucas A
5e6adfff99 Disable windows key only while in gameplay. 2020-07-23 12:45:14 +02:00
Lucas A
4102dae999 Revert commit 939441ae 2020-07-23 11:56:46 +02:00
Lucas A
939441ae40 Disable the windows key only when in gameplay. 2020-07-16 14:50:11 +02:00
Lucas A
022e4b6335 Apply review suggestions. 2020-07-06 11:15:56 +02:00
Lucas A
ce5da5c51b Block CTRL + ESC 2020-07-05 20:21:56 +02:00
Lucas A
8869979599 Trigger hook activation on bind. 2020-07-04 12:30:09 +02:00
Lucas A
fc1eb42a65 Disable windows key while in gameplay. 2020-07-01 17:15:41 +02:00
Dean Herbert
6beb28b685 Rename method to be less bad 2020-06-12 18:07:39 +09:00
Dean Herbert
95f57ca88c Remove duplicate calls to CheckForUpdatesAsync 2020-06-12 18:05:23 +09:00
Dean Herbert
6296cd62d0 Merge branch 'master' into update-button 2020-06-12 18:00:36 +09:00
Dean Herbert
e26dc7ef55
Merge pull request #9260 from smoogipoo/fix-publish
Fix dotnet publish with runtime specification not working
2020-06-12 13:24:04 +09:00
smoogipoo
a48e36fd31 Fix dotnet publish with runtime specification not working 2020-06-12 12:58:33 +09:00
Shane Woolcock
fca6a6d69f Implement file drop with DragDrop event 2020-06-12 09:46:21 +09:30
Shane Woolcock
b89dcb6a77 Fix cursor not hiding with SDL2 backend 2020-06-11 13:08:41 +09:30
Craftplacer
101604e741 Redesign classes and generally improve code 2020-06-08 00:39:33 +02:00
Craftplacer
e95ffcb528 Merge remote-tracking branch 'upstream/master' into update-button 2020-06-07 22:51:03 +02:00
smoogipoo
8aa8d2c880 Resolve NREs 2020-06-03 16:59:37 +09:00
smoogipoo
f3b5149648 Move some suggestions to warnings, resolve issues 2020-06-03 16:48:44 +09:00
Salman Ahmed
82fe99cf4a
Replace any potential usage of Environment.CurrentDirectory with a new RuntimeInfo.StartupDirectory
Using `Environment.CurrentDirectory` for storing / reading files is dangerous as the current directory is mutable and can be changed when performing a certain operation (like opening solutions in roslyn type reference builder for example).
2020-05-31 02:24:49 +03:00
Dean Herbert
9ab3e3a6d5
Merge branch 'master' into update-button 2020-05-13 20:50:33 +09:00
Dean Herbert
d6840d880a Update StableStorage implementation in line with framework changes 2020-05-08 10:40:04 +09:00
Craftplacer
ebd1df8c28 Change property name to CanCheckForUpdate 2020-05-08 02:50:58 +02:00
Craftplacer
3c24ca08d0 Check whether the build is deployed within the public check updates method 2020-05-08 02:48:27 +02:00
Craftplacer
e6ad28a1cb Use property instead of type checking 2020-05-08 02:09:37 +02:00
Craftplacer
836efe3f7c Initial commit 2020-05-07 08:07:22 +02:00
alex
0e2ccac33b Add spaces to comments 2020-05-04 18:36:24 -07:00
Dean Herbert
6477a7b73e Centralise creation of UpdateManagers 2020-03-05 13:34:04 +09:00
dependabot-preview[bot]
b7e14569eb
Bump DiscordRichPresence from 1.0.147 to 1.0.150
Bumps [DiscordRichPresence](https://github.com/Lachee/discord-rpc-csharp) from 1.0.147 to 1.0.150.
- [Release notes](https://github.com/Lachee/discord-rpc-csharp/releases)
- [Commits](https://github.com/Lachee/discord-rpc-csharp/commits)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-02-21 03:11:10 +00:00
dependabot-preview[bot]
5609c92aaf
Bump DiscordRichPresence from 1.0.121 to 1.0.147
Bumps [DiscordRichPresence](https://github.com/Lachee/discord-rpc-csharp) from 1.0.121 to 1.0.147.
- [Release notes](https://github.com/Lachee/discord-rpc-csharp/releases)
- [Commits](https://github.com/Lachee/discord-rpc-csharp/commits)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-01-27 07:50:21 +00:00
Salman Ahmed
5a2ed5391d Update license year 2020-01-19 23:51:10 +03:00
Dean Herbert
63de934ee5
Merge branch 'master' into sdl-arg 2020-01-14 12:45:45 +08:00
Lucas A
ec95cbd0af Don't update rich presence if the rpc client isn't initialized. 2020-01-11 16:03:00 +01:00
Dean Herbert
a5e30859a9
Truncate rich presence status strings to 128 bytes (#7318)
Truncate rich presence status strings to 128 bytes

Co-authored-by: Dan Balasescu <smoogipoo@smgi.me>
2019-12-25 12:28:44 +09:00
smoogipoo
1a7937bcf7 Apply suggested optimisations 2019-12-25 12:04:28 +09:00
smoogipoo
36dd0e6998 Make ellipsis length into a static 2019-12-25 11:14:40 +09:00
smoogipoo
f1f9e1f658 Don't truncate with exactly 128 bytes 2019-12-23 19:56:05 +09:00