100 Commits

Author	SHA1	Message	Date
OliBomby	ebe1d852f5	remove other usages of hitobject SampleControlPoint	2023-04-25 16:01:43 +02:00
Dean Herbert	5b3d7a8f26	Fix typo in missing-preview-point message	2023-02-02 14:34:59 +09:00
Dean Herbert	c2cde8361a	Fix message not reading well	2023-02-02 14:33:41 +09:00
Dean Herbert	3a861fd943	Remove multiple cases of excess braces	2023-02-02 14:28:21 +09:00
cdwcgt	76296eb35a	Consistent with BeatmapsetVerifier	2023-02-01 11:52:14 +08:00
cdwcgt	5afb733fb2	change IssueTemplatePreviewTimeConflict's text	2023-01-23 15:26:28 +09:00
cdwcgt	e5eab72aeb	add check for preview time setting	2023-01-19 01:08:37 +09:00
andy840119	a1a9238bd1	Use empty string instead of null because issue template not accept null.	2022-10-30 16:31:07 +08:00
andy840119	505ec800da	File name should be nullable.	2022-10-30 16:29:54 +08:00
andy840119	db48a57fa7	Remove nullable disable annotation in some checks class.	2022-10-30 16:28:49 +08:00
andy840119	24c27e62f6	Remove nullable disable annotation in the issue and issue template-related class.	2022-10-30 16:25:15 +08:00
Dean Herbert	ac99c1ad69	Migrate the majority of existing file lookups to use new extension methods	2022-08-10 16:01:16 +09:00
Bartłomiej Dach	26c5b59f6d	Replace usages of string.To{Lower,Upper}()	2022-06-24 11:57:45 +02:00
Dan Balasescu	f8830c6850	Automated #nullable processing	2022-06-17 16:37:17 +09:00
Dean Herbert	51251e3204	Fix CI reported warnings	2022-01-12 22:39:00 +09:00
Dean Herbert	eb70a1eeb7	Replace compatibility properties with direct references	2022-01-12 18:13:14 +09:00
Dean Herbert	3811bd8520	Fix some null inspections	2022-01-12 17:00:16 +09:00
Dean Herbert	59e763467f	Move StoragePath implementation to an extension method	2021-11-19 16:08:38 +09:00
Naxesss	b888185799	Properly dispose of Stream in bg quality check	2021-11-10 05:06:11 +01:00
Dean Herbert	e43d91ad5d	Fix another case of incorrect null checking in editor verification processing	2021-11-04 15:18:10 +09:00
Dean Herbert	1e73b09e57	Fix another couple of cases of incorrect string null/empty checking	2021-11-04 14:22:28 +09:00
Dean Herbert	6944151486	Apply batch fixing of built-in types using var	2021-10-27 13:04:41 +09:00
Bartłomiej Dach	c7db286b94	Merge branch 'master' into file-sanity-checks	2021-10-14 00:17:29 +02:00
Dean Herbert	82f7f99f37	Refactor to use scoped using (and also correctly dispose TagLib portion)	2021-10-12 10:46:26 +09:00
Naxesss	f2f97602f2	Dispose of video resource later ... We need the Stream to stay open here because `StreamFileAbstraction` uses it later in the block.	2021-10-12 00:40:39 +02:00
Naxesss	47b4d03145	Dispose of Streams when used	2021-10-12 00:13:38 +02:00
Naxesss	ce69dd3588	Use Prescan flag for audio length check	2021-10-11 23:57:23 +02:00
Naxesss	8f093b9a11	Use TagLib instead of ManagedBass	2021-10-11 13:56:26 +02:00
Naxesss	f0cd18a721	Only check each video file once	2021-10-11 13:55:50 +02:00
Naxesss	6aa054b5fa	Change to non-BASS error template	2021-10-11 13:53:23 +02:00
Naxess	6da2a3d51f	Add zero-length objects check and tests	2021-07-13 10:50:11 +02:00
Naxess	dc4285582b	Fix misplaced "f" in issue message	2021-07-13 06:07:04 +02:00
Naxess	c8f58cbf6c	Add audio in video check and tests	2021-07-13 04:17:41 +02:00
Naxess	a4a1919842	Add too short audio files check and tests	2021-07-13 03:46:45 +02:00
Naxess	0a8fd01b99	Add zero byte check and tests	2021-07-13 03:45:21 +02:00
Naxess	9f9e96ce9e	Add check for spanDuration <= 0 prior to division	2021-06-27 15:40:09 +02:00
Naxess	a4a5325b73	Improve acceptable difference for repeat edges ... Likelihood that `spanDuration` is greater than E+7 is quite low in any realistic case, so this should work fine.	2021-06-27 15:39:31 +02:00
Naxess	4cfa0ae5ec	Improve precision for repeat edges	2021-06-27 03:26:35 +02:00
Naxess	2cd7eda3c4	Add "or equal to" to volume threshold xmldocs	2021-06-27 02:30:12 +02:00
Naxess	0c0fd291d9	Order hitobjects by endtime	2021-06-27 01:25:03 +02:00
Naxess	4796b1b208	Use local variables for hasHitsound & couldHaveHitsound	2021-06-27 00:04:30 +02:00
Naxess	5bc08ebadb	Rename hasHitsounds -> mapHasHitsounds	2021-06-26 23:49:25 +02:00
Naxess	d29e6f4695	Add negligible template to PossibleTemplates	2021-06-26 23:49:06 +02:00
Naxess	1913084342	Use HitSampleInfo.AllAdditions instead of new list	2021-06-26 23:48:28 +02:00
Naxess	f78cc9397e	Factor out edge type logic	2021-06-26 20:45:31 +02:00
Naxess	51147405c5	Make || and && priority explicit	2021-06-26 20:44:39 +02:00
Naxess	4b436b774d	Add few hitsounds check	2021-06-26 19:20:46 +02:00
Naxess	d8117fa730	Add muted objects check	2021-06-26 19:20:34 +02:00
Dean Herbert	fcb226bd20	Add local variable for regular access to HitObjects	2021-05-14 16:23:45 +09:00
Naxess	19800f5f7f	Move IBeatmap arg into context	2021-05-13 11:24:22 +02:00