Hydria
1e19def153
2nd fix to cover all scenarios
2023-07-22 16:44:01 +01:00
Hydria
ef2134a92a
Fix issue with processing LN orders
...
Related Issue: https://github.com/ppy/osu/issues/22756
The trigger in question happens when
(1) in a chord: a longer LN, then a shorter LN is processed respectively.
(2) in a chord: a long LN, then a note is processed respectively.
however, given the opposite processing step, it will fail to trigger.
We observe that both situations have the same pattern, however has undeterministic results, which only depends on the order the mapper placed each note.
2023-07-22 10:45:48 +01:00
Hydria
2b85ab6888
Merge remote-tracking branch 'upstream/master' into LNFixHotfix
2023-07-03 17:46:06 +01:00
Hydria
5d5e6a5ab7
Finalised LN Adjustment Values
...
Spent a couple days discussing this on the pp rework server about values that were the most acceptable, these seemed to be the best from the community standpoint of top players.
Note: This is more to fix issues with the current system, not to be a final solution.
Related Google Sheets Page: https://docs.google.com/spreadsheets/d/1P0AxfdKvMHwWBQder4ZkFGO1fC9eADSGCryA5-UGriU/edit?usp=sharing
2023-07-03 17:45:30 +01:00
Bartłomiej Dach
f6939223b3
Merge pull request #24071 from peppy/availability-fixes
...
Add handling of "unknown" beatmap availability in multiplayer flow
2023-07-02 21:32:40 +02:00
Bartłomiej Dach
21f758947d
Merge branch 'master' into availability-fixes
2023-07-02 20:38:37 +02:00
Bartłomiej Dach
7b3cb5b410
Merge pull request #24068 from peppy/fix-sign-out-string
...
Use more correct localised string source for "sign out" text
2023-07-02 19:20:24 +02:00
Dean Herbert
95c30fe12a
Duplicate sign out string for now
2023-07-03 00:14:26 +09:00
Dean Herbert
b3c874fdc5
Merge pull request #24099 from bdach/fix-oob-selection-box-again
...
Fix edge cases where selection buttons go outside playfield bounds
2023-07-02 09:37:50 +09:00
Bartłomiej Dach
d017be50f1
Merge pull request #24081 from Cootz/restore-scores-after-bearmap-reinstallation
...
Reattach any orphaned scores when a beatmap is imported
2023-07-01 22:33:38 +02:00
Bartłomiej Dach
9eec1337b3
Use slightly different condition for better UX
2023-07-01 21:39:08 +02:00
Bartłomiej Dach
183777f8df
Fix edge cases where selection buttons go outside playfield bounds
...
Addresses
https://github.com/ppy/osu/discussions/23599#discussioncomment-6300885 .
2023-07-01 21:27:17 +02:00
Bartłomiej Dach
746212be7b
Remove weird .Run(r => r.Write(...)) construction
2023-07-01 20:42:34 +02:00
Bartłomiej Dach
b6e9422aa4
Fix typo in test name
2023-07-01 20:38:00 +02:00
Bartłomiej Dach
1ce60378be
Rewrite comments further
2023-07-01 20:37:33 +02:00
Bartłomiej Dach
fe2ca5cfef
Merge pull request #24087 from peppy/less-tablet-error-spam
...
Ensure "tablet support disabled" notification is only shown once
2023-07-01 18:46:27 +02:00
Bartłomiej Dach
c3667aaa0b
Merge pull request #24097 from peppy/scrollbar-clickability
...
Increase the minimum size of the scroll bar
2023-07-01 18:17:48 +02:00
Dean Herbert
5f880397a9
Increase the minimum size of the scroll bar
...
Allows easier targetting when there is a lot of content in the scroll view
As discussed in https://github.com/ppy/osu/discussions/24095#discussioncomment-6332398 .
2023-07-02 00:04:56 +09:00
Dean Herbert
5bd91a531d
Tidy up comments and code
2023-07-01 23:37:22 +09:00
Dean Herbert
a4a9223726
Move score re-attach to PostImport
2023-07-01 23:12:04 +09:00
Cootz
8d25e2c3e1
Add importer update test
2023-07-01 09:49:06 +03:00
Cootz
2b1d637292
Add missing ruleset store
2023-07-01 09:48:42 +03:00
Cootz
f5d3a24582
Rename test
2023-06-30 20:15:38 +03:00
Cootz
428383708c
Add test for import
2023-06-30 20:13:14 +03:00
Dean Herbert
e2db6159d6
Ensure "tablet support disabled" notification is only shown once
2023-06-30 13:47:55 +09:00
Bartłomiej Dach
1f3d833b05
Merge pull request #24080 from peppy/star-rating-no-rounding
...
Never remove significant digits from star rating displays
2023-06-29 21:27:30 +02:00
Cootz
87308abec2
Merge branch 'master' into restore-scores-after-bearmap-reinstallation
2023-06-29 08:29:41 +03:00
Cootz
47ccbddfb1
Reword comment
2023-06-29 08:08:10 +03:00
Cootz
351f217c8c
Reassign existing scores to new/re-exported beatmap
2023-06-29 08:07:43 +03:00
Dean Herbert
34f53965c4
Never remove significant digits from stsar rating displays
...
Closes https://github.com/ppy/osu/issues/24079 .
2023-06-29 13:55:04 +09:00
Dean Herbert
537404440d
Set the beatmap locally available for participants list tests
2023-06-29 13:17:42 +09:00
Bartłomiej Dach
90cb3dac86
Merge pull request #24076 from bastianpedersen/localise-chat-notifications
...
Localise chat related notifications
2023-06-28 22:36:53 +02:00
Bartłomiej Dach
81e759cb6b
Merge pull request #24070 from peppy/fix-flip-undo-states
...
Trigger state change when flipping via hotkey in the editor
2023-06-28 22:24:31 +02:00
Bastian Pedersen
ea87000539
Localise chat related notifications
2023-06-28 21:11:56 +02:00
Bartłomiej Dach
27eef6996b
Merge branch 'master' into fix-flip-undo-states
2023-06-28 20:49:42 +02:00
Bartłomiej Dach
05f1526c48
Merge pull request #24060 from peppy/fix-editor-save-failure
...
Fix incorrect realm copy logic when a beatmap becomes detached from its set
2023-06-28 20:49:21 +02:00
Bartłomiej Dach
e4e08c0f5f
Fix selection handlers eating hotkey presses they didn't handle
2023-06-28 20:48:22 +02:00
Bartłomiej Dach
0940ab1e11
Add failing tests covering correct flip handling
2023-06-28 20:48:02 +02:00
Bartłomiej Dach
e1600b3d72
Merge branch 'master' into fix-editor-save-failure
2023-06-28 19:56:58 +02:00
Bartłomiej Dach
6ce0ca832e
Delete test case covering beatmap detach scenario
...
Due to being fundamentally incompatible with the `Debug.Fail()` call
added in 99e55bb9c03972fdee0569ee4ae7a5c37eac84a9.
This reverts commit 4ecc724841ac075f24f8d5695fb277672ccceca8.
2023-06-28 19:52:11 +02:00
Dean Herbert
5d209b3ffc
Change default availability in MultiplayerRoomUser to Unknown
2023-06-28 16:38:20 +09:00
Dean Herbert
fec086aec8
Fix OnlinePlayBeatmapAvailabilityTracker not passing through Unknown state
2023-06-28 16:02:46 +09:00
Dean Herbert
3883c28b15
Add visual display in participants list when availability is still being established
2023-06-28 16:02:46 +09:00
Dean Herbert
664a2b2255
Force a beatmap availability state change when selected item is changed
2023-06-28 16:02:46 +09:00
Dean Herbert
91354b1570
Avoid performing any actions when BeatmapAvailability is updated to Unknown
2023-06-28 16:01:54 +09:00
Dean Herbert
29376ffcc0
Trigger state change when flipping via hotkey in the editor
...
This will trigger a change even if nothing happens. But I think that's
okay (not easy to avoid) because the change handler should be aware that
nothing changed, if anything.
Closes https://github.com/ppy/osu/issues/24065 .
2023-06-28 13:52:51 +09:00
Dean Herbert
99e55bb9c0
Add logging and Debug.Fail on detached beatmap detection
2023-06-28 12:21:05 +09:00
Dean Herbert
1d4380cfd0
Merge pull request #24058 from peppy/full-term-exact-match
...
Add support for matching full terms at song select using suffixed `!`
2023-06-28 12:14:15 +09:00
Dean Herbert
b3f2a3ccdf
Use more correct localised string source for "sign out" text
2023-06-28 12:11:40 +09:00
Dean Herbert
bc26d52dbd
Merge pull request #24067 from bdach/fix-difficulties-not-deleting-from-db
...
Fix delete difficulty flow not actually deleting the difficulty from realm
2023-06-28 12:06:01 +09:00
