61410 Commits

This Branch

This Branch

All Branches

• Merge pull request #24064 from bastianpedersen/localise-common-game-notifications

  Localise common game notifications

  Bartłomiej Dach · 2023-06-27 22:40:22 +02:00
  eb82bd3871
• Fix hotkey presses generating unnecessary undo history

  The buttons don't check whether the operation they correspond to is
  possible to perform in the current state of the selection box, so not
  checking `Can{Reverse,Rotate}` causes superfluous undo states to be
  added without any real changes if an attempt is made to reverse or
  rotate a selection that cannot be reversed or rotated.

  Bartłomiej Dach · 2023-06-27 22:25:04 +02:00
  9be2d9d62e
• Add test coverage for rotate hotkeys
  Bartłomiej Dach · 2023-06-27 22:10:53 +02:00
  444f71541a
• Mention hotkeys in button tooltips
  Bartłomiej Dach · 2023-06-27 22:04:15 +02:00
  17ed45d07c
• Switch to == true
  Bartłomiej Dach · 2023-06-27 22:02:15 +02:00
  54280f06be
• Enable NRT in SelectionBox
  Bartłomiej Dach · 2023-06-27 22:01:44 +02:00
  ad3a470eaf
• Merge pull request #23926 from ItsShamed/hud/kc-skinnable

  Make key counter skinnable

  Bartłomiej Dach · 2023-06-27 21:57:41 +02:00
  eb6bdb5a38
• Add test cases covering full phrase case insensitivity
  Bartłomiej Dach · 2023-06-27 21:50:39 +02:00
  bca1a91087
• Trim full phrase filters in a more precise manner
  Bartłomiej Dach · 2023-06-27 21:50:36 +02:00
  bf99fc61b8
• Add test case for full phrase match mode trimming chars from inside phrase
  Bartłomiej Dach · 2023-06-27 21:45:52 +02:00
  aba380b001
• Rename MatchMode.{None -> Substring}
  Bartłomiej Dach · 2023-06-27 21:28:37 +02:00
  e3d97b37f1
• Merge branch 'master' into full-term-exact-match
  Bartłomiej Dach · 2023-06-27 21:27:39 +02:00
  06654dc618
• Merge pull request #24057 from peppy/add-title-search-support

  Add missing "title=" search support at song select

  Bartłomiej Dach · 2023-06-27 21:25:09 +02:00
  d731b84c73
• Add even more safety against unloaded components
  Bartłomiej Dach · 2023-06-27 21:21:14 +02:00
  7052f87eb8
• Fix XML doc not mirroring string
  Bastian Pedersen · 2023-06-27 21:02:44 +02:00
  62dcd513ca
• Add back missing punctunation
  Bastian Pedersen · 2023-06-27 21:01:39 +02:00
  8a2cd57f4e
• Localise common game notifications
  Bastian Pedersen · 2023-06-27 20:56:35 +02:00
  37ee3a7bbd
• Add test coverage for title query parsing
  Bartłomiej Dach · 2023-06-27 20:41:03 +02:00
  11577d1df0
• Merge branch 'master' into hud/kc-skinnable
  Bartłomiej Dach · 2023-06-27 20:35:47 +02:00
  af66ccbfdf
• Fix broken test step
  Bartłomiej Dach · 2023-06-27 20:29:27 +02:00
  9681ee7eeb
• Attempt to fix more test failures
  Bartłomiej Dach · 2023-06-27 20:17:58 +02:00
  ada9c48bde
• Fix incorrect realm copy logic when a beatmap becomes detached from its set

  The code here was assuming that if the beatmap which is having changes
  copied across does not exist within the `BeatmapSet.Beatmaps` list, it
  was not yet persisted to realm.
  
  In some edge case, it can happen that the beatmap *is* persisted to
  realm but not correctly attached to the beatmap set. I don't yet know
  how this occurs, but it has caused loss of data for at least two users.
  
  The fix here is to check realm-wide for the beatmap (using its primary
  key) rather than only in the list. We then handle the scenario where the
  beatmap needs to be reattached to the set as a seprate step.
  
  ---
  
  This does raise others questions like "are we even structuring this
  correctly? couldn't a single beatmap exist in two different sets?"
  
  Maybe, but let's deal with that if/when it comes up.

  Dean Herbert · 2023-06-27 18:20:01 +09:00
  8e80e2fa32
• Add test coverage of save failure when beatmap is detached from set
  Dean Herbert · 2023-06-27 18:18:58 +09:00
  4ecc724841
• Add xmldoc on LegacyTotalScore
  Dan Balasescu · 2023-06-27 17:18:32 +09:00
  6e2369e651
• Fix float division

  Firstly, this is intended to be a float division.
  
  Secondly, dividing integers by 0 results in an exception, but dividing
  non-zero floats by 0 results in +/- infinity which will be clamped to
  the upper range.
  In particular, this occurs when the beatmap has 1 hitobject (0 drain
  length).

  Dan Balasescu · 2023-06-27 17:14:35 +09:00
  5f350aa66f
• Add support for Ctrl + < / > to rotate selection in editor

  As discussed in https://github.com/ppy/osu/discussions/24048.

  Dean Herbert · 2023-06-27 17:01:41 +09:00
  c6d952abe3
• Add a visual effect when keyboard shortcuts are used to trigger selection box buttons
  Dean Herbert · 2023-06-27 17:01:13 +09:00
  7ddbf4eaa7
• Change JudgementCountController to a Component and remove handling overrides
  Dean Herbert · 2023-06-27 16:39:21 +09:00
  41890cfc65
• Rename ClicksPerSecondCalculator to ClicksPerSecondController
  Dean Herbert · 2023-06-27 16:38:46 +09:00
  8bd6f7a46a
• Change JudgementCountController to a Component
  Dean Herbert · 2023-06-27 16:38:15 +09:00
  de23a4691e
• Move controllers above skinnable elements in initialisation order
  Dean Herbert · 2023-06-27 16:37:23 +09:00
  113b570bd4
• Refactor InputCountController to not require being added to foreign body via Attach

  I've made the flow match `ClicksPerSecondCalculator` as close as
  possible. Hopefully this reads better.

  Dean Herbert · 2023-06-27 16:36:00 +09:00
  e21583ff1b
• Add safety to tests to ensure loaded
  Dean Herbert · 2023-06-27 16:04:34 +09:00
  e99de0eb5d
• Add test coverage of new matching mode
  Dean Herbert · 2023-06-27 15:44:58 +09:00
  19ec6d5455
• Add support for matching full terms using suffixed !
  Dean Herbert · 2023-06-27 15:34:33 +09:00
  c423f77d53
• Add missing "title=" search support at song select
  Dean Herbert · 2023-06-27 15:21:13 +09:00
  702266198b
• Store old total score as LegacyTotalScore
  Dan Balasescu · 2023-06-27 14:59:40 +09:00
  0c5c09597c
• Merge pull request #24045 from peppy/exact-match-song-select

  Add exact match support for song select searches

  Dean Herbert · 2023-06-27 13:47:26 +09:00
  9b08aaf93f
• Attempt to remedy HUD overlay test failure by waiting more
  Bartłomiej Dach · 2023-06-26 22:41:31 +02:00
  9c87d42f2b
• Fix incorrect indent size
  Bartłomiej Dach · 2023-06-26 22:40:25 +02:00
  40ceb4dfac
• Merge branch 'master' into exact-match-song-select
  Bartłomiej Dach · 2023-06-26 22:33:50 +02:00
  9c30b1d3e0
• Use == true rather than ?? false
  Bartłomiej Dach · 2023-06-26 22:29:20 +02:00
  e998be0eee
• Escape user input before embedding into regex
  Bartłomiej Dach · 2023-06-26 22:27:48 +02:00
  4cb122dad4
• Add failing test case for filters potentially crashing due to invalid regex
  Bartłomiej Dach · 2023-06-26 22:27:08 +02:00
  4873aaf7ed
• Remove weird nullable enable and double licence header
  Bartłomiej Dach · 2023-06-26 22:19:52 +02:00
  8a7a42b7ec
• Merge pull request #24053 from bdach/fix-skip-when-ready-2

  Fix skip not always triggering in multiplayer

  Dean Herbert · 2023-06-27 05:10:14 +09:00
  c84a75406c
• Fix skip not always triggering in multiplayer
  timiimit · 2023-06-26 21:26:41 +02:00
  e1cbcabe0b
• Rename Judgement{Tally -> CountController}
  Bartłomiej Dach · 2023-06-26 19:30:04 +02:00
  7200855d46
• Rename {KeyCounter -> InputCount}Controller
  Bartłomiej Dach · 2023-06-26 19:27:42 +02:00
  8d91580dc1
• Group input handling members together
  Bartłomiej Dach · 2023-06-26 19:25:52 +02:00
  4ac48e4cd8