osu-lazer

Use constant online IDs in tests to avoid preview not working randomly

Bartłomiej Dach · 2021-11-24 20:34:33 +01:00

1907b42f82

Update working beatmap when returning to match

Dan Balasescu · 2021-11-24 19:56:02 +09:00

132bb59203

Merge pull request #15781 from peppy/beatmap-set-status

Rename `BeatmapSetOnlineStatus` to `BeatmapOnlineStatus`

Dan Balasescu · 2021-11-24 19:25:29 +09:00

e176083898

Merge branch 'master' into beatmap-card/track-preview

Dean Herbert · 2021-11-24 18:54:25 +09:00

b739b6a725

Rename BeatmapSetOnlineStatus to BeatmapOnlineStatus

This variable is used at more than just a set level.

Dean Herbert · 2021-11-24 18:42:49 +09:00

183b95cbc2

Replace one more usage

Dean Herbert · 2021-11-24 18:29:33 +09:00

0fe27cc8a1

Fix a few incorrectly updated arguments

Dean Herbert · 2021-11-24 18:14:18 +09:00

7603f7eb36

Combine all test data BeatmapSetInfo creation into a single method

Dean Herbert · 2021-11-24 18:07:32 +09:00

0c819b9cfb

Merge pull request #15778 from peppy/ruleset-info-id-usage

Update usages of `RulesetInfo.ID` to use `OnlineID` instead

Dan Balasescu · 2021-11-24 16:55:28 +09:00

74b6c33fab

Merge pull request #15772 from peppy/remove-model-list-inits

Initialise `BeatmapSet.Beatmaps` list at construction time

Dan Balasescu · 2021-11-24 16:41:19 +09:00

8ce5324c8b

Update mock RulesetInfo usage to set OnlineID instead of ID

Dean Herbert · 2021-11-24 15:50:26 +09:00

f283770f34

Revert changes causing BeatmapSet.Metadata to be expectedly null in some tests

Dean Herbert · 2021-11-24 14:52:08 +09:00

44c34ca7b2

Merge pull request #15770 from peppy/fix-incorrect-id-usage-in-tests

Fix incorrect usage of `ID` in `TestSceneMultiplayerResults`

Dan Balasescu · 2021-11-24 13:51:30 +09:00

cf17c51df2

Fix cases of dynamically assigning Beatmaps to BeatmapSetInfo using list assignment

Dean Herbert · 2021-11-24 13:27:37 +09:00

8c60f37508

Fix incorrect usage of ID in TestSceneMultiplayerResults

Dean Herbert · 2021-11-24 13:05:51 +09:00

b1f3e98045

Update cases where equality can be used instead of primary key equality

Dean Herbert · 2021-11-24 12:49:57 +09:00

729f681938

Merge pull request #15757 from smoogipoo/fix-multiplayer-tests

Fix several intermittent multiplayer test failures

Dean Herbert · 2021-11-24 09:32:01 +09:00

049f25a133

Implement preview track playback

Bartłomiej Dach · 2021-11-23 23:17:30 +01:00

1a1603f0db

Implement basic behaviour of play button

Bartłomiej Dach · 2021-11-23 22:44:09 +01:00

9164f006aa

Add test scene for thumbnail component

Bartłomiej Dach · 2021-11-23 22:44:08 +01:00

b44db9f5e5

Wait for ready button to be enabled first

Dan Balasescu · 2021-11-23 17:09:38 +09:00

a521d1b835

Merge pull request #15745 from bdach/settings-number-box-stack-overflow

Fix crashes on trying to play back replays of seeded mods with seed value over 1 billion

Dan Balasescu · 2021-11-23 16:36:05 +09:00

fd4d5e98a7

Revert unnecessary changes

Dan Balasescu · 2021-11-23 16:17:09 +09:00

6363833fb3

Fix a few more multiplayer test timeouts

These can be tested by adding a `Task.Delay(3000);` at the end of the
`MultiplayerClient.JoinRoom` task. The reason is typically that
`Client.Room` becomes not-null but the join task still hasn't completed
yet, so e.g. the ready button is still disabled.

Dan Balasescu · 2021-11-23 16:07:03 +09:00

69a9fc9732

Rewrite overflow test step for legibility

Bartłomiej Dach · 2021-11-23 06:43:17 +01:00

b596a0204c

Fix potential test failure in TestSceneMultiplayerReadyButton

Couldn't exactly reproduce https://github.com/ppy/osu/runs/4294316800,
but I found a similar issue via:

```diff
diff --git a/osu.Game.Tests/Visual/Multiplayer/TestSceneMultiplayerReadyButton.cs b/osu.Game.Tests/Visual/Multiplayer/TestSceneMultiplayerReadyButton.cs
index 84b63a5733..29cac9b061 100644
--- a/osu.Game.Tests/Visual/Multiplayer/TestSceneMultiplayerReadyButton.cs
+++ b/osu.Game.Tests/Visual/Multiplayer/TestSceneMultiplayerReadyButton.cs
@@ -3,6 +3,7 @@

 using System;
 using System.Linq;
+using System.Threading;
 using System.Threading.Tasks;
 using NUnit.Framework;
 using osu.Framework.Allocation;
@@ -81,6 +82,8 @@ private void load(GameHost host, AudioManager audio)

                         await Client.ToggleReady();

+                        Thread.Sleep(1000);
+
                         readyClickOperation.Dispose();
                     });
                 }
```

Dan Balasescu · 2021-11-23 14:07:55 +09:00

10bd7176e0

Merge pull request #15735 from peppy/remove-ruleset-info-inheritance

Remove subclassing of `RulesetInfo`

Dean Herbert · 2021-11-23 10:18:32 +09:00

e580fc5abc

Add extended test coverage for desired input handling

Bartłomiej Dach · 2021-11-22 20:39:44 +01:00

dced6a2e68

Add failing test case for number box stack overflow scenario

Bartłomiej Dach · 2021-11-22 20:26:45 +01:00

2350806b4c

Use Equals in carousel tests for better realm compatibility

Dean Herbert · 2021-11-22 17:20:21 +09:00

001f7c36f3

Remove subclassing of RulesetInfo

Dean Herbert · 2021-11-22 16:39:17 +09:00

b9923e5396

Fix APIRoom queue mode not updated on change

Dan Balasescu · 2021-11-22 13:46:01 +09:00

f64d20ed71

Merge branch 'master' into multi-queueing-modes

Dean Herbert · 2021-11-22 12:32:47 +09:00

bbb3abbc61

Adjust test to match new logic

Dan Balasescu · 2021-11-22 11:20:19 +09:00

cad6d1d25d

Compare playlist item IDs instead in tests

Dan Balasescu · 2021-11-22 11:17:32 +09:00

53dbbd6d64

Merge branch 'master' into multi-queueing-modes

Dan Balasescu · 2021-11-22 07:46:45 +09:00

4b498c7bd6

Merge branch 'master' into beatmap-card/download-button

Dean Herbert · 2021-11-21 20:04:26 +09:00

c0962b1c4f

Merge branch 'master' into beatmap-card/download-button

Bartłomiej Dach · 2021-11-20 18:49:11 +01:00

65cb011bac

Use BindTarget from card rather than caching & resolving download tracker

Bartłomiej Dach · 2021-11-20 18:48:26 +01:00

297de27a6a

Change difficulty cache storage type to nullable

The recent changes related to adding support for working beatmap load
cancellation exposed a flaw in the beatmap difficulty cache. With the
way the difficulty computation logic was written, any error in the
calculation process (including beatmap load timeout, or cancellation)
would result in a 0.00 star rating being permanently cached in memory
for the given beatmap.

To resolve, change the difficulty cache's return type to nullable.
In failure scenarios, `null` is returned, rather than
`default(StarDifficulty)` as done previously.

Bartłomiej Dach · 2021-11-20 17:00:50 +01:00

15feb17da8

Replace existing cases with new helper method

Dean Herbert · 2021-11-19 22:15:41 +09:00

83b4625bd5

Merge branch 'master' into multi-queueing-modes

Dan Balasescu · 2021-11-19 18:58:15 +09:00

de0e8ad822

Update queue mode names

Dan Balasescu · 2021-11-19 18:28:43 +09:00

4e625b78e2

Remove namespacing of queue tests