osu-lazer

Merge pull request #18462 from frenzibyte/fix-timeline-zooming

Fix timeline objects disappearing prematurely on wide-screens

Dan Balasescu · 2022-06-05 11:49:44 +09:00

b897e1464f

Update DaySeparator to use new design throughout

Moves `DaySeparator` chat component to it's own file and update it to
match new chat design. Makes use of several virtual attributes that can
be overridden to update spacing and layout in other usage contexts.

Remove redundant usage of `ChatOverlayDaySeparator`, since the new
design is now part of the base class.

Create `StandAloneDaySeparator` to use in `StandAloneChatDisplay` which
overrides attributes to match correct spacing and layout for its design.

Ensure that `DrawableChannel.CreateDaySeparator` returns type of
`DaySeparator` instead of `Drawable`.

Jai Sharma · 2022-06-04 18:02:14 +01:00

c0aaeff2b3

Merge pull request #18523 from peppy/tap-button

Add tap for BPM button

Dan Balasescu · 2022-06-03 18:11:10 +09:00

1c738e22ae

Add new failing test coverage

Salman Ahmed · 2022-06-03 02:34:10 +03:00

588151f48b

Update test to match expectation

Salman Ahmed · 2022-06-03 02:22:16 +03:00

ca68751fdc

Merge branch 'master' into fix-timeline-zooming

Salman Ahmed · 2022-06-03 02:00:09 +03:00

8471b24659

Fix compilation failure due not applying rename fully

Bartłomiej Dach · 2022-06-02 21:18:09 +02:00

6f1437e73d

Merge branch 'master' into multiplayer-leaderboard-user-mods-2

Bartłomiej Dach · 2022-06-02 20:45:10 +02:00

59ffc8b08e

Fix test button references

Dean Herbert · 2022-06-02 17:29:45 +09:00

c42485cea9

Merge pull request #18422 from smoogipoo/detect-exclusive-fullscreen

Detect exclusive fullscreen on Windows

Dean Herbert · 2022-06-02 15:13:02 +09:00

5adbf85654

Mark players as playing

Dan Balasescu · 2022-06-02 14:22:45 +09:00

793dfe2bc8

Fix disposing previous leaderboard too late

Dan Balasescu · 2022-06-02 14:22:15 +09:00

600da89f72

Add basics of tap button

Dean Herbert · 2022-06-02 11:57:06 +09:00

d12f6ea221

Merge branch 'master' into fix-dummmy-api-request-firing-2

Dean Herbert · 2022-06-02 07:47:21 +09:00

24ce10ed6f

Merge pull request #18502 from peppy/editor-timing-follow-current-time

Add automatic control point tracking to the timing screen

Dean Herbert · 2022-06-02 07:37:03 +09:00

6b297bc6ed

Refactor warning to notice in method names and usages

Dean Herbert · 2022-06-01 16:51:58 +09:00

42598ce22a

Add adjustment buttons

Dean Herbert · 2022-05-31 21:31:20 +09:00

a940676fc2

Merge branch 'scoreprocessor-cleanup' into multiplayer-leaderboard-user-mods-2

Dan Balasescu · 2022-05-31 19:53:37 +09:00

13d85b8cc7

Ensure rows have loaded before attempting to click them

Dean Herbert · 2022-05-31 15:54:07 +09:00

9746cbb161

Add automatic control point tracking to the timing screen

Dean Herbert · 2022-05-31 15:00:30 +09:00

cf5da44492

Refactor settings item "warning" text to allow non-warning state

Dean Herbert · 2022-05-31 14:01:42 +09:00

53844d3df1

Merge branch 'master' into fix-dummmy-api-request-firing-2

Dean Herbert · 2022-05-31 12:23:26 +09:00

c892aed797

Merge pull request #18427 from sw1tchbl4d3r/currently_playing_search

Add search bar for the `CurrentlyPlayingDisplay`

Dean Herbert · 2022-05-30 23:03:00 +09:00

1d5a156c15

Ensure some results have been loaded in playlist results screen tests

Basically, the failing delayed test would fire two web requests during
the proceedings. In unfortunate timing, the first would succeed and the
test would think "everything is okay", but the actual request loading
results has not yet run.

This check ensures *something* is loaded, which seems to be enough to
make things reliable.

Dean Herbert · 2022-05-30 19:29:16 +09:00

17174a7b09

Use new score processor in MultiplayerGameplayLeaderboard

Dan Balasescu · 2022-05-30 19:26:26 +09:00

22d998dc2a

Select correct channel regardless of load order

Dean Herbert · 2022-05-30 17:57:48 +09:00

0981d415a1

Remove "V2" suffix from ChatOverlay components

Dean Herbert · 2022-05-30 17:54:09 +09:00

f65d2db77f

Merge pull request #18442 from jai-x/new-chat-announce-channel

Display Announce type channels separately in new chat overlay

Dean Herbert · 2022-05-30 16:53:15 +09:00

9e678101cf

Merge branch 'master' into currently_playing_search

Dean Herbert · 2022-05-30 16:48:53 +09:00

5478ac21ea

Merge pull request #18477 from frenzibyte/fix-timeline-context-menu

Fix context menu no longer opening for hitobjects in timeline

Dan Balasescu · 2022-05-30 11:49:06 +09:00

be998cdb0a

Merge pull request #18487 from jai-x/remove-old-chat

Remove old chat overlay components

Dan Balasescu · 2022-05-30 11:04:05 +09:00

779ec7d9db

Fix some more chat tests failing intermittently

```
TearDown : osu.Framework.Testing.Drawables.Steps.AssertButton+TracedException : Channel 1 ready
--TearDown
   at osu.Framework.Threading.ScheduledDelegate.RunTaskInternal()
   at osu.Framework.Threading.Scheduler.Update()
   at osu.Framework.Graphics.Drawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Platform.GameHost.UpdateFrame()
   at osu.Framework.Threading.GameThread.processFrame()
   at osu.Framework.Threading.GameThread.RunSingleFrame()
   at osu.Framework.Threading.GameThread.<createThread>g__runWork|66_0()
   at System.Threading.Thread.StartHelper.Callback(Object state)
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)

-----

One or more child tests had errors
  Exception doesn't have a stacktrace

[runtime] 2022-05-29 19:29:09 [verbose]: 💨 Class: TestSceneChatOverlayV2
[runtime] 2022-05-29 19:29:09 [verbose]: 🔶 Test:  TestSlowLoadingChannel
[runtime] 2022-05-29 19:29:09 [verbose]: Chat is now polling every 60000 ms
[runtime] 2022-05-29 19:29:09 [verbose]: 🔸 Step #1 Setup request handler
[runtime] 2022-05-29 19:29:09 [verbose]: 🔸 Step #2 Add test channels
[runtime] 2022-05-29 19:29:09 [verbose]: 🔸 Step #3 Show overlay (slow-loading)
[runtime] 2022-05-29 19:29:09 [verbose]: 🔸 Step #4 Join channel 1
[runtime] 2022-05-29 19:29:09 [verbose]: 🔸 Step #5 Select channel 1
[runtime] 2022-05-29 19:29:09 [verbose]: 🔸 Step #6 Channel 1 loading
[runtime] 2022-05-29 19:29:09 [verbose]: 🔸 Step #7 Join channel 2
[runtime] 2022-05-29 19:29:09 [verbose]: 🔸 Step #8 Select channel 2
[runtime] 2022-05-29 19:29:09 [verbose]: 🔸 Step #9 Channel 2 loading
[runtime] 2022-05-29 19:29:09 [verbose]: 🔸 Step #10 Finish channel 1 load
[runtime] 2022-05-29 19:29:09 [verbose]: 🔸 Step #11 Channel 1 ready
[runtime] 2022-05-29 19:29:09 [verbose]: 💥 Failed
[runtime] 2022-05-29 19:29:09 [verbose]: ⏳ Currently loading components (2)
[runtime] 2022-05-29 19:29:09 [verbose]: TestSceneChatOverlayV2+SlowLoadingDrawableChannel
[runtime] 2022-05-29 19:29:09 [verbose]: - thread: ThreadedTaskScheduler (LoadComponentsAsync (standard))
[runtime] 2022-05-29 19:29:09 [verbose]: - state:  Loading
[runtime] 2022-05-29 19:29:09 [verbose]: TestSceneChatOverlayV2+SlowLoadingDrawableChannel
[runtime] 2022-05-29 19:29:09 [verbose]: - thread: ThreadedTaskScheduler (LoadComponentsAsync (standard))
[runtime] 2022-05-29 19:29:09 [verbose]: - state:  Ready
[runtime] 2022-05-29 19:29:09 [verbose]: 🧵 Task schedulers
[runtime] 2022-05-29 19:29:09 [verbose]: LoadComponentsAsync (standard) concurrency:4 running:1 pending:0
[runtime] 2022-05-29 19:29:09 [verbose]: LoadComponentsAsync (long load) concurrency:4 running:0 pending:0
[runtime] 2022-05-29 19:29:09 [verbose]: 🎱 Thread pool
[runtime] 2022-05-29 19:29:09 [verbose]: worker:          min 32     max 32,767 available 32,765
[runtime] 2022-05-29 19:29:09 [verbose]: completion:      min 32     max 1,000  available 1,000

```

Dean Herbert · 2022-05-30 04:34:10 +09:00

03deb336b2

Remove old chat overlay components

Jai Sharma · 2022-05-29 20:08:43 +01:00

8f596520f3

Merge branch 'master' into new-chat-announce-channel

Bartłomiej Dach · 2022-05-29 18:55:43 +02:00

f9f8a32380

Centralise DrawableChannel checks and account for async load delays

Dean Herbert · 2022-05-29 23:16:26 +09:00

caee9e67b6

Remove redundant initialiser

Bartłomiej Dach · 2022-05-29 16:06:01 +02:00

18f75d8c58

Fix unsafe config fetching

Dean Herbert · 2022-05-29 22:55:53 +09:00

c078c06902

Add failing test coverage

Salman Ahmed · 2022-05-29 15:23:32 +03:00

12d5b355e4

Add failing test case

Salman Ahmed · 2022-05-28 17:45:00 +03:00

0349d92f8b

Fix remaining cases of incorrect GameplayState construction in tests

Manual attempts to initialise replaced by a new `TestGameplayState`
helper for ease of use.

Bartłomiej Dach · 2022-05-28 15:23:29 +02:00

a8e1c5ba87

Fix unobserved exceptions due to using unconverted beatmap

`TestSceneBeatmapSkinFallbacks` was locally caching a `GameplayState`
instance to fulfill dependencies of a
`SkinnableTargetComponentsContainer`. However, it was doing so using
`new TestBeatmap()`, which is a raw decoded beatmap that hasn't been
converted to any ruleset yet, which was causing failures in
`BeatmapDifficultyCache.GetTimedDifficultyAttributesAsync()` as that
method is expecting to receive a post-conversion, ready-for-gameplay
beatmap.

Resolve by proxying forward dependency instances from the
already-known-to-be-working `actualComponentsContainer`.

Bartłomiej Dach · 2022-05-28 15:23:29 +02:00

dcf3d76954

Fix unobserved exceptions due to unimplemented beatmap converter

`TestSceneStatisticsPanel` intends to check the operation of statistics
panels using dummy ruleset classes. However, `StatisticsPanel` relies on
being able to retrieve the playable beatmap, which requires a converter.
One was not provided by the dummy rulesets, therefore the retrieval
would fail with an unobserved exception.

To fix, add a barebones converter implementation that is enough for the
test to pass.

Bartłomiej Dach · 2022-05-28 14:10:57 +02:00

e18fec3d89

Display Announce type channels separately in new chat overlay

Jai Sharma · 2022-05-27 16:18:22 +01:00

320b6ca631

Address code style issues