8043 Commits

• Merge branch 'master' into mod-validation-tests
  Salman Ahmed · 2022-08-26 15:00:07 +03:00
  1fd1672d89
• Merge branch 'master' into fix-playlist-overlay-test-failures
  Dean Herbert · 2022-08-26 20:25:53 +09:00
  6dc859973b
• Fix check not accounting for mods not existing in certain rulesets

  Also check all instances, rather than first.

  Dean Herbert · 2022-08-26 19:59:26 +09:00
  5ef8e26ebe
• Merge branch 'master' into mod-validation-tests
  Dean Herbert · 2022-08-26 19:48:42 +09:00
  580754833f
• Fix TimelineTestScene's beatmap getting overwritten by EditorClockTestScene
  Dean Herbert · 2022-08-26 18:38:52 +09:00
  9c9238d6e8
• Fix various test scenes not adding EditorClock to the draw hierarchy
  Dean Herbert · 2022-08-26 18:08:43 +09:00
  4b72e55770
• Split out test assertion methods to read better
  Dean Herbert · 2022-08-26 16:56:03 +09:00
  9050f54681
• Fix lead in tests not waiting for player to start running

  The tests are only meant to ensure that gameplay eventually starts.
  
  The case where failures can occur is where the master clock is behind
  the player clock (due to being in lead-in time). Because the test is
  running in real-time, it can take arbitrary amounts of time to catch up.
  
  If it took too long, the test would fail.

  Dean Herbert · 2022-08-25 18:00:14 +09:00
  a8c699610a
• Rename asserts to method names to make it easier to track in logs
  Dean Herbert · 2022-08-25 17:30:13 +09:00
  ddb434f47a
• Improve understandability of TestMostInSyncUserIsAudioSource
  Dean Herbert · 2022-08-25 16:47:33 +09:00
  a5c61d9a52
• Merge branch 'master' into no-gameplay-clock-gameplay-offset
  Dean Herbert · 2022-08-25 16:24:55 +09:00
  3a17c6df08
• Fix some BeatmapCarousel tests not correctly reinitialising local data per run

  Closes https://github.com/ppy/osu/issues/19949.

  Dean Herbert · 2022-08-25 14:03:26 +09:00
  1032b2a68c
• Code cleanup (CPS)
  Ryuki · 2022-08-24 17:13:23 +02:00
  5cddc7ed1f
• Merge branch 'master' into kps
  Dean Herbert · 2022-08-24 18:18:45 +09:00
  5129716612
• Remove dollar sign
  Dean Herbert · 2022-08-24 17:17:59 +09:00
  ddccf4defe
• Rename PlayerArea.GameplayClock to SpectatorPlayerClock for clarity
  Dean Herbert · 2022-08-24 17:13:14 +09:00
  27b57947e4
• Ensure elapsed time is always non-zero when advancing SpectatorPlayerClock
  Dean Herbert · 2022-08-24 17:13:14 +09:00
  5f01f461b3
• Merge branch 'master' into no-gameplay-clock-gameplay-offset
  Dean Herbert · 2022-08-24 16:52:10 +09:00
  5079e0d83d
• Rename spectator clock sync classes
  Dean Herbert · 2022-08-24 15:13:08 +09:00
  995e6664b6
• Merge branch 'master' into no-gameplay-clock-gameplay-offset
  Dean Herbert · 2022-08-23 17:36:06 +09:00
  ec61a94dc9
• Remove pointless initial import
  Dean Herbert · 2022-08-23 17:33:53 +09:00
  9a579871c0
• Use local realm rather than fetching from dependencies
  Dean Herbert · 2022-08-23 17:33:53 +09:00
  a62deae3cc
• Ensure all initial imports are completed before running playlist overlay tests steps
  Dean Herbert · 2022-08-23 17:33:53 +09:00
  690e048864
• Code cleanup for CPS tests

  - Remove null-forgiving operator usages
  - Fix code quality issues mentionned by NVika

  Ryuki · 2022-08-22 10:47:37 +02:00
  b597049524
• Merge pull request #19695 from naoei/ruleset-localization

  Change most ruleset-accessible string types to Localisable strings

  Dean Herbert · 2022-08-22 16:13:23 +09:00
  058d67f8e8
• Merge pull request #19783 from bdach/mod-select/presets-dont-open-customisation

  Fix selecting preset containing Difficulty Adjust automatically opening customisation panel

  Dan Balasescu · 2022-08-22 15:44:00 +09:00
  0815b01b75
• Use less custom classes for CPS tests
  Ryuki · 2022-08-22 00:03:24 +02:00
  c56390cd7b
• Merge branch 'master' into ruleset-localization
  Nao · 2022-08-20 21:39:10 -04:00
  189a407cb1
• Merge branch 'master' into kps
  Dean Herbert · 2022-08-20 15:24:58 +09:00
  da407aa827
• Update TestSceneSpectator to user new assert style
  Dean Herbert · 2022-08-19 01:46:19 +09:00
  15d49b0357
• Update calculator and tests to match changes on clocks
  Ryuki · 2022-08-18 18:40:02 +02:00
  3de35a1518
• Increase lenience on TestSceneLeadIn tests

  I've gone through these in detail and can't find an issue with the
  actual flow of things. For whatever reason, the new structure has a
  slightly higher delay, likely due to performing less `Seek` calls
  (previously a `Seek` was called after the clock start which may have
  been making this more accurate on the first `Player.Update`).
  
  I don't think it really matters that this is slightly off, but we'll see
  how this plays out.

  Dean Herbert · 2022-08-19 01:39:00 +09:00
  cc86909633
• Update TestSceneLeadIn to use new assert style
  Dean Herbert · 2022-08-18 19:26:19 +09:00
  2eba8650ca
• Update TestSceneLeadIn to use new assert style
  Dean Herbert · 2022-08-18 18:54:10 +09:00
  728cd96508
• Merge pull request #19779 from peppy/no-gameplay-clock

  Remove all remaining usage of `GameplayClock`

  Dan Balasescu · 2022-08-18 18:52:57 +09:00
  fa167b1d12
• Merge branch 'master' into no-gameplay-clock
  Dean Herbert · 2022-08-17 22:21:10 +09:00
  e7ddbc41c8
• Remove unnecessary local implementation in TestScenePlaybackControl
  Dean Herbert · 2022-08-17 19:21:54 +09:00
  553ae4781f
• Add some extra initial state checks to TestSceneEditorSeekSnapping
  Dean Herbert · 2022-08-17 19:21:46 +09:00
  4ef4d66f49
• Fix flaky quick retry test
  Dan Balasescu · 2022-08-17 17:09:44 +09:00
  3a0017c87b
• Merge branch 'master' into no-gameplay-clock
  Dean Herbert · 2022-08-17 15:21:20 +09:00
  20256aad11
• Merge pull request #19594 from BlauFx/improve_retry_behaviour

  Skip song intro on quick restart

  Dan Balasescu · 2022-08-16 20:18:12 +09:00
  24fd411720
• Make test actually test things
  Dean Herbert · 2022-08-16 14:40:02 +09:00
  9a1a7bae89
• Modify flow to avoid weird bindable and value resetting
  Dean Herbert · 2022-08-16 14:17:35 +09:00
  6761f869f9
• Fix running TestScenePlayerLoader interactively leaving volume in a bad state
  Dean Herbert · 2022-08-16 13:40:46 +09:00
  a15e6f19aa
• Merge branch 'master' into improve_retry_behaviour
  Dean Herbert · 2022-08-16 13:06:04 +09:00
  c9baadcf88
• Adjust test scene to reflect new behaviour
  Bartłomiej Dach · 2022-08-15 20:43:19 +02:00
  a494e55d93
• Add failing test case
  Bartłomiej Dach · 2022-08-15 20:38:22 +02:00
  f0ad31b650
• Add preset column to mod select test scene
  Bartłomiej Dach · 2022-08-15 18:38:37 +02:00
  5ff2e41a55
• Remove remaining usage of GameplayClock
  Dean Herbert · 2022-08-15 20:22:36 +09:00
  704568ae3b
• Fix IsCatchingUp not being in correct state
  Dean Herbert · 2022-08-15 20:17:48 +09:00
  87760bbc06