osu-lazer

Tooling updates (#37031 )

Most of this is as everywhere else, but there's also interesting code
inspection fixes from the InspectCode bump, so I'll talk about that a
little.

## [Fix suspicious equality in
`Hotkey`](https://github.com/ppy/osu/commit/948136e49e88a721827d54e51c5759fe9aca811d)

Inspection:
https://www.jetbrains.com/help/resharper/TypeWithSuspiciousEqualityIsUsedInRecord.Global.html

Pretty annoying to fix, nullable array types are a pain. Does look legit
though.

## [Fix `StarDifficulty` using inefficient struct
equality](https://github.com/ppy/osu/commit/2db775ebb0bb9f18de67677ef84b993465d26545)

Inspection:
https://www.jetbrains.com/help/resharper/DefaultStructEqualityIsUsed.Global.html

This is a dodgy one because there's no real sane way to define equality
on `StarDifficulty` now that it has difficulty and performance
attributes jammed into it. So I just basically shut the inspection up
with a `record` modifier and move on.

Unclear where the equality is used precisely. It's from a global
inspection. F12 is very unhelpful when trying to track down usages of
`Equals()`. We definitely have `Bindable<StarDifficulty>` instances and
those do use equality. Maybe more than that.

## [Use `nameof` expressions to reference enum member
names](https://github.com/ppy/osu/commit/aa08175c803bc725f3b15a92174dfe6d1b812d91)

Inspection:
https://www.jetbrains.com/help/resharper/CanSimplifyDictionaryRemovingWithSingleCall.html

Pretty quaint.

## [Prefer using concrete values over `default` or
`new()`](https://github.com/ppy/osu/commit/b21ee08d7748be10d42268d5c2eb77369026545d)

Inspection:
https://www.jetbrains.com/help/resharper/PreferConcreteValueOverDefault.html

I could see this one going both ways, but I'm kinda sold on this
inspection. Explicit is always better. Saves some allocations in the
`CancellationToken` cases as well.

## [Explicitly call `.AsEnumerable()` in some realm
usages](https://github.com/ppy/osu/commit/c8ce1ecd42b9d8abb8b9e2ab93d471f463e80401)

Inspection:
https://www.jetbrains.com/help/resharper/PossibleUnintendedQueryableAsEnumerable.html

Not fully sold on this one but it's quick and simple so might as well.

## [Simplify dictionary removal with single `.Remove()`
call](https://github.com/ppy/osu/commit/5964ceccea900302df726b7a8ecbf6b74eb2e427)

Inspection:
https://www.jetbrains.com/help/resharper/CanSimplifyDictionaryRemovingWithSingleCall.html

Not much to say.

Bartłomiej Dach · 2026-03-19 00:05:52 +09:00

18d4ba5874

Ignore more potentially incorrect data from BASS

This is still a workaround but arguably it's something we could leave in
place without much loss. I think this at least feels better than the
previous code.

Notably, you could argue the test coverage of the fail case is lower
since made it implicit that all tests will avoid the "backwards seek"
detections.  But we never really had tests correctly- fail on the original
so I don't see any loss of value.

Dean Herbert · 2025-08-14 19:20:30 +09:00

82906300b4

Emit important replay frames on every judgement

- Closes https://github.com/ppy/osu/issues/4287
- Probably closes https://github.com/ppy/osu/issues/25405 (but not
  retroactively)

Up until now, whether or not a replay frame is emitted depended solely
on the user's input, i.e. mouse movement or key presses/releases. This,
intersected with the replay playback system which is given allowance to
perform interpolation between replay frames, leads to potential
situations wherein a replay can play inaccurately when a judgement takes
place without user input meaningfully changing. One such case is slider
ends with their 36ms of judgement leniency; see
https://github.com/ppy/osu/issues/25405#issuecomment-2879031106 for
details on that.

To that end, this commit aims to counteract that issue by *forcing* an
important replay frame to be emitted on every new judgement recorded
during gameplay. This will only benefit rulesets wherein judgements can
occur that are not inherently tied to user input changing, which are
going to be osu! as mentioned above, and maybe possibly catch. I don't
foresee this doing anything relevant for taiko or mania.

Bartłomiej Dach · 2025-05-15 11:43:09 +02:00

9f91c2e25c

Resolve test failures

Dan Balasescu · 2025-04-04 23:17:16 +09:00

319e3db14e

Fix thread-race leading to OnScreenDisplay crash

Dan Balasescu · 2025-04-04 22:48:33 +09:00

abfda9cbcd

Allow locking orientation on iOS in certain circumstances

Salman Alshamrani · 2024-12-29 22:15:21 -05:00

7563a18c7f

Initialise container earlier to avoid null reference failures

Dean Herbert · 2024-10-23 18:46:20 +09:00

064aaeb60e

Fix playfield skinning layer no longer correctly rotating with the playfield

Closes https://github.com/ppy/osu/issues/30353.

Regressed in
https://github.com/ppy/osu/commit/4a39873e2aac3a6fa71a3be06407d9afb7df8922.

Bartłomiej Dach · 2024-10-21 13:49:12 +02:00

e89a4561ab

Fix incorrect xmldoc and adjust colour provider to match Player

Dean Herbert · 2024-05-01 20:30:36 +08:00

87e814e201

Merge branch 'master' into tcm-resume

Dan Balasescu · 2024-03-14 12:22:46 +09:00

0beaa8e8c5

Use ArgumentNullException.ThrowIfNull in more places

Berkan Diler · 2024-03-05 10:19:47 +01:00

9bac60a98f

Fix catch by moving cursor-specific handling local

Dan Balasescu · 2024-03-04 16:08:17 +09:00

bce3bd55e5

Add flag to allow backwards seeks in tests

Dean Herbert · 2024-02-29 23:05:28 +08:00

4184a5c1ef

Rename ClicksPerSecondCalculator to ClicksPerSecondController

Dean Herbert · 2023-06-27 16:38:46 +09:00

8bd6f7a46a

Rename {KeyCounter -> InputCount}Controller

Bartłomiej Dach · 2023-06-26 19:27:42 +02:00

8d91580dc1

Merge branch 'master' into hud/kc-skinnable

tsrk · 2023-06-25 15:42:08 +02:00

350d722c8d

revert: bring back old attachment flow

As discussed, this would bring more problems that anything.

Refs: 4c39708, f83a4f4

tsrk · 2023-06-25 15:21:55 +02:00

a7088ffe22

Change "floating fruits" mod to only apply adjustments to the playfield

Avoids things like touch screen inputs also being flipped.

Note that these adjustments can't be applied directly to the playfield
due to how playfields are used in various rulesets (basically relying on
the `PlayfieldAdjustContainer` to get things in the right place).

Closes #24000.

Dean Herbert · 2023-06-23 14:18:43 +09:00

08b3c0cce0

refactor: tidy up attachement flow

TODO: find better naming and improve XMLDocs

tsrk · 2023-06-18 22:57:21 +02:00

f83a4f4952

refactor: remove detachment logic

No real use case, cleaning up the diff

tsrk · 2023-06-15 12:24:37 +02:00

b4cbcb210e

feat: integrate attachment flow in SkinComponentsContainer

tsrk · 2023-06-06 00:27:43 +02:00

6fc6729677

Move KeyCounter components to HUD namespace

Dean Herbert · 2023-03-07 16:41:39 +09:00

28520414aa

Merge pull request #22635 from peppy/use-overlays-container-more

Use `Overlays` container rather than `KeyBindingInputManager` for flashlight

Dean Herbert · 2023-02-22 18:30:21 +09:00

a8c692a215

Remove contradictory remark from xmldoc

Bartłomiej Dach · 2023-02-21 21:05:46 +01:00

ab97b02235

Move DrawableRuleset.Audio to a less generic level

Dean Herbert · 2023-02-21 19:03:52 +09:00

1acc536248

Merge branch 'master' into revert-result-in-playfield

Bartłomiej Dach · 2023-02-19 16:33:10 +01:00

3183f5cee2

Revert ResumeOverlay setter accessibility change

Bartłomiej Dach · 2023-02-16 21:26:01 +01:00

b8084a15eb

Always create ResumeOverlay, with UseResumeOverlay flag only affecting whether it is displayed or not

Dean Herbert · 2023-02-16 15:47:20 +09:00

ce9ef3bc3c

Expose and consume OsuInputManager explicitly

Dean Herbert · 2023-02-14 17:36:07 +09:00

5ec5222d8a

Move Overlays container to accept input and be frame-stable

Dean Herbert · 2023-02-14 17:35:12 +09:00

970388d4e2

Restructure UseResumeOverlay to correctly handle a value change before BDL load

Dean Herbert · 2023-02-14 15:11:33 +09:00

63f3498762

Add UseResumeOverlay and use it for hiding the ResumeOverlay

Pasi4K5 · 2023-02-13 23:51:39 +01:00

e4b84ebd0b

Remove HidesResumeOverlay and set ResumeOverlay to null in OsuModAutopilot

Pasi4K5 · 2023-01-24 00:49:09 +01:00

8b47af6503

Hide ResumeOverlay when OsuModAutopilot is enabled

Pasi4K5 · 2023-01-22 03:44:59 +01:00

75a1a2ec2f

Move judgement result revert logic to Playfield

Previously, some judgement results were not reverted
when the source DHO is not alive (e.g. frames skipped in editor).
Now, all results are reverted in the exact reverse order.

ekrctb · 2023-01-19 19:57:13 +09:00

812a4b412a

Partial everything

Dan Balasescu · 2022-11-27 00:00:27 +09:00

7bc8908ca9

Update xmlodc and add nullability attributes

Salman Ahmed · 2022-10-13 00:16:42 +03:00

4fb156ef4e

Rename various cursor symbols

- `IProvideCursor.MenuCursor` -> `IProvideCursor.Cursor`
 - `MenuCursor` -> `MenuCursorContainer

Salman Ahmed · 2022-10-11 16:21:01 +03:00

9b45a9cf76

Tidy up attach logic

Dean Herbert · 2022-08-24 19:36:01 +09:00

f3847b90fd

Merge branch 'master' into kps

Dean Herbert · 2022-08-20 15:24:58 +09:00

da407aa827

Remove FrameStableClock (and redirect usages to FrameStabilityContainer)

Dean Herbert · 2022-08-15 19:19:19 +09:00

27569e2ed5

Rename all "KeysPerSecond" usages to "ClicksPerSecond"

Ryuki · 2022-08-14 20:12:11 +02:00

2aa3a1b50d

Remove KPS acronym usage

Ryuki · 2022-08-11 10:01:39 +02:00

3c6461b9e4

Use DI to provide dependencies for KPS Calculator and improve input

gathering

KPS Calculator now uses DI to retrieve the clocks. Using `HUDOverlay` it
is now cached for `KeysPerSecondCounter`s to resolve it. This also
allows to make an "Attach" flow like `KeyCounter`.

Ryuki · 2022-08-08 21:54:06 +02:00

b52a07c16a

Rename MenuCursorContainer and clean up code

Dean Herbert · 2022-07-26 14:11:52 +09:00

ef10145d6f

Automated #nullable processing

Dan Balasescu · 2022-06-17 16:37:17 +09:00

f8830c6850

Move DrawableRuleset binding to LoadComplete to avoid exceptions on InputManager access

Dean Herbert · 2022-03-18 15:28:48 +09:00

0988c2b0fa

Expose DrawableRuleset audio adjustments as non-container