Dean Herbert
5104e4db21
Add step to TestSceneChannelListItem
to actually select an item
2022-03-21 14:33:50 +09:00
Dean Herbert
812343b410
Merge branch 'master' into new-chat-channel-control
2022-03-21 14:14:02 +09:00
Jai Sharma
ba5a43b526
Rename ControlItem
-> ChannelListItem
and associated classes
2022-03-19 21:49:14 +00:00
Salman Ahmed
46e66e66e4
Make opening chat overlay opt-in to add coverage for unloaded chat overlays
...
Causes `TestHighlightWhileChatNeverOpen` to fail as expected.
2022-03-17 08:19:40 +03:00
Bartłomiej Dach
a8cefca685
Simplify fade-out transform
2022-03-16 21:49:04 +01:00
Bartłomiej Dach
03d3969b38
Remove unnecessary OsuColour
cache
...
One is already cached at `OsuGameBase` level.
2022-03-16 21:46:02 +01:00
Jai Sharma
c2e4779c2e
Remove redundant spacing in ControlItem
test scene
2022-03-16 11:57:11 +00:00
Dean Herbert
2452d84e98
Add missing Schedule
call to allow individual tests from TestSceneMessageNotifier
to pass
2022-03-16 18:44:30 +09:00
Jai Sharma
6628b7c654
Ensure existing items are expired and cleared in ChannelControlItem test setup
2022-03-14 22:21:18 +00:00
Jai Sharma
75958bf270
Refactor ControlItemText to use bindable flow for unread state
2022-03-14 21:32:30 +00:00
Jai Sharma
b01a809d55
Refactor ControlItemMention to use bindable flow
2022-03-14 21:26:33 +00:00
Jai Sharma
9621ef9437
Use OsuColour.Red1 for ControlItemClose hover colour
2022-03-14 21:10:39 +00:00
Jai Sharma
e9f0ad33ef
Use autosizing for ChannelControlItem test scene
2022-03-14 20:06:31 +00:00
Jai Sharma
c0d82dfb41
Code quality fixes
2022-03-14 19:42:55 +00:00
Jai Sharma
39c30516d0
Implement ChannelControlItem
for new chat design
...
Adds new component `ChannelControlItem` and it's child components to be
used as the clickable control in the new chat sidebar for joined
channels.
Has public properties `HasUnread` and `MentionCount` to control the
display of the channel having unread messages or mentions of the user.
Channel select/join requests are exposed via `OnRequestSelect` and
`OnRequestLeave` events respectively which should be handled by a parent
component.
Requires a cached `Bindable<Channel>` instance to be managed by a parent
component.
Requires a cached `OveralayColourScheme` instance to be provided by a
parent component.
2022-03-14 18:55:27 +00:00
Salman Ahmed
cc87563d57
Merge branch 'master' into chat-mention-highlight
2022-03-11 17:51:22 +03:00
Salman Ahmed
a31611bdec
Improve channel switching flow in HighlightMessage
2022-03-10 23:07:15 +03:00
Salman Ahmed
e419370830
Add test coverage for highlighting message on left channel
2022-03-10 21:30:02 +03:00
Dean Herbert
022dd88aef
Merge branch 'master' into chat-mention-highlight
2022-03-10 14:23:23 +09:00
Salman Ahmed
f229447453
Add too many messages to better test long scrolls
2022-03-10 04:01:07 +03:00
Salman Ahmed
d4de435eb2
Add test case for highlighting while chat overlay is hidden
2022-03-10 02:50:27 +03:00
Salman Ahmed
80c0df6af5
Scroll chat line to channel center
...
We may eventually want that encapsulated within `ScrollIntoView`, as it
would also come in handy for `GameplayLeaderboard`.
2022-03-10 02:50:15 +03:00
Jai Sharma
b67f9269f9
Remove NewChat
namespace
2022-03-09 18:13:56 +00:00
Jai Sharma
9720a06b16
Use int
in ChannelListing test
2022-03-09 00:52:33 +00:00
Jai Sharma
a3477c3841
Implement ChannelListing
for new chat design
...
Adds components `ChannelListing` and `ChannelListing` item with visual
test. Essentially a more simplified version of the existing
`ChannelSelectionOverlay` component.
Correctly implements `IFilterable` behaviour to filter child channel
items. Channel joined state is based on the underlying `Joined` bindable
of the `Channel` class.
Channel join/leave events are exposed via `OnRequestJoin` and
`OnRequestLeave` events which should be handled by parent component.
Requires a cached `OverlayColourScheme` instance to be provided by the
parent overlay component when added.
2022-03-08 22:30:58 +00:00
Dean Herbert
56ad684f5b
Fix potential test failure on slow realm callback in TestSceneBeatmapDownloadButton
...
As brought to light by https://gist.github.com/smoogipoo/56eda7ab56b9d1966556f2ca7a80a847 .
2022-03-09 01:11:46 +09:00
Salman Ahmed
7f47be4680
Refactor message highlighting logic to rely on a Channel
data bindable
2022-03-08 03:19:37 +03:00
Salman Ahmed
741702549b
Add test coverage for chat overlay message highlighting
2022-03-07 05:10:49 +03:00
Salman Ahmed
cb2133944d
Add test coverage for channel message highlighting
2022-03-07 05:10:49 +03:00
Salman Ahmed
9bc1f3f014
Further refactor and simplify ChannelScrollContainer
2022-03-06 23:34:12 +03:00
Salman Ahmed
5b3ffb12b7
Refactor channel scrolling container to handle manual scrolls resiliently
2022-03-05 23:27:07 +03:00
Dan Balasescu
e947c97e10
Merge branch 'master' into spectator-reliability
2022-02-25 20:20:30 +09:00
Dean Herbert
14c8ce50a0
Prefix all test send methods in TestSpectatorClient
with Send
2022-02-24 02:23:48 +09:00
Dean Herbert
98aaf83177
Add a centralised constant for the osu URL schema protocol
2022-02-18 15:57:37 +09:00
Dan Balasescu
4f86a2cb61
Merge pull request #16525 from bdach/beatmap-listing-overflow-and-scrolling
...
Improve usability of expanded card content on beatmap listing
2022-01-20 14:14:44 +09:00
Bartłomiej Dach
4cad5890c6
Add test coverage for news sidebar showing wrong headers
2022-01-19 23:12:35 +01:00
Bartłomiej Dach
d925e44b40
Add test coverage for beatmap card expanded content clipping
2022-01-19 22:08:52 +01:00
Dean Herbert
1b62a685f3
Merge branch 'master' into realm-integration/score-and-beatmaps
2022-01-18 15:07:59 +09:00
Dean Herbert
0ba0b5f11a
Fix test step not being until
when it needs to be
2022-01-17 19:45:32 +09:00
Dean Herbert
a80e461000
Add better test coverage of user top scores
2022-01-17 16:23:58 +09:00
Dean Herbert
6436b6186f
Rewrite TestScenScoresContainer
to work again
2022-01-17 15:15:39 +09:00
Dean Herbert
4f8d29c1c0
Merge branch 'master' into realm-integration/score-and-beatmaps
2022-01-13 18:25:09 +09:00
Dean Herbert
e1f5acd689
Remove names from user dictionary
2022-01-13 12:40:19 +09:00
Dean Herbert
31a3161189
Make tests compile again
2022-01-12 17:00:16 +09:00
Dan Balasescu
3cb5f43f77
Fix incorrect action returned for wiki links in DEBUG mode
2022-01-11 17:46:49 +09:00
Dan Balasescu
269df08fc9
Make ChatLink tests into proper unit test methods
2022-01-11 17:42:02 +09:00
Bartłomiej Dach
82d6639a3b
Decouple rankings table test from online API
2022-01-09 14:42:19 +01:00
Bartłomiej Dach
881fa2b86b
Add basic test scene for scoreboard time
2022-01-07 19:18:16 +01:00
Bartłomiej Dach
2660f41339
Add failing test case for old cards not expiring correctly
2022-01-03 19:28:14 +01:00
Joseph Madamba
7de43e3aba
Fix most open compound words in identifiers being closed
2021-12-27 20:26:28 -08:00
Joseph Madamba
98524d60a4
Fix clear identifier typos
2021-12-27 20:26:28 -08:00
Bartłomiej Dach
27c5cc5bd8
Add testing for beatmap card size switching
2021-12-23 15:55:51 +01:00
Bartłomiej Dach
02fa1c21b7
Adjust existing placeholder test to demonstrate failure case
2021-12-22 15:03:20 +01:00
Dean Herbert
0f8a6a3f64
Fix intermittent failures on TestSceneBeatmapListingOverlay
...
In the specific method, there was no wait step after the initial fetch
(unlike all of the rest), meaning the fetch may not have finished in
time for the follow-up steps.
As seen at
https://github.com/ppy/osu/runs/4588058438?check_suite_focus=true .
2021-12-21 14:12:06 +09:00
Bartłomiej Dach
097402677d
Add test for ranked/unranked user display
2021-12-19 13:40:22 +01:00
Bartłomiej Dach
c112177559
Bring profile header test in line with modern conventions
...
- Removed online code that didn't work anyway after the introduction of
the development web instance.
- Removed some weird test steps.
- Fixed online/offline test steps not working at all due to identical
user ID.
2021-12-19 13:40:21 +01:00
Dan Balasescu
488374b4a2
Don't show multiplayer channels in chat overlay
2021-12-16 16:41:47 +09:00
Dean Herbert
bff02bedbf
Rename APIScoreInfo
to APIScore
2021-12-10 16:11:49 +09:00
Dan Balasescu
a445dcd2c6
Fix incorrect test namespace
2021-12-10 02:09:31 +09:00
Dan Balasescu
1a0945daba
Siplify condition, allow host to always remove items
2021-12-09 14:33:50 +09:00
Dan Balasescu
c34c580ad4
Add client-side + interface implementation
2021-12-09 03:08:59 +09:00
Bartłomiej Dach
38702beabf
Merge branch 'master' into i-ruleset-store
2021-12-04 15:05:39 +01:00
Dean Herbert
1eed2436e6
Clean up unused resolved properties
2021-12-03 18:49:49 +09:00
Dean Herbert
e75e209053
Cache and consume IRulesetStore
where feasible
2021-12-03 18:16:01 +09:00
Bartłomiej Dach
05f7ea6b6d
Remove mentions of "panel" and "direct" from names of old download buttons
2021-11-27 15:08:03 +01:00
Bartłomiej Dach
a043d1e427
Move old beatmap download button to more general namespace
2021-11-27 15:06:57 +01:00
Bartłomiej Dach
567c985da0
Remove beatmap panel test scene
2021-11-27 14:56:27 +01:00
Dean Herbert
183b95cbc2
Rename BeatmapSetOnlineStatus
to BeatmapOnlineStatus
...
This variable is used at more than just a set level.
2021-11-24 18:42:49 +09:00
Dean Herbert
f283770f34
Update mock RulesetInfo
usage to set OnlineID
instead of ID
2021-11-24 15:50:26 +09:00
Dean Herbert
692e846acd
Rename BeatmapSetInfo.OnlineBeatmapSetID
to OnlineID
to match interface
2021-11-12 17:52:44 +09:00
Dean Herbert
6a098a8634
Rename BeatmapInfo.OnlineBeatmapID
to OnlineID
to match interface
2021-11-12 17:46:24 +09:00
Dan Balasescu
1c40d5bc08
Merge branch 'master' into remove-stupid-weak-reference-bindable-events
2021-11-08 14:41:32 +09:00
Dean Herbert
78aef9ce86
Merge branch 'master' into remove-stupid-weak-reference-bindable-events
2021-11-08 13:35:49 +09:00
Dean Herbert
54f72d68ca
Revert weird event flow in model manager/importers
2021-11-05 19:12:49 +09:00
Dean Herbert
ba74dd93b2
Remove weird fetchOnline
logic
2021-11-05 13:55:34 +09:00
Dean Herbert
ead64282dd
Split out a couple more nested classes
2021-11-05 13:40:44 +09:00
Dean Herbert
b9983add15
Rename User
to APIUser
and move to correct namespace
2021-11-04 18:21:31 +09:00
Dean Herbert
77be610b26
Revert "Clean up DirectDownloadButton
test scene"
...
This reverts commit baabe99f78
.
2021-11-04 17:09:20 +09:00
Dean Herbert
8f459e6ce8
Fix APIBeatmapSet.Beatmaps
being IEnumerable
, causing stupid issues
2021-11-04 16:44:17 +09:00
Dean Herbert
baabe99f78
Clean up DirectDownloadButton
test scene
2021-11-04 16:28:29 +09:00
Dean Herbert
66f4516eee
Allow creating sample API models without specifying a ruleset
2021-11-04 15:23:04 +09:00
Dean Herbert
caa9d8997b
Merge branch 'master' into score-refactor/less-create-score-info
2021-11-01 22:59:11 +09:00
Dean Herbert
90a0a5e0b7
Fix attempting to set properties of null BeatmapSet
s in tests
2021-11-01 17:12:15 +09:00
Dean Herbert
a16c8f1ebc
Update all beatmap overlay views to use APIBeatmap
/APIBeatmapSet
2021-10-29 18:50:55 +09:00
Dean Herbert
31403daa20
Change DrawableProfileScore
to use APIScoreInfo
2021-10-29 15:14:52 +09:00
Dean Herbert
817369903a
Rename API score classes
2021-10-29 13:40:56 +09:00
Dean Herbert
d19580cf60
Fix incorrectly changed difficulty count in recently updated test
2021-10-27 16:44:11 +09:00
Dean Herbert
6944151486
Apply batch fixing of built-in types using var
2021-10-27 13:04:41 +09:00
Dan Balasescu
f687ed8599
Merge pull request #15283 from peppy/test-api-beatmap-set
...
Add ability to make test `APIBeatmapSet`s from test scenes
2021-10-26 15:34:19 +09:00
Dean Herbert
2c308f3008
Rename BeatmapMetrics
to APIFailTimes
2021-10-25 15:34:41 +09:00
Dean Herbert
20baae9094
Move online metrics out of BeatmapInfo
model
2021-10-25 15:32:18 +09:00
Dean Herbert
045dd94a6e
Move online metrics out of BeatmapSetInfo
model
2021-10-25 15:12:39 +09:00
Dean Herbert
19312435d0
Add ability to make test APIBeatmaps
from test scenes
...
Allow tests to create a sample `APIBeatmapSet`
One step towards removing calls to `ToBeatmap` / `ToBeatmapSet`.
2021-10-25 14:18:13 +09:00
Bartłomiej Dach
00732822c3
Replace insufficiently specific exception type
...
Resolves compilation failures for the newly-added Android build-only CI
job caused by inspection CA2201 ("Exception type System.Exception is not
sufficiently specific").
2021-10-24 17:45:39 +02:00
Dean Herbert
0706ad70fb
Move BeatmapSetOnlineInfo
to an interface type
2021-10-21 16:58:42 +09:00
Andrei Zavatski
0f8d270442
Remove online part since it doesn't really check anything
2021-10-20 11:27:24 +03:00
Andrei Zavatski
faabc75a3e
Fix failing test
2021-10-20 10:54:08 +03:00
Andrei Zavatski
6f38e6166d
Fix and improve TestSceneUserProfilePreviousUsernames
2021-10-20 10:32:00 +03:00
Bartłomiej Dach
12da27cde7
Add test coverage for loading process on channel join
2021-10-05 20:52:40 +02:00
Dean Herbert
853cf6feaa
Rename last remaining BeatmapInfo Beatmap
usage
2021-10-04 17:35:53 +09:00
Dean Herbert
ec61c3c5ee
Rename all remaining cases
2021-10-03 00:55:29 +09:00
Dan Balasescu
d9b4fae4e5
Merge branch 'master' into chat-command
2021-09-13 13:32:44 +09:00
Bartłomiej Dach
3467b1f60c
Retouch chat command test slightly
2021-09-12 13:00:52 +02:00
Davran Dilshat
eeaa8a8380
code quality
2021-09-11 16:47:20 +01:00
Davran Dilshat
605933c467
typo
2021-09-11 16:23:17 +01:00
Davran Dilshat
7924a990a3
add tests for /chat command
2021-09-11 16:22:35 +01:00
Dean Herbert
309460e505
Merge pull request #14675 from ekrctb/featured-artist-markers
...
Add featured artist markers to beatmap listing and overlay
2021-09-10 14:30:33 +09:00
Bartłomiej Dach
32de13cb96
Use consistent assertions for checking placeholder presence
2021-09-09 21:33:02 +02:00
Dean Herbert
2e00c71842
Add failing test coverage
2021-09-10 01:57:33 +09:00
ekrctb
a2c2646230
Use a counter instead of RNG
2021-09-09 19:36:47 +09:00
ekrctb
210640af09
Fix overlay not refreshed in TestSceneBeatmapSetOverlay
2021-09-09 12:39:40 +09:00
ekrctb
8745d299dc
Add visual tests for featured artist markers
2021-09-08 13:27:57 +09:00
Davran Dilshat
7f9b80e3e5
add tests for ShowUser() username overload
2021-09-05 15:11:41 +01:00
Bartłomiej Dach
e503182a8d
Merge branch 'master' into activity-on-multiplayer-screens
2021-08-24 18:50:55 +02:00
Dean Herbert
4bbc98737f
Fix english in test steps
2021-08-24 14:39:03 +09:00
Dean Herbert
8cd972a9fe
Merge branch 'master' into pinned-comment
2021-08-24 14:37:31 +09:00
smoogipoo
956c1cc216
Merge branch 'master' into activity-on-multiplayer-screens
2021-08-24 12:33:34 +09:00
Salman Ahmed
9d807656f2
Add more complete test coverage of decoupling
2021-08-23 21:08:59 +03:00
Salman Ahmed
e33c3fcdbf
Add test coverage for new changes
2021-08-23 13:53:03 +03:00
Salman Ahmed
6931721864
Revert test coverage
2021-08-23 12:39:27 +03:00
Salman Ahmed
391c4e529c
Add test coverage for all added features
2021-08-23 11:12:48 +03:00
Nathan Alo
cc3468b4ab
apply suggestions
...
- make `UserActivity.InGame` and derive that to `InSoloGame` and `InMultiplayerGame`
- rename `SoloGame` to `InSoloGame`
- rename `MultiplayerGame` to `InMultiplayerGame`
2021-08-16 06:32:33 +08:00
Gagah Pangeran Rosfatiputra
4494ff55e3
fix pinned drawable comment test
2021-08-14 00:17:45 +07:00
Gagah Pangeran Rosfatiputra
48b84db7b9
add no comment and single comment test
2021-08-13 23:59:36 +07:00
Gagah Pangeran Rosfatiputra
1c32993fe5
initialize pinned comments in test offline comment
2021-08-13 23:03:42 +07:00
Gagah Pangeran Rosfatiputra
e3f91413cf
add pinned comment test case for comment container
2021-08-13 18:53:31 +07:00
Gagah Pangeran Rosfatiputra
ff860b90a9
add pinned test case for drawable comment
2021-08-13 12:57:30 +07:00
smoogipoo
2850f6ce95
Privatise counter again
2021-08-13 13:24:05 +09:00
smoogipoo
ee034874bb
Merge branch 'master' into remove-comments-page
2021-08-13 13:17:13 +09:00
Gagah Pangeran Rosfatiputra
f2f84a2e23
wait for content to load in test
2021-08-11 12:11:39 +07:00
Gagah Pangeran Rosfatiputra
595763ae34
add test case for supporter and non supporter
2021-08-10 14:58:11 +07:00
Gagah Pangeran Rosfatiputra
bdf6c2a5ed
add changelog supporter promo test scene
2021-08-10 12:00:26 +07:00
Dean Herbert
9b9dacf3fe
Update usages of Drawable.Click()
2021-08-04 17:30:33 +09:00
Dean Herbert
118e13227a
Update existing test to make use of ManualInputManager.Keys
2021-08-03 19:08:59 +09:00
smoogipoo
062207fcd9
Fix TestSceneCurrentlyPlayingDisplay reusing cached spectator client
2021-08-03 18:16:58 +09:00
Salman Ahmed
db760b0dbf
Merge branch 'master' into localisation-header
2021-08-03 05:16:02 +03:00
Gagah Pangeran Rosfatiputra
dc864abbd8
add link test
2021-07-26 21:08:57 +07:00
Gagah Pangeran Rosfatiputra
f80c46e2a0
add heading test
2021-07-26 21:04:08 +07:00
Gagah Pangeran Rosfatiputra
55e8a44db6
add test for DrawableComment
...
Can reproduce the issue at https://github.com/ppy/osu/issues/13993
2021-07-26 18:15:59 +07:00
ekrctb
1bac471b49
Adapt to PlatformAction
type change
2021-07-21 16:12:53 +09:00
Salman Ahmed
6a8c16d3ef
Fix news/wiki tests checking against incorrect constant string
2021-07-20 03:29:32 +03:00
kj415j45
5b4a1ef70a
Update test to match Breadcrumb change
2021-07-17 20:40:59 +08:00
Dean Herbert
4e52aee5a0
Merge branch 'master' into wiki-image-block
2021-07-02 18:19:46 +09:00
smoogipoo
1b2d00f796
Trigger successes
2021-06-29 20:13:39 +09:00
Gagah Pangeran Rosfatiputra
a1fe9df378
add test to check sprite image width
2021-06-29 10:14:51 +07:00
Gagah Pangeran Rosfatiputra
0e29ae037b
add wide image test
2021-06-28 20:50:29 +07:00
Gagah Pangeran Rosfatiputra
ab977d91f0
fix image test not load
...
looks like forgot to change this after `CurrentPath` shenanigan
2021-06-28 20:40:22 +07:00
Bartłomiej Dach
709e555566
Rename test steps for legibility
2021-06-26 20:27:15 +02:00
Bartłomiej Dach
b7c4fe2052
Rewrite test helpers to also handle clearing filters
2021-06-26 20:25:43 +02:00
Bartłomiej Dach
51888d0d5a
Rename test methods
2021-06-26 20:24:42 +02:00