75266 Commits

This Branch

This Branch

All Branches

• Merge pull request #31390 from peppy/slider-end-suppress-fix

  Fix slider end circles not remaining for long enough when hit animations disabled

  Bartłomiej Dach · 2025-01-07 14:49:25 +01:00
  d2918894a0
• Merge pull request #31388 from peppy/fix-reverse-arrow-animation

  Remove use of `Loop` (and transforms) for slider repeat arrow animations

  Bartłomiej Dach · 2025-01-07 14:43:09 +01:00
  bda1c3f6e8
• Force new combo on objects succeeding a break

  No issue thread for this again. Reported internally on discord:
  https://discord.com/channels/90072389919997952/1259818301517725707/1320420768814727229
  
  Placing this logic in the beatmap processor, as a post-processing step,
  means that the new combo force won't be visible until a placement has
  been committed. That can be seen as subpar, but I tried putting this
  logic in the placement and it sucked anyway:
  
  - While the combo number was correct, the colour looked off, because it
    would use the same combo colour as the already-placed objects after
    said break, which would only cycle to the next, correct one on
    placement
  
  - Not all scenarios can be handled in the placement. Refer to one of the
    test cases added in the preceding commit, wherein two objects are
    placed far apart from each other, and an automated break is inserted
    between them - the placement has no practical way of knowing whether
    it's going to have a break inserted automatically before it or not.

  Bartłomiej Dach · 2025-01-07 14:06:23 +01:00
  c93b87583a
• Add test coverage for expected behaviour
  Bartłomiej Dach · 2025-01-07 13:59:26 +01:00
  973f606a9e
• Clamp OD in performance calculation to fix negative OD gaining pp (#31447)

  Co-authored-by: James Wilson <tsunyoku@gmail.com>

  StanR · 2025-01-07 12:49:55 +00:00
  3b58d5e435
• Add consistentRatioPenalty to the Colour skill. (#31285)

  * fix colour
  
  * review fix
  
  Co-authored-by: StanR <castl@inbox.ru>
  
  * remove cancelled out operand
  
  * increase nerf, adjust tests
  
  * fix automated spacing issues
  
  * up penalty
  
  * adjust tests
  
  * apply review changes
  
  * fix nullable hell
  
  ---------
  
  Co-authored-by: StanR <castl@inbox.ru>

  Jay Lawton · 2025-01-07 11:36:56 +00:00
  4095b2662b
• Fix combo properties multiple reassignments
  Andrei Zavatski · 2025-01-07 14:00:31 +03:00
  8f4eafea4e
• Do not expose track directly in EditorClock

  Intends to stop people from mutating it directly, and going through
  `EditorClock` members like `AudioAdjustments` instead.

  Bartłomiej Dach · 2025-01-07 11:40:18 +01:00
  98bb723438
• Add config option
  Dan Balasescu · 2025-01-07 19:32:30 +09:00
  45e0adcd25
• Remove unused protected field
  Bartłomiej Dach · 2025-01-07 11:26:08 +01:00
  275e8ce7b7
• Re-route editor tempo adjustment via EditorClock and remove it on gameplay test
  Bartłomiej Dach · 2025-01-07 11:25:00 +01:00
  a5036cd092
• Add failing test
  Bartłomiej Dach · 2025-01-07 11:23:47 +01:00
  3c03406b45
• Display notification on friend presence changes
  Dan Balasescu · 2025-01-07 19:12:33 +09:00
  51b62a6d8e
• Mark recommendation test as flaky

  Will revisit during song select refactoring no doubt.

  Dean Herbert · 2025-01-07 17:58:12 +09:00
  b8a10d9b0e
• Fix multiple animation inconsistencies pointed out in review
  Dean Herbert · 2025-01-07 16:54:11 +09:00
  8d913e8971
• Fix star range display looking a bit bad when changing opacity
  Dean Herbert · 2025-01-07 16:42:06 +09:00
  383fda7431
• Refactor StarRatingRangeDisplay test to be more usable
  Dean Herbert · 2025-01-07 16:42:06 +09:00
  a0496c60a4
• Ensure slider is not selectable when body is not visible
  Dean Herbert · 2025-01-07 16:38:22 +09:00
  1648f2efa3
• Merge pull request #31418 from peppy/intro-file-integrity

  Ensure intro files exist in storage during startup

  Bartłomiej Dach · 2025-01-07 08:14:40 +01:00
  01e9c0f15e
• Merge pull request #31306 from bdach/aspire-slider-breakage

  Fix slider event generator incorrectly not generating repeats when tick distance is zero

  Dan Balasescu · 2025-01-07 11:50:18 +09:00
  77d9c955ea
• Merge pull request #31436 from EVAST9919/editor-alloc

  Reduce allocations in the editor caused by `TimelineBlueprintContainer`

  Dan Balasescu · 2025-01-07 11:31:39 +09:00
  638128ba88
• Clear out old protocol data when installing

  If we're the only capable app, windows will open us by default.

  Susko3 · 2025-01-07 00:07:04 +00:00
  2381975359
• Register URI handler as ProgID and add that to Capabilities
  Susko3 · 2025-01-07 00:00:14 +00:00
  31bf162db6
• Clear out old way of specifying default association

  If we're the only app for a filetype, windows will automatically associate us.
  And if a new app is installed, it'll prompt the user to choose a default.

  Susko3 · 2025-01-06 23:55:35 +00:00
  64843a5e83
• Register application capability with file extensions

  https://learn.microsoft.com/en-us/windows/win32/shell/default-programs#registering-an-application-for-use-with-default-programs

  Susko3 · 2025-01-06 23:41:44 +00:00
  56eec929ca
• Make ProgramId public
  Susko3 · 2025-01-06 23:35:05 +00:00
  804fe0013d
• Use cleaner array creation expression
  Andrei Zavatski · 2025-01-07 01:23:19 +03:00
  d35b308745
• Fix allocations in updateSamplePointContractedState
  Andrei Zavatski · 2025-01-07 00:48:58 +03:00
  791ca915e4
• Reduce HitSampleInfo constants allocations
  Andrei Zavatski · 2025-01-07 00:36:58 +03:00
  e8dc09f5bc
• Merge pull request #31433 from bdach/romanised-metadata-ascii-only

  Constrain range of usable characters in romanised metadata to ASCII only

  Dean Herbert · 2025-01-07 03:29:44 +09:00
  1ca28d74a3
• Fix angle bonuses calculating repetition incorrectly, apply distance scaling to wide bonus (#31320)

  * Fix angle bonuses calculating repetition incorrectly, apply distance scaling to wide bonus
  
  * Buff speed to compensate for streams losing pp
  
  * Adjust speed multiplier
  
  * Adjust wide scaling
  
  * Fix tests

  StanR · 2025-01-06 15:08:14 +00:00
  76ac11ff59
• Constrain range of usable characters in romanised metadata to ASCII only

  Closes https://github.com/ppy/osu/issues/31398.
  
  Rationale given in issue.
  
  Compare stable logic:
  
  - https://github.com/peppy/osu-stable-reference/blob/2280c4c436f80d04f9c79d3c905db00ac2902273/osu!/GameModes/Edit/Forms/SongSetup.cs#L118-L122
  - https://github.com/peppy/osu-stable-reference/blob/2280c4c436f80d04f9c79d3c905db00ac2902273/osu!common/Helpers/GeneralHelper.cs#L410-L423
  
  The control character check is a bit gratuitous (text boxes will already
  not allow insertion of those, see
  https://github.com/ppy/osu-framework/blob/e05cb86ff64abd343de49a143ada9734fd160a0a/osu.Framework/Graphics/UserInterface/TextBox.cs#L92),
  but as it's a general helper I figured might as well.

  Bartłomiej Dach · 2025-01-06 14:04:47 +01:00
  3a4497af32
• Don't require track to be playing to fix test failures on some platforms
  Dean Herbert · 2025-01-06 18:27:00 +09:00
  ca9e16387a
• Always show dialog when clicking supporter icon before opening browser

  I managed to do this by accident three times today while testing using
  the dashboard display, so it's time to action on it.
  
  Touched on in
  https://github.com/ppy/osu/discussions/30740#discussioncomment-11345996.
  Was also mentioned recently in discord or another discussion explicitly
  but I can't find that.

  Dean Herbert · 2025-01-06 17:51:04 +09:00
  4f1a6b4688
• Merge pull request #31386 from peppy/fix-applying-offset

  Fix not being able to apply last play offset after returning to song select

  Dan Balasescu · 2025-01-06 11:40:12 +09:00
  448790a76f
• Merge pull request #31414 from frenzibyte/fix-display

  Fix mobile release dialog obstructed by the software keyboard

  Dean Herbert · 2025-01-05 00:37:29 +09:00
  d6e73d75d2
• Reduce nesting slightly
  Dean Herbert · 2025-01-05 00:32:06 +09:00
  37da72d764
• Fix DrawableManiaRuleset not cached as itself in subtypes

  i.e. editor mania ruleset

  Salman Alshamrani · 2025-01-04 02:36:06 -05:00
  a241d1f503
• Fix player no longer handling non-loaded beatmaps
  Salman Alshamrani · 2025-01-04 02:35:48 -05:00
  21389820c5
• Ensure intro files exist in storage

  Guards against user interdiction.
  
  See
  [https://discord.com/channels/188630481301012481/1097318920991559880/1324765503012601927](recent)
  but not only case of this occurring.

  Dean Herbert · 2025-01-04 15:27:49 +09:00
  72dfdac2e2
• Add test coverage of user deleting intro files
  Dean Herbert · 2025-01-04 15:26:42 +09:00
  e15978cc65
• Fix mobile release dialog obstructed by the software keyboard
  Salman Alshamrani · 2025-01-03 22:01:06 -05:00
  3fc86f60ee
• Merge pull request #31403 from frenzibyte/mobile-disclaimer
  Dean Herbert · 2025-01-04 02:35:36 +09:00
  b4698851a3
• Localise text
  Dean Herbert · 2025-01-04 01:28:33 +09:00
  2cd86cbf91
• Adjust popup icon animation slightly
  Dean Herbert · 2025-01-04 01:28:09 +09:00
  da85517036
• Make popup body text left aligned when multiple lines of text are provided
  Dean Herbert · 2025-01-04 01:19:56 +09:00
  60fd0be481
• Update copy and require actually clicking button to confirm
  Dean Herbert · 2025-01-04 01:13:03 +09:00
  1d81dade25
• Only flip value if popup was definitely shown
  Dean Herbert · 2025-01-04 00:58:19 +09:00
  97d065d887
• Flip navigation test expectations in line with new behaviour
  Dean Herbert · 2025-01-04 00:55:12 +09:00
  1161b7b3c0
• Move dialog class location
  Salman Alshamrani · 2025-01-03 00:27:26 -05:00
  c40371c052