75266 Commits

This Branch

This Branch

All Branches

• Speed up metronome when holding control
  Marvin Schürz · 2024-12-30 03:13:22 +01:00
  8be500535d
• Add basic difficulty & performance calculation for Autopilot mod on osu! ruleset (#21211)

  * Set speed distance to 0
  
  * Reduce speed & flashlight, remove aim
  
  * Remove speed AR bonus
  
  * cleanup autopilot mod check in `SpeedEvaluator`
  
  * further decrease speed rating for extra hand availability
  
  * Pass all mods to the speed evaluator, zero out distance bonus instead of distance
  
  ---------
  
  Co-authored-by: tsunyoku <mbruhyo@gmail.com>
  Co-authored-by: StanR <hi@stanr.info>

  James Wilson · 2024-12-29 19:29:57 +00:00
  988ed374ae
• Merge pull request #31303 from bdach/pause-on-gameplay-test

  Pause playback when entering gameplay test from editor

  Dean Herbert · 2024-12-28 04:41:28 +09:00
  10ee2e28c2
• Merge pull request #31307 from bdach/id3-tags

  Populate metadata from ID3 tags when changing beatmap audio track in editor

  Dean Herbert · 2024-12-28 02:41:49 +09:00
  ac348b8780
• Fix failing test scene due to new dependency
  Dean Herbert · 2024-12-28 01:02:15 +09:00
  1b2a223a5f
• Populate metadata from ID3 tags when changing beatmap audio track in editor

  - Closes https://github.com/ppy/osu/issues/21189
  - Supersedes / closes https://github.com/ppy/osu-framework/pull/5627
  - Supersedes / closes https://github.com/ppy/osu/pull/22235
  
  The reason why I opted for a complete rewrite rather than a revival of
  that aforementioned pull series is that it always felt quite gross to me
  to be pulling framework's audio subsystem into the task of reading ID3
  tags, and I also partially don't believe that BASS is *good* at reading
  ID3 tags. Meanwhile, we already have another library pulled in that is
  *explicitly* intended for reading multimedia metadata, and using it
  does not require framework changes. (And it was pulled in explicitly for
  use in the editor verify tab as well.)
  
  The hard and dumb part of this diff is hacking the gibson such that
  the metadata section on setup screen actually *updates itself*
  after the resources section is done doing its thing. After significant
  gnashing of teeth I just did the bare minimum to make work by caching
  a common parent and exposing an `Action?` on it. If anyone has better
  ideas, I'm all ears.

  Bartłomiej Dach · 2024-12-27 15:16:03 +01:00
  6a6db5a22b
• Rewrite of the Rhythm Skill within osu!taiko (#31284)

  * implement bell curve into diffcalcutils
  
  * remove unneeded attributes
  
  * implement new rhythm skill
  
  * change dho variables
  
  * update dho rhythm
  
  * interval interface
  
  * implement rhythmevaluator
  
  * evenhitobjects
  
  * evenpatterns
  
  * evenrhythm
  
  * change attribute ordering
  
  * initial balancing
  
  * change naming to Same instead of Even
  
  * remove attribute bump for display
  
  * Fix diffcalc tests
  
  ---------
  
  Co-authored-by: StanR <hi@stanr.info>

  Jay Lawton · 2024-12-27 16:30:30 +03:00
  824497d82c
• Remove duplicated block
  Dean Herbert · 2024-12-27 21:36:07 +09:00
  a9a5bb2c6a
• Fix slider event generator incorrectly not generating repeats when tick distance is zero

  RFC. This closes https://github.com/ppy/osu/issues/31186.
  
  To explain why: The issue occurs on
  https://osu.ppy.sh/beatmapsets/594828#osu/1258033, specifically on the
  slider at time 128604. The failure site is
  
  	https://github.com/ppy/osu/blob/fa0d2f4af22fb9319e2a8773bf635368d86360be/osu.Game.Rulesets.Osu/Edit/Blueprints/Sliders/SliderCircleOverlay.cs#L65-L66
  
  wherein `LastRepeat` is `null`, even though the slider's `RepeatCount`
  is 1 and thus `SpanCount` is 2.
  
  In this case, `SliderEventGenerator` is given a non-zero `tickDistance`
  but a zero `length`. The former is clamped to the latter:
  
  	https://github.com/ppy/osu/blob/fa0d2f4af22fb9319e2a8773bf635368d86360be/osu.Game/Rulesets/Objects/SliderEventGenerator.cs#L34
  
  Because of this, a whole block of code pertaining to tick generation
  gets turned off, because of zero tick spacing - however, that block also
  includes within it *repeat* generation, for seemingly very little reason
  whatsoever:
  
  	https://github.com/ppy/osu/blob/fa0d2f4af22fb9319e2a8773bf635368d86360be/osu.Game/Rulesets/Objects/SliderEventGenerator.cs#L47-L77
  
  While a zero tick distance would indeed cause `generateTicks()` to loop
  forever, it should have absolutely no effect on repeats.
  
  While this *is* ultimately an aspire-tier bug caused by people pushing
  things to limits, I do believe that in this case a fix is warranted
  because of how hard the current behaviour violates invariants. I do not
  like the possibility of having a slider with multiple spans and no
  repeats.

  Bartłomiej Dach · 2024-12-27 12:38:31 +01:00
  e7225399a2
• Add failing test case
  Bartłomiej Dach · 2024-12-27 12:38:31 +01:00
  ecf64dfc57
• Round object coordinates to nearest integers rather than truncating

  Addresses https://github.com/ppy/osu/issues/31256.

  Bartłomiej Dach · 2024-12-27 11:10:29 +01:00
  e9762422b3
• Add setters to hitobject coordinate interfaces
  Bartłomiej Dach · 2024-12-27 11:01:47 +01:00
  0d16ed028b
• Add failing test case
  Bartłomiej Dach · 2024-12-27 11:01:47 +01:00
  0c02369bdc
• Pause playback when entering gameplay test from editor

  Closes https://github.com/ppy/osu/issues/31290.
  
  Tend to agree that this is a good idea for gameplay test at least. Not
  sure about other similar interactions like exiting - I don't think it
  matters what's done in those cases, because for exiting timing is in no
  way key, so I just applied this locally to gameplay test.

  Bartłomiej Dach · 2024-12-27 09:08:16 +01:00
  5abad07412
• Add failing assertions
  Bartłomiej Dach · 2024-12-27 09:04:41 +01:00
  ed397c8fee
• Change OsuModRelax hit leniency to be the same as in stable
  StanR · 2024-12-26 18:13:09 +05:00
  94d56d3584
• Merge pull request #31277 from kongehund/switch-scroll-direction-beat-snap

  Switch scroll direction for beat snap

  Bartłomiej Dach · 2024-12-26 09:25:32 +01:00
  fa0d2f4af2
• Add migration
  Dean Herbert · 2024-12-26 15:46:12 +09:00
  2a374c0695
• Fix volume adjust key repeat not working as expected

  Regressed in https://github.com/ppy/osu/pull/31146.
  
  Closes part of https://github.com/ppy/osu/issues/31267.

  Dean Herbert · 2024-12-26 15:05:59 +09:00
  e752531aec
• Switch scroll direction for beat snap

  Matches stable better

  kongehund · 2024-12-26 00:35:21 +01:00
  1f60adbaf1
• Remove unused usings
  Dan Balasescu · 2024-12-25 23:45:36 +09:00
  6579b05561
• Don't display on matching beatmap/ruleset
  Dan Balasescu · 2024-12-25 23:39:01 +09:00
  e7c272b8b9
• Display user style in participant panel
  Dan Balasescu · 2024-12-25 23:30:24 +09:00
  c3aa9d6f8a
• Rewrite everything to better support spectator server messaging
  Dan Balasescu · 2024-12-25 22:24:21 +09:00
  0093af8f55
• Fix test
  Dan Balasescu · 2024-12-25 16:51:50 +09:00
  95fe8d67e4
• Fix co-variant array conversion
  Dan Balasescu · 2024-12-25 16:46:02 +09:00
  a407e3f3e0
• Merge pull request #31138 from bdach/mark-as-played

  Implement ability to mark beatmap as played

  Dean Herbert · 2024-12-24 21:43:15 +09:00
  2024.1224.0 62e536baf6
• Merge pull request #31226 from frenzibyte/fix-raw-input-mobile

  Add `Hidden` cursor state flag on non-desktop platforms as well

  Dean Herbert · 2024-12-24 21:35:50 +09:00
  df3b300fff
• Fix inspection
  Dan Balasescu · 2024-12-24 20:22:16 +09:00
  a2dc16f8df
• Use online ruleset_id to build local score models
  Dan Balasescu · 2024-12-24 20:13:42 +09:00
  b4f35f330c
• Add some comments
  Dan Balasescu · 2024-12-24 19:40:06 +09:00
  c88e906cb6
• Fix freemods button opening overlay unexpectedly
  Dan Balasescu · 2024-12-24 19:39:56 +09:00
  d8ff5bcacb
• Add style selection to playlists screen
  Dan Balasescu · 2024-12-24 19:28:09 +09:00
  ac738f109a
• Adjust namings
  Dan Balasescu · 2024-12-24 19:05:50 +09:00
  971ccb6a4e
• Use lastAngle when nerfing repeated angles on acute bonus (#31245)

  * Use `lastAngle` when nerfing repeated angles on acute bonus
  
  * Bump acute multiplier
  
  * Correct outdated wiggle bonus comment
  
  * Update test
  
  ---------
  
  Co-authored-by: StanR <hi@stanr.info>

  James Wilson · 2024-12-24 12:43:44 +03:00
  3ddeaf8460
• Merge pull request #31259 from peppy/intro-volume-adjust

  Fix adjusting volume using scroll wheel not working during intro

  Bartłomiej Dach · 2024-12-24 10:18:10 +01:00
  287b880ec7
• Merge pull request #31258 from peppy/reduce-dim-seasonal

  Slightly reduce background brightness at main menu when seasonal lighting is active

  Bartłomiej Dach · 2024-12-24 10:18:01 +01:00
  a169bf557d
• Block beatmap presents in style select screen
  Dan Balasescu · 2024-12-24 18:04:36 +09:00
  40486c4f38
• Only allow selecting beatmaps within 30s length
  Dan Balasescu · 2024-12-24 17:57:59 +09:00
  7777c44775
• Fix adjusting volume using scroll wheel not working during intro
  Dean Herbert · 2024-12-24 17:11:21 +09:00
  ce1eda7e54
• Slightly reduce background brightness at main menu when seasonal lighting is active
  Dean Herbert · 2024-12-24 17:10:48 +09:00
  d8686f55f7
• Merge pull request #31254 from peppy/fix-invisible-circle-sprites

  Fix some hitcircle sprites missing in certain skins since last release

  Bartłomiej Dach · 2024-12-24 09:05:16 +01:00
  6b56c658b3
• Merge pull request #31147 from peppy/editor-beat-snap-adjust-scroll

  Change beat snap divisor adjust defaults to be Ctrl+Scroll instead of Ctrl+Shift+Scroll

  Bartłomiej Dach · 2024-12-24 09:03:42 +01:00
  2211a4d505
• Merge branch 'master' into editor-beat-snap-adjust-scroll
  Bartłomiej Dach · 2024-12-24 08:21:34 +01:00
  1f90be3fea
• Add explanatory comment for schema version bump
  Bartłomiej Dach · 2024-12-24 08:21:27 +01:00
  d9be172647
• Fix legacy hitcircle fallback logic being broken with recent fix

  I was a bit too eager to replace all calls with the new `provider`
  in
  https://github.com/ppy/osu/commit/dae380b7fa927c351e2e413c5b23834f717908d9,
  while it doesn't actually make sense.
  
  To handle the case that was trying to be fixed, using the `provider` to
  check whether the *prefix* version of the circle sprite is available is
  enough alone.
  
  Closes https://github.com/ppy/osu/issues/31200

  Dean Herbert · 2024-12-24 16:05:44 +09:00
  b8d6bba039
• Update framework
  Dean Herbert · 2024-12-24 15:17:10 +09:00
  a5d354d753
• Merge pull request #31220 from normalid-awa/feature/skin/rename-skin

  Add ability to rename the skin

  Dean Herbert · 2024-12-24 14:24:48 +09:00
  362311d040
• Merge pull request #31238 from frenzibyte/make-featured-artist-setting

  Save "featured artists" filter to user settings and disable toggling on iOS

  Dean Herbert · 2024-12-24 14:07:20 +09:00
  85f5234880
• Change order of skin layout editor button for better visual balance
  Dean Herbert · 2024-12-24 13:42:18 +09:00
  378bef34ef