75266 Commits

This Branch

This Branch

All Branches

• Fix statistics update not being shown on results screen if it arrives too fast

  As reported in
  https://discord.com/channels/188630481301012481/1097318920991559880/1288160137286258799.

  Bartłomiej Dach · 2024-09-24 17:52:19 +02:00
  20e7ade3b0
• Add failing test case
  Bartłomiej Dach · 2024-09-24 17:51:54 +02:00
  555d4ffe89
• Animate SelectionBox buttons on unfreeze
  Marvin Schürz · 2024-09-24 16:42:37 +02:00
  99a80b399c
• Some extra tweaking
  StanR · 2024-09-24 18:24:00 +05:00
  872628b8b8
• Actually use bindables rather than stick things in Update()
  Bartłomiej Dach · 2024-09-24 15:15:28 +02:00
  9f4e48dde7
• Adjust some multipliers
  StanR · 2024-09-24 17:57:31 +05:00
  75dc822540
• Apply NRT to directory & file selectors
  Bartłomiej Dach · 2024-09-24 14:55:05 +02:00
  16fc413a4a
• Redesign directory & file selector (and update usages accordingly)
  Bartłomiej Dach · 2024-09-24 14:54:48 +02:00
  7f8b64bb6d
• Merge pull request #29968 from bdach/cache-for-spectate-screen

  Use cache for beatmap lookups on spectate screen

  Dean Herbert · 2024-09-24 20:59:33 +09:00
  b7d8cb2371
• Move mouse horizontally in test to make sure it doesn't accidentally maintain aspect ratio
  Marvin Schürz · 2024-09-24 13:45:03 +02:00
  15c4b1dc8f
• Add tests for shift and alt modifiers in select box
  Marvin Schürz · 2024-09-24 13:35:56 +02:00
  3ad7342964
• balancing attempts
  tsunyoku · 2024-09-24 12:24:54 +01:00
  5eb23d3a71
• Merge branch 'master' into skinning-colour-customisation
  Bartłomiej Dach · 2024-09-24 13:02:22 +02:00
  4f57a67ea4
• Merge pull request #29942 from minetoblend/fix/slider-scale-origin

  Fix scaling sliders ignoring the scale origin

  Bartłomiej Dach · 2024-09-24 13:02:04 +02:00
  145f2b6de7
• Simplify accent colour assignment in argon wedge piece
  Bartłomiej Dach · 2024-09-24 12:53:54 +02:00
  4c2ebdb2db
• Rename parameter
  Marvin Schürz · 2024-09-24 12:40:28 +02:00
  b54b4063be
• bump global multiplier
  tsunyoku · 2024-09-24 11:28:15 +01:00
  ce5c666c34
• correct distanceBonus code comment
  tsunyoku · 2024-09-24 11:23:34 +01:00
  98d9b5eec8
• update incorrect code comment

  Co-authored-by: StanR <castl@inbox.ru>

  James Wilson · 2024-09-24 11:22:46 +01:00
  ac9c1508b1
• add TestMinimumEnclosingCircle
  OliBomby · 2024-09-24 11:56:04 +02:00
  3031b68552
• Remove usage of switch expression syntax

  It's not universally accepted here and a `when` crept in that can be
  bypassed entirely using rather clean baseline language constructs, so
  why bother at this point.

  Bartłomiej Dach · 2024-09-24 11:53:02 +02:00
  86432078dd
• Revert "add a max depth to prevent stack overflow"

  This reverts commit bf245aa9d6.

  OliBomby · 2024-09-24 11:44:02 +02:00
  c857de3a9a
• make speed bonuses additive, scale distanceBonus
  tsunyoku · 2024-09-24 10:06:07 +01:00
  4da78a8c00
• fix warnings
  OliBomby · 2024-09-23 17:34:45 +02:00
  b274ed9427
• Don't snap to global grid while placing grid
  OliBomby · 2024-09-23 17:24:09 +02:00
  0f0f490598
• Clarify criteria of grid spacing subdivision
  OliBomby · 2024-09-23 16:39:09 +02:00
  fe10621771
• Merge pull request #29966 from bdach/unsafe-deep-clone

  Fix score being cloned in async method causing random errors (again)

  Dean Herbert · 2024-09-23 23:37:46 +09:00
  f08134f443
• Convert 'grid from points' button to placement tool
  OliBomby · 2024-09-23 16:36:45 +02:00
  0a5a463380
• Refactor PlacementBlueprint to not be hitobject specific
  OliBomby · 2024-09-23 16:33:36 +02:00
  1a81e12192
• Merge pull request #29972 from bdach/editor/setup-screen-dropdown

  Implement "form" dropdown control

  Dean Herbert · 2024-09-23 23:30:25 +09:00
  31e423058d
• Implement "form" dropdown control
  Bartłomiej Dach · 2024-09-23 14:41:39 +02:00
  d6c17f6ac0
• Fix argon volume-aware hitsounds not correctly playing immediately after object placement

  Closes https://github.com/ppy/osu/issues/29832.
  
  The underlying reason for the incorrect sample playback was an equality
  comparer failure.
  
  Samples are contained in several pools which are managed by the
  playfield. In particular, the pools are keyed by `ISampleInfo`
  instances. This means that for correct operation, `ISampleInfo` has to
  implement `IEquatable<ISampleInfo>` and also provide an appropriately
  correct `GetHashCode()` implementation. Different audible samples must
  not compare equal to each other when represented by `ISampleInfo`.
  
  As it turns out, `VolumeAwareHitSampleInfo` failed on this, due to not
  overriding equality members. Therefore, a `new
  HitSampleInfo(HitSampleInfo.HIT_NORMAL, HitSampleInfo.BANK_NORMAL,
  volume: 70)` was allowed to compare equal to a
  `VolumeAwareHitSampleInfo` wrapping it, *even though they correspond to
  completely different sounds and go through entirely different lookup
  path sequences*.
  
  Therefore, to fix, provide more proper equality implementations for
  `VolumeAwareHitSampleInfo`.
  
  When testing note that this issue *only occurs immediately after
  placing an object*. Saving and re-entering editor makes this issue go
  away. I haven't looked too long into why, but the general gist of it is
  ordering; it appears that a `normal-hitnormal` pool exists at point
  of query of a new object placement, but does not seem to exist when
  entering editor afresh. That said I'm not sure that ordering aspect of
  this bug matters much if at all, since the two `IHitSampleInfo`s should
  never be allowed to alias with each other at all wrt equality.

  Bartłomiej Dach · 2024-09-23 13:38:26 +02:00
  e8a394f894
• Remove GetHashCode
  StanR · 2024-09-23 16:30:02 +05:00
  08bded82fd
• Add failing test case to demonstrate failure
  Bartłomiej Dach · 2024-09-23 13:17:46 +02:00
  41826d0606
• add a max depth to prevent stack overflow
  OliBomby · 2024-09-23 13:16:45 +02:00
  bf245aa9d6
• return to stackalloc because its faster
  OliBomby · 2024-09-23 13:13:33 +02:00
  eead6b9eae
• use collection expression instead of stackalloc
  OliBomby · 2024-09-23 12:15:42 +02:00
  203951780e
• Add benchmark for minimum enclosing circle
  OliBomby · 2024-09-23 12:15:31 +02:00
  86817d0cfc
• Use cache for beatmap lookups on spectate screen

  @peppy noticed recently that attempting to spectate just a few users was
  very likely to end up in requests very quickly being rejected with code
  429 ("Too Many Requests").
  
  I'm somewhat certain that the reason for that is that a significant
  number of players is wont to retry a lot in quick succession. That means
  that spectator server is going to note a lot of gameplay start and end
  messages in quick succession, too. And as it turns out, every gameplay
  start would end up triggering a new beatmap set fetch request:
  
  	https://github.com/ppy/osu/blob/ccf1acce56798497edfaf92d3ece933469edcf0a/osu.Game/Screens/Spectate/SpectatorScreen.cs#L131-L134
  	https://github.com/ppy/osu/blob/ccf1acce56798497edfaf92d3ece933469edcf0a/osu.Game/Screens/Play/SoloSpectatorScreen.cs#L168-L172
  	https://github.com/ppy/osu/blob/ccf1acce56798497edfaf92d3ece933469edcf0a/osu.Game/Screens/Play/SoloSpectatorScreen.cs#L243-L256
  
  To attempt to curtail that, use the beatmap cache instead, which should
  prevent these unnecessary requests from firing in the first place,
  therefore reducing the chance of the client getting throttled.
  
  This technically means that a different endpoint is used to fetch the
  data (`GET /beatmaps/?ids[]=` rather than `GET
  /beatmapsets/lookup?beatmap_id={id}`), but docs claim that both should
  return the same data, and it looks to work fine in practice.

  Bartłomiej Dach · 2024-09-23 12:15:19 +02:00
  4b349ba387
• use RNG.Next
  OliBomby · 2024-09-23 11:44:07 +02:00
  42549e81aa
• verify n<=3 in minCircleTrivial
  OliBomby · 2024-09-23 11:43:36 +02:00
  40cfaabc53
• update wikipedia url
  OliBomby · 2024-09-23 11:42:28 +02:00
  d0f12006a4
• use named tuple members
  OliBomby · 2024-09-23 11:42:02 +02:00
  447d178e01
• rename region
  OliBomby · 2024-09-23 11:39:42 +02:00
  0d06b122c1
• Assert default origin not null in rotation handle
  OliBomby · 2024-09-23 11:37:42 +02:00
  a9ebfbe431
• Merge branch 'master' into rhythm-fixes
  StanR · 2024-09-23 14:25:32 +05:00
  6ed151ccf5
• Continue displaying storyboard even if fully dimmed in specific circumstances

  Closes https://github.com/ppy/osu/issues/9315.
  Closes https://github.com/ppy/osu/issues/29867.
  
  Notably, this does nothing about
  https://github.com/ppy/osu/issues/25075, but I'm not sure what to do
  with that one in the first place.

  Bartłomiej Dach · 2024-09-23 11:19:31 +02:00
  0f758ca25f
• fix outdated comment
  OliBomby · 2024-09-23 10:56:03 +02:00
  92b5650ff8
• Replace speed buff with aim buff
  StanR · 2024-09-23 13:49:25 +05:00
  e04b88a9b0
• Fix score being cloned in async method causing random errors (again)

  Compare: https://github.com/ppy/osu/pull/24548.
  
  I don't have a reproduction scenario (judging from the stack trace
  of the crash it's likely to be nigh-impossible to concoct a reliable
  one), but there is some circumstantial evidence that this might help,
  namely that that previous fix above worked, and the pathway that's
  failing here is similarly async to the one that pull fixed. So I'm just
  gonna start with that and hope that it does the job.

  Bartłomiej Dach · 2024-09-23 09:51:02 +02:00
  881c9dfbba