47 Commits

• Use better guard (and reword subsequent comment)

  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Bartłomiej Dach · 2025-09-02 12:42:07 +02:00
  4ed72efeae
• Use SingleOrDefault() instead of LastOrDefault()

  `LastOrDefault()` is arbitrary, and I hope this doesn't matter for
  anything, because if it does, then that's utterly *horrifying*.

  Bartłomiej Dach · 2025-09-02 08:08:23 +02:00
  903d91b697
• Add one more comment
  Bartłomiej Dach · 2025-09-02 08:08:22 +02:00
  b0dcd06b38
• Move null check after loop over nested hitobjects
  Marvin Schürz · 2025-09-01 13:13:28 +02:00
  ffb6ae2066
• Fix mismatch in cutoff time check between preventMissOnPreviousHitObjects and markPreviousObjectsHit
  Marvin Schürz · 2025-09-01 13:05:22 +02:00
  385529ec78
• Revert moving markPreviousObjectsHit into LoadAsyncComplete

  Running that there caused a test failure due to modifying drawables' transforms outside the update thread

  Marvin Schürz · 2025-09-01 12:10:12 +02:00
  060854f23a
• Prevent npr in tests due to drawable ruleset not being available
  Marvin Schürz · 2025-09-01 11:12:19 +02:00
  689cc27e68
• Move markPreviousObjectsHit into LoadAsyncComplete
  Marvin Schürz · 2025-09-01 11:11:26 +02:00
  da7e256302
• Recursively update hit results for nested drawables
  Marvin Schürz · 2025-09-01 11:10:30 +02:00
  9827f9f189
• Fix crash when marking previous objects as hit
  marvin · 2025-08-30 19:36:17 +02:00
  d6b4c2958d
• Disallow placing gameplay leaderboard in skins outside player

  Closes https://github.com/ppy/osu/issues/33542.
  
  For a diff this simple this took much more hemming and hawing because
  things are a bit annoying here from a few angles:
  
  - The only way that is considered idiomatic right now for a skin
    component to not be applicable to a screen is to require a dependency
    from DI that is only provided by applicable screens.
    `DrawableGameplayLeaderboard` has a few of those dependencies, but the
    scope of all the usages makes it so that the only really viable one to
    use here is `IGameplayLeaderboardProvider` itself (see: visual tests,
    and also the usage of multiplayer spectator, where the leaderboard is
    *not* under a player instance).
  
  - The smelly part of this is that the `Player` inheritance hierarchy
    must ensure that *every* non-abstract class has an
    `IGameplayLeaderboardProvider` cached. It is not trivial - if not
    straight up impossible - to force this via some `Player` level
    abstract method, because such a method would need to somehow
    accommodate all possible leaderboard providers. That however also
    means that every possible future `Player` implementor *must inherently
    know* to also cache a leaderboard provider lest it die at runtime. I
    don't love that, but I also don't see better alternatives.
  
  - Speaking of which, I also noticed that solo spectator and playlists
    don't have gameplay leaderboards. At all. Which I don't believe to be
    something that I broke with the leaderboard work - I'm pretty sure
    that was the pre-existing state - however I don't see any reason why
    they *couldn't* receive gameplay leaderboards. I'm not doing that
    here, though, just leaving TODOs for later.

  Bartłomiej Dach · 2025-06-09 13:11:29 +02:00
  6416f59c7b
• Fix editor player sometimes crashing because of instantiating wrong judgement result type for object

  Closes https://github.com/ppy/osu/issues/33231.
  
  I'm not sure how to reproduce the instances of this reported to sentry
  with `Drawable{Slider,Spinner}`, but this bug is about to be made worse
  by `DrawableHoldNote` in mania getting its own `JudgementResult` subtype
  in https://github.com/ppy/osu/pull/33194 - for that one to reproduce
  just start gameplay test while editor is seeked to a time instant where
  a hold note is mid-hold.
  
  There's possibly an argument here that `CreateResult()` should live on
  `HitObject` and not `DrawableHitObject`, and I'd even be partial to such
  an argument, but doing that would be a rather hard ruleset API break
  (albeit trivial one to resolve), and also may dredge up past
  conversations about `Judgement` and `JudgementResult` (cf.
  https://github.com/ppy/osu/pull/26563) that I would rather not get into
  again.
  
  Notably this is not source-breaking for rulesets. It may be
  binary-breaking, I haven't tested.

  Bartłomiej Dach · 2025-05-22 10:20:39 +02:00
  70c6ddbe30
• Show user tag control only following local user gameplay
  Bartłomiej Dach · 2025-03-12 12:19:33 +01:00
  e70ad14647
• Fix editor player crashing with UR counter present in skin

  Closes https://github.com/ppy/osu/issues/28764.

  Bartłomiej Dach · 2024-07-08 11:14:32 +02:00
  db7774485a
• Implement quick exit hotkeys for editor test play
  Bartłomiej Dach · 2024-07-02 14:34:36 +02:00
  d85c467856
• Implement quick pause toggle for editor test play
  Bartłomiej Dach · 2024-07-02 14:34:35 +02:00
  e28befb98d
• Implement autoplay toggle for editor test play

  Contains some hacks to fix weird behaviours like rewinding to the start
  on enabling autoplay, or gameplay cursor hiding.

  Bartłomiej Dach · 2024-07-02 14:34:31 +02:00
  1e4db77925
• Fix formatting
  Bartłomiej Dach · 2024-06-28 09:45:45 +02:00
  a3ea36d2b2
• Ensure past drawable objects also get their results populated in editor test play
  Bartłomiej Dach · 2024-06-28 09:37:10 +02:00
  7ac5bd4d37
• Fix incorrect handling of nested objects when inside parent object's duration
  Dean Herbert · 2024-05-29 23:30:47 +09:00
  fdb47f8dfa
• Apply results rather than fake a replay frame
  Dean Herbert · 2024-05-29 23:28:37 +09:00
  126837fadd
• Fix the majority of cases where gameplay stil doesn't end due to judgement count mismatch
  Dean Herbert · 2024-05-29 22:57:17 +09:00
  3b5b7b2f88
• Avoid passing beatmap in from editor when it's already present
  Dean Herbert · 2024-05-29 21:32:55 +09:00
  d2c86b0813
• Merge branch 'master' into fix/editor-test-exit
  Dean Herbert · 2024-05-29 21:08:36 +09:00
  16e2fa2c6a
• Remove unused ruleset parameter when testing beatmap in editor
  Dean Herbert · 2024-03-01 20:28:52 +08:00
  c6201ea5de
• Contains + Add to TryAdd
  Nitrous · 2024-01-11 11:36:58 +08:00
  6cd255f549
• Enumerate nested hit objects
  Nitrous · 2024-01-10 15:27:41 +08:00
  72e302dfac
• Make all hit objects before the start time marked as hit.
  Nitrous · 2024-01-10 15:19:38 +08:00
  b74c3b1c5c
• Fix editor not prompting before saving beatmap for export
  Dean Herbert · 2023-10-25 14:39:46 +09:00
  6934e045df
• Automated pass
  Dean Herbert · 2023-06-24 01:00:03 +09:00
  0ab0c52ad5
• Add TestingBeatmap activity
  Joseph Madamba · 2023-02-12 13:11:42 -08:00
  bbeef53569
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Merge branch 'master' into editor-test-play-dont-retain-test-time
  Bartłomiej Dach · 2022-11-19 12:09:04 +01:00
  c05c1625f2
• When returning to the editor after test play, use the original editor time rather than the point of exit
  Dean Herbert · 2022-11-17 12:36:24 +09:00
  a4e713a61f
• Don't seek to current editor location when location is close to (or before) the first object
  Dean Herbert · 2022-11-17 12:32:35 +09:00
  bfcd9e0f45
• Move IGameplaySettings override to compose screen to keep test mode unaffected
  Salman Ahmed · 2022-11-17 01:45:16 +03:00
  7a28a7f2a0
• Fix combo colour normalisation setting not applying to editor test play
  Dean Herbert · 2022-11-16 17:54:49 +09:00
  ee6fffec5f
• Move operation of setting GameplayClockContainer.StartTime to Reset call
  Dean Herbert · 2022-08-22 14:11:06 +09:00
  af2e82d7d5
• Fix potential crash when exiting editor test mode
  Dean Herbert · 2022-07-14 01:00:18 +09:00
  7ac04d0478
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Update screen transition events to use new event args
  Dean Herbert · 2022-04-22 00:52:44 +09:00
  832d37b2c2
• Remove startFromSkipTarget parameter and update usages that required said behaviour
  Dean Herbert · 2022-04-13 14:25:43 +09:00
  fbf0e5a45c
• Fix test gameplay starting in a hidden state
  Bartłomiej Dach · 2021-11-13 22:11:00 +01:00
  6b4b6de554
• Propagate clock state from gameplay test back to editor
  Bartłomiej Dach · 2021-11-13 22:11:00 +01:00
  2562412125
• Propagate clock state from editor to gameplay test
  Bartłomiej Dach · 2021-11-13 22:10:59 +01:00
  d2ddc25ab3
• Tweak loader transition when testing gameplay in editor
  Bartłomiej Dach · 2021-11-13 13:39:18 +01:00
  b47c0b63f4
• Move gameplay test pieces to own namespace
  Bartłomiej Dach · 2021-11-13 13:39:17 +01:00
  a5ba3bd012