h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2026-06-08 22:04:47 +08:00
Code Issues Releases Wiki Activity

Fix mismatch in cutoff time check between preventMissOnPreviousHitObjects and markPreviousObjectsHit

Browse Source
This commit is contained in:
Marvin Schürz
2025-09-01 13:05:22 +02:00
Unverified
parent 060854f23a
commit 385529ec78
1 changed files with 11 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
osu.Game/Screens/Edit/GameplayTest/EditorPlayer.cs
+11 -10
View File
@@ -124,27 +124,28 @@ namespace osu.Game.Screens.Edit.GameplayTest
{
void preventMiss(HitObject hitObject)
{
if (hitObject.StartTime > editorState.Time)
return;
var drawableObject = DrawableRuleset.Playfield.HitObjectContainer
.AliveObjects
.LastOrDefault(it => it.HitObject == hitObject);
preventMissOnDrawable(drawableObject);
if (drawableObject != null)
preventMissOnDrawable(drawableObject);
}
void preventMissOnDrawable(DrawableHitObject? drawableObject)
void preventMissOnDrawable(DrawableHitObject drawableObject)
{
if (drawableObject?.Entry == null)
if (drawableObject.Entry == null)
return;
var result = drawableObject.CreateResult(drawableObject.HitObject.Judgement);
result.Type = result.Judgement.MaxResult;
drawableObject.Entry.Result = result;
foreach (var nested in drawableObject.NestedHitObjects)
preventMissOnDrawable(nested);
if (drawableObject.HitObject.GetEndTime() < editorState.Time)
{
var result = drawableObject.CreateResult(drawableObject.HitObject.Judgement);
result.Type = result.Judgement.MaxResult;
drawableObject.Entry.Result = result;
}
}
void removeListener()