114 Commits

• Move BeatmapVersion from BeatmapInfo to IBeatmap

  Closes https://github.com/ppy/osu/issues/32420.
  
  The failure cause here is that in editor the beatmap version for the
  beatmap affected (or... any beatmap, really), is 0 (ZERO). That is
  probably a regression from https://github.com/ppy/osu/pull/32315, but
  like... can we universally agree that calling that change "a regression"
  in any capacity is dumb? Like what was that code *doing* playing dumb
  reference games and copying stuff into an arbitrary instance that could
  get or not get used later on? And now you have a 50/50 chance of
  accessing the *correct* model's field, depending on whether you go via
  `BeatmapInfo` or `Beatmap.BeatmapInfo`?
  
  Moving the field to `IBeatmap`, i.e. what is by now - by consensus,
  since https://github.com/ppy/osu/pull/28473 - supposed to be the "decoded
  and materialised" beatmap, fixes this issue.
  
  I probably should have done this as part of
  https://github.com/ppy/osu/pull/28473 but it slipped my mind. Probably
  for the better too because this change has rather large chances of
  breaking stuff so maybe better to examine it in isolation (via diffcalc
  runs or whatever).
  
  For added humour points, you'd say that the field on `BeatmapInfo` was
  not `[Ignore]`d, so this is a realm schema change, right? No. As far as
  I can tell, it's not. I opened realm studio and `BeatmapVersion` *is not
  a listed column` on `Beatmap` models.
  
  I'm also not gonna get into the fact that I think `EditorBeatmap` doing
  dumb games with juggling two `BeatmapInfo` references since
  https://github.com/ppy/osu/pull/15075 is bad, because I don't think I
  have the mental capacity to hotfix this by going down that train of
  thought.

  Bartłomiej Dach · 2025-03-17 15:04:48 +01:00
  91f3be5fea
• Ensure EditorBeatmap.PerformOnSelection() marks objects in selection as updated

  Closes https://github.com/ppy/osu/issues/28791.
  
  The reason why nudging was not changing hyperdash state in catch was
  that `EditorBeatmap.Update()` was not being called on the objects that
  were being modified, therefore postprocessing was not performed,
  therefore hyperdash state was not being recomputed.
  
  Looking at the usage sites of `EditorBeatmap.PerformOnSelection()`,
  about two-thirds of callers called `Update()` themselves on the objects
  they mutated, and the rest didn't. I'd say that's the failure of the
  abstraction and it should be `PerformOnSelection()`'s responsibility to
  call `Update()` there. Yes in some of the cases here this will cause
  extraneous calls that weren't done before, but the method is already
  heavily disclaimed as 'expensive', so I'd say usability should come
  first.

  Bartłomiej Dach · 2025-02-18 12:06:42 +01:00
  e6174f195c
• Implement basic bookmark support in editor
  Bartłomiej Dach · 2024-12-03 15:14:22 +01:00
  d60b7f4798
• Move bookmarks out of BeatmapInfo

  Not sure why I didn't do that in https://github.com/ppy/osu/pull/28473...

  Bartłomiej Dach · 2024-12-03 14:17:14 +01:00
  808934581f
• Merge branch 'master' into beatmap-info-purge
  Dean Herbert · 2024-07-23 12:09:32 +09:00
  d707e29ff7
• Enforce IBeatmap.Breaks to be sorted chronologically
  Salman Ahmed · 2024-07-08 16:06:38 +03:00
  b33e54d064
• Remove unused code
  Dan Balasescu · 2024-07-02 12:21:24 +09:00
  31edca866c
• Revert "Change breaks list to IReadOnlyList"

  This reverts commit 2c3b411bb5.

  Dan Balasescu · 2024-07-02 12:16:11 +09:00
  04da1209f7
• Change breaks list to IReadOnlyList
  Dean Herbert · 2024-07-02 11:59:24 +09:00
  2c3b411bb5
• Isolate bindable breaks list to EditorBeatmap
  Dean Herbert · 2024-07-02 11:31:55 +09:00
  005af280f2
• Fix ManiaModInvert permanently messing up the beatmap
  Dan Balasescu · 2024-07-01 15:02:00 +09:00
  f942595829
• Remove no-longer-necessary null propagation
  Bartłomiej Dach · 2024-06-19 11:21:57 +02:00
  2d9c3fbed2
• Implement automatic break period generation
  Bartłomiej Dach · 2024-06-19 10:22:06 +02:00
  4022a8b06c
• Make list of breaks bindable
  Bartłomiej Dach · 2024-06-19 07:44:03 +02:00
  6a6ccbc09f
• Move CountdownOffset out of BeatmapInfo
  Bartłomiej Dach · 2024-06-12 14:15:00 +02:00
  dd50d6fa6e
• Move Countdown out of BeatmapInfo
  Bartłomiej Dach · 2024-06-12 14:15:00 +02:00
  d373f752d6
• Move TimelineZoom out of BeatmapInfo
  Bartłomiej Dach · 2024-06-12 14:15:00 +02:00
  7f2a6f6f5a
• Move GridSize out of BeatmapInfo
  Bartłomiej Dach · 2024-06-12 14:15:00 +02:00
  6685c5ab74
• Move DistanceSpacing out of BeatmapInfo
  Bartłomiej Dach · 2024-06-12 14:14:58 +02:00
  3634307d7c
• Move SamplesMatchPlaybackRate out of BeatmapInfo
  Bartłomiej Dach · 2024-06-12 13:32:23 +02:00
  c216283bf4
• Move EpilepsyWarning out of BeatmapInfo
  Bartłomiej Dach · 2024-06-12 13:28:41 +02:00
  f64a0624a5
• Move WidescreenStoryboard out of BeatmapInfo
  Bartłomiej Dach · 2024-06-12 13:23:53 +02:00
  1ab86ebd24
• Move LetterboxInBreaks out of BeatmapInfo
  Bartłomiej Dach · 2024-06-12 13:18:44 +02:00
  a6b7600bf2
• Move SpecialStyle out of BeatmapInfo
  Bartłomiej Dach · 2024-06-12 13:12:30 +02:00
  011c2e3651
• Move StackLeniency out of BeatmapInfo
  Bartłomiej Dach · 2024-06-12 13:04:33 +02:00
  0a4560a03e
• Move AudioLeadIn out of BeatmapInfo
  Bartłomiej Dach · 2024-06-12 13:04:28 +02:00
  4339e2dc4a
• Fix stack leniency not applying immediately after change
  Bartłomiej Dach · 2024-06-10 14:34:22 +02:00
  25b2dfa601
• Add xmldoc mention about performance overhead of PerformOnSelection()
  Bartłomiej Dach · 2024-06-04 10:36:30 +02:00
  ecfcf7a2c0
• Preserve storyboard events when saving a beatmap in the editor

  Until we have full encoding support for storyboards, this stop-gap
  measure ensures that storyboards don't just disappear from existence.

  Dean Herbert · 2024-04-30 00:01:56 +08:00
  fd3f4a9e7b
• Use sane BeatmapInfo for preview time mutation

  `EditorBeatmap.BeatmapInfo` is usually the correct instance for mutating
  properties that should persist in the database.

  Salman Ahmed · 2023-01-07 14:23:36 +03:00
  904c76e437
• Fix changing preview point not prompting for save
  Bartłomiej Dach · 2023-01-01 19:54:26 +01:00
  b689ad6d80
• Merge branch 'master' into previewTime
  Bartłomiej Dach · 2023-01-01 18:38:19 +01:00
  0e59b55a12
• Fix the MOTHERLOAD of undetected issues that are now visible thanks to net6.0
  Dean Herbert · 2022-12-16 18:16:26 +09:00
  27c497145f
• only get;
  cdwcgt · 2022-12-16 09:58:58 +09:00
  f0246df1a9
• Add ability to set preview time
  cdwcgt · 2022-12-16 01:03:30 +09:00
  c164744064
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Make sure all selected items get deleted
  ekrctb · 2022-10-05 21:58:05 +09:00
  0613388aaa
• Rename event to be more generic (and add comprehensive xmldoc)
  Dean Herbert · 2022-09-13 14:59:30 +09:00
  f53507828c
• fix with new event
  OliBomby · 2022-09-13 02:20:52 +02:00
  fd48249eef
• revert the fix
  OliBomby · 2022-09-13 01:09:42 +02:00
  718f8c4ee2
• invoking hitobject updated before invoking removed
  OliBomby · 2022-09-12 17:50:11 +02:00
  8400de4b2e
• Merge pull request #19800 from peppy/fix-editor-ear-rape

  Fix slider ticks playing back at infinite rate while making changes to a slider in the editor

  Dan Balasescu · 2022-08-17 15:50:58 +09:00
  0cf3c5570a
• Move delegate debounce logic to Editor itself
  Dean Herbert · 2022-08-17 14:04:57 +09:00
  8ce50e98a6
• Fix slider ticks playing back at infinite rate while making changes to a slider in the editor
  Dean Herbert · 2022-08-16 15:27:58 +09:00
  ea50936d71
• Fix multiple cases of mutations at editor setup screen not triggering a state save
  Dean Herbert · 2022-08-02 16:47:37 +09:00
  efa3c3b757
• Add messages to all InvalidOperationExceptions

  Without this, they can be very non-descript and hard to track down

  Dean Herbert · 2022-06-28 01:34:25 +09:00
  569fde4b47
• Update parameter discards
  Dean Herbert · 2022-06-24 21:26:19 +09:00
  31a447fda0
• Merge branch 'master' into editor-controlpoint-undo-redo
  Dan Balasescu · 2022-06-20 13:47:01 +09:00
  468e5fcbed
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Support undo/redo for control points
  Dan Balasescu · 2022-06-13 15:45:08 +09:00
  7e7716f942