118 Commits

• Refactor hit windows class structure to reduce rigidity

  This change pulls back a significant degree of overspecialisation and
  rigidity in the class structure of `HitWindows` to make subsequent
  changes to hit windows, whose purpose is to improve replay playback
  accuracy, possible to do cleanly.
  
  Notably:
  
  - `HitWindows` is full abstract now. In a few use cases, and as a
    reference for ruleset implementors, `DefaultHitWindows` is provided as
    a separate class instead.
  
    This fixes the weirdness wherein `HitWindows` always declared 6 fields
    for result types but some of them would never be set to a non-zero
    value or read.
  
  - `HitWindow.GetRanges()` is deleted because it is overspecialised and
    prevents being able to adjust hitwindows by ±0.5ms cleanly which will
    be required later.
  
    The fallout of this is that the assertion that used `GetRanges()` in
    the `HitWindows` ctor must use something else now, and the closest
    thing to it was `GetAllAvailableWindows()`, which didn't return
    the miss window - so I made it return the miss window and fixed the
    one consumer that didn't want it (bar hit error meter) to skip it.
  
  - Diff also contains some clean-up around `DifficultyRange` to unify
    handling of it.

  Bartłomiej Dach · 2025-06-25 08:40:12 +02:00
  8b542e5442
• Cancel ApplyDefaults() when requested

  Also didn't notice a particular case here, but if all code passes up
  until we get to the `foreach (var h in nestedHitObjects)` below, then we
  could end up stuck here for quite a while.

  Dan Balasescu · 2025-03-03 14:46:13 +09:00
  033952029e
• Exit loop when cancellation requested

  The following manages to create all hitobjects but proceeds to get stuck
  in this method:
  
  `dotnet run -- difficulty 1607040 -r:2`

  Dan Balasescu · 2025-03-03 14:19:19 +09:00
  ad9a963bd0
• Implement auto additions editor-only
  OliBomby · 2024-10-01 16:40:48 +09:00
  0a78eb9628
• Merge pull request #23443 from OliBomby/edit-nodesample

  Make NodeSamples editable

  Dean Herbert · 2024-06-18 11:12:02 +09:00
  316125d47a
• Use more descriptive HitObject names for debugger displays
  Dan Balasescu · 2024-06-13 15:18:39 +09:00
  91f2cf8cc3
• Merge branch 'master' into edit-nodesample
  Bartłomiej Dach · 2024-06-06 13:42:25 +02:00
  86b13074a0
• Adjust xmldoc slightly
  Dean Herbert · 2024-02-18 17:54:29 +08:00
  9655e8c48a
• Make CreateJudgement public again and add remarks
  Andrei Zavatski · 2024-02-16 20:24:02 +03:00
  060b01eee8
• Cache created judgement in HitObject
  Andrei Zavatski · 2024-02-09 23:20:31 +03:00
  c500264306
• Clean up DrawableHitObject events on Dispose

  This is just general safeties to avoid cases where
  components don't correctly unbind events.

  Dean Herbert · 2024-01-29 15:28:20 +09:00
  de32e7815b
• Merge remote-tracking branch 'upstream/master' into edit-nodesample
  OliBomby · 2024-01-25 11:33:29 +01:00
  c2d57dc77c
• Remove all usage of LegacyDifficultyControlPoint
  Dean Herbert · 2023-09-07 17:41:57 +09:00
  b34a36f6ce
• Adjust CreateHitSampleInfo to handle additions correctly, rather than implementing locally
  Dean Herbert · 2023-05-30 14:04:02 +09:00
  114f12a790
• Rename GetSampleInfo to better describe what method does

  Also add full xmldoc

  Dean Herbert · 2023-05-17 14:07:48 +09:00
  dc51d5ecf3
• Fix bank not correctly being assigned when adding sample additions in editor
  Dean Herbert · 2023-05-16 18:52:52 +09:00
  d9ae822966
• add sample info to Banana and SpinnerBonusTick
  OliBomby · 2023-05-01 14:54:06 +02:00
  27cfadca16
• fix sample of drumroll ticks being bankless
  OliBomby · 2023-04-29 23:52:24 +02:00
  92efd04f31
• removed all usage of hitobject's DifficultyControlPoint
  OliBomby · 2023-04-26 18:17:02 +02:00
  354cd23874
• remove all regular usage of DifficultyControlPoint
  OliBomby · 2023-04-26 17:55:38 +02:00
  c44f71a737
• remove all test usages of SampleControlPoint
  OliBomby · 2023-04-26 14:21:52 +02:00
  c6fc180659
• Remove IContext & add IHasGenerateTicks
  OliBomby · 2023-04-26 13:10:57 +02:00
  6c70948681
• Invoke ApplyDefaultsToSelf
  OliBomby · 2023-04-26 11:46:05 +02:00
  e27c4dfa10
• remove unused directives
  OliBomby · 2023-04-25 13:06:37 +02:00
  97910d6be6
• remove ApplyLegacyInfo method
  OliBomby · 2023-04-25 12:52:21 +02:00
  891b87a5ff
• Add LegacyContext
  OliBomby · 2023-04-25 12:12:46 +02:00
  ea1e6e9798
• made the SampleControlPoint and DifficultyControlPoint obsolete
  OliBomby · 2023-04-25 11:34:09 +02:00
  a4c6850ab2
• Move MaximumJudgementOffset to HitObject

  We want to access this property for computing lifetime

  ekrctb · 2023-01-19 21:23:55 +09:00
  11e1b22bf5
• Implement hold "sliding" samples in osu!mania
  Dean Herbert · 2022-10-11 16:31:37 +09:00
  f060e6a780
• Convert == usages to ReferenceEquals
  Dan Balasescu · 2022-06-20 16:56:19 +09:00
  e0c82d11ab
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Add the ability for HitObjects to specify auxiliary samples
  Dean Herbert · 2022-03-14 17:19:48 +09:00
  8676a2587c
• Fix oversubscription to StartTimeBindable.ValueChanged
  Bartłomiej Dach · 2022-01-12 19:29:49 +01:00
  afce976f08
• Remove no longer necessary guards against default control points

  The subscription in which the guards were present was moved from
  constructor to `ApplyDefaults()`, and at that point neither the sample
  control point or the difficulty point can be the default point, because
  there are explicit paths that overwrite those with blank points in the
  same methods, prior to the subscription's registration.
  
  The only worry would be that someone would set the default point on the
  object themselves, but at that point that is most likely programmer
  error anyhow.

  Bartłomiej Dach · 2022-01-11 22:14:47 +01:00
  80ccff9068
• Fix sample control point time being calculated before defaults applied

  In editor contexts, the `StartTimeBindable` subscription in `HitObject`
  was firing before defaults were applied, which in the case of sliders
  manifested in an infinite end time. `ApplyDefaults()` also did not
  always set the time of the control point to the correct value, which
  matters when the beatmap is encoded.
  
  Ensure that the control points receive the correct time values during
  default application, and only register the `StartTimeBindable` change
  callback after defaults have been successfully applied.

  Bartłomiej Dach · 2022-01-11 21:38:59 +01:00
  7a25fe79b7
• Ensure HitObject-local control points are non-default after ApplyDefaults

  We will probably want to make this whole flow more efficient in the
  future, but this should suffice for now.

  Dean Herbert · 2021-10-26 16:06:03 +09:00
  dae7cdc4c5
• Merge branch 'master' into no-more-difficulty-control-points-info
  smoogipoo · 2021-10-08 18:41:17 +09:00
  bc37cb6f43
• Convert usages of BeatmapDifficulty to IBeatmapDifficultyInfo
  Dean Herbert · 2021-10-01 16:55:50 +09:00
  a92d499d7a
• Merge branch 'master' into no-more-difficulty-control-points-info
  Dean Herbert · 2021-09-28 13:53:56 +09:00
  46bafb6252
• Reduce NestedHitObject enumerator overhead

  This was especially bad due to it allocating on any and every start time
  change, even the first (see usage in `HitObject.ctor`).

  Dean Herbert · 2021-09-20 15:09:27 +09:00
  16e60eed56
• Change SampleControlPoint time to use leniency in bindable changed event too
  Dean Herbert · 2021-09-14 16:24:55 +09:00
  a7ae3cc03e
• Ensure time of HitObject related ControlPoints are kept in sync with the hitobject
  Dean Herbert · 2021-09-10 15:59:30 +09:00
  cd227213e6
• Clone control points when copying to HitObjects
  Dean Herbert · 2021-09-10 14:36:39 +09:00
  714f55b6bc
• Fix new ordering of retrieval meaning EndTime is not available in time
  Dean Herbert · 2021-09-03 17:11:12 +09:00
  6894ed3426
• Assign default control points earlier in HitObject construction
  Dean Herbert · 2021-09-03 17:11:12 +09:00
  74f385bad8
• Ensure all hitobject level control points are populated before calling virtual defaults application
  Dean Herbert · 2021-09-03 17:11:12 +09:00
  1aff4c2238
• Write out DifficultyControlPoints into HitObjects
  Dean Herbert · 2021-09-03 16:58:16 +09:00
  b41b1e2394
• Actually serialise SampleControlPoints along with HitObjects
  Dean Herbert · 2021-08-31 15:14:03 +09:00
  d988aa1680
• Apply the default SampleControlPoint if not externally provided

  This is mostly to handle tests for now, as generally this should be
  provided by an external source in all other cases.

  Dean Herbert · 2021-08-30 17:21:07 +09:00
  4da2dca339
• Move to legacy namespace
  Dean Herbert · 2021-08-30 17:14:53 +09:00
  ccacf56dd8