332 Commits

• Move toggle implementation to work on all scrolling rulesets automatically
  Dean Herbert · 2023-09-01 19:53:10 +09:00
  37c2b330a2
• Move comment to more fitting place
  Bartłomiej Dach · 2023-07-28 22:10:10 +02:00
  caad931a16
• Rename Apply{Vertical -> Horizontal}Centering to match common understanding
  Bartłomiej Dach · 2023-07-28 22:09:28 +02:00
  6d018c08af
• Fix playfield not taking up full width correclty when not vertically centered
  Dean Herbert · 2023-07-28 16:40:14 +09:00
  c9155f85ab
• Fix osu!taiko editor playfield missing a piece

  Regressed with recent centering changes in https://github.com/ppy/osu/pull/24220

  Dean Herbert · 2023-07-27 02:24:10 +09:00
  deba6e2508
• Fix playfield getting cut off (again) at tall aspect ratios
  Dean Herbert · 2023-07-21 15:20:20 +09:00
  b58354ac64
• Reduce width of right toolbar ever so slightly (and use more shared constants)
  Dean Herbert · 2023-07-21 14:39:15 +09:00
  f489dbd7a9
• Merge branch 'master' into slider-control-point-no-distance-snap
  Bartłomiej Dach · 2023-05-26 19:52:54 +02:00
  53c91349fe
• Split out grid snapping modes into "relative" and "global" types
  Dean Herbert · 2023-05-25 21:41:19 +09:00
  804671ca74
• Fix hotkeys not actually working
  Dean Herbert · 2023-05-24 14:56:11 +09:00
  a22ad98cb7
• Merge branch 'master' into sample-set-controls
  Dean Herbert · 2023-05-24 14:03:04 +09:00
  298989ffd2
• Add more padding around playfield in editor to avoid overlap with tool areas

  Closes #23130.

  Dean Herbert · 2023-05-02 15:37:02 +09:00
  67f83f246b
• Move inspector into own file
  Dean Herbert · 2023-04-04 19:17:34 +09:00
  3209b09270
• Tidy up dependency resolution
  Dean Herbert · 2023-04-04 19:14:30 +09:00
  4aed483005
• Add view for selections of size != 1
  Dean Herbert · 2023-04-04 19:11:48 +09:00
  195b5fc3f1
• Add object type
  Dean Herbert · 2023-04-04 19:05:50 +09:00
  b0d5761667
• Add hit object inspector view
  Dean Herbert · 2023-04-04 19:03:45 +09:00
  c356c163fa
• Move right-side editor toolbox to base HitObjectComposer

  Move right-side editor toolbox to base `HitObjectComposer`

  Dean Herbert · 2023-04-04 19:00:56 +09:00
  f9ebdadfe8
• Use more generic wording for future-proofing
  Bartłomiej Dach · 2023-02-19 15:06:40 +01:00
  d9ca7102f0
• Combine config and time checks into one

  Functionally equivalent right now, but the combined variant is more
  localised to what it actually needs to do, and less error-prone if
  any new code gets appended to the method.

  Bartłomiej Dach · 2023-02-19 13:14:51 +01:00
  aac32a2c9f
• change bindable seekToHitObject to private
  Maximilian Kruse · 2023-02-19 10:18:02 +01:00
  f3522c4162
• Add setting to disable automatic seeking after object placement
  Maximilian Kruse · 2023-02-18 19:43:45 +01:00
  ddd37bb319
• Expose Ruleset from HitObjectComposer instead
  Derrick Timmermans · 2022-11-30 12:17:58 +01:00
  6a61e70766
• Merge branch 'master' into Editor-DrawableRuleset-Dependencies
  Dean Herbert · 2022-11-30 17:42:46 +09:00
  4215f4f5d7
• Fix code style
  Derrick Timmermans · 2022-11-27 21:48:44 +01:00
  93ba84e5ff
• Provide ruleset dependencies only to Compose Placement Blueprints
  Derrick Timmermans · 2022-11-27 21:43:33 +01:00
  70c320b2e8
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Dispose DrawableRulesetDependencies in HitObjectComposer
  Derrick Timmermans · 2022-11-25 08:27:22 +01:00
  65e5c9a3ae
• Provide DrawableRulesetDependencies from HitObjectComposer
  Derrick Timmermans · 2022-11-24 13:13:45 +01:00
  7b620392fe
• Stop HitObjectComposer from handling Shift+Number keys
  Dean Herbert · 2022-10-24 15:19:36 +09:00
  d0e6bda9ef
• Add icon and radio button logic
  Dean Herbert · 2022-10-19 21:35:08 +09:00
  50e24ddd87
• Fix osu! editor padding being applied to toolboxes

  The result of https://github.com/ppy/osu/pull/20739 and https://github.com/ppy/osu/pull/20738 having unintended side effects when applied together.

  Dean Herbert · 2022-10-18 14:32:00 +09:00
  6a7f6c76ff
• Add background behind editor toolbox groups
  Dean Herbert · 2022-10-13 16:36:19 +09:00
  4d99c7002b
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Update screen padding and colouring to better match new designs
  Dean Herbert · 2022-05-24 18:43:22 +09:00
  17206bbebf
• Add enum to snap method as alternative to mutliple nested invocations
  Dean Herbert · 2022-05-12 16:19:07 +09:00
  c0abce918f
• Merge branch 'master' into cache-at-interface
  Dean Herbert · 2022-05-05 18:54:24 +09:00
  e83604a1fc
• Remove unnecessary type specification in HitObjectComposer's caching
  Dean Herbert · 2022-05-05 16:44:37 +09:00
  5a1ac71d90
• Move snap provider caching to interfaces
  Dean Herbert · 2022-05-05 16:44:37 +09:00
  1c6a233cc0
• Move IPlacementHandler caching to interface
  Dean Herbert · 2022-05-05 16:43:02 +09:00
  b411b59006
• Add xmldoc and rename methods in IPositionSnapProvider for legibility
  Dean Herbert · 2022-05-05 15:58:21 +09:00
  f6fc926f1a
• Combine editor toolbox container implementation and fix input blocking

  Until now, toolbox scroll areas would block input from arriving behind
  them, even when no visible element was clicked.
  
  In addition, clicking on a button inside a toolbox would still send a
  `MouseDown` event to things behind it. Specifically, the editor's
  `HitObjectComposer` would receive these events and also place objects
  when the user does not expect them to be placed.
  
  This fixes another regression that occurred due to `ScrollContainer`s no
  longer blocking input theirselves.

  Dean Herbert · 2022-05-04 17:41:30 +09:00
  b325f0ee0b
• Minor cleanup

  Just from reading diff.

  Salman Ahmed · 2022-04-28 07:14:43 +03:00
  2e8372fe90
• Introduce DistancedHitObjectComposer and supersede OsuToolboxComposite
  Salman Ahmed · 2022-04-28 06:44:50 +03:00
  835898dd30
• Encapsulate distance spacing control handling to a "distance toolbox composite"

  Encapsulated in a way which can allow further extensibility for the
  right-side area of toolboxes.

  Salman Ahmed · 2022-04-24 08:33:03 +03:00
  8ed39009fd
• Change "distance spacing" multipler type to double

  Avoids losing precision on initial load, causing an unnecessary
  hash change in `EditorChangeHandler`.
  
  Resolves test failures in `TestSceneEditorChangeStates`
  (https://github.com/ppy/osu/runs/5192493482?check_suite_focus=true).

  Salman Ahmed · 2022-02-16 03:28:12 +03:00
  0992bec2c8
• Remove e.ShiftPressed handling for now

  Broken on macOS, will be handled differently later on as discussed.

  Salman Ahmed · 2022-02-15 02:21:53 +03:00
  868dcd20f5
• Expose distance spacing in IPositionSnapProvider for updating distance grid

  Alternate method is to expose a `SnapDistancesChanged` event in
  `IPositionSnapProvider` instead, but I chose this way as an analogue to
  `IBeatSnapProvider.BeatDivisor`, which might even make sense to be
  exposed as `BindableBeatDivisor` instead of caching that separately.

  Salman Ahmed · 2022-02-15 02:21:53 +03:00
  528dc03b8c
• Add "distance spacing" multiplier for osu! ruleset

  While osu!catch also implements a distance snap grid, it doesn't rely on
  `GetBeatSnapDistanceAt` (unlike osu!), therefore it can't have the
  "distance spacing" multiplier yet.

  Salman Ahmed · 2022-02-15 02:21:53 +03:00
  19ee05c232
• Move files to UI namespace
  Dean Herbert · 2022-02-14 17:51:39 +09:00
  b9d9fc56af