33 Commits

• Disallow placing gameplay leaderboard in skins outside player

  Closes https://github.com/ppy/osu/issues/33542.
  
  For a diff this simple this took much more hemming and hawing because
  things are a bit annoying here from a few angles:
  
  - The only way that is considered idiomatic right now for a skin
    component to not be applicable to a screen is to require a dependency
    from DI that is only provided by applicable screens.
    `DrawableGameplayLeaderboard` has a few of those dependencies, but the
    scope of all the usages makes it so that the only really viable one to
    use here is `IGameplayLeaderboardProvider` itself (see: visual tests,
    and also the usage of multiplayer spectator, where the leaderboard is
    *not* under a player instance).
  
  - The smelly part of this is that the `Player` inheritance hierarchy
    must ensure that *every* non-abstract class has an
    `IGameplayLeaderboardProvider` cached. It is not trivial - if not
    straight up impossible - to force this via some `Player` level
    abstract method, because such a method would need to somehow
    accommodate all possible leaderboard providers. That however also
    means that every possible future `Player` implementor *must inherently
    know* to also cache a leaderboard provider lest it die at runtime. I
    don't love that, but I also don't see better alternatives.
  
  - Speaking of which, I also noticed that solo spectator and playlists
    don't have gameplay leaderboards. At all. Which I don't believe to be
    something that I broke with the leaderboard work - I'm pretty sure
    that was the pre-existing state - however I don't see any reason why
    they *couldn't* receive gameplay leaderboards. I'm not doing that
    here, though, just leaving TODOs for later.

  Bartłomiej Dach · 2025-06-09 13:11:29 +02:00
  6416f59c7b
• Update usages of GameplayClockContainer not using an adjustable source
  Dean Herbert · 2023-09-22 16:22:36 +09:00
  c40bd74138
• Don't apply decoupling to SpectatorPlayerClocks

  See inline comment for reasoning. It's a bit complicated.

  Dean Herbert · 2023-09-22 16:22:35 +09:00
  8367bb6bee
• Fix incorrect dependency caching

  These are tested framework-side to throw exceptions, but the
  test is ignored for the source generated version because it quietly
  allows this scenario.
  
  The source gen project should eventually have an analyser for these
  unsupported cases, or we could consider relaxing this particular case.

  Dan Balasescu · 2023-07-20 22:30:49 +09:00
  733ce4c382
• Rename {KeyCounter -> InputCount}Controller
  Bartłomiej Dach · 2023-06-26 19:27:42 +02:00
  8d91580dc1
• test: change hideTarget drawable and testing logic

  Doesn't change what it needs to test conceptually

  tsrk · 2023-06-16 17:24:40 +02:00
  f9321a24d9
• refactor: decouple Trigger logic from KeyCounterDisplay

  This allows to keep a coeherent state regardless of the progress of the play

  tsrk · 2023-06-14 21:13:35 +02:00
  c637fddf73
• test: remove hard usages of KeyCounterDisplay
  tsrk · 2023-06-14 13:25:24 +02:00
  758831b983
• Massage tests a bit more
  Dan Balasescu · 2023-05-25 16:38:22 +09:00
  6d9ba9248d
• Rename Add/AddRange methods as they are no longer conflicting with Container
  Dean Herbert · 2023-03-15 18:02:41 +09:00
  5f9b13a775
• Move KeyCounter components to HUD namespace
  Dean Herbert · 2023-03-07 16:41:39 +09:00
  28520414aa
• Merge branch 'master' into gameplay/key-counter-abstraction
  Dean Herbert · 2023-03-07 16:09:45 +09:00
  8f6df5ea0f
• refactor(KeyCounterDisplay): apply suggestions

  I also took the freedom to add type checking, as we can't limit the
  usage of `Add()` since it's a Container. The exception thrown also
  advises of using the suggested `AddTrigger()` instead.

  tsrk · 2023-02-22 14:58:27 +00:00
  1beec71037
• Add clipboard dependency to SkinEditor specific tests

  This is usually provided by the `SkinEditorOverlay`, which is not always
  present in tests.

  Dean Herbert · 2023-02-16 15:24:38 +09:00
  2fbaf88a3c
• refactor: rename trigger classes

  Makes it better to understand their purpose

  tsrk · 2023-02-15 21:46:13 +00:00
  076eb81b21
• refactor: separate impl of KeyCounterDisplay

  This allows for different layouts of display. Idk, maybe someone would
  want to mix both variants? (don't do this please). This commit is mostly
  prep for further changes.

  tsrk · 2023-02-13 01:36:12 +00:00
  11d0e185b8
• Move skin editor to overlays namespace
  Dean Herbert · 2023-02-02 14:00:31 +09:00
  8dc2e6872e
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Remove remaining usage of GameplayClock
  Dean Herbert · 2022-08-15 20:22:36 +09:00
  704568ae3b
• Make GameplayClockContainer also an IGameplayClock and expose to remaining tests
  Dean Herbert · 2022-08-15 18:30:53 +09:00
  f81c7644b4
• Move all usage of GameplayClock to IGameplayClock
  Dean Herbert · 2022-08-15 18:30:53 +09:00
  c8764cb333
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Fix remaining cases of incorrect GameplayState construction in tests

  Manual attempts to initialise replaced by a new `TestGameplayState`
  helper for ease of use.

  Bartłomiej Dach · 2022-05-28 15:23:29 +02:00
  a8e1c5ba87
• Cache gameplay clock in more places to fix song progress related tests
  Bartłomiej Dach · 2022-03-17 21:22:07 +01:00
  a8bb696e5b
• Change PerformancePointsCounter resolution requirements to be required

  All other similar UI components have required dependencies, so this is
  mainly to bring things in line with expectations. I am using this fact
  in the skin editor to only show components which can be used in the
  current editor context (by `try-catch`ing their
  `Activator.CreateInstance`).

  Dean Herbert · 2022-03-17 14:56:35 +09:00
  ac739c9dae
• Require ScoreProcessor to receive ruleset
  Dan Balasescu · 2022-03-14 15:51:10 +09:00
  3fff7f4b7e
• Update existing function type rather than adding an override
  Dean Herbert · 2021-06-02 16:04:53 +09:00
  f8ae70e562
• Enable autoplay in skin editor tests
  Dean Herbert · 2021-05-13 14:55:11 +09:00
  e0e9106921
• Remove unnecessary binding logic from HUDOverlay
  Dean Herbert · 2021-05-07 17:51:46 +09:00
  1cb10c2a22
• Add missing cache rules
  Dean Herbert · 2021-05-07 17:50:44 +09:00
  3044b1c432
• Update skin editor test scene to cache a ScoreProcessor
  Dean Herbert · 2021-05-07 17:22:56 +09:00
  84a4ff333e
• Update HealthDisplay components to use DI to attach data source
  Dean Herbert · 2021-05-07 17:22:45 +09:00
  755588258e
• Allow skin editor to be invoked from any context

  This is kind of how I see things working going forward, where the editor
  can be applied to anything in the game which supports it (ie. a results
  screen, gameplay screen, etc.) and it will immediately allow changing
  the interface.
  
  This adds a test scene which shows this working with gameplay.

  Dean Herbert · 2021-04-29 16:12:15 +09:00
  de73ac7cec