76 Commits

• Do not give swell ticks any visual representation

  Why is this a thing at all? How has it survived this long? I don't know.
  
  As far as I can tell this only manifests on selected beatmaps with "slow
  swells" that spend the entire beatmap moving in the background. On other
  beatmaps the tick is faded out, probably due to the initial transform
  application that normally "works" but fails hard on these slow swells.
  
  Can be seen on https://osu.ppy.sh/beatmapsets/1432454#taiko/2948222.

  Bartłomiej Dach · 2025-02-24 15:32:17 +01:00
  c82cf40928
• Fix drum rolls losing width on strong state toggle in editor

  Fixes https://github.com/ppy/osu/issues/30480.

  Bartłomiej Dach · 2024-11-05 11:10:49 +01:00
  387fbc2214
• Move all remaining osu!taiko sample playback logic out of DrawableHitObjects
  Dean Herbert · 2023-06-30 15:21:34 +09:00
  e87cf6d256
• Fix sample silence being one level too low

  4a7b011a53 inadvertently unearthed that
  nested strong hits could play samples of their own accord, rather than
  delegating to `DrumSampleTriggerSource` as they were supposed to. This
  was an unfortunate omission due to how the inheritance structure of
  `TaikoHitObject` looks like (some irrelevant classes omitted for
  brevity):
  
  	DrawableTaikoHitObject
  		DrawableTaikoHitObject<TObject> <-- `GetSamples()` was overridden to empty here
  			DrawableTaikoStrongableHitObject
  				DrawableHit
  				DrawableDrumRoll
  				DrawableDrumRollTick
  			DrawableSwell
  			DrawableSwellTick
  		DrawableStrongNestedHit <-- all strong nested hits are here => didn't receive `GetSamples()` override
  			DrawableHit.StrongNestedHit
  			DrawableDrumRoll.StrongNestedHit
  			DrawableDrumRollTick.StrongNestedHit
  
  To fix, move the `GetSamples()` override one level higher, to the
  non-generic `DrawableTaikoHitObject`, to suppress the spurious sample
  playbacks.
  
  The stale reference in the comment was also updated to match current
  code.

  Bartłomiej Dach · 2023-05-21 18:58:26 +02:00
  9915fac2c8
• Reword ambiguous xmldoc
  Bartłomiej Dach · 2023-02-12 13:31:29 +01:00
  67b6df3172
• Move taiko-specific property out of DrawableHitObject
  Dean Herbert · 2023-02-12 16:09:28 +09:00
  9d09141ab7
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Add note about taiko pooling oversight
  Dean Herbert · 2022-11-07 18:32:12 +09:00
  aa61eb8f4b
• Update Remove/RemoveRange/RemoveAll calls in line with framework changes
  Dean Herbert · 2022-08-29 15:57:40 +09:00
  a215d009fe
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Update with keybinding changes
  smoogipoo · 2021-09-16 18:26:12 +09:00
  f9d5abff8a
• Fix taiko drawable hit content not correctly being removed on regeneration
  Dean Herbert · 2021-05-21 16:41:40 +09:00
  0bcd0cda6b
• Prepare base DHO for HO application
  Bartłomiej Dach · 2020-12-20 15:42:24 +01:00
  a25cd910f8
• Reflect can-be-strong split in DHO structure
  Bartłomiej Dach · 2020-12-13 13:08:30 +01:00
  b1635ecd16
• Introduce base class for hitobjects that can be strong
  Bartłomiej Dach · 2020-12-13 12:36:39 +01:00
  f74567e8eb
• Rename Strong{-> Nested}HitObject
  Bartłomiej Dach · 2020-12-13 12:34:14 +01:00
  1ddc896b76
• Make HitSampleInfo immutable
  smoogipoo · 2020-12-01 15:37:51 +09:00
  5760e1c1fc
• Fix bindable propagation potentially making swells strong
  Dean Herbert · 2020-10-09 17:12:10 +09:00
  cb96a40dd6
• Avoid API change to DrawableHitObject
  Dean Herbert · 2020-09-24 13:28:29 +09:00
  33fad27ec2
• Change properties to methods and improve naming
  Dean Herbert · 2020-09-24 13:22:31 +09:00
  156edf24c2
• Handle type/strength changes from samples changes
  Dean Herbert · 2020-09-23 18:09:40 +09:00
  9a0e5ac154
• Fix taiko sample selection not updating when changing strong/rim type
  Dean Herbert · 2020-09-23 17:59:11 +09:00
  8f3eb9a422
• Support Strong bindable changes
  Dean Herbert · 2020-05-29 16:45:47 +09:00
  50fcd4149f
• Support HitType bindable changes
  Dean Herbert · 2020-05-29 16:45:47 +09:00
  4e9631b546
• Add test for final sample output
  Dean Herbert · 2020-05-19 23:28:13 +09:00
  db4e3047dd
• Fix taiko sample mapping for strong hits
  Dean Herbert · 2020-05-11 12:53:54 +09:00
  b4d790c076
• Add remaining taiko hitobject skinnables and expose as SkinnableDrawable for safety
  Dean Herbert · 2020-04-15 18:03:23 +09:00
  eb165840cb
• Fix typo in DrawableTaikoHitObject
  Andrei Zavatski · 2020-04-15 07:00:38 +03:00
  f4b5a17b65
• Change inheritance of taiko hit pieces to better allow for skinning
  Dean Herbert · 2020-04-11 13:33:49 +09:00
  7fba291134
• Apply OnRelease method signature refactorings
  smoogipoo · 2020-01-22 13:22:34 +09:00
  7b2f58eb30
• Remove manual hitobject sample namespacing
  smoogipoo · 2020-01-02 14:27:27 +09:00
  0f8a76afde
• CA1715: use prefix for generic parameters.
  Huo Yaoyuan · 2019-12-17 13:00:25 +08:00
  40b43b85f1
• Add back/obsolete old AddNested() method
  smoogipoo · 2019-10-17 14:02:08 +09:00
  f429a8f7c2
• Rename parameter
  smoogipoo · 2019-10-17 12:53:54 +09:00
  d8f3678c3c
• Make taiko use the new nested hitobject structure
  smoogipoo · 2019-10-17 11:57:00 +09:00
  d49ef6a36b
• Fix taiko sample namespace
  smoogipoo · 2019-09-04 12:47:10 +09:00
  5efd455ce4
• Share logic with other rulesets (and make default)
  Dean Herbert · 2019-08-28 18:12:47 +09:00
  9a98f39f06
• Merge remote-tracking branch 'origin/master' into fix-taiko-proxy-rewind

  # Conflicts:
  #	osu.Game.Rulesets.Taiko/Objects/Drawables/DrawableTaikoHitObject.cs

  smoogipoo · 2019-08-27 17:42:45 +09:00
  3723c441d2
• Add initial fade transform
  smoogipoo · 2019-08-27 15:33:53 +09:00
  bc7a81e733
• Fix taiko proxies being removed on rewind
  smoogipoo · 2019-08-27 15:24:49 +09:00
  b85e62a6e2
• Use transform management for taiko hit objects
  iiSaLMaN · 2019-08-27 05:03:56 +03:00
  843da26dba
• Flip default to the preferred method going forward
  Dean Herbert · 2019-07-22 15:55:38 +09:00
  c3b81bef4a
• Fix skinning support for combobreak
  Dean Herbert · 2019-06-30 21:58:30 +09:00
  60ea3d4e1a
• Apply newline additions
  Dean Herbert · 2019-04-01 12:16:32 +09:00
  612db31c38
• Fix incorrect usage of InternalChildren

  Could cause overwriting of components added by base DrawableHitObjcet class (such as samples)

  Dean Herbert · 2019-03-25 13:48:55 +09:00
  39df8cce19
• Fix remaining issues
  Dean Herbert · 2019-02-28 13:31:40 +09:00
  26d53d06a9
• Update licence header (and remove year)
  Dean Herbert · 2019-01-24 17:43:03 +09:00
  8617aaa2a7
• OpenTK -> osuTK
  smoogipoo · 2018-11-20 17:14:59 +09:00
  f27bd3ef3e
• Fix nullref
  smoogipoo · 2018-11-19 17:05:51 +09:00
  08ffa18936
• Fix taiko proxies not receiving the correct lifetimes
  smoogipoo · 2018-11-15 20:26:12 +09:00
  e207dd728b