179 Commits

• Convert gameplay leaderboard to skinnable component

  This PR converts the leaderboard into a full-fledged skinnable component
  that can be manipulated by users at will.
  
  Notably, this finally allows https://github.com/ppy/osu/issues/20422 to
  be fixed - although it's a very mixed bag, for several reasons:
  
  - Because of taiko players' refusal to see reason^W^W^W^Winsistence on
    keeping stable behaviours related to aspect ratio treatment, I have to
    assume the worst case scenario, which means than on typical
    resolutions like 16:9 (or even worse, 4:3), the leaderboard will
    likely not occupy as much vertical space as it probably could.
  
  - Additionally, there's the problem of where to put the spectator list.
    I settled on putting it to the right of the leaderboard, but that's
    kind of janky, because the leaderboard sometimes collapses and
    sometimes fully hides, leading to a very awkward space left behind. If
    we had the capability to anchor elements to other elements, maybe this
    could be resolved, but for now, I'm not sure what to do. I think if
    some users are bothered by it they can move it where they want it. Or
    delete it.

  Bartłomiej Dach · 2025-04-24 13:10:30 +02:00
  59b826c321
• Mark MathHelper.Clamp() as banned API

  See previous commit for partial rationale.
  
  There's an argument to be made about the `NaN`-spreading semantics being
  desirable because at least something will loudly fail in that case, but
  I'm not so sure about that these days. It feels like either way if
  `NaN`s are produced, then things are outside of any control, and chances
  are the game can probably continue without crashing. And, this move
  reduces our dependence on osuTK, which has already been living on
  borrowed time for years now and is only awaiting someone brave to go
  excise it.

  Bartłomiej Dach · 2025-02-28 13:48:22 +01:00
  35b0ff80bb
• Merge spectator list classes into one skinnable
  Bartłomiej Dach · 2025-01-17 11:23:14 +01:00
  3c4bfc0a01
• Add skinnable spectator list to default skins
  Bartłomiej Dach · 2025-01-15 14:29:53 +01:00
  99c7e164dc
• Fix osu!catch fruits not resizing on texture change
  Dan Balasescu · 2024-09-02 15:23:40 +09:00
  30fb3c3999
• Component -> Lookup
  Dean Herbert · 2024-08-23 14:48:50 +09:00
  48cfd77ee8
• Remove requirement of base calls to ensure user skin container layouts are retrieved
  Dean Herbert · 2024-08-22 19:14:30 +09:00
  1435fe24ae
• Rename Target lookup to Component
  Dean Herbert · 2024-08-22 19:00:28 +09:00
  b57b8168a6
• Move GlobalSkinnableContainers to global scope
  Dean Herbert · 2024-08-22 18:46:07 +09:00
  9a21174582
• Rename SkinComponentsContainerLookup to GlobalSkinnableContainerLookup
  Dean Herbert · 2024-08-22 18:39:36 +09:00
  f37cab0c6e
• Fix legacy key counter position not matching stable
  Salman Ahmed · 2024-08-21 00:10:16 +09:00
  20658ef4ee
• Merge pull request #26254 from frenzibyte/mania-combo-counter

  Add argon/classic osu!mania combo counter

  Dean Herbert · 2024-08-15 17:56:28 +09:00
  5710f0f302
• Fix beatmap skin always overriding ruleset HUD components
  Salman Ahmed · 2024-08-15 16:47:10 +09:00
  49c71f7863
• Standardise skin transformer code structure
  Dean Herbert · 2024-08-12 14:27:21 +09:00
  d2eb6ccb8c
• Update in line with new changes
  Dean Herbert · 2024-08-09 14:55:01 +09:00
  80c814008f
• Avoid making non-ruleset transformers in Ruleset.CreateSkinTransformer

  This didn't make any sense, so let's do it a better way.

  Dean Herbert · 2024-08-08 16:29:54 +09:00
  60d383448f
• Merge branch 'master' into ruleset-specific-combo-counter
  Dean Herbert · 2024-08-08 03:21:52 +09:00
  3c572abaa7
• Use transformers for per-skin key counter implementation
  Dean Herbert · 2024-08-06 18:17:21 +09:00
  725dc4de9b
• Remove pointless assert
  Salman Ahmed · 2024-06-25 01:10:12 +03:00
  e8de293be5
• Merge branch 'master' into ruleset-specific-combo-counter
  Bartłomiej Dach · 2024-06-04 15:44:11 +02:00
  5fcea01c13
• Remove behaviour of flipping catcher plate on direction change
  Salman Ahmed · 2024-02-14 07:17:05 +03:00
  02de9122d4
• Refactor CatchLegacySkinTransformer logic and remove HiddenByRulesetImplementation entirely
  Salman Ahmed · 2023-12-30 03:55:45 +03:00
  e469e06271
• Move combo counter to ruleset-specific HUD components target
  Salman Ahmed · 2023-12-30 03:47:52 +03:00
  eedb436389
• Fix legacy catcher sprites getting shrunk
  Salman Ahmed · 2023-10-10 01:26:59 +03:00
  fc63ee43be
• Adjust catcher origin position to match 1:1 with stable

  Change catcher origin position logic to 1:1 match stable on legacy skin

  Salman Ahmed · 2023-10-10 01:26:59 +03:00
  0fb7895a52
• Adjust gameplay element maximum size limits for backwards compatibility

  The new limits were chosen by sampling across over 4000 skins. The
  methodology for doing so is described in the following gist:
  
  	https://gist.github.com/bdach/6228ba41d128b23d1f89142f404108a3

  Bartłomiej Dach · 2023-10-05 20:37:10 +02:00
  0ae4a0f11f
• Use correct maximum size for droplets
  Salman Ahmed · 2023-09-21 19:02:31 +03:00
  c4fc4199d1
• Simplify some maximum size specs
  Dean Herbert · 2023-09-20 12:48:15 +09:00
  8e16b1d507
• Change extension from retrieval to post-processing instead
  Salman Ahmed · 2023-09-19 03:40:30 +03:00
  291a91be66
• Revert "Update GetTexture signature rather than creating new overload"

  This reverts commit 96f12cfbaa.

  Salman Ahmed · 2023-09-19 03:21:19 +03:00
  57dc76b345
• Update GetTexture signature rather than creating new overload
  Dean Herbert · 2023-09-05 18:01:19 +09:00
  96f12cfbaa
• Add limit to catch palpable object elements
  Salman Ahmed · 2023-09-03 02:22:58 +03:00
  f182f571cb
• Replace various local implementations of rewinding checks with new property
  Dean Herbert · 2023-07-07 15:21:24 +09:00
  e0fc97bb93
• Fix combo counter on legacy skins flipping when "Floating Fruits" mod is active

  Closes #23989.

  Dean Herbert · 2023-06-22 18:46:43 +09:00
  4be8eede88
• Standardise all local SkinComponentsContainerLookup variables to containerLookup
  Dean Herbert · 2023-02-16 15:33:56 +09:00
  76f7accd13
• Rename SkinnableTargetContainer to SkinComponentsContainer

  Also use full `SkinComponentsContainerLookup` instead of the sub-type.
  This will potentially be useful once we bring in per-ruleset targets.

  Dean Herbert · 2023-02-15 18:37:41 +09:00
  a92e42bb84
• Simplify and rename SkinnableTargetComponentsContainer
  Dean Herbert · 2023-02-15 17:30:21 +09:00
  8bbd00822c
• Remove now unnecessary using
  Berkan Diler · 2022-12-26 22:50:36 +01:00
  335cb0205f
• Use generic Enum methods
  Berkan Diler · 2022-12-26 20:36:39 +01:00
  c7ca4bbba5
• Remove unused osu!catch ArgonJudgementPiece
  Dean Herbert · 2022-12-24 03:35:27 +08:00
  e8a0f8996c
• Combine base class for JudgementPiece
  Dean Herbert · 2022-12-24 03:32:13 +08:00
  727ac00f6d
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Add "Component" prefix to lookup naming
  Dean Herbert · 2022-11-09 17:46:43 +09:00
  1aa0e40f2f
• Rename SkinnableTarget to GlobalSkinLookup
  Dean Herbert · 2022-11-09 17:46:43 +09:00
  e75c3b3f94
• Rename ISkinComponent to ISkinLookup
  Dean Herbert · 2022-11-09 17:46:43 +09:00
  c908969d9b
• Apply nullability to osu!catch skinning classes
  Dean Herbert · 2022-11-09 13:58:58 +09:00
  2952dbc8fb
• Fix incorrect constant
  Dean Herbert · 2022-10-29 18:07:17 +09:00
  a985151e31
• Adjust metrics to make banana lens flares look better
  Dean Herbert · 2022-10-28 19:35:50 +09:00
  40efa1603b
• Add fade to banana's lighting as it approaches the catcher

  This also avoids using the `UprightScalingContainer` (and allows for
  scale adjust in the process).

  Dean Herbert · 2022-10-28 18:29:59 +09:00
  e87b541c58
• Apply two minor fixes from code review

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2022-10-28 10:19:53 +09:00
  9969c00ead