52 Commits

• Add failing test
  Dan Balasescu · 2024-08-13 18:34:28 +09:00
  93c1a27f22
• Cache created judgement in HitObject
  Andrei Zavatski · 2024-02-09 23:20:31 +03:00
  c500264306
• Remove now-redundant code
  ekrctb · 2023-01-19 19:57:25 +09:00
  32acaa44be
• Move judgement result revert logic to Playfield

  Previously, some judgement results were not reverted
  when the source DHO is not alive (e.g. frames skipped in editor).
  Now, all results are reverted in the exact reverse order.

  ekrctb · 2023-01-19 19:57:13 +09:00
  812a4b412a
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Remove unused using
  Dan Balasescu · 2022-09-22 20:58:23 +09:00
  7527d815e8
• Fix failing test
  Dean Herbert · 2022-09-22 20:43:38 +09:00
  a2ff31f37d
• Adjust variables slightly for readability
  Dean Herbert · 2022-09-21 01:29:12 +09:00
  cb8ed1f144
• Fixed TestCatcherWidth and added TestFruitClampedToCatchableRegion
  Drison64 · 2022-09-20 12:41:06 +02:00
  979f7f88a1
• Reverted changes
  Drison64 · 2022-09-19 17:25:35 +02:00
  18fe37bb22
• Fixed TestCatcherCatchWidth failing
  Drison64 · 2022-09-18 22:05:09 +02:00
  ca9fe9f240
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Added an extra unit test when actually catching the last banana to also clear the plate
  Darius Wattimena · 2021-11-18 20:23:42 +01:00
  9685892b94
• Added a unit test to cover clearing of the plate when missing the last banana
  Darius Wattimena · 2021-11-18 20:07:03 +01:00
  cfedbb92c1
• Apply batch fixing of built-in types using var
  Dean Herbert · 2021-10-27 13:04:41 +09:00
  6944151486
• Convert usages of BeatmapDifficulty to IBeatmapDifficultyInfo
  Dean Herbert · 2021-10-01 16:55:50 +09:00
  a92d499d7a
• Move catcher trail generation logic to CatcherArea
  ekrctb · 2021-07-27 19:07:37 +09:00
  da69867fd4
• Move catcher trail generation logic to Catcher

  It resolves mutual dependency of `Catcher` and `CatcherTrailDisplay`.
  Trail generation logic is moved to `Catcher`.
  The generation logic no longer uses delayed scheduling because the hidden state is hard to manage.
  Instead, the last time a trail is generated is calculated and used.
  The new logic has a different behavior when the dash key is pressed in succession under 50ms, but it is not noticeable for normal plays.

  ekrctb · 2021-07-26 17:51:59 +09:00
  bb046fa3b8
• Pass DroppedObjectContainer via constructor instead of DI

  It is now just one level deep, so it is not beneficial to use DI here.
  This effectively reverts ae09c23e.

  ekrctb · 2021-07-19 20:11:49 +09:00
  b88ee3c1a1
• Relax caught object stacking test

  The stacking code currently uses an unseeded RNG and there is a non-zero chance the stack will be very flat (small Y position difference).
  Technically, `RNG.NextSingle(0, 5)` can return `0`, but extremely unlikely that the all RNG calls return 0.

  ekrctb · 2021-07-04 10:23:49 +09:00
  623ba15919
• Move caught object stack vertical offset logic
  ekrctb · 2021-07-02 20:43:47 +09:00
  170513568b
• Resolve DroppedObjectContainer via DI
  ekrctb · 2021-06-24 16:09:13 +09:00
  ae09c23e4e
• Add DroppedObjectContainer class
  ekrctb · 2021-06-24 15:51:54 +09:00
  16d5893535
• Maintain catch hit explosion by lifetime entries

  - Fix hit explosion not showing when a replay is rewound to a time after a hit object is caught

  ekrctb · 2021-06-04 19:46:50 +09:00
  181f1da3d3
• Add stacking test logic to TestSceneCatcherArea for skinned testing
  Dean Herbert · 2021-04-22 17:34:53 +09:00
  2203552e9e
• Update tests to better support stack regeneration cases
  Dean Herbert · 2021-04-22 17:13:19 +09:00
  84a7138223
• Update usages of config with framework changes
  smoogipoo · 2021-03-17 16:10:16 +09:00
  7fa5fd5647
• more specific type droppedObjectContainer
  ekrctb · 2020-12-09 10:35:01 +09:00
  ccca7e0b25
• Make object on the catcher plate separate CaughtObject class
  ekrctb · 2020-12-08 21:11:40 +09:00
  c301223d8c
• Fix hit lighting colour not applied in TestSceneCatcher
  ekrctb · 2020-12-08 21:07:12 +09:00
  ed50fd445e
• Restore hyper dash state on revert judgement result
  ekrctb · 2020-12-08 15:21:47 +09:00
  100b365c98
• Restore catcher state on revert judgement result
  ekrctb · 2020-12-08 15:03:03 +09:00
  cb76a2d7b5
• Move catcher state changing logic to OnNewResult method
  ekrctb · 2020-12-08 14:28:30 +09:00
  0213f77b4b
• Fix & clarify catcher tests
  ekrctb · 2020-12-04 10:14:00 +09:00
  3de46d0a3b
• Add more TestSceneCatcher tests

  Some tests are moved from TestSceneCatcherArea

  ekrctb · 2020-12-03 16:44:36 +09:00
  1d669cf65e
• Refactor fruit dropping code

  - The repeated `Remove` call was quadratic complexity.
    Now it is linear time.

  ekrctb · 2020-12-03 16:44:36 +09:00
  2eb2c934cc
• Remove all RequiredTypes usages
  smoogipoo · 2020-05-16 18:17:12 +09:00
  648999a2de
• Mark Catcher.additiveTarget to never be null

  And provide empty containers instead.

  Salman Ahmed · 2020-04-22 05:04:07 +03:00
  95de2c6f7f
• Add skinnable test scene per ruleset to better allow dynamic compilation
  Dean Herbert · 2020-04-07 16:20:13 +09:00
  2c840c52a3
• Split out CatcherArea nested classes and reorder methods
  Dean Herbert · 2020-03-13 12:59:30 +09:00
  1733519c3a
• Add animation and fallback catcher support
  Dean Herbert · 2020-03-10 12:36:25 +09:00
  0d18ea1d29
• Update catcher test to use SkinnableTestScene
  Dean Herbert · 2020-02-17 17:19:46 +09:00
  a3e0f84fcc
• Apply fixes
  Dean Herbert · 2019-11-25 11:30:55 +09:00
  45514ff660
• Merge branch 'master'

  Conflicts:
  	osu.Game.Tests/Visual/Gameplay/TestSceneSkinnableDrawable.cs

  Dean Herbert · 2019-09-05 14:40:30 +09:00
  c0bcbfd892
• Update some case sensitive resources lookups in-line with resources
  Dean Herbert · 2019-09-04 10:44:24 +09:00
  40c61894ef
• Refactor skin configuration to be infinitely extensible
  Dean Herbert · 2019-09-03 17:57:34 +09:00
  bebc3309ce
• Update naming
  Dean Herbert · 2019-08-30 15:13:29 +09:00
  70e417533f
• Introduce the concept of SkinComponents

  Removes reliance on string lookups and better defines elements for introduction into database

  Dean Herbert · 2019-08-30 14:55:52 +09:00
  a15828ab25
• Fix build issues
  iiSaLMaN · 2019-08-23 15:18:56 +03:00
  94b5caf740
• Pass sample info to Skin.GetSample
  iiSaLMaN · 2019-08-23 14:32:43 +03:00
  d8535574d1