Dan Balasescu
cc59434ea4
Fix crash due to being too forgiving of nulls
...
This one is super duper annoying to test, because we already have e.g.
`TestScenePlaylistsScreen`. The only way to test it would be to use an
`OsuGameTestScene`.
Maybe this is okay?
2024-11-21 20:52:34 +09:00
Dan Balasescu
dc45816566
Fix inspection
2024-11-21 20:41:14 +09:00
Dan Balasescu
6870c99eb2
Enable NRT for multiplayer and playlists
2024-11-21 20:32:09 +09:00
Bartłomiej Dach
a679f0736e
Add ability to close playlists within grace period after creation
2024-11-20 12:36:12 +01:00
Dean Herbert
6fba6de4dc
Merge branch 'master' into multiplayer-remove-cmc-and-composite
2024-11-20 17:24:55 +09:00
Dean Herbert
03de518484
Fix missing updateRoomPlaylist call
2024-11-20 16:56:22 +09:00
Sheppsu
7d4062d2ad
remove redundant Scale attribute
2024-11-18 04:04:28 -05:00
Sheppsu
29e7adcd3b
add player settings to multi spectator screen
2024-11-18 03:57:50 -05:00
Dan Balasescu
1a656d0ec3
Remove CachedModelDependencyContainer usages from online play
2024-11-15 15:59:28 +09:00
Dan Balasescu
bfbae9458a
Remove OnlinePlayComposite
2024-11-15 15:59:28 +09:00
Dan Balasescu
34c0f72dd6
Make Room.Playlist non-bindable
2024-11-15 15:51:01 +09:00
Dan Balasescu
b16edbbf52
Make Room.RecentParticipants non-bindable
2024-11-15 15:25:43 +09:00
Dan Balasescu
dc5337d771
Make Room.UserScore non-bindable
2024-11-15 14:42:46 +09:00
Dan Balasescu
c4f8fd1832
Make Room.DifficultyRange non-bindable
2024-11-15 14:42:46 +09:00
Dan Balasescu
487a010b12
Make Room.PlaylistItemStats non-bindable
2024-11-15 14:42:46 +09:00
Dan Balasescu
80b3e330a6
Make Room.ChannelId non-bindable
2024-11-15 14:42:46 +09:00
Dan Balasescu
6c84e425f8
Make Room.MaxAttempts non-bindable
2024-11-15 14:42:46 +09:00
Dan Balasescu
0ceaafe731
Make Room.Duration & Room.StartDate & Room.EndDate non-bindable
2024-11-15 14:42:45 +09:00
Dan Balasescu
89de4f0f87
Make Room.AutoStartDuration non-bindable
2024-11-15 14:42:45 +09:00
Dan Balasescu
b8bae30b66
Make Room.ParticipantCount & Room.MaxParticipants non-bindable
2024-11-15 14:42:45 +09:00
Dan Balasescu
f001cce24a
Make Room.AutoSkip non-bindable
2024-11-15 14:42:18 +09:00
Dan Balasescu
ec5be6dbc3
Make Room.Password & Room.HasPassword non-bindable
2024-11-15 14:42:18 +09:00
Dan Balasescu
198681e644
Make Room.QueueMode non-bindable
2024-11-15 14:42:18 +09:00
Dan Balasescu
7e3e5208f0
Make Room.Availability non-bindable
2024-11-15 14:42:18 +09:00
Dan Balasescu
5d4838a08b
Make Room.Status non-bindable
2024-11-15 14:42:18 +09:00
Dan Balasescu
81e4cb348f
Make Room.Type non-bindable
2024-11-15 14:42:18 +09:00
Dan Balasescu
bde7b8e610
Make Room.Category non-bindable
2024-11-15 14:42:18 +09:00
Dan Balasescu
8694f7e1cc
Make Room.Host non-bindable
2024-11-15 14:42:17 +09:00
Dan Balasescu
6160df1586
Make Room.Name non-bindable
2024-11-15 14:29:15 +09:00
Dean Herbert
3262b6d989
Refactor to avoid dual-boolean mess
2024-11-14 22:10:45 +09:00
Dan Balasescu
a2a930aa35
Fix CI issues
2024-11-13 17:15:50 +09:00
Dan Balasescu
5b2568d18b
Fix cases where the bindable is resolved directly
2024-11-13 16:38:49 +09:00
Dan Balasescu
99762da7b8
Make RoomID non-bindable
...
Most important changes are to `RoomSubScreen` and `PlaylistsRoomSubScreen`, because those are the only two cases that now bind to the event instead.
2024-11-13 16:28:54 +09:00
Dan Balasescu
f3fd87af7b
Make DrawableMatchRoom structurally match other implementations
2024-11-12 20:32:59 +09:00
Dan Balasescu
72564b5c98
Make CurrentPlaylistItem not a bindable
2024-11-12 18:17:24 +09:00
Dan Balasescu
788ecc1e7b
Replace MultiplayerRoomComposite with local bindings
2024-11-06 15:31:27 +09:00
Bartłomiej Dach
968835bb44
Do not show daily challenge conclusion notification on disconnection
...
Closes https://github.com/ppy/osu/issues/30194 .
2024-10-11 14:18:19 +02:00
Dean Herbert
8773c34fdd
Rename enum to non-plural now that it won't conflict
2024-10-01 19:55:46 +09:00
Dean Herbert
ad3007eaad
Adjust ILocalUserPlayInfo to expose whether gameplay is in a paused/break state
2024-10-01 17:53:46 +09:00
Ianlucht
cd94d6e2bc
fixed if statement format
2024-09-07 14:01:38 -06:00
Ianlucht
e6f81abc3b
cleaned up whitespace
2024-09-07 13:57:12 -06:00
Ianlucht
170737b68f
added DailyChallengeIntro to notification
2024-09-07 13:48:14 -06:00
Ianlucht
958bfde51d
added DailyChallengeIntro to notification
2024-09-07 13:46:42 -06:00
Dean Herbert
7b13943377
Handle changes to the automatic download setting immediately
2024-09-02 19:20:05 +09:00
Dean Herbert
872d14ed88
Fix incorrect handling of ordered playlist items
2024-09-02 19:18:43 +09:00
Dean Herbert
6227e4f848
Apply NRT to MultiplayerSpectateButton
2024-09-02 16:37:38 +09:00
Dean Herbert
38a62eed44
Add automatic downloading support when spectating a multiplayer room
2024-09-02 16:37:38 +09:00
Dean Herbert
e79604cc13
Merge pull request #29542 from frenzibyte/show-daily-challenge-intro-once-per-session
...
Show daily challenge intro screen once per session
2024-09-01 21:27:16 +09:00
Dean Herbert
3bc42db3a6
Fix event leak in Multiplayer implementation
...
Very likely closes #29088 . It's the only thing I could find odd in the
memory dump.
2024-08-30 16:14:19 +09:00
Dean Herbert
84bceca778
Assume we can always fetch the ruleset
2024-08-26 15:38:58 +09:00
Dean Herbert
7f5f3a4589
Fix mod icons potentially showing incorrectly at daily challenge intro
...
Prefer using the beatmap's rulesets over the current user selection.
Closes https://github.com/ppy/osu/issues/29559 .
2024-08-22 13:57:19 +09:00
Salman Ahmed
637c9aeef0
Add DailyChallengeIntroPlayed session static
2024-08-21 03:37:04 +09:00
Andrei Zavatski
f74263db81
Remove extra box in OnlinePlayBackgroundScreen
2024-08-17 01:01:51 +03:00
Bartłomiej Dach
306e84c7ac
Move disposal method to more expected location
2024-08-12 10:46:58 +02:00
Jamie Taylor
c6fa348d82
Add sound design for daily challenge intro animation
2024-08-09 23:05:33 +09:00
Dean Herbert
0cb3b6a1f8
Add back TrySetDailyChallengeBeatmap call for safety
2024-08-08 22:10:26 +09:00
Dean Herbert
8eb0ef1e33
Merge branch 'master' into daily-challenge-intro-audio-auto-download
2024-08-08 22:09:21 +09:00
Dean Herbert
03d543ec99
Fix potential test failure in daily challenge tests
...
See https://github.com/ppy/osu/actions/runs/10296877688/job/28500580680 .
2024-08-08 16:53:22 +09:00
Dean Herbert
3f3145e109
Start playing music during intro if download finishes early
2024-08-08 15:10:18 +09:00
Dean Herbert
5d66eda982
Add support for automatically downloading daily challenge during the intro display
2024-08-08 15:10:18 +09:00
Dean Herbert
e95d61d4c2
Remove accidental double handling of beatmap availability in DailyChallenge
2024-08-08 15:10:18 +09:00
Dean Herbert
f91a3e9a35
Start playing daily challenge track as part of intro sequence
2024-08-08 15:10:17 +09:00
Dean Herbert
5891780427
Show initial text a bit longer
2024-08-08 14:15:40 +09:00
Dean Herbert
7058fedf42
Merge branch 'master' into daily-challenge-intro-screen-part-2
2024-08-08 14:12:16 +09:00
Dean Herbert
25dddb694a
And then completely change the animation to a new style
2024-08-08 14:02:43 +09:00
Dean Herbert
f72f5ee7e3
More improvements maybe
2024-08-08 13:29:10 +09:00
Dean Herbert
9bafdeeeff
Improve animation
2024-08-08 13:17:25 +09:00
Dean Herbert
8773c2f7eb
Merge pull request #29281 from kstefanowicz/multiplayer-chat-focus-hint
...
Add "enter" hint to in-gameplay chatbox placeholder text
2024-08-08 01:29:42 +09:00
Dean Herbert
cfd7f96e76
Add missing exit line causing completely incorrect behaviour
2024-08-07 23:29:24 +09:00
kstefanowicz
775f76f472
Have placeholder text change while focused
2024-08-07 07:47:35 -04:00
Dean Herbert
e52d80a41b
Add more difficulty information and further tweaks to visuals
2024-08-07 19:08:04 +09:00
Dean Herbert
083fe32d20
Improve feel of animation
2024-08-07 19:07:45 +09:00
Salman Ahmed
a0615a8f18
Frenzi's WIP animation
2024-08-07 19:07:45 +09:00
Dean Herbert
cfccd74441
Add daily challenge intro sequence
2024-08-07 19:07:44 +09:00
Dean Herbert
6870311c1e
Remove requirement of specifying animateOnnter in BackgroundScreen ctor
2024-08-07 19:07:44 +09:00
Dean Herbert
3c05b975a0
Fix clicking the beatmap import notification at the daily challenge screen exiting to main menu
2024-08-07 19:07:43 +09:00
Dean Herbert
5a63c25f49
Fix clicking the beatmap import notification at the daily challenge screen exiting to main menu
2024-08-07 14:42:34 +09:00
Dan Balasescu
f92e2094c1
Adjust localisation string name + formatting
2024-08-05 12:34:24 +09:00
kstefanowicz
b0757a13c2
Add "enter" hint to chatbox placeholder text while in-game
2024-08-04 12:32:08 -04:00
Dean Herbert
e77489f2a9
Allow notification of new strings
2024-07-31 03:10:36 +09:00
Dean Herbert
bdc465e1c6
Reword notification text slightly
2024-07-31 03:06:35 +09:00
Dean Herbert
d75c170ba1
Merge branch 'master' into daily-challenge/better-messaging
2024-07-30 19:04:48 +09:00
Dean Herbert
d5f9173288
Remove unused local variable
2024-07-30 19:04:43 +09:00
Bartłomiej Dach
1b57a2a136
Show new daily challenge notification globally
2024-07-30 10:36:26 +02:00
Dean Herbert
aa2515763c
Merge pull request #29184 from bdach/daily-challenge/wrong-mods-after-replay
...
Fix mods persisting after watching replay from daily challenge screen
2024-07-29 23:23:45 +09:00
Bartłomiej Dach
b46f3c97da
Add notification on daily challenge conclusion & start of new one
...
Because I wish to stop seeing "DAILY CHALLENGE WHERE" every day
on #general.
The notifications are constrained to the daily challenge screen only to
not spam users who may not care.
2024-07-29 14:30:10 +02:00
Dean Herbert
7afcd72872
Fix potentially too many scores displaying in breakdown while in gameplay
2024-07-29 20:58:42 +09:00
Dean Herbert
05056f0e8a
Remove no longer required AlwaysPresent definition
...
This also reverts commit 7fedfd368c
2024-07-29 20:43:56 +09:00
Dean Herbert
5a1002c1a0
Ensure score breakdown doesn't spam scores when not visible
2024-07-29 20:43:50 +09:00
Bartłomiej Dach
f1a84a5111
Fix mods persisting after watching replay from daily challenge screen
...
Closes https://github.com/ppy/osu/issues/29133 .
Hope I can be forgiven for no tests. I had a brief try but writing them
is going to take hours.
2024-07-29 12:52:30 +02:00
Bartłomiej Dach
cebd38c6eb
Merge pull request #29163 from Joehuu/copy-lb-mods-daily
...
Add ability to copy leaderboard mods in daily challenge
2024-07-29 12:09:27 +02:00
Bartłomiej Dach
2ff0a89b4f
Convert into auto-property even more
2024-07-29 10:59:21 +02:00
Bartłomiej Dach
aa7f6f81ef
Merge pull request #29127 from Joehuu/add-negative-horizontal-padding-daily
...
Fix daily challenge background clipping when settings/notifications is opened
2024-07-29 10:28:48 +02:00
Joseph Madamba
f6eb9037df
Add ability to copy leaderboard mods in daily challenge
2024-07-27 23:55:56 -07:00
Salman Ahmed
7fedfd368c
Fix score breakdown tooltips appearing in other feeds
2024-07-28 07:22:58 +03:00
Joseph Madamba
d55e861b90
Fix daily challenge background clipping when settings/notifications is opened
2024-07-26 16:55:15 -07:00
Dean Herbert
9323f89357
Fix "Beatmap not downloaded" tooltip hint not showing in daily challenge
2024-07-27 02:06:56 +09:00
Dean Herbert
0421e1e9d0
Reduce number spacing a bit more
2024-07-26 23:21:44 +09:00
Dean Herbert
96049807c4
Adjust weight and text in event feed output
...
Just some minor adjustments.
2024-07-26 23:20:32 +09:00
Dean Herbert
4fa6a19409
Merge pull request #29108 from bdach/daily-challenge/better-breakdown
...
Improve score breakdown on daily challenge
2024-07-26 23:12:04 +09:00
