38575 Commits

Author	SHA1	Message	Date
Dean Herbert	32207d4112	Remember the last used custom divisor when cycling divisor types	2023-06-01 17:11:49 +09:00
Dean Herbert	bcde2cbc73	Apply NRT to BeatDivisorControl	2023-06-01 16:58:14 +09:00
Dean Herbert	f52ed41f10	Use better defaults of 1/4 and 1/6 when cycling types	2023-06-01 16:28:03 +09:00
Dean Herbert	55a3847036	Merge pull request #23708 from peppy/labelled-slider-visibility ... Adjust background colour used in `LabelledDrawable`s to allow visibility of some elements	2023-06-01 13:08:17 +09:00
Bartłomiej Dach	d78df0b084	Merge pull request #23695 from peppy/realm-startup-error-handling ... Adjust realm startup for added reliability	2023-05-31 22:46:58 +02:00
Dean Herbert	20439e80f6	Adjust background colour used in LabelledDrawables to allow visibility of sliders	2023-05-31 23:24:21 +09:00
Dean Herbert	812def124f	Merge pull request #23661 from peppy/fix-multiplayer-present-crash ... Fix `OnResume` / `OnSuspending` potentially getting called before `OnEntering` on a sub screen	2023-05-31 19:43:30 +09:00
Dean Herbert	18eb15bfa5	Gracefully handle failures in cleaning up pending file deletions	2023-05-31 19:39:43 +09:00
Bartłomiej Dach	2e81cae201	Move comment to more correct place	2023-05-30 23:18:34 +02:00
Bartłomiej Dach	62d1774407	Apply same comment & reworded condition to suspend too	2023-05-30 21:54:56 +02:00
Dean Herbert	741ee84ed6	Add comment and use full conditional similar to extension method ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2023-05-30 18:38:28 +09:00
Dean Herbert	14a376c041	Merge branch 'master' into scorev2	2023-05-30 14:34:43 +09:00
Dean Herbert	4e0f40bee5	Split out multiplier retrieval into a function and use a default multiplier for all rulesets	2023-05-30 14:20:26 +09:00
Dean Herbert	fd919879c3	Merge branch 'master' into acc-challenge	2023-05-30 13:24:34 +09:00
Dean Herbert	a0be526266	Adjust realm backup procedure to hard fail if running out of attempts ... Previously, if the backup procedure failed, startup would continue and the user's realm database may be deleted. I think in such a fail case I'd rather the game didn't startup so the user gets in touch (or reads the log files themselves) rather than potentially losing data.	2023-05-30 13:04:34 +09:00
Dean Herbert	79694897be	Ensure a potential exception from cleanupPendingDeletions doesn't mark realm corrupt ... The whole restructure here is to move the nested call out of the `try-catch`. I noticed this while looking at a corrupt database issue a user reported (https://github.com/ppy/osu/discussions/23694). It's not the first time we've seen a corrupt database error where the "corrupt" version works just fine on a second attempt. Maybe this isn't the issue and it's just a transitive file access violation but it definitely feels like this should be fixed regardless.	2023-05-30 13:00:17 +09:00
Dean Herbert	61d9b50993	Merge pull request #23640 from 17steen/make_pause_menu_translatable ... Make GameplayMenuOverlay translatable	2023-05-30 09:36:19 +09:00
Bartłomiej Dach	5604dfb758	Merge branch 'master' into acc-challenge	2023-05-29 22:33:57 +02:00
Bartłomiej Dach	314a0f80f3	Reword setting name & description	2023-05-29 22:12:37 +02:00
Bartłomiej Dach	36f60def6d	Merge pull request #23679 from cdwcgt/percentage-format-slider ... Format percentage based on significant decimal digits	2023-05-29 21:18:23 +02:00
Dean Herbert	b3ca409339	Rename a few remaining CountAccuracyJudgement variable	2023-05-29 20:08:22 +09:00
Dean Herbert	1558723420	Merge branch 'master' into scorev2	2023-05-29 20:06:32 +09:00
Dean Herbert	df662afbd5	Pass ScoreProcessorStatistics to FrameHeader, rather than the full processor	2023-05-29 20:00:42 +09:00
Dean Herbert	1a6d9e9ff0	Apply NRT to GameplayLeaderboardScore and change GetDisplayedScore handling ... I don't feel too confident with the default scoring function being assigned in the constructor to a publicly settable delegate. This just feels a bit more elegant, and handles the (likely-never-used) case where we need to restore the default function. An alternative would be to provide the function as a `ctor` argument, but I believe that wasn't done here to allow using the `ILeaderboardScore` interface.	2023-05-29 20:00:29 +09:00
Dean Herbert	fcd7a1d51a	Move GetDisplayScore xmldoc to interface and remove getter	2023-05-29 19:41:53 +09:00
Dean Herbert	9a886125ad	Ensure GameplayScoreCounter's display score is updated on ScoringMode change ... This isn't strictly required, but only because of a kind of hacky behaviour where `HUDOverlay` will recreate all components on a scoring mode change currently (see 8f6df5ea0f/osu.Game/Screens/Play/HUDOverlay.cs (L410-L418)). Best we do this just in case that happens to go away in the future.	2023-05-29 19:00:02 +09:00
Dean Herbert	22be045de3	Apply NRT to GameplayScoreCounter	2023-05-29 18:48:17 +09:00
Dean Herbert	a789d1e49c	Add xmldoc and change naming around ScoreProcessorStatistics a bit	2023-05-29 18:38:16 +09:00
Dean Herbert	b0501c4e5c	Actually use paused header	2023-05-29 10:24:59 +09:00
Dean Herbert	f5b258a044	Merge branch 'master' into make_pause_menu_translatable	2023-05-29 01:16:52 +09:00
cdwcgt	333e785f8b	Revert "Provides higher precision settings" ... This reverts commit ec61840e7d. 😐	2023-05-28 09:50:11 +09:00
Bartłomiej Dach	ba5f76fcc8	Merge pull request #23667 from peppy/fix-taiko-editor-placement-before-first-control-poiunt ... Fix placing objects before the first control point in the osu!taiko editor failing	2023-05-27 17:58:28 +02:00
cdwcgt	a05312c9a2	simplify format method ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2023-05-27 23:44:50 +09:00
cdwcgt	89c8ef3c9b	Format percentage based on significant decimal digits	2023-05-27 23:35:59 +09:00
cdwcgt	ec61840e7d	Provides higher precision settings	2023-05-27 23:25:01 +09:00
cdwcgt	318431a1b7	make MaximumAchievable to default	2023-05-27 21:27:32 +09:00
Robin Oger	cfa1280028	GameplayMenuOverlay.cs: add translatable strings for Retry count: and Song progress: ... This makes the assumption that languages will prefer having the number on the right	2023-05-27 12:47:05 +02:00
Robin Oger	a01577cba5	Adapt changes to fit master	2023-05-27 12:29:14 +02:00
Robin Oger	d5bfbe2b89	Merge branch 'master' into make_pause_menu_translatable ... # Conflicts: # osu.Game/Screens/Play/FailOverlay.cs # osu.Game/Screens/Play/GameplayMenuOverlay.cs # osu.Game/Screens/Play/PauseOverlay.cs	2023-05-27 12:22:50 +02:00
Bartłomiej Dach	53c91349fe	Merge branch 'master' into slider-control-point-no-distance-snap	2023-05-26 19:52:54 +02:00
Bartłomiej Dach	574ecf939c	Merge pull request #23647 from peppy/pause-screen-progress ... Show current progress on pause screen	2023-05-26 19:36:30 +02:00
Dean Herbert	725734bc03	Merge pull request #23649 from peppy/keep-selection-buttons-on-screen ... Ensure editor selection buttons remain on screen when selection is near edge	2023-05-26 20:51:45 +09:00
Dean Herbert	6b0e215246	Add (int) flooring and handle potential NaN value	2023-05-26 20:44:13 +09:00
Dean Herbert	cb468fa4ec	Fix OverlappingScrollAlgorithm returning incorrect results for TimeAt before first control point	2023-05-26 19:59:19 +09:00
Bartłomiej Dach	96fe7cbe54	Merge branch 'master' into sample-set-controls	2023-05-25 21:58:16 +02:00
Bartłomiej Dach	7d8f08c0ea	Fix ComposeBlueprintContainer briefly assigning auto bank ... Seems to have had no consequence due to the way `AutomaticBankAssignment` works (that flag is checked in `PlacementBlueprint.UpdateTimeAndPosition()`, which runs essentially every frame), but let's avoid putting it there at all ever.	2023-05-25 21:49:29 +02:00
Bartłomiej Dach	adee624a8f	Change PlacementBlueprint.AutomaticBankAssignment to property ... Mostly for consistency.	2023-05-25 21:32:21 +02:00
Bartłomiej Dach	b9be886ae1	Merge branch 'master' into pause-screen-progress	2023-05-25 20:34:11 +02:00
Bartłomiej Dach	6425a33b45	Merge branch 'master' into beatmap-length-calcualtions	2023-05-25 17:44:15 +02:00
Bartłomiej Dach	78f41f7109	Fix spelling	2023-05-25 17:33:41 +02:00