1381 Commits

• Also disable counting on argon display in test

  Mostly for my own peace of mind.

  Bartłomiej Dach · 2023-04-25 20:17:57 +02:00
  196b5b41eb
• Fix test failures due to type mismatch
  Bartłomiej Dach · 2023-04-25 20:10:11 +02:00
  753fa09356
• Fix key counter test not testing the full binding of IsCounting
  Dean Herbert · 2023-04-25 21:37:19 +09:00
  0c3a015953
• Merge branch 'master' into gameplay/argon-key-counter_le-retour
  Dean Herbert · 2023-04-25 19:54:31 +09:00
  d8b4db3a13
• Add failing test case

  Covering nested object reverts not firing the parent's `RevertResult`
  event in accordance with what the xmldoc of the event states.

  Bartłomiej Dach · 2023-04-11 18:24:34 +02:00
  0cc92ce5f9
• Merge branch 'master' into gameplay/argon-key-counter_le-retour
  Dean Herbert · 2023-04-06 23:39:57 +09:00
  0c71fa1bbd
• Merge pull request #22868 from peppy/no-epilepsy-warning-storyboard-disable

  Don't show epilepsy warning when storyboards are disabled

  Dean Herbert · 2023-04-06 12:32:38 +09:00
  e6872629f3
• Merge branch 'master' into gameplay/argon-key-counter_le-retour
  tsrk · 2023-04-05 22:57:36 +02:00
  809b817e8e
• Merge branch 'master' into update-skinnable-sound-before-playing
  Bartłomiej Dach · 2023-04-05 22:56:25 +02:00
  ba753a8aac
• Add tests for suppressing epilepsy warning when storyboard disabled
  Bartłomiej Dach · 2023-04-05 20:56:50 +02:00
  6df7614b9d
• Ensure storyboards are enabled in existing epilepsy warning tests
  Bartłomiej Dach · 2023-04-05 20:53:54 +02:00
  02c6126be7
• Merge branch 'master' into gameplay/key-counter-abstraction
  Bartłomiej Dach · 2023-04-05 19:45:14 +02:00
  432f698697
• Merge branch 'master' into fix-replay-fail-on-exit
  Bartłomiej Dach · 2023-04-03 21:23:23 +02:00
  8cc425774b
• Fix missing using statements in multiple test scenes
  Dean Herbert · 2023-04-03 15:37:10 +09:00
  6239789188
• Merge branch 'master' into gameplay/key-counter-abstraction
  Dean Herbert · 2023-04-03 15:33:35 +09:00
  b0c09df259
• Add failing test coverage of saving failed replay causing progression to results
  Dean Herbert · 2023-03-29 14:00:11 +09:00
  9b45591c2f
• Addressed changes
  Terochi · 2023-03-21 23:15:49 +01:00
  1478a26cc0
• Add test coverage of cyclic selection triggering when more than one item is selected
  Dean Herbert · 2023-03-21 21:31:10 +09:00
  fb51221c2b
• Add failing test coverage showing that replay will fail on exiting gameplay
  Dean Herbert · 2023-03-16 17:12:46 +09:00
  a81408ca06
• Add test coverage of SkinnableSound not updating in time when not present
  Dean Herbert · 2023-03-16 15:41:05 +09:00
  159c8833c7
• Apply NRT to TestSceneSkinnableSound
  Dean Herbert · 2023-03-16 15:10:35 +09:00
  5378cdff20
• Rename Add/AddRange methods as they are no longer conflicting with Container
  Dean Herbert · 2023-03-15 18:02:41 +09:00
  5f9b13a775
• Fix super-dodgy cast of IEnumerable to Drawable
  Dean Herbert · 2023-03-15 18:01:22 +09:00
  8908648f97
• Add test coverage and fix fail case where a drag selection ends incorrectly with cyclic selection
  Dean Herbert · 2023-03-15 15:16:48 +09:00
  1cf870d956
• Add tests covering drag selection
  Dean Herbert · 2023-03-14 21:04:51 +09:00
  3c4e2d8700
• revert: make counters an IEnumerable again

  As suggested by bdach as this would make the last two commits useless
  
  Refs: 5d15426

  tsrk · 2023-03-09 10:25:03 +00:00
  d806b85a30
• refactor: make KCD a CompositeDrawable
  tsrk · 2023-03-08 00:47:16 +00:00
  44297a7d0a
• Move KeyCounter components to HUD namespace
  Dean Herbert · 2023-03-07 16:41:39 +09:00
  28520414aa
• Tidy up Add method logic
  Dean Herbert · 2023-03-07 16:21:57 +09:00
  15d65059b5
• Merge branch 'master' into gameplay/key-counter-abstraction
  Dean Herbert · 2023-03-07 16:09:45 +09:00
  8f6df5ea0f
• Add test coverage of cyclic selection in skin editor
  Dean Herbert · 2023-03-07 15:11:47 +09:00
  d2fcdf6e0e
• Merge branch 'master' into skin-editor-depth-changing
  Bartłomiej Dach · 2023-02-27 19:24:53 +01:00
  92edb0f868
• style: use Trigger initialisation
  tsrk · 2023-02-22 17:59:39 +00:00
  6307b3948a
• Merge pull request #22659 from peppy/fix-taiko-drum-nested-sample-detection

  Fix `GameplaySampleTriggerSource` not considering nested objects when determining the best sample to play

  Bartłomiej Dach · 2023-02-22 18:56:59 +01:00
  d679703fa2
• refactor(KeyCounterDisplay): apply suggestions

  I also took the freedom to add type checking, as we can't limit the
  usage of `Add()` since it's a Container. The exception thrown also
  advises of using the suggested `AddTrigger()` instead.

  tsrk · 2023-02-22 14:58:27 +00:00
  1beec71037
• Merge pull request #22635 from peppy/use-overlays-container-more

  Use `Overlays` container rather than `KeyBindingInputManager` for flashlight

  Dean Herbert · 2023-02-22 18:30:21 +09:00
  a8c692a215
• Add test coverage of bring-to-front / send-to-back operations
  Dean Herbert · 2023-02-22 18:17:20 +09:00
  32a9c066df
• Fix weird nullability in TestSceneSkinEditor
  Dean Herbert · 2023-02-22 18:17:20 +09:00
  90ca635a17
• Update assertion to also check GameplayClockContainer's current time
  Dean Herbert · 2023-02-22 15:26:09 +09:00
  f61fbcf3fc
• Seek using GameplayClockContainer
  Dean Herbert · 2023-02-22 14:41:20 +09:00
  a511e64fa5
• Fix test compile failures from Audio hoisting
  Bartłomiej Dach · 2023-02-21 21:03:00 +01:00
  d59d153654
• Merge branch 'master' into fix-taiko-drum-nested-sample-detection
  Bartłomiej Dach · 2023-02-21 20:53:06 +01:00
  3d2fcb0cca
• Merge branch 'master' into skin-editor-clipboard
  Bartłomiej Dach · 2023-02-21 19:35:58 +01:00
  ec1bf7b0b2
• Update slider sample source asserts to match expected behaviour

  As pointed out in review, if the current time is after the end of the
  slider, the correct hit object to use for sample retrieval is the object
  itself, not any nested object.

  Dean Herbert · 2023-02-21 14:04:38 +09:00
  9321ec29dc
• Add wait steps to ensure frame-stable clock has caught up before checking state
  Dean Herbert · 2023-02-21 14:04:19 +09:00
  e686b4393e
• Merge branch 'master' into fix-taiko-drum-nested-sample-detection
  Dean Herbert · 2023-02-21 13:58:15 +09:00
  5ba6059911
• Merge branch 'master' into revert-result-in-playfield
  Bartłomiej Dach · 2023-02-19 16:33:10 +01:00
  3183f5cee2
• Merge branch 'master' into skin-editor-clipboard
  Bartłomiej Dach · 2023-02-17 22:59:18 +01:00
  704dddf14b
• Merge branch 'master' into skinnable-clean-up-documentation
  Bartłomiej Dach · 2023-02-17 20:59:18 +01:00
  6afa65bd3d
• refactor(KeyCounter): address bindables issues

  `IsCounting` is back being an auto-property.
  `countPresses` is now encapsulated and being exposed as an
  `IBindable<int>` via `CountPresses`

  tsrk · 2023-02-16 22:20:34 +00:00
  ddd6c1a1c6