Endrik Tombak
07db977af5
Remove no longer necessary force calculation
...
Is no longer necessary because recommender uses bindable state value changes, compared to when the test was written, and runs the state change once on load
2020-11-21 14:36:43 +02:00
Endrik Tombak
72d9da5fac
Apply review suggestions
2020-11-21 14:26:09 +02:00
Endrik Tombak
6c5a6b42e5
Only calculate recommended SR once
2020-11-21 14:09:32 +02:00
Endrik Tombak
944f3480c2
Merge branch 'master' of https://github.com/ppy/osu into present-recommended
...
Conflicts:
osu.Game/OsuGameBase.cs
osu.Game/Screens/Select/DifficultyRecommender.cs
osu.Game/Screens/Select/SongSelect.cs
2020-11-21 14:01:01 +02:00
Dan Balasescu
09f905355d
Merge pull request #10922 from peppy/fix-judgement-ordering
...
Ensure legacy skin judgements display in front of hitobjects
2020-11-20 23:20:18 +09:00
smoogipoo
9520cf6481
Merge branch 'master' into fix-judgement-ordering
2020-11-20 22:49:33 +09:00
Dan Balasescu
3890639ac1
Merge pull request #10903 from peppy/legacy-judgement-particles
...
Add ParticleExplosion and use to give legacy skins particle explosions
2020-11-20 22:48:13 +09:00
Dan Balasescu
58fc61aa95
Merge branch 'master' into legacy-judgement-particles
2020-11-20 22:19:11 +09:00
Dan Balasescu
221f759dc7
Merge pull request #10919 from peppy/remove-dead-playfield-code
...
Remove no longer necessary code from OsuPlayfield
2020-11-20 22:18:43 +09:00
Dan Balasescu
721005e306
Merge pull request #10921 from peppy/hitcircle-test-scene-shows-judgements
...
Refactor TestSceneHitCircle to show judgements
2020-11-20 22:08:27 +09:00
Dan Balasescu
de824e47df
Merge branch 'master' into remove-dead-playfield-code
2020-11-20 21:48:24 +09:00
Dan Balasescu
8785da1b41
Merge pull request #10917 from peppy/no-applause-on-autoplay
...
Don't play flair animations / sounds when watching autoplay or viewing a result directly
2020-11-20 21:48:10 +09:00
Dan Balasescu
b799fcf65b
Merge pull request #10916 from peppy/fix-editor-context-menus-outside-playfield
...
Fix slider right click context menus not being shown outside the valid playfield area
2020-11-20 21:47:44 +09:00
Dan Balasescu
4213d6bdba
Merge pull request #10890 from peppy/legacy-jugement-match-stable-transforms
...
Adjust judgement animations to match stable
2020-11-20 21:47:21 +09:00
Dean Herbert
649013728c
Merge pull request #10923 from smoogipoo/followpoint-pooling
...
Implement follow point pooling
2020-11-20 20:53:20 +09:00
Dan Balasescu
79752bcb19
Merge branch 'master' into legacy-jugement-match-stable-transforms
2020-11-20 20:51:27 +09:00
Dean Herbert
cc6348aaf9
Merge branch 'hitcircle-test-scene-shows-judgements' into fix-judgement-ordering
2020-11-20 20:08:17 +09:00
Dean Herbert
a26b0915b4
Fix scheduled tasks not being cleaned up between test steps
2020-11-20 20:08:05 +09:00
Dean Herbert
f77ca4ac3a
Merge branch 'master' into followpoint-pooling
2020-11-20 17:18:38 +09:00
smoogipoo
7bd75eca81
Separate classes
2020-11-20 16:53:08 +09:00
smoogipoo
c1f56cd0ba
Remove aliveness hackery
2020-11-20 16:52:27 +09:00
smoogipoo
85eb98a7ec
Clean up some code reuse
2020-11-20 16:43:07 +09:00
Dean Herbert
53b6d90ab4
Don't show default judgements in front of objects for now
2020-11-20 16:30:58 +09:00
Dean Herbert
a00e0d7279
Move CanBeNull specification to the interface
2020-11-20 16:30:48 +09:00
Dean Herbert
7fe0923fcf
Show main judgement content above hitobjects
2020-11-20 16:25:48 +09:00
Dean Herbert
cc7fa6f800
Merge branch 'hitcircle-test-scene-shows-judgements' into fix-judgement-ordering
2020-11-20 16:25:46 +09:00
Dean Herbert
d4054c87d3
Refactor TestSceneHitCircle to show judgements
2020-11-20 16:24:17 +09:00
smoogipoo
2418f17b0c
Fix lifetime not being set correctly in some cases
2020-11-20 16:19:02 +09:00
Dean Herbert
0e9999ecb1
Merge branch 'remove-dead-playfield-code' into fix-judgement-ordering
2020-11-20 16:12:48 +09:00
smoogipoo
2ed2ddfe8a
Rename methods
2020-11-20 15:39:29 +09:00
smoogipoo
33eea64cfc
Fix follow points not updating on positional changes
2020-11-20 15:31:04 +09:00
Dean Herbert
185653b1d8
Remove depth specifications
2020-11-20 15:11:24 +09:00
Dean Herbert
45b1fcf26f
Remove unnecessary using statement
2020-11-20 15:01:37 +09:00
Dean Herbert
af67b4a346
Remove no longer necessary code from OsuPlayfield
2020-11-20 14:57:08 +09:00
Dean Herbert
8c32d3f781
Don't play flair animations / sounds when watching autoplay or viewing a result directly
...
I think this is a pretty good place to be for now. The flair will play
if you just watched a play (local, replay or spectator) but will not
play if you are coming from song select (viewing a replay's result
screen from the leaderboard) or in the case of autoplay.
Closes #10762 .
2020-11-20 14:32:31 +09:00
smoogipoo
c53a8fafe6
Make test fail as expected
2020-11-20 14:25:07 +09:00
smoogipoo
2fc53a278d
Add back reorder support
2020-11-20 14:10:28 +09:00
smoogipoo
17ff7fe163
Fix failing test due to early lifetime end
2020-11-20 13:55:27 +09:00
smoogipoo
a3145ed96d
Fix test compile errors
2020-11-20 13:54:41 +09:00
Dean Herbert
b547abafb2
Fix slider right click context menus not being shown outside the valid playfield area
...
Closes #10816 .
2020-11-20 13:46:23 +09:00
Dan Balasescu
229aed1d46
Merge pull request #10915 from peppy/update-framework
...
Update framework
2020-11-20 13:12:27 +09:00
Dean Herbert
1df3f88fc4
Update framework
2020-11-20 12:32:17 +09:00
Dean Herbert
b997f98b25
Merge pull request #10914 from bdach/prevent-composer-null-crash
2020-11-20 12:18:44 +09:00
Bartłomiej Dach
6356b2dde9
Prevent editor from crashing for rulesets with no compose screen implementation
2020-11-19 22:11:52 +01:00
smoogipoo
d467a00eea
Add initial followpoint pooling implementation
2020-11-20 00:11:31 +09:00
Dean Herbert
1c7ee2ca5f
Simplify math by making direction a float
2020-11-19 18:46:19 +09:00
Dean Herbert
dd5b90cf6c
Add test coverage of animation restarting
2020-11-19 18:08:54 +09:00
Dean Herbert
84e73e88d5
Use structs for parts for added safety
2020-11-19 18:08:54 +09:00
Dean Herbert
3a7291c5cf
Fix some behavioural regressions
2020-11-19 17:56:11 +09:00
Dean Herbert
476d0256cc
Replace particle explosion implementation with DrawNode version
2020-11-19 17:22:37 +09:00