James Wilson 45234b5b72
Add beatmap difficulty before mods as context for score multiplier calculations ( #37921 ) ...
- Part of https://github.com/ppy/osu/issues/37818
Access to difficulty info is required for the upcoming multiplier
proposals. All places providing difficulty info intentionally use
`IBeatmapInfo` as the difficulty info exposed to the calculator should
_always_ be pre-mods for our usecase.
There's a couple of quirks:
- The usage in `ScoreProcessor` is a bit troubling to me but I can't see
a way to make it better without refactoring it. Essentially, we don't
have a beatmap until `ApplyBeatmap` is called, but most usages of
`ScoreProcessor` are setting `Mods` prior to `ApplyBeatmap` so there is
a `null` check in the logic for when mods change. Additionally, this
means a new bindable of the beatmap via `ApplyBeatmap` which also feels
a bit dirty. Open to suggestions.
- ~~`BeatmapLeaderboardScore.Tooltip` is using a null-forgiving on the
`BeatmapInfo`, but there's basically no context available on if this is
an issue - the only code path which sets the score is `SetContent` which
has no callers, so it's essentially dead code. Makes sense given it's
Select V1.~~
---------
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com >
2025-05-15 18:37:42 +09:00
2026-05-27 16:09:16 +09:00
2022-11-27 00:00:27 +09:00
2022-11-27 00:00:27 +09:00
2023-06-24 01:00:03 +09:00
2023-06-24 01:00:03 +09:00
2023-07-13 22:13:40 +09:00
2023-06-24 01:00:03 +09:00
2022-11-27 00:00:27 +09:00
2026-03-06 02:09:05 +09:00
2025-09-11 16:09:17 +09:00
2023-06-24 01:00:03 +09:00
2024-09-30 14:05:20 +02:00
2024-07-08 01:00:36 -07:00
2024-11-29 06:54:48 +09:00
2023-06-24 01:00:03 +09:00
2023-06-24 01:00:03 +09:00
2026-04-04 00:17:31 +09:00
2026-05-21 08:38:30 +02:00
2025-10-28 19:39:07 -07:00
2023-06-24 01:00:03 +09:00
2023-06-24 01:00:03 +09:00
2025-11-20 10:12:43 +01:00
2023-06-24 01:00:03 +09:00
2023-06-24 01:00:03 +09:00
2023-06-24 01:00:03 +09:00
2024-12-11 16:28:51 +09:00
2026-02-28 04:22:58 +09:00
2026-01-12 23:38:17 -05:00
2026-05-22 17:21:06 +09:00
2026-01-13 16:20:03 +09:00
2026-01-23 13:18:48 +01:00
2025-04-23 08:55:29 +02:00
2025-10-23 10:53:58 +02:00
2025-06-04 19:58:04 +02:00
2022-11-27 00:00:27 +09:00
2026-01-26 15:12:52 +09:00
2024-09-04 11:57:09 +02:00
2023-06-24 01:00:03 +09:00
2022-11-27 00:00:27 +09:00
2022-11-27 00:00:27 +09:00
2025-10-24 11:52:45 +02:00
2023-06-24 01:00:03 +09:00
2025-12-23 05:58:57 -05:00
2023-06-24 01:00:03 +09:00
2026-02-18 20:01:38 +09:00
2025-06-16 15:47:57 +09:00
2023-06-24 01:00:03 +09:00
2025-06-12 15:18:38 +09:00
2025-09-08 13:54:06 +09:00
2026-05-22 08:00:50 +02:00
2025-04-24 08:47:08 +02:00
2023-06-18 14:19:38 +02:00
2024-09-02 11:33:37 +02:00
2025-02-24 09:15:21 +01:00
2023-06-24 01:00:03 +09:00
2025-05-19 16:16:33 +09:00
2022-11-27 00:00:27 +09:00
2025-08-21 09:00:46 +02:00
2022-11-27 00:00:27 +09:00
2026-02-09 12:50:40 +09:00
2024-05-06 08:53:41 +02:00
2026-05-28 12:44:59 +02:00
2023-06-24 01:00:03 +09:00
2023-10-11 12:47:12 -07:00
2026-04-07 13:43:14 +02:00
2024-05-05 15:43:46 -07:00
2026-01-15 17:52:30 +09:00
2022-11-27 00:00:27 +09:00
2024-06-27 06:41:44 +03:00
2022-11-27 00:00:27 +09:00
2022-11-27 00:00:27 +09:00
2022-11-27 00:00:27 +09:00
2024-12-20 15:28:24 +09:00
2022-11-27 00:00:27 +09:00
2022-11-27 00:00:27 +09:00
2023-06-24 01:00:03 +09:00
2024-07-24 23:26:23 +03:00
2024-08-05 17:01:00 +09:00
2024-12-16 15:21:07 +09:00
2023-12-27 17:42:18 +01:00
2023-06-24 01:00:03 +09:00
2023-06-24 01:00:03 +09:00
2023-02-26 14:39:34 -08:00
2023-06-24 01:00:03 +09:00
2023-06-24 01:00:03 +09:00
2025-10-09 15:28:15 +09:00
2023-12-28 13:58:00 +01:00
2023-01-01 23:49:15 +01:00
2023-02-03 12:19:09 +01:00
2024-02-01 21:32:37 +01:00
2023-06-24 01:00:03 +09:00
2024-06-27 06:41:44 +03:00
2023-10-26 12:11:26 +02:00
2022-11-27 00:00:27 +09:00
2022-11-27 00:00:27 +09:00
2026-04-08 00:40:50 +09:00
2025-01-11 01:42:59 +09:00
2023-05-25 17:32:48 +09:00
2023-06-24 01:00:03 +09:00
2024-09-20 18:07:26 +02:00
2023-01-05 14:41:26 +03:00
2025-04-18 06:32:00 -04:00
2026-03-06 02:09:05 +09:00
2025-03-22 22:49:34 -04:00
2022-11-27 00:00:27 +09:00
2023-06-24 01:00:03 +09:00
2025-06-14 15:05:05 +03:00
2025-05-09 15:05:41 +09:00
2025-04-18 07:36:21 -04:00
2022-11-27 00:00:27 +09:00
2022-11-27 00:00:27 +09:00
2026-03-21 22:18:02 +09:00
2025-12-23 05:58:57 -05:00
2025-05-30 02:20:57 +09:00
2023-06-24 01:00:03 +09:00
2022-11-27 00:00:27 +09:00
2023-06-24 01:00:03 +09:00
2026-01-26 15:12:52 +09:00
2026-01-26 15:12:52 +09:00
2022-11-27 00:00:27 +09:00
2026-04-07 14:14:49 +02:00
2024-12-16 15:21:07 +09:00
2024-01-17 08:28:47 +03:00
2023-06-24 01:00:03 +09:00
2024-09-04 14:09:50 +02:00
James Wilson
45234b5b72