72 Commits

• Move GetSettingUnderlyingValue to a SettingSource extension method
  Dean Herbert · 2022-03-15 14:54:00 +09:00
  1814a325d8
• Revert "Merge pull request #16889 from smoogipoo/remove-mod-multiplier"

  This reverts commit 252b945d3b, reversing
  changes made to a1b39a96cf.

  Dean Herbert · 2022-02-17 13:26:12 +09:00
  7307e68e9c
• Update xmldoc to mention that multipliers are not applied anywhere
  Dean Herbert · 2022-02-16 17:32:22 +09:00
  23933fc881
• No longer require Mod implementation
  Dan Balasescu · 2022-02-16 16:36:02 +09:00
  4c1413e0c7
• Move more specification from Mod to IMod
  Dean Herbert · 2021-09-10 12:42:53 +09:00
  c3531e1361
• Refactor exposed mod retrieval methods for better safety
  Dean Herbert · 2021-09-10 11:09:13 +09:00
  cf633973a9
• Remove IJsonSerializable interface

  Was pretty pointless and made it hard to use the custom serialisation
  terms arbitrarily in tests.

  Dean Herbert · 2021-08-31 14:39:20 +09:00
  c25ab6835c
• Remove leftover unused using
  Salman Ahmed · 2021-08-19 07:17:43 +03:00
  072560ba3e
• Cache mod settings rather than fetching everytime
  Salman Ahmed · 2021-08-18 09:17:42 +03:00
  1ae4a1910a
• Add hash code support for Mod
  Salman Ahmed · 2021-08-17 04:27:04 +03:00
  060ba0692d
• Add IDeepCloneable interface and update existing CreateCopy methods to use it
  Dean Herbert · 2021-07-19 12:54:17 +09:00
  3c028ce05c
• Fix obsolete message in Mod.Ranked
  Henry Lin · 2021-07-02 15:55:25 +08:00
  6a0c5b54c3
• Rename Mod.Ranked back to avoid breaking ruleset API
  Dean Herbert · 2021-07-02 12:50:58 +09:00
  0396a03bbc
• Replace and obsolete Ranked flag with IsUserPlayable
  Dean Herbert · 2021-06-09 14:17:03 +09:00
  d0e9f8ef90
• Use nameof
  smoogipoo · 2021-04-16 15:40:06 +09:00
  8c4804dd7a
• Apply changes resulting from IBindable interface updates
  smoogipoo · 2021-04-16 15:10:53 +09:00
  d1c72f5e13
• Make Mod.Description abstract and add missing descriptions
  Dean Herbert · 2021-04-15 14:36:26 +09:00
  346e36d32a
• Take current mod settings value into account on equality comparsion
  Salman Ahmed · 2021-04-12 20:51:13 +03:00
  92fab653e1
• Merge branch 'master' into mod-using-reference-equality
  Salman Ahmed · 2021-04-11 19:48:55 +03:00
  18fb9f5ac9
• Always reset local user settings when a mod is deselected in ModSelectOverlay
  Dean Herbert · 2021-02-09 13:44:42 +09:00
  8204d360a8
• Change CopyFrom to always overwrite all settings with incoming values
  Dean Herbert · 2021-02-09 13:44:11 +09:00
  be379e0e3c
• Rename param to match method body
  Bartłomiej Dach · 2021-01-10 15:35:53 +01:00
  4b4adc927c
• Target logic at this and adjust variables
  Salman Ahmed · 2021-01-09 00:31:18 +03:00
  0aad0c7c6c
• Merge remote-tracking branch 'upstream/master' into fix-mod-buttons-not-copying-settings
  Salman Ahmed · 2021-01-09 00:26:18 +03:00
  375ecf92ed
• Clarify & cleanup comments some
  Bartłomiej Dach · 2021-01-03 13:44:29 +01:00
  9e4a925ab1
• Rename parameters for readability
  Bartłomiej Dach · 2021-01-03 13:25:44 +01:00
  a3e29b9154
• Copy values using Bind to also copy defaults
  Dean Herbert · 2021-01-03 20:45:03 +09:00
  2501707d7d
• Add internal pathway for ensuring correct application of bindable mods
  Dean Herbert · 2021-01-03 15:48:28 +09:00
  29dbb1cc0d
• Simplify some default value checks (we are sure the return is an IBindable)
  Dean Herbert · 2021-01-03 15:47:15 +09:00
  23e216fa0b
• Revert drive-by changes
  Salman Ahmed · 2021-01-01 15:40:40 +03:00
  c1a1e3acc5
• Apply documentation suggestions

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Salman Ahmed · 2021-01-01 15:34:09 +03:00
  a031c8e0b6
• Add method for copying properties from another mod
  Salman Ahmed · 2021-01-01 03:46:09 +03:00
  b4df2d6d43
• Fix wrong checks..
  Salman Ahmed · 2020-12-28 15:30:52 +03:00
  41b79d938b
• Fix IMod now using reference equality as well
  Salman Ahmed · 2020-12-28 15:19:28 +03:00
  5efcdbd431
• Fix mod using reference equality unless casted to IMod
  Salman Ahmed · 2020-12-27 02:42:13 +03:00
  43f8f3638a
• Update class exclusion for dynamic compilation
  smoogipoo · 2020-09-04 20:41:08 +09:00
  1143d5d992
• Fix mods sharing bindable instances
  smoogipoo · 2020-08-13 19:48:31 +09:00
  3cb22fad82
• Simplify string construction logic
  Dean Herbert · 2020-03-23 15:20:56 +09:00
  205f4dcb54
• remove redundant ToString call
  Liam DeVoe · 2020-03-22 22:51:29 -04:00
  889608a408
• simplify SettingDescription default definition
  Liam DeVoe · 2020-03-22 22:07:09 -04:00
  98b8f82810
• use string.Empty in IconTooltip
  Liam DeVoe · 2020-03-22 22:06:54 -04:00
  ea87afd577
• use string.Empty, use base SettingDescription for [Osu/Catch]ModDifficultyAdjust
  Liam DeVoe · 2020-03-22 18:50:09 -04:00
  63e9b2a299
• move overridability to SettingDescription method
  Liam DeVoe · 2020-03-20 16:34:36 -04:00
  cda1efef0b
• Revert "use SettingSource to define IconTooltip format"

  This reverts commit 5a6d8f1932.

  Liam DeVoe · 2020-03-20 16:05:12 -04:00
  7bdbdd25f8
• use var for list declaration

  Co-Authored-By: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Liam DeVoe · 2020-03-20 14:37:31 -04:00
  3d95592130
• oops, missed a newline
  Liam DeVoe · 2020-03-20 13:36:16 -04:00
  9e3bff3b97
• fix style issues
  Liam DeVoe · 2020-03-20 13:21:44 -04:00
  9dc8146811
• use SettingSource to define IconTooltip format
  Liam DeVoe · 2020-03-20 12:47:17 -04:00
  5a6d8f1932
• show mod settings in ModIcon tooltip
  Liam DeVoe · 2020-03-18 23:43:26 -04:00
  18bf7c913b
• Update comment

  Co-Authored-By: Salman Ahmed <email@iisalman.me>

  ProTheory8 · 2020-01-21 08:44:22 +05:00
  02f26e4a4d