61556 Commits

This Branch

This Branch

All Branches

• Merge pull request #24308 from peppy/tournament-ladder-improvements

  General improvements to tournament client ladder editor

  Bartłomiej Dach · 2023-07-20 21:40:57 +02:00
  fedf830b82
• Merge pull request #24291 from peppy/editor-cyclic-selection

  Add support for cyclic selection in beatmap editor

  Bartłomiej Dach · 2023-07-20 21:31:08 +02:00
  166efd1aa8
• Adjust inline comment
  Bartłomiej Dach · 2023-07-20 20:51:39 +02:00
  07e0a703d7
• Add test coverage of double click behaviour
  Bartłomiej Dach · 2023-07-20 20:51:17 +02:00
  48024cd17f
• Fix test step descriptions
  Bartłomiej Dach · 2023-07-20 20:47:33 +02:00
  f60a6e9893
• Make dragging ladder more snappy
  Dean Herbert · 2023-07-21 03:34:41 +09:00
  97e572d4da
• Add grid snapping to ladder editor
  Dean Herbert · 2023-07-21 03:34:41 +09:00
  fb4eaaeae9
• Move ladder editor controls to control panel
  Dean Herbert · 2023-07-21 03:34:41 +09:00
  ca14b4a35f
• Add masking around ladder view
  Dean Herbert · 2023-07-21 03:34:41 +09:00
  ac6a103721
• Merge branch 'master' into editor-cyclic-selection
  Bartłomiej Dach · 2023-07-20 20:19:46 +02:00
  708dd355cd
• Merge pull request #24289 from peppy/editor-prefer-closest

  Change beatmap editor to always select the closest object in time

  Bartłomiej Dach · 2023-07-20 19:54:17 +02:00
  2f772abea6
• Merge branch 'master' into editor-prefer-closest
  Bartłomiej Dach · 2023-07-20 19:16:09 +02:00
  210e114f7d
• Add xmldoc to ApplySelectionOrder()
  Bartłomiej Dach · 2023-07-20 19:16:04 +02:00
  511948ba56
• Merge pull request #24303 from peppy/update-framework

  Update framework

  Dean Herbert · 2023-07-20 23:39:41 +09:00
  8dfe93cbb9
• Fix incorrect dependency caching

  These are tested framework-side to throw exceptions, but the
  test is ignored for the source generated version because it quietly
  allows this scenario.
  
  The source gen project should eventually have an analyser for these
  unsupported cases, or we could consider relaxing this particular case.

  Dan Balasescu · 2023-07-20 22:30:49 +09:00
  733ce4c382
• Update inspection rules in line with source generation change
  Dean Herbert · 2023-07-20 20:05:38 +09:00
  71a643d640
• Update framework
  Dean Herbert · 2023-07-20 20:05:38 +09:00
  f791f21dcb
• More realm analytic disables
  Dean Herbert · 2023-07-20 17:51:33 +09:00
  d9d055361a
• Merge pull request #24290 from peppy/beatmap-offset-all-difficulties

  Change offset calibration control to adjust for all difficulties of the current beatmap set

  Bartłomiej Dach · 2023-07-19 22:31:38 +02:00
  285a232cc2
• Merge pull request #24295 from peppy/fix-multiplayer-deadlock

  Fix deadlock when logging out while at the create match screen

  Bartłomiej Dach · 2023-07-19 20:04:13 +02:00
  7800ea9841
• Fix nullability inspection
  Bartłomiej Dach · 2023-07-19 19:23:08 +02:00
  764029bde1
• Clarify guard condition in RoomSubScreen
  Dean Herbert · 2023-07-19 19:39:10 +09:00
  e47722565a
• Fix deadlock when logging out while at the create match screen

  Closes https://github.com/ppy/osu/issues/24275.

  Dean Herbert · 2023-07-19 19:37:38 +09:00
  18aace177a
• Apply NRT to TestSceneComposerSelection
  Dean Herbert · 2023-07-19 17:22:25 +09:00
  94c5b8ed32
• Fix double-click handling when cyclic selection is enabled

  Removes the limitations of cyclic selection as a result.

  Dean Herbert · 2023-07-19 17:21:20 +09:00
  cf3949c9e2
• Add test coverage of beatmap editor cyclic selection
  Dean Herbert · 2023-07-19 17:21:20 +09:00
  d33b174243
• Change offset calibration control to adjust for all difficulties of the current beatmap set
  Dean Herbert · 2023-07-19 17:13:19 +09:00
  5ec9cd84b2
• Update skin editor cyclic test to match expectations better
  Dean Herbert · 2023-07-19 16:56:16 +09:00
  9d46d00294
• Change editor to always perform selection of closest object
  Dean Herbert · 2023-07-19 16:56:16 +09:00
  5ade093c5a
• Add test coverage of selection preferring closest objects
  Dean Herbert · 2023-07-19 16:56:16 +09:00
  4e4dcc9846
• Merge pull request #24236 from Joehuu/remove-android-manifest-overlay

  Remove android manifest overlay

  Bartłomiej Dach · 2023-07-17 22:12:11 +02:00
  88ac53557a
• Merge pull request #24189 from peppy/discord-rpc-reconnect-fix

  Re-enable connection retrying on discord connector

  Bartłomiej Dach · 2023-07-17 19:58:37 +02:00
  551c243945
• Re-enable connection retrying on discord connector
  Bartłomiej Dach · 2023-07-17 19:19:03 +02:00
  17aac0694e
• Merge pull request #24256 from tybug/update-download-icon

  Use `FontAwesome.Download` for updates instead of `FontAwesome.Upload`

  Dean Herbert · 2023-07-17 12:25:04 +09:00
  66269be189
• use fa_download for updates instead of fa_upload
  Liam DeVoe · 2023-07-16 15:21:15 -04:00
  6200e207d2
• Merge pull request #24255 from bdach/multiplayer-disconnection-schedule-bomb

  Fix several issues in multiplayer exit-on-disconnection flow

  Dean Herbert · 2023-07-17 04:04:38 +09:00
  2023.717.0 a472fe6789
• Fix MultiplayerMatchSubScreen erroneously pushing exit dialog on API failure

  If `IAPIProvider.State` changes from `Online` at any point when being on
  an `OnlinePlayScreen`, it will be forcefully exited from. However,
  `MultiplayerMatchSubScreen` had local logic that suppressed the exit in
  order to show a confirmation dialog.
  
  The problem is, that in the suppression logic,
  `MultiplayerMatchSubScreen` was checking
  `MultiplayerClient.IsConnected`, which is a SignalR flag, and was not
  checking `IAPIAccess.State`, which is maintained separately. Due to
  differing timeouts and failure thresholds, it is not impossible to have
  `MultiplayerClient.IsConnected == true` but `IAPIAccess.State !=
  APIState.Online`.
  
  In such a case, the match subscreen would wrongly consider itself to be
  still online and due to that, push useless confirmation dialogs, while
  being in the process of being forcefully exited. This then caused the
  dialog to cause a crash, as it was calling `.Exit()` on the screen which
  would already have been exited by that point, by the force-exit flow.

  Bartłomiej Dach · 2023-07-16 19:56:22 +02:00
  7fbd47e9ee
• Fix PopupDialog potentially accumulating schedules during load
  Bartłomiej Dach · 2023-07-16 19:43:37 +02:00
  cd02a8a9ca
• Update DiscordRichPresence to pull in performance fix

  See https://github.com/Lachee/discord-rpc-csharp/pull/237

  Dean Herbert · 2023-07-17 02:24:51 +09:00
  a6b1559e1f
• Merge pull request #24246 from bdach/fix-exit-dialog-crash

  Fix potential crash in confirm exit dialog while attempting to exit game

  Dean Herbert · 2023-07-17 01:11:07 +09:00
  acb51dfca3
• Update framework
  Dean Herbert · 2023-07-17 00:55:25 +09:00
  e25cd03e4b
• Remove unused local variable
  Bartłomiej Dach · 2023-07-16 17:10:26 +02:00
  a42992d3fd
• Fix PerformAction<T>() potentially crashing when no matching button is found
  Bartłomiej Dach · 2023-07-16 16:55:20 +02:00
  d25a03984b
• Add failing test covering exit dialog crash
  Bartłomiej Dach · 2023-07-16 16:55:20 +02:00
  72bf43e297
• Remove android manifest overlay
  Joseph Madamba · 2023-07-15 23:38:06 -07:00
  ce12afde70
• Merge pull request #24233 from chayleaf/fix-taiko-maps-not-finishing

  Fix taiko maps sporadically not completing with Hidden mod active

  Dean Herbert · 2023-07-16 13:32:38 +09:00
  2023.716.0 50e6f0aee9
• Fix covariant array spec in new test
  Dean Herbert · 2023-07-16 12:48:58 +09:00
  416ee0d99c
• Merge pull request #24235 from AkiSakurai/toplocalrank

  Compute the top local rank directly without an expensive detach call

  Dean Herbert · 2023-07-16 12:14:56 +09:00
  2d51aa21b7
• Merge pull request #24219 from peppy/fix-mania-everything

  Fix osu!mania scores failing to convert to new standardised score due to cast failure

  Dean Herbert · 2023-07-16 11:54:42 +09:00
  cf70f5e04d
• simplify code
  Aki · 2023-07-16 10:21:32 +08:00
  cb354685ca