68897 Commits

This Branch

This Branch

All Branches

• Merge pull request #29533 from bdach/fix-sample-bank-stuff-again

  Fix incorrect bank set / sample addition logic

  Dan Balasescu · 2024-08-29 21:36:26 +09:00
  fec8fa46fa
• Merge pull request #29637 from Joehuu/collapse-pinned-comment-replies

  Hide pinned comment replies initially to match web

  Dan Balasescu · 2024-08-29 16:21:19 +09:00
  a077acc599
• Hide pinned comment replies initially to match web
  Joseph Madamba · 2024-08-28 23:05:15 -07:00
  ef443b0b5d
• Add failing pinned comment replies state test
  Joseph Madamba · 2024-08-28 22:58:57 -07:00
  f0b2176c30
• Merge pull request #29576 from peppy/allow-seek-in-more-places

  Allow seeking via music controller overlay on more screens

  Bartłomiej Dach · 2024-08-28 12:23:09 +02:00
  d49cd717d6
• Merge pull request #29615 from peppy/break-overlay-improvements

  Add shadow around break overlay middle content to make sure it remains visible

  Bartłomiej Dach · 2024-08-27 11:16:08 +02:00
  321e509f11
• Merge pull request #29612 from peppy/fix-hold-note-default-node-samples

  Fix osu!mania hold notes playing a sound at their tail in the editor

  Bartłomiej Dach · 2024-08-27 11:15:47 +02:00
  334b25fb12
• Merge pull request #29500 from frenzibyte/fix-pausing-for-the-millionth-time

  Fix oversight in osu! pause input handling

  Bartłomiej Dach · 2024-08-27 10:04:47 +02:00
  7c0550d251
• Fix test and NRT failure
  Bartłomiej Dach · 2024-08-27 09:49:49 +02:00
  e59689f31a
• Merge pull request #29560 from peppy/fix-daily-challenge-intro-mod-display

  Fix mod icons potentially showing incorrectly at daily challenge intro

  Bartłomiej Dach · 2024-08-27 09:37:11 +02:00
  8d7053d367
• Apply NRT to BreakOverlay
  Dean Herbert · 2024-08-27 15:01:51 +09:00
  98faa07590
• Add shadow around break overlay middle content to make sure it remains visible
  Dean Herbert · 2024-08-27 15:01:50 +09:00
  797b020747
• Move break overlay (and cursor) further forward in depth

  I didn't really want to move the cursor in front of the HUD, but we face
  a bit of an impossible scenario otherwise (it should definitely be in
  front of the break overlay for visibility).
  
  So I'll deal with it for now.

  Dean Herbert · 2024-08-27 14:52:11 +09:00
  abdbe510b8
• Fix TestSceneBreakTracker not removing old drawables

  Also adds a bright background for testing overlay display.

  Dean Herbert · 2024-08-27 14:33:36 +09:00
  c2c83fe73d
• Ban Vortice.* imports

  They have colours and boxes and other classes that conflict with our
  naming. We never use them.

  Dean Herbert · 2024-08-27 14:30:07 +09:00
  dce32a7983
• Merge pull request #25953 from OliBomby/free-sliders

  Add ability to change slider length by dragging slider tail

  Dean Herbert · 2024-08-27 14:12:02 +09:00
  75f2ad1e51
• Fix osu!mania hold notes playing a sound at their tail in the editor

  Closes #29584.

  Dean Herbert · 2024-08-27 14:06:02 +09:00
  9840a07eaf
• Merge branch 'master' into free-sliders
  Dean Herbert · 2024-08-27 13:32:24 +09:00
  1b26e1c126
• Apply NRT to remaining classes in slider blueprint namespace
  Dean Herbert · 2024-08-27 13:18:55 +09:00
  50a8348bf9
• Tidy some thing up
  Dean Herbert · 2024-08-27 13:13:22 +09:00
  4fc96ebfde
• Assume we can always fetch the ruleset
  Dean Herbert · 2024-08-26 15:38:58 +09:00
  84bceca778
• Merge pull request #29604 from cl8n/mod-icon-misc

  Improve mod icon contrast and mod aconym readability

  Dean Herbert · 2024-08-26 14:05:43 +09:00
  e6c0056199
• Increase mod icon acronym font weight
  clayton · 2024-08-25 20:42:57 -07:00
  70d08b9e97
• Use more contrasting color for mod icon foreground
  clayton · 2024-08-25 20:42:34 -07:00
  2bb72762ad
• Merge pull request #29585 from 424ever/daily-play-count-colours

  Fix Daily Challenge play count using a different colour than osu-web

  Dean Herbert · 2024-08-24 23:08:29 +09:00
  d93ca3de23
• Fix Daily Challenge play count using a different colour than osu-web
  Jonas Brandstötter · 2024-08-24 11:21:28 +02:00
  89a4025c01
• Merge pull request #29577 from peppy/skin-deserialise-fix

  Fix some older lazer skins failing to load properly

  Dean Herbert · 2024-08-23 23:17:01 +09:00
  a30fe9daff
• Fix deserialise failing with some old skins
  Dean Herbert · 2024-08-23 20:44:45 +09:00
  885d832e98
• Add failing test showing deserialise failing with some skins
  Dean Herbert · 2024-08-23 20:44:35 +09:00
  3943fe96f4
• Add a bit of logging around medal awarding

  Might help with https://github.com/ppy/osu/issues/29119.

  Dean Herbert · 2024-08-23 19:49:24 +09:00
  1e39af8ac5
• Remove conditional inhibiting seek when beatmap change is not allowed

  In testing I can't find a reason for this to exist. Blaming back shows
  that it existed before we had `AllowTrackControl` and was likely being
  used as a stop-gap measure to achieve the same thing. It's existed since
  over 6 years ago.
  
  Let's give removing it a try to fix some usability concerns?
  
  Closes https://github.com/ppy/osu/issues/29563.

  Dean Herbert · 2024-08-23 18:21:31 +09:00
  2a479a84dc
• Merge pull request #29564 from peppy/skinnable-components-what-2

  Remove requirement of `base` calls to ensure user skin container layouts are retrieved

  Dean Herbert · 2024-08-23 17:52:46 +09:00
  60271fb0f7
• Component -> Lookup
  Dean Herbert · 2024-08-23 14:48:50 +09:00
  48cfd77ee8
• Merge pull request #29537 from normalid-awa/feature/song-select/allow-copy-url-from-context-menu

  Allow copying beatmap link in song select carousel context menu

  Bartłomiej Dach · 2024-08-22 14:03:39 +02:00
  bd6943ebc2
• Remove remaining early base lookup calls which were missed
  Dean Herbert · 2024-08-22 20:13:28 +09:00
  46d55d5e61
• Merge pull request #29562 from peppy/remove-migration-leftover-message

  Remove "leftover files" notification when migration partly fails

  Bartłomiej Dach · 2024-08-22 12:32:44 +02:00
  b3e961f6c5
• Add missing user ruleset to link copying for beatmap panels
  Dean Herbert · 2024-08-22 19:18:41 +09:00
  58552e9768
• Remove requirement of base calls to ensure user skin container layouts are retrieved
  Dean Herbert · 2024-08-22 19:14:30 +09:00
  1435fe24ae
• Merge pull request #29512 from peppy/toolbar-pp-change-weird

  Fix toolbar PP change showing `+0` instead of `0`

  Bartłomiej Dach · 2024-08-22 12:08:12 +02:00
  a32a817305
• Rename Target lookup to Component
  Dean Herbert · 2024-08-22 19:00:28 +09:00
  b57b8168a6
• Move GlobalSkinnableContainers to global scope
  Dean Herbert · 2024-08-22 18:46:07 +09:00
  9a21174582
• Rename GameplaySkinComponentLookup -> SkinComponentLookup
  Dean Herbert · 2024-08-22 18:46:03 +09:00
  36b4013fa6
• Rename SkinComponentsContainerLookup to GlobalSkinnableContainerLookup
  Dean Herbert · 2024-08-22 18:39:36 +09:00
  f37cab0c6e
• Fix EVEN MORE code quality inspections!
  Bartłomiej Dach · 2024-08-22 11:16:24 +02:00
  1859e173f2
• Fix more code quality inspections
  Bartłomiej Dach · 2024-08-22 10:49:24 +02:00
  9997271a6a
• Rename SkinComponentsContainer to SkinnableContainer
  Dean Herbert · 2024-08-22 17:42:50 +09:00
  41756520b1
• Remove unused using directives
  Bartłomiej Dach · 2024-08-22 10:05:45 +02:00
  9020739f36
• Fix flooring causing delta to not work as expected
  Dean Herbert · 2024-08-22 16:22:00 +09:00
  67f0ea5d7d
• Remove "leftover files" notification when migration partly fails

  People were deleting files they shouldn't, causing osu! to lose track of
  where the real user files are.
  
  For now let's just keep things simple and not let the users know that
  some files got left behind. Usually the files which are left behind are
  minimal and it should be fine to leave this up to the user.
  
  Closes https://github.com/ppy/osu/issues/29505.

  Dean Herbert · 2024-08-22 16:09:11 +09:00
  b3be04aff1
• Merge pull request #29545 from peppy/timeline-redesign-in-circles

  Further timeline usability tweaks

  Bartłomiej Dach · 2024-08-22 08:39:34 +02:00
  df94c22a29