62006 Commits

This Branch

This Branch

All Branches

• Fix/rework ModAccuracyChallenge calculation
  Dan Balasescu · 2023-05-18 20:45:02 +09:00
  00e0411369
• Fix base score added for non-accuracy-affecting objects
  Dan Balasescu · 2023-05-18 20:32:50 +09:00
  ef86be6d21
• Remove unnecessary override
  Dan Balasescu · 2023-05-18 20:10:28 +09:00
  c33e4fe75e
• Add TotalScore to replay frame headers
  Dan Balasescu · 2023-05-18 20:08:49 +09:00
  808818768b
• Remove ScoreManager.GetTotalScore()
  Dan Balasescu · 2023-05-18 20:08:49 +09:00
  f3591f83a2
• Remove ScoreManager.Mode, handle per-use
  Dan Balasescu · 2023-05-18 20:08:49 +09:00
  510b8e4c78
• Add MaxTotalScore for performance breakdown calculator
  Dan Balasescu · 2023-05-18 17:47:25 +09:00
  829e47d30b
• Add some helper methods, fix precision differences

  Introduces some error at all times, but if we're to store scores everywhere as
  `long`, then the same precision should be applied to the "during
  gameplay" path as well.

  Dan Balasescu · 2023-05-18 17:44:31 +09:00
  f2483a1cf8
• Remove a couple of unnecessary volume declarations
  Dean Herbert · 2023-05-18 14:12:57 +09:00
  ee522253cb
• Add test coverage for failing case
  Joseph Madamba · 2023-05-17 20:23:37 -07:00
  caa79704ac
• Merge pull request #23580 from peppy/fix-profile-button-depth

  Ensure scroll-to-top button is displayed above all overlay content

  Bartłomiej Dach · 2023-05-17 21:23:46 +02:00
  9ca1c7f7b7
• Merge pull request #23576 from peppy/fix-random-button-right-click

  Fix random button hover state sticking when rewinding using right mouse button

  Bartłomiej Dach · 2023-05-17 21:02:39 +02:00
  fb441b864e
• Chat message notifications always play on unfocused window
  Dimmitsaras · 2023-05-17 18:34:39 +03:00
  7ac6688a0f
• Make EditorClock non-nullable in PlacementBlueprint
  Dean Herbert · 2023-05-17 21:40:52 +09:00
  b58ab28765
• Add TODO regarding failing stack display code
  Dean Herbert · 2023-05-17 17:52:17 +09:00
  214d7e07fa
• Update combo information on placement blueprint
  Dean Herbert · 2023-05-17 17:26:19 +09:00
  0b25818bd2
• Fix weird purple tint on placement object in timeline
  Dean Herbert · 2023-05-17 17:26:19 +09:00
  9563d4f730
• Move combo information updating to an interface level helper method
  Dean Herbert · 2023-05-17 17:26:19 +09:00
  8d925c8a8a
• Improve previous hitobject lookup efficient and correctness
  Dean Herbert · 2023-05-17 17:19:29 +09:00
  e43f2c2c43
• Apply NRT to PlacementBlueprint
  Dean Herbert · 2023-05-17 17:19:29 +09:00
  7d7d402d4e
• Update beat divisor control to show ticks in more visually correct locations

  As proposed in https://github.com/ppy/osu/discussions/23527.

  Dean Herbert · 2023-05-17 16:34:12 +09:00
  87ff28b022
• Adjust BeatDivisorControl test to show control mmuch larger
  Dean Herbert · 2023-05-17 16:33:58 +09:00
  ec2b9165d5
• Apply NRT and simplify some remaining code
  Dean Herbert · 2023-05-17 16:18:13 +09:00
  730bc3a961
• Make OnlinePlayPill class abstract
  Dean Herbert · 2023-05-17 16:13:03 +09:00
  e97d027230
• Ensure scroll-to-top button is displayed above all overlay content
  Dean Herbert · 2023-05-17 15:42:38 +09:00
  79e1d978e7
• Add text hints to accuracy heat map to better describe travel direction
  Dean Herbert · 2023-05-17 15:22:48 +09:00
  3054348c73
• Enable NRT on AccuracyHeatmap
  Dean Herbert · 2023-05-17 15:03:59 +09:00
  9fe787acd8
• Show "rewind" text on random button when beginning a right mouse press
  Dean Herbert · 2023-05-17 14:51:40 +09:00
  764f0323f4
• Fix random button hover state not correctly being reset on right click
  Dean Herbert · 2023-05-17 14:51:40 +09:00
  94b184712d
• Revert "Merge pull request #23570 from huoyaoyuan/inspect-code-cs11"

  This reverts commit ab2bd123e7, reversing
  changes made to 267e63320f.

  Dean Herbert · 2023-05-17 14:49:47 +09:00
  dc421bd2af
• Fix weird optional usage in HitSampleInfo.With
  Dean Herbert · 2023-05-17 14:11:52 +09:00
  510ebe1f23
• Rename GetSampleInfo to better describe what method does

  Also add full xmldoc

  Dean Herbert · 2023-05-17 14:07:48 +09:00
  dc51d5ecf3
• Change default volume when constructing a HitSampleInfo to non-zero
  Dean Herbert · 2023-05-17 14:06:02 +09:00
  a8bc337006
• Merge branch 'master' into use-atomic-ReplaceRange

  This reverts 0dcf1b540e

  Susko3 · 2023-05-17 06:56:54 +02:00
  fec47fa690
• Fix storyboard video-only check being inverted
  Joseph Madamba · 2023-05-16 21:51:32 -07:00
  d6fa44240d
• Removed import for Allocation and other unnecessary [Resolved] tag missed in last commit
  John · 2023-05-16 21:14:55 -07:00
  b7dc8d49ba
• Removed unnecessary [Resolved] attribute (thanks bdach)

  Moved accent color assignment from OnUpdate to ApplyCustomUpdateState. In order to get this to work, a flag needed to be added to DrawableHitObject.cs to disable combo color updates also being applied.

  John · 2023-05-16 21:08:56 -07:00
  e2633ae993
• Merge pull request #23572 from bdach/avoid-display-settings-feedback

  Work around issues with bindable/event feedback in layout settings

  Dean Herbert · 2023-05-17 12:03:45 +09:00
  0d3c64dc32
• Merge pull request #23570 from huoyaoyuan/inspect-code-cs11

  Update InspectCode to 2022.3.3 and enable C# 11

  Dean Herbert · 2023-05-17 11:37:57 +09:00
  ab2bd123e7
• Use better issue reference
  Bartłomiej Dach · 2023-05-16 23:47:47 +02:00
  c97b7a077e
• Add reference to youtrack issue to suppression
  Bartłomiej Dach · 2023-05-16 22:42:25 +02:00
  70426a5042
• Prevent feedback by using atomic .ReplaceRange()

  `display.NewValue` will never be null, checked on SDL + osuTK/Android.
  
  On Android it's a 0x0 display, importantly not null.

  Susko3 · 2023-05-16 21:57:31 +02:00
  2d7fe68311
• Attempt to preserve old resolution when switching displays
  Bartłomiej Dach · 2023-05-16 21:14:09 +02:00
  0dcf1b540e
• Avoid bindable/event feedback when changing resolution
  Bartłomiej Dach · 2023-05-16 21:02:23 +02:00
  88ce627c8e
• Turn off inspection of MSBuild unknown property
  Huo Yaoyuan · 2023-05-17 00:13:08 +08:00
  84de463e2e
• Update InspectCode to 2022.3.3 and enable C# 11
  Huo Yaoyuan · 2023-05-17 00:07:06 +08:00
  ddfdd712bd
• Add test coverage of failing sample bank transfer
  Dean Herbert · 2023-05-16 18:52:52 +09:00
  ebce39cd1c
• Rename editor sample adjustment test scene to increase scope of tests
  Dean Herbert · 2023-05-16 18:52:52 +09:00
  8528fcaedc
• Fix bank not correctly being assigned to some taiko hit cases
  Dean Herbert · 2023-05-16 18:52:52 +09:00
  31fff72eb6
• Fix bank not correctly being assigned when adding sample additions in editor
  Dean Herbert · 2023-05-16 18:52:52 +09:00
  d9ae822966