Boudewijn Popkema
d01421b951
clear remembered username when checkbox is unticked
2024-02-21 23:15:37 +01:00
Andrei Zavatski
4cefa8bb8d
Reduce allocations in TimelineBlueprintContainer
2024-02-21 23:13:10 +03:00
Dean Herbert
901bb01f57
Merge pull request #27293 from peppy/update-framework
...
Update framework
2024-02-21 22:19:37 +08:00
Bartłomiej Dach
805f0b6a29
Remove unused using directive
2024-02-21 14:55:10 +01:00
Dean Herbert
1f4ab7a0e8
Merge branch 'slider-input-alloc' into update-framework
2024-02-21 21:45:14 +08:00
Dean Herbert
fc30abc7b0
Merge branch 'indented-code-block' into update-framework
2024-02-21 21:44:25 +08:00
Dean Herbert
9d732bd9b1
Merge branch 'remove-legacy-gl' into update-framework
2024-02-21 21:44:19 +08:00
Dean Herbert
6d32cfb7ee
Update framework
2024-02-21 21:39:33 +08:00
Dean Herbert
67626e55cb
Merge pull request #27292 from bdach/carousel-sorting-again
...
Fix beatmap carousel string carousel not matching expectations
2024-02-21 21:09:28 +08:00
Dean Herbert
fb593470d5
Use DEFAULT instead of INSTANCE or static field
...
Matches other similar comparers.
2024-02-21 21:02:20 +08:00
Bartłomiej Dach
929858226a
Use custom comparer in beatmap carousel for expected sort behaviour
2024-02-21 12:43:18 +01:00
Bartłomiej Dach
04a2ac3df3
Add benchmarking for custom string comparer
2024-02-21 12:43:17 +01:00
Bartłomiej Dach
59235d6c50
Implement custom comparer for expected carousel sort behaviour
...
Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>
2024-02-21 12:43:17 +01:00
Bartłomiej Dach
259be976e8
Adjust test to fail
2024-02-21 11:42:34 +01:00
Bartłomiej Dach
cd1acf1ef9
Merge pull request #27288 from peppy/fix-follow-circle-animation
...
Fix classic skin follow circles animating from incorrect starting point
2024-02-21 10:53:56 +01:00
Dean Herbert
9c40ff2911
Merge pull request #27278 from EVAST9919/grid-update
...
Apply padding to `GridContainer`s directly where possible
2024-02-21 17:29:21 +08:00
Dan Balasescu
0c359502af
Merge pull request #27286 from peppy/fix-approach-circle
...
Fix `LegacyApproachCircle` incorrectly applying scaling factor
2024-02-21 17:22:55 +09:00
Dean Herbert
a137fa5480
Fix classic skin follow circles animating from incorrect starting point
2024-02-21 15:43:53 +08:00
Dean Herbert
949ea29eef
Merge pull request #27275 from EVAST9919/mania-editor-alloc
...
Reduce mania editor allocations with many objects selected
2024-02-21 15:05:59 +08:00
Dean Herbert
a11a83ac48
Improve comment regarding scale adjust of approach circles
2024-02-21 13:44:04 +08:00
Dean Herbert
86e3b597b4
Fix LegacyApproachCircle incorrectly applying scaling factor
2024-02-21 13:18:51 +08:00
Andrei Zavatski
2543a48ac8
Apply padding to GridContainers directly
2024-02-20 23:18:37 +03:00
Andrei Zavatski
b92cff9a8e
Reduce allocations in ManiaSelectionBlueprint
2024-02-20 20:47:41 +03:00
Andrei Zavatski
871bdb9cf7
Reduce string allocations in TimeInfoContainer
2024-02-20 20:31:18 +03:00
Andrei Zavatski
6678c4783b
Fix PlaybackControl string allocations
2024-02-20 19:31:28 +03:00
Andrei Zavatski
e9aca9226a
Reduce allocations in ManiaPlayfield.TotalColumns
2024-02-20 19:10:03 +03:00
Dean Herbert
ef413c08f1
Merge pull request #27249 from EVAST9919/editor-alloc
...
Reduce osu editor allocations with many objects selected
2024-02-20 15:06:25 +08:00
Dan Balasescu
40d6e8ce85
Remove legacy OpenGL renderer option, it's now just OpenGL
2024-02-20 15:14:30 +09:00
Dean Herbert
3ea47e64f0
Merge pull request #27258 from Loreos7/storage-error-localisation
...
Localise storage error popup dialog
2024-02-20 13:37:10 +08:00
Joseph Madamba
2ff8667dd2
Revert "Centralise global rank display logic to new class"
...
Also don't show on `LoginOverlay` usage for now.
2024-02-19 12:11:12 -08:00
Andrei Zavatski
3791ab30c4
Reduce allocations in HitCircleOverlapMarker
2024-02-19 20:55:43 +03:00
Andrei Zavatski
c758640311
Reduce allocations in ComposerDistanceSnapProvider
2024-02-19 20:49:56 +03:00
Andrei Zavatski
29900353d9
Reduce allocations in SliderSelectionBlueprint
2024-02-19 20:26:15 +03:00
Dean Herbert
fc34c5a505
Merge pull request #27243 from myQwil/beatmap_offset_virtual
...
Change `userBeatmapOffsetClock` to a `FramedOffsetClock`
2024-02-20 01:06:01 +08:00
Mike Will
012d6b7fe1
Change userBeatmapOffsetClock to a FramedOffsetClock
...
Assuming that the global audio offset is set perfectly, such that
any audio latency is fully accounted for, if a specific beatmap
still sounds out of sync, that would no longer be a latency issue.
Instead, it would indicate a misalignment between the beatmap's
track and time codes, the correction for which should be a
virtual-time offset, not a real-time offset.
2024-02-19 09:14:49 -05:00
Dean Herbert
c87bc8b597
Merge pull request #27180 from bdach/better-submission-failure-messaging
...
Add better submission failure messaging
2024-02-19 21:38:23 +08:00
Bartłomiej Dach
ec26ab51d1
Use different wording
2024-02-19 13:56:21 +01:00
Bartłomiej Dach
d7b1e3ba50
Merge pull request #27226 from peppy/no-audio-filter-funny-business
...
Ensure audio filters can't be attached before load (or post-disposal)
2024-02-19 13:01:34 +01:00
Dean Herbert
398eaee5d0
Merge pull request #27238 from bdach/disable-nested-managers-when-skin-editor-open
...
Disable nested input managers on edited screen when skin editor is open
2024-02-19 19:27:26 +08:00
Bartłomiej Dach
f5666185ab
Merge pull request #27239 from peppy/fix-cached-beatmap
...
Fix `WorkingBeatmapCache` caching beatmap in wrong state leading to crash
2024-02-19 12:06:45 +01:00
Bartłomiej Dach
1ca566c6b0
Disable nested input managers on edited screen when skin editor is open
2024-02-19 10:19:25 +01:00
Dean Herbert
7f82f10317
Fix beatmap potentially loading in a bad state
...
Over-caching could mean that a beatmap could load and cause a late
crash. Let's catch it early to avoid such a crash occurring.
2024-02-19 17:18:07 +08:00
Bartłomiej Dach
444ac5ed4d
Add failing test coverage
2024-02-19 09:59:25 +01:00
maromalo
5a448ce02f
Turn BPMDisplay to RollingCounter<int>
2024-02-18 19:59:56 -03:00
Salman Ahmed
bdf91209b6
Merge pull request #27224 from peppy/fix-logo-tracking-single-thread
...
Fix logo tracking container being behind by one frame
2024-02-19 01:20:53 +03:00
Andrei Zavatski
3059ddf3b2
Fix allocations in SliderInputManager
2024-02-19 01:08:40 +03:00
Dean Herbert
998d820666
Ensure audio filters can't be attached before load (or post-disposal)
...
Will probably fix https://github.com/ppy/osu/issues/27225 ?
2024-02-19 00:25:01 +08:00
Dean Herbert
6b6a6aea54
Apply NRT to LogoTrackingContainer
2024-02-18 23:35:26 +08:00
Dean Herbert
882f11bf79
Fix logo tracking container being off by one frame
...
This was especially visible at the main menu when running in single thread mode.
2024-02-18 23:19:57 +08:00
Dean Herbert
415a65bf59
Add failing tests for beatmap inconsistencies
2024-02-18 19:32:21 +08:00
