5259 Commits

Author	SHA1	Message	Date
Dan Balasescu	f942595829	Fix ManiaModInvert permanently messing up the beatmap	2024-07-01 15:02:00 +09:00
Dan Balasescu	3b3f914cd2	Merge branch 'master' into pp_counter_fix	2024-06-28 12:40:56 +09:00
Dean Herbert	fd6b77ea92	Fix distance snap control being removed	2024-06-27 23:59:38 +09:00
Dan Balasescu	0379abd714	Prevent multiple invocations of failure procedure	2024-06-26 13:57:18 +09:00
PercyDan54	2de0852551	Fix transient rank value applied to bindable	2024-06-25 18:06:50 +08:00
Dean Herbert	c58bb62408	Merge branch 'master' into hit-animations	2024-06-23 04:32:47 +09:00
sometimes	89d3f67eb3	fix accuracyProcess typo	2024-06-20 22:06:00 -04:00
Bartłomiej Dach	ad2cd0ba8f	Adjust behaviour of hit animations toggle to match user expectations	2024-06-20 13:42:32 +02:00
Dean Herbert	14104e57d4	Merge branch 'master' into timeline-drag-selection-crash	2024-06-20 15:16:10 +09:00
Dean Herbert	0eb533f2fd	Merge pull request #28444 from bdach/scrolling-ruleset-editor-reloads ... Reload scrolling hitobject composer on control point changes	2024-06-20 15:15:26 +09:00
Bartłomiej Dach	4022a8b06c	Implement automatic break period generation	2024-06-19 10:22:06 +02:00
Bartłomiej Dach	6a6ccbc09f	Make list of breaks bindable	2024-06-19 07:44:03 +02:00
Givikap120	1ddfc8f011	Updated the tests according to new logic ... and fixed one minor CI code quality thing	2024-06-18 15:48:21 +03:00
Givikap120	ec2b8f3bc3	Changed timed difficulty attributes to be "per-HitObject" instead of "per-DifficultyHitObject"	2024-06-18 15:41:41 +03:00
Dean Herbert	316125d47a	Merge pull request #23443 from OliBomby/edit-nodesample ... Make NodeSamples editable	2024-06-18 11:12:02 +09:00
Bartłomiej Dach	7cfe8d8df2	Reduce editor opacity of several editor components when hovering over composer ... Addresses https://github.com/ppy/osu/discussions/24384.	2024-06-17 12:14:28 +02:00
Dan Balasescu	41446a08b6	Annotate ControlPoint and Mod for AOT trimming support	2024-06-17 16:19:33 +09:00
Bartłomiej Dach	bdeea37a44	Commit active placement when starting drag selection via timeline ... This was reported in https://github.com/ppy/osu/pull/28474, albeit the code changes proposed there did not fix the issue at all. See 8b6385f7d0 for demonstration of the crash scenario. Basically what is happening there is: - The starting premise is that there is a spinner placement active. - At this time, a drag selection is started via the timeline. - Once the drag selection finds at least one suitable object to select, it mutates `SelectedItems`. - When selection changes for any reason, the `HitObjectComposer` decides to switch to the "select" tool, regardless of why the selection changed. - Changing the active tool causes the current placement - if any - to be committed, which mutates the beatmap. - Back at the drag box selection code, this causes a "collection modified when enumerating" exception. The proposed fix here is to eagerly commit active placement - if any - when drag selection is initiated via the timeline, which avoids this issue. This also appears to vaguely match stable behaviour and is sort of consistent with the logic of committing any outstanding changes upon switching to the selection tool.	2024-06-14 09:32:40 +02:00
Dan Balasescu	91f2cf8cc3	Use more descriptive HitObject names for debugger displays	2024-06-13 15:18:39 +09:00
Bartłomiej Dach	922837dd3a	Reload scrolling composer on control point changes	2024-06-11 12:01:35 +02:00
Bartłomiej Dach	10af642342	Split mania difficulty section implementation off completely from base ... - "Circle size" / key count needs completely different handling. - Approach rate does not exist in mania.	2024-06-11 11:30:20 +02:00
Salman Ahmed	6f729be573	Merge branch 'master' into LeaderBoardScore_clean	2024-06-07 22:42:49 +03:00
Bartłomiej Dach	86b13074a0	Merge branch 'master' into edit-nodesample	2024-06-06 13:42:25 +02:00
Dean Herbert	091104764e	Fix AssemblyRulesetStore not marking rulesets as available	2024-06-02 17:33:06 +09:00
Dean Herbert	4162d0babe	Merge pull request #28297 from Hecatia-Lapislazuli/near-straight-slider-crash-fix ... Fix for nearly straight sliders causing a crash	2024-05-31 20:00:47 +09:00
Aurelian	9111da81d2	Updated comments	2024-05-31 08:20:19 +02:00
Bartłomiej Dach	a6c776dac8	Use hopefully safer implementation of anchoring judgements to objects	2024-05-29 11:11:43 +02:00
Aurelian	542809a748	Reduced subpoints limit to be a more practical value	2024-05-29 09:39:46 +02:00
Aurelian	6c4def1c09	Added check for infinite subpoints for PerfectCurve	2024-05-27 20:32:18 +02:00
Dean Herbert	740a3377fa	Merge branch 'master' into LeaderBoardScore_clean	2024-05-27 17:18:41 +09:00
Dean Herbert	11c3d11db9	Fix cinema mod not hiding playfield skin layer	2024-05-27 14:52:28 +09:00
Salman Ahmed	5955378004	Replace "X mods" text with a pill indicator	2024-05-25 16:11:24 +03:00
Aurelian	b2c4e0e951	Reworked linear line check, and optimized scaled flat slider test	2024-05-24 14:05:56 +02:00
Aurelian	fff52be59a	Addressed code quality issues	2024-05-24 09:30:24 +02:00
Aurelian	d948e0fc5c	Nearly straight sliders are treated as linear	2024-05-24 08:26:17 +02:00
Dean Herbert	d0b1ebff5a	Revert "Temporary rollback of framework / SDL3" ... This reverts commit d7d569cf4e.	2024-05-22 16:29:39 +08:00
Dean Herbert	d7d569cf4e	Temporary rollback of framework / SDL3	2024-05-21 14:36:16 +08:00
Dean Herbert	a3960bf715	Add inline comment explaining LifetimeEnd set for future visitors	2024-05-15 14:17:28 +08:00
Dean Herbert	cfb2c8272b	Set a rudimentary lifetime end to improve seek performance in scrolling rulesets	2024-05-14 05:02:08 +08:00
Dean Herbert	a780abb0b4	Merge pull request #27912 from bdach/pre-mod-multiplier-score ... Store total score without mod multipliers to local database and to replays, and send it on score submission	2024-05-10 22:46:34 +08:00
Dan Balasescu	3b8b56cbcb	Apply required changes after framework masking updates	2024-05-09 20:18:53 +09:00
Bartłomiej Dach	c9414da5d4	Merge branch 'master' into pre-mod-multiplier-score	2024-05-08 13:39:44 +02:00
Bartłomiej Dach	14658824e7	Adjust distance snap grid momentary toggle logic to not hide it on spacing adjust	2024-05-02 14:11:44 +02:00
Bartłomiej Dach	fe9e6168fe	Merge pull request #28050 from peppy/delay-resume-visibility ... Tweak resume overlay to allow better visibility of hit objects underneath	2024-05-01 15:49:31 +02:00
Dean Herbert	87e814e201	Fix incorrect xmldoc and adjust colour provider to match Player	2024-05-01 20:30:36 +08:00
Dean Herbert	fd3f4a9e7b	Preserve storyboard events when saving a beatmap in the editor ... Until we have full encoding support for storyboards, this stop-gap measure ensures that storyboards don't just disappear from existence.	2024-04-30 00:01:56 +08:00
Bartłomiej Dach	cbbf2dd158	Fix DifficultyBindable bound desync between maxValue and CurrentNumber.MaxValue	2024-04-23 18:58:40 +02:00
Bartłomiej Dach	787e60f706	Fix LegacyDrainingHealthProcessor drain rate computation diverging to infinity	2024-04-23 18:57:14 +02:00
Bartłomiej Dach	1f010c4bfd	Merge pull request #27808 from smoogipoo/fix-incorrect-pp-counter ... Fix gameplay PP counter not matching results screen	2024-04-23 08:43:49 +02:00
Bartłomiej Dach	70a5288a68	Do not attempt to pass files that don't look like audio to BASS	2024-04-22 10:45:09 +02:00