Bartłomiej Dach
875f986979
Remove default from base ResultsScreen too
2020-11-21 14:38:38 +01:00
Dean Herbert
2db42f8e67
Remove default allowRetry parameter value from ResultsScreen
2020-11-20 14:35:44 +09:00
Dean Herbert
8c32d3f781
Don't play flair animations / sounds when watching autoplay or viewing a result directly
...
I think this is a pretty good place to be for now. The flair will play
if you just watched a play (local, replay or spectator) but will not
play if you are coming from song select (viewing a replay's result
screen from the leaderboard) or in the case of autoplay.
Closes #10762 .
2020-11-20 14:32:31 +09:00
Dean Herbert
c5b172d0dd
Remove synchronous lookup path from BeatmapDifficultyCache
2020-11-06 14:53:15 +09:00
Dean Herbert
0103b12575
Add basic base class to begin to standardise function across caching components
2020-11-06 13:26:39 +09:00
Dean Herbert
14bb079feb
Rename ScorePerformanceManager to ScorePerformanceCache
2020-11-06 13:15:33 +09:00
Dean Herbert
5113d4af8f
Rename BeatmapDifficultyManager to BeatmapDifficultyCache
2020-11-06 13:14:29 +09:00
Dean Herbert
73b290aca3
Merge branch 'master' into results-dynamic-pp-calc
2020-11-02 14:47:33 +09:00
Lucas A
6bfff43634
Extract StatisticCounter to a separate class and use it instead.
2020-11-01 13:25:36 +01:00
Dean Herbert
6a293dd536
Add missing ctor parameters back
2020-10-31 18:56:30 +09:00
Dean Herbert
979eb1685b
Merge branch 'master' into results-screen-applause
2020-10-31 18:47:49 +09:00
Dean Herbert
46d89d55f4
Add note about ScheduleAfterChildren requirement
2020-10-30 12:47:04 +09:00
Dean Herbert
0c1d12460f
Remove unused parameter
2020-10-30 10:30:11 +09:00
Dean Herbert
404885af89
Merge branch 'results-screen-animate-once' into results-screen-applause
2020-10-29 18:52:54 +09:00
Dean Herbert
3491dea9e2
Fix scroll logic running before children may be alive in flow
2020-10-29 18:51:54 +09:00
Dean Herbert
f1b8a8f7f5
Remove unused using
2020-10-29 18:16:04 +09:00
Dean Herbert
0a0239a7c7
Only play results panel animation once (and only for the local user)
2020-10-29 17:08:59 +09:00
Dean Herbert
11f85779d5
Fix panel expanded state being updated multiple times unnecessarily
2020-10-29 17:08:59 +09:00
Dean Herbert
71e373ff51
Make results panels aware of whether they are a local score that has just been set
2020-10-29 17:08:59 +09:00
Dean Herbert
4a26084df8
Only play results panel animation once (and only for the local user)
2020-10-29 17:04:33 +09:00
Dean Herbert
f1ce09930e
Fix panel expanded state being updated multiple times unnecessarily
2020-10-29 17:03:45 +09:00
Dean Herbert
5d5b0221e5
Add skinning support for legacy applause playback
2020-10-29 16:32:29 +09:00
Dean Herbert
fb82c043a5
Add rank appear sound (new default)
2020-10-29 16:11:37 +09:00
Dean Herbert
a8e9c62583
Make results panels aware of whether they are a local score that has just been set
2020-10-29 16:11:25 +09:00
Dean Herbert
9141f48b04
Remove beatmap-based ctor to promote single flow
2020-10-23 14:57:27 +09:00
Lucas A
cf69eacae9
Make StarRatingDisplay dynamic.
2020-10-21 19:05:14 +02:00
Bartłomiej Dach
ba818e3ae0
Merge branch 'master' into results-dynamic-pp-calc
2020-10-19 21:41:07 +02:00
Bartłomiej Dach
68b505ab86
Extract helper function for pp value handling
2020-10-12 22:14:45 +02:00
Joehu
8faa86b048
Add ability to toggle extended statistics using space or enter
2020-10-10 18:32:22 -07:00
Lucas A
e845cc92b8
Round pp values to nearest integer.
2020-10-10 19:58:06 +02:00
Lucas A
de522d53ea
Make CalculatePerformanceAsync() nullable.
2020-10-10 19:16:21 +02:00
Dan Balasescu
a6d19cd2d6
Merge pull request #10431 from peppy/fix-distribution-graph-rounding
...
Fix incorrect timing distribution display due to lack of rounding
2020-10-09 18:12:29 +09:00
Dean Herbert
8be19fd820
Increase height of contracted score panel to fit mods again
2020-10-09 13:26:09 +09:00
Dean Herbert
ff5a1937f5
Fix test logic and stabilise rounding direction
2020-10-09 05:04:03 +09:00
Dean Herbert
a5b2c4195e
Fix incorrect timing distribution display due to lack of rounding
2020-10-09 04:41:45 +09:00
Lucas A
a425cf4a31
Fix broken class reference.
2020-10-07 13:29:10 +02:00
Lucas A
7f5cf04b2b
Fix merge conflicts.
2020-10-07 13:28:49 +02:00
Dean Herbert
f77ad8cf39
Remove unused using
2020-10-07 17:03:34 +09:00
Dean Herbert
31d347be5c
Make extended score panel taller to better fit all information
2020-10-07 16:50:00 +09:00
Dean Herbert
67398b5d95
Move timestamp text out of flow and attach to bottom edge
2020-10-07 16:30:14 +09:00
Dean Herbert
6ac70945f2
Show bonus judgements on expanded panel
2020-10-07 16:17:28 +09:00
Dean Herbert
c0bc6a75b3
Show auxiliary judgements on next line
2020-10-07 16:17:17 +09:00
Dean Herbert
e281d724b8
Consume display name logic
2020-10-07 15:43:52 +09:00
Bartłomiej Dach
2b1ef16f89
Replace comparison references to HitResult.Miss with IsHit
2020-10-02 23:31:24 +02:00
Lucas A
35f7de2084
Apply review suggestions.
2020-09-29 18:08:21 +02:00
Lucas A
6efc4c4250
Cache performance calculations to prevent recomputations.
2020-09-28 19:04:39 +02:00
Lucas A
ddede85704
Split performance calculation to its own class.
2020-09-27 12:44:29 +02:00
Lucas A
3cb9103fe0
Inherit PerformanceStatistic from CounterStatistic
2020-09-27 09:37:57 +02:00
Lucas A
4d94bf3163
Rename CalculateScorePerformance -> CalculatePerformance
2020-09-25 19:16:33 +02:00
Lucas A
77a9d92f42
Add dynamic pp calculation to score panels for local scores
2020-09-25 19:15:40 +02:00
smoogipoo
a07597c369
Adjust displays to use new results/orderings
2020-09-25 20:22:59 +09:00
Dan Balasescu
f84b5087bd
Merge pull request #10226 from peppy/results-fix-relayout-misalignment
...
Fix score panel being incorrectly vertically aligned on screen resize
2020-09-24 15:50:31 +09:00
Dan Balasescu
02d8355321
Merge pull request #10224 from peppy/results-statistics-replay-button
...
Add more descriptive description and download button when statistics not available
2020-09-24 14:31:38 +09:00
Dean Herbert
5612357574
Fix score panel being incorrectly vertically aligned on screen resize
2020-09-24 12:49:32 +09:00
Dean Herbert
fda6e88dd3
Fix braces style
2020-09-24 12:39:08 +09:00
Dean Herbert
cb903ec9e2
Fix extended statistics not being vertically centered
2020-09-24 12:21:46 +09:00
Dean Herbert
f4d2c2684d
Add more descriptive description and download button when statistics not available
2020-09-24 12:21:08 +09:00
smoogipoo
37a659b2af
Refactor/add xmldocs
2020-09-09 17:36:47 +09:00
smoogipoo
117c7ec6b2
Merge branch 'master' into score-recalc
2020-09-09 14:38:36 +09:00
Bartłomiej Dach
3ca2a7767a
Exclude misses and empty window hits from UR calculation
2020-08-31 14:29:37 +02:00
Bartłomiej Dach
3b22b891d1
Add failing test cases
2020-08-31 14:29:18 +02:00
Bartłomiej Dach
88ae9ca91d
Merge branch 'master' into fix-unhide-hud-not-updating-stats
2020-08-31 11:48:19 +02:00
Dean Herbert
a171d0e292
Remove unused methods and classes
2020-08-31 18:14:22 +09:00
Dean Herbert
abdb991923
Hide misses from timing distribution graph
2020-08-31 14:15:47 +09:00
Joehu
0a643fd5e5
Fix replay download button always being disabled when initial score's replay is unavailable
2020-08-29 09:33:01 -07:00
smoogipoo
c1838902a6
Add to more places
2020-08-28 22:51:48 +09:00
Bartłomiej Dach
6846a245f4
Reapply lost anchoring fix
2020-08-27 20:51:28 +02:00
Bartłomiej Dach
ea1f07e311
Simplify/rename SimpleStatisticRow mess
2020-08-27 20:37:10 +02:00
Bartłomiej Dach
ce013ac9b4
Make statistic header optional
2020-08-27 20:18:53 +02:00
Bartłomiej Dach
f152e1b924
Revert IStatisticRow changes
2020-08-27 20:13:44 +02:00
Bartłomiej Dach
f8042e6fd3
Add fade to prevent jarring transitions
2020-08-26 22:34:28 +02:00
Bartłomiej Dach
c3197da3da
Adjust simple statistic item font sizes
2020-08-26 22:34:28 +02:00
Bartłomiej Dach
d81d538b7e
Move out row anchor/origin set to one central place
2020-08-26 22:34:27 +02:00
Bartłomiej Dach
5973e2ce4e
Add component for unstable rate statistic
2020-08-26 22:06:27 +02:00
Bartłomiej Dach
7c3368ecbe
Reintroduce SimpleStatisticRow as a data class
2020-08-26 19:33:33 +02:00
Bartłomiej Dach
f5e52c80b4
Rename {-> Drawable}SimpleStatisticRow
2020-08-26 19:25:59 +02:00
Bartłomiej Dach
927a2a3d2d
Introduce IStatisticRow interface
2020-08-26 19:19:42 +02:00
Bartłomiej Dach
f09f882cc7
Add component for displaying simple statistics on result screen
2020-08-25 22:51:40 +02:00
Salman Ahmed
ee9fa11d14
Use With(s => ...)
extension for better readability
2020-08-19 07:47:02 +03:00
Salman Ahmed
9d10658e3c
Allow providing custom sprite text for RollingCounter<T>
2020-08-03 20:14:17 +03:00
smoogipoo
308f8bf9bf
Fix inverted naming
2020-07-31 23:11:42 +09:00
Dan Balasescu
d63f040477
Merge branch 'master' into multi-position
2020-07-31 23:10:25 +09:00
Dean Herbert
909b38a019
Merge branch 'master' into multi-pagination
2020-07-31 22:41:24 +09:00
smoogipoo
b361761d86
Add position display in contracted score panels
2020-07-31 22:02:25 +09:00
smoogipoo
17018ffa8b
Fix potentially triggering new requests too early
2020-07-31 21:33:04 +09:00
smoogipoo
9966d4f3b3
Add more loading spinners
2020-07-31 19:57:05 +09:00
smoogipoo
9f6446d836
Add xmldocs + refactoring
2020-07-28 21:45:12 +09:00
smoogipoo
42e88c53d7
Embed behaviour into UserCoverBackground
2020-07-28 20:50:55 +09:00
smoogipoo
54d2f2c8cd
Delay loading of cover backgrounds in score panels
2020-07-28 20:34:09 +09:00
smoogipoo
255b733fe8
Merge branch 'master' into multi-pagination
2020-07-28 20:20:54 +09:00
smoogipoo
46ea775cfb
Implement paging
2020-07-22 20:24:55 +09:00
Dean Herbert
cccb47e6e0
Add user cover background to expanded version of score panel
2020-07-22 11:29:23 +09:00
Dean Herbert
0125a7ef3b
Fix single-frame glitch in SS grade display animation
2020-07-15 15:36:17 +09:00
Joehu
daa7430fd8
Fix statistics screen blocking retry, home, and alt f4
2020-07-14 00:00:43 -07:00
Joehu
718f06c690
Use Mod.AdjustRank() instead
2020-07-02 12:35:32 -07:00
Joehu
fa252d5e95
Fix score panel not showing silver s/ss badges on hd/fl plays
2020-07-01 17:37:38 -07:00
Joehu
5c1f1ab622
Fix avatar in score panel being unclickable when statistics panel is visible
2020-07-01 14:31:06 -07:00
smoogipoo
1701c844a6
Fix scroll container height on smaller ui scales
2020-06-30 16:36:53 +09:00
Derrick Timmermans
bb81f908fb
Exclude EmptyHitWindow from being considered in TimingDistributionGraph
2020-06-29 15:53:56 +08:00
Dean Herbert
6bcc693c2f
Add ability to close statistics by clicking anywhere
2020-06-23 15:21:23 +09:00